From: Max <msuraev(a)sysmocom.de>
Change ranges of arguments for si2quater neighbor lists to more
convenient values.
---
openbsc/src/libbsc/bsc_vty.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/openbsc/src/libbsc/bsc_vty.c b/openbsc/src/libbsc/bsc_vty.c
index e81308b..b928738 100644
--- a/openbsc/src/libbsc/bsc_vty.c
+++ b/openbsc/src/libbsc/bsc_vty.c
@@ -2766,9 +2766,10 @@ DEFUN(cfg_bts_neigh, cfg_bts_neigh_cmd,
return CMD_SUCCESS;
}
+
DEFUN(cfg_bts_si2quater_neigh_add, cfg_bts_si2quater_neigh_add_cmd,
- "si2quater neighbor-list add earfcn <1900-2200> threshold <0-1000>
"
- "[<0-255>]", "SI2quater Neighbor List\n"
+ "si2quater neighbor-list add earfcn <0-65535> threshold <0-31>
"
+ "[<0-7>]", "SI2quater Neighbor List\n"
"SI2quater Neighbor List\n" "Add to manual SI2quater neighbor
list\n"
"EARFCN of neighbor\n" "EARFCN of neighbor\n" "threshold
high bits\n"
"threshold high bits\n" "measurement bandwidth\n")
@@ -2805,7 +2806,7 @@ DEFUN(cfg_bts_si2quater_neigh_add, cfg_bts_si2quater_neigh_add_cmd,
}
DEFUN(cfg_bts_si2quater_neigh_del, cfg_bts_si2quater_neigh_del_cmd,
- "si2quater neighbor-list del earfcn <1900-2200>",
+ "si2quater neighbor-list del earfcn <0-65535>",
"SI2quater Neighbor List\n"
"SI2quater Neighbor List\n"
"Delete from SI2quater manual neighbor list\n"
@@ -2826,7 +2827,7 @@ DEFUN(cfg_bts_si2quater_neigh_del, cfg_bts_si2quater_neigh_del_cmd,
}
DEFUN(cfg_bts_si2quater_uarfcn_add, cfg_bts_si2quater_uarfcn_add_cmd,
- "si2quater neighbor-list add uarfcn <1900-2200> <0-511>
<0-1>",
+ "si2quater neighbor-list add uarfcn <0-16383> <0-511>
<0-1>",
"SI2quater Neighbor List\n"
"SI2quater Neighbor List\n" "Add to manual SI2quater neighbor
list\n"
"UARFCN of neighbor\n" "UARFCN of neighbor\n" "scrambling
code\n"
@@ -2852,7 +2853,7 @@ DEFUN(cfg_bts_si2quater_uarfcn_add,
cfg_bts_si2quater_uarfcn_add_cmd,
}
DEFUN(cfg_bts_si2quater_uarfcn_del, cfg_bts_si2quater_uarfcn_del_cmd,
- "si2quater neighbor-list del uarfcn <1900-2200> <0-511>",
+ "si2quater neighbor-list del uarfcn <0-16383> <0-511>",
"SI2quater Neighbor List\n"
"SI2quater Neighbor List\n"
"Delete from SI2quater manual neighbor list\n"
--
2.7.4
Show replies by date
From: Max <msuraev(a)sysmocom.de>
---
openbsc/src/libbsc/system_information.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/openbsc/src/libbsc/system_information.c
b/openbsc/src/libbsc/system_information.c
index 3b0f889..0d96621 100644
--- a/openbsc/src/libbsc/system_information.c
+++ b/openbsc/src/libbsc/system_information.c
@@ -68,7 +68,7 @@ static int is_dcs_net(const struct gsm_bts *bts)
return 1;
}
-/* Return q(m) for given NR_OF_TDD_CELLS - see Table 9.1.54.1a, 3GPP TS 44.018 */
+/* Return p(n) for given NR_OF_TDD_CELLS - see Table 9.1.54.1a, 3GPP TS 44.018 */
unsigned range1024_p(unsigned n)
{
switch (n) {
--
2.7.4
Hi Max,
On Thu, Apr 28, 2016 at 05:51:14PM +0200, suraev(a)alumni.ntnu.no wrote:
Change ranges of arguments for si2quater neighbor
lists to more
convenient values.
this commit is not about 'convenience' but about 'correctness in terms
of the ranges permitted for the respective values under the applicable
3GPP specification'.
--
- Harald Welte <laforge(a)gnumonks.org>
http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
(ETSI EN 300 175-7 Ch. A6)