abis_nm_pchan4chcomb API and return value
Dear Harald, there is an open coverity issue in osmo-bts (CID 1040768) and it is about mixing enum types. enum abis_nm_chan_comb abis_nm_pchan4chcomb(uint8_t chcomb)
Hi Holger, sorry for the late response. On Thu, Dec 12, 2013 at 05:45:51PM +0100, Holger Hans Peter Freyther wrote:
enum abis_nm_chan_comb abis_nm_pchan4chcomb(uint8_t chcomb)
From the name of the method I would expect it to return a pchan. E.g. it should return gsm_phys_chan_config?
yes, correct.
static const enum abis_nm_chan_comb chcomb4pchan[] = {
and at the indexes we use values from gsm_phys_chan_config. Do you think the below is correct?
yes, the patch is correct. I noticed you applied it already... Regards, -- - Harald Welte <laforge@gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)
participants (2)
-
Harald Welte -
Holger Hans Peter Freyther