26 Jan
2017
26 Jan
'17
4:46 p.m.
Looks related to this osmo-trx nightly package build breakage?
https://osmocom.org/issues/1928
~N
On Wed, Jan 25, 2017 at 07:42:53PM +0000, Harald Welte wrote:
Harald Welte has submitted this change and it was
merged.
Change subject: Do not embed sqlite3 when building
......................................................................
Do not embed sqlite3 when building
Change-Id: If5edadc04c3ff953b451676e55ad3d00d4e43c82
---
M Makefile.am
M Makefile.common
2 files changed, 1 insertion(+), 2 deletions(-)
Approvals:
Tom Tsou: Looks good to me, approved
Harald Welte: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/Makefile.am b/Makefile.am
index 06251f0..f9f5a5c 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -28,7 +28,6 @@
# Order must be preserved
SUBDIRS = \
- sqlite3 \
CommonLibs \
GSM \
Transceiver52M
diff --git a/Makefile.common b/Makefile.common
index 734ab3a..d7927a5 100644
--- a/Makefile.common
+++ b/Makefile.common
@@ -33,6 +33,6 @@
COMMON_LA = $(top_builddir)/CommonLibs/libcommon.la
GSM_LA = $(top_builddir)/GSM/libGSM.la
-SQLITE_LA = $(top_builddir)/sqlite3/libsqlite.la -ldl
+SQLITE_LA = -lsqlite3
MOSTLYCLEANFILES = *~
--
To view, visit https://gerrit.osmocom.org/1484
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If5edadc04c3ff953b451676e55ad3d00d4e43c82
Gerrit-PatchSet: 2
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge(a)gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Ruben Undheim <ruben.undheim(a)gmail.com>
Gerrit-Reviewer: Tom Tsou <tom(a)tsou.cc>
--
- Neels Hofmeyr <nhofmeyr(a)sysmocom.de> http://www.sysmocom.de/
=======================================================================
* sysmocom - systems for mobile communications GmbH
* Alt-Moabit 93
* 10559 Berlin, Germany
* Sitz / Registered office: Berlin, HRB 134158 B
* Geschäftsführer / Managing Directors: Harald Welte
26 Jan
26 Jan
4:53 p.m.
New subject: [MERGED] osmo-trx[master]: Do not embed sqlite3 when building
Hi Harald, Thomas,
I think it also makes sense to remove sqlite3 subdirectory, since it's no
longer used. Any reason it's kept in the repository?
Please excuse typos. Written with a touchscreen keyboard.
--
Regards,
Alexander Chemeris
CEO Fairwaves, Inc.
https://fairwaves.co
On Jan 26, 2017 18:46, "Neels Hofmeyr" <nhofmeyr(a)sysmocom.de> wrote:
Looks related to this osmo-trx nightly package build
breakage?
https://osmocom.org/issues/1928
~N
On Wed, Jan 25, 2017 at 07:42:53PM +0000, Harald Welte wrote:
Harald Welte has submitted this change and it was
merged.
Change subject: Do not embed sqlite3 when building
......................................................................
Do not embed sqlite3 when building
Change-Id: If5edadc04c3ff953b451676e55ad3d00d4e43c82
---
M Makefile.am
M Makefile.common
2 files changed, 1 insertion(+), 2 deletions(-)
Approvals:
Tom Tsou: Looks good to me, approved
Harald Welte: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/Makefile.am b/Makefile.am
index 06251f0..f9f5a5c 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -28,7 +28,6 @@
# Order must be preserved
SUBDIRS = \
- sqlite3 \
CommonLibs \
GSM \
Transceiver52M
diff --git a/Makefile.common b/Makefile.common
index 734ab3a..d7927a5 100644
--- a/Makefile.common
+++ b/Makefile.common
@@ -33,6 +33,6 @@
COMMON_LA = $(top_builddir)/CommonLibs/libcommon.la
GSM_LA = $(top_builddir)/GSM/libGSM.la
-SQLITE_LA = $(top_builddir)/sqlite3/libsqlite.la -ldl
+SQLITE_LA = -lsqlite3
MOSTLYCLEANFILES = *~
--
To view, visit https://gerrit.osmocom.org/1484
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If5edadc04c3ff953b451676e55ad3d00d4e43c82
Gerrit-PatchSet: 2
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge(a)gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Ruben Undheim <ruben.undheim(a)gmail.com>
Gerrit-Reviewer: Tom Tsou <tom(a)tsou.cc>
--
- Neels Hofmeyr <nhofmeyr(a)sysmocom.de> http://www.sysmocom.de/
=======================================================================
* sysmocom - systems for mobile communications GmbH
* Alt-Moabit 93
* 10559 Berlin, Germany
* Sitz / Registered office: Berlin, HRB 134158 B
* Geschäftsführer / Managing Directors: Harald Welte
5:10 p.m.
New subject: [MERGED] osmo-trx[master]: Do not embed sqlite3 when building
It should have been removed with gerrit 1485
<https://gerrit.osmocom.org/1485>. See also gerrit 1691
<https://gerrit.osmocom.org/1691> for follow-up fixes.
On 26.01.2017 16:53, Alexander Chemeris wrote:
Hi Harald, Thomas,
I think it also makes sense to remove sqlite3 subdirectory, since it's
no longer used. Any reason it's kept in the repository?
--
Max Suraev <msuraev(a)sysmocom.de> http://www.sysmocom.de/
=======================================================================
* sysmocom - systems for mobile communications GmbH
* Alt-Moabit 93
* 10559 Berlin, Germany
* Sitz / Registered office: Berlin, HRB 134158 B
* Geschaeftsfuehrer / Managing Director: Harald Welte
5:53 p.m.
New subject: [MERGED] osmo-trx[master]: Do not embed sqlite3 when building
Great. I was also going to ask about debian contrl files, etc. Glad
this is already fixed.
Is there a way to subscribe to gerrit patches for a particular project?
On Thu, Jan 26, 2017 at 8:10 PM, Max <msuraev(a)sysmocom.de> wrote:
It should have been removed with gerrit 1485
<https://gerrit.osmocom.org/1485>. See also gerrit 1691
<https://gerrit.osmocom.org/1691> for follow-up fixes.
On 26.01.2017 16:53, Alexander Chemeris wrote:
--
Regards,
Alexander Chemeris.
CEO, Fairwaves, Inc.
https://fairwaves.co
Hi Harald, Thomas,
I think it also makes sense to remove sqlite3 subdirectory, since it's no
longer used. Any reason it's kept in the repository?
--
Max Suraev <msuraev(a)sysmocom.de> http://www.sysmocom.de/
=======================================================================
* sysmocom - systems for mobile communications GmbH
* Alt-Moabit 93
* 10559 Berlin, Germany
* Sitz / Registered office: Berlin, HRB 134158 B
* Geschaeftsfuehrer / Managing Director: Harald Welte
9:40 p.m.
New subject: [MERGED] osmo-trx[master]: Do not embed sqlite3 when building
On Thu, Jan 26, 2017 at 08:53:07PM +0400, Alexander Chemeris wrote:
Great. I was also going to ask about debian contrl
files, etc. Glad
this is already fixed.
Is there a way to subscribe to gerrit patches for a particular project?
I'm not sure, but I guess not. We have our gerrit-log mailing list that catches
all changes https://lists.osmocom.org/mailman/listinfo/gerrit-log -- otherwise
take a look at your user's settings, maybe there's such a feature hidden there?
~N
2656
days inactive
2656
days old
4 comments
3 participants
participants (3)
-
Alexander Chemeris -
Max -
Neels Hofmeyr