baseband-devel

baseband-devel@lists.osmocom.org

2022 discussions

[PATCH] Remove comp128 from public API - use osmocom/crypt/auth.h instead
by Max 02 Jun '15

02 Jun '15

Signed-off-by: Max <max.suraev(a)fairwaves.co> --- TODO-RELEASE | 1 + include/Makefile.am | 6 +++--- include/osmocom/gsm/comp128.h | 4 ++-- src/gsm/auth_comp128v1.c | 2 +- src/gsm/comp128.c | 2 +- src/gsm/libosmogsm.map | 1 - tests/comp128/comp128_test.c | 1 - 7 files changed, 8 insertions(+), 9 deletions(-) diff --git a/TODO-RELEASE b/TODO-RELEASE index d03aa49..956b4be 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -1,2 +1,3 @@ #library what description / commit summary line +libosmogsm api-change remove comp128 from public API libosmogb abi-change bssgp: Fix bssgp_tx_fc_bvc parameter type diff --git a/include/Makefile.am b/include/Makefile.am index 52c6a38..b4da54e 100644 --- a/include/Makefile.am +++ b/include/Makefile.am @@ -51,8 +51,6 @@ nobase_include_HEADERS = \ osmocom/gsm/a5.h \ osmocom/gsm/abis_nm.h \ osmocom/gsm/apn.h \ - osmocom/gsm/comp128.h \ - osmocom/gsm/comp128v23.h \ osmocom/gsm/gan.h \ osmocom/gsm/gsm0341.h \ osmocom/gsm/gsm0411_smc.h \ @@ -121,7 +119,9 @@ endif noinst_HEADERS = \ osmocom/core/timer_compat.h \ - osmocom/gsm/kasumi.h + osmocom/gsm/kasumi.h \ + osmocom/gsm/comp128.h \ + osmocom/gsm/comp128v23.h osmocom/core/bit%gen.h: osmocom/core/bitXXgen.h.tpl $(AM_V_GEN)$(MKDIR_P) $(dir $@) diff --git a/include/osmocom/gsm/comp128.h b/include/osmocom/gsm/comp128.h index 33b997a..c45da37 100644 --- a/include/osmocom/gsm/comp128.h +++ b/include/osmocom/gsm/comp128.h @@ -9,10 +9,10 @@ #include <stdint.h> /* - * Performs the COMP128 algorithm (used as A3/A8) + * Performs the COMP128v1 algorithm (used as A3/A8) * ki : uint8_t [16] * srand : uint8_t [16] * sres : uint8_t [4] * kc : uint8_t [8] */ -void comp128(const uint8_t *ki, const uint8_t *srand, uint8_t *sres, uint8_t *kc); +void comp128v1(const uint8_t *ki, const uint8_t *srand, uint8_t *sres, uint8_t *kc); diff --git a/src/gsm/auth_comp128v1.c b/src/gsm/auth_comp128v1.c index 41aef71..c40027e 100644 --- a/src/gsm/auth_comp128v1.c +++ b/src/gsm/auth_comp128v1.c @@ -28,7 +28,7 @@ static int c128v1_gen_vec(struct osmo_auth_vector *vec, struct osmo_sub_auth_data *aud, const uint8_t *_rand) { - comp128(aud->u.gsm.ki, _rand, vec->sres, vec->kc); + comp128v1(aud->u.gsm.ki, _rand, vec->sres, vec->kc); vec->auth_types = OSMO_AUTH_TYPE_GSM; return 0; diff --git a/src/gsm/comp128.c b/src/gsm/comp128.c index b7a2382..e36c20d 100644 --- a/src/gsm/comp128.c +++ b/src/gsm/comp128.c @@ -185,7 +185,7 @@ _comp128_permutation(uint8_t *x, uint8_t *bits) } void -comp128(const uint8_t *ki, const uint8_t *rand, uint8_t *sres, uint8_t *kc) +comp128v1(const uint8_t *ki, const uint8_t *rand, uint8_t *sres, uint8_t *kc) { int i; uint8_t x[32], bits[128]; diff --git a/src/gsm/libosmogsm.map b/src/gsm/libosmogsm.map index 22428a2..c80c15f 100644 --- a/src/gsm/libosmogsm.map +++ b/src/gsm/libosmogsm.map @@ -26,7 +26,6 @@ abis_nm_ipa_magic; osmo_sitype_strs; -comp128; dbm2rxlev; gprs_cipher_gen_input_i; diff --git a/tests/comp128/comp128_test.c b/tests/comp128/comp128_test.c index eb6fb12..d6a6401 100644 --- a/tests/comp128/comp128_test.c +++ b/tests/comp128/comp128_test.c @@ -6,7 +6,6 @@ #include <osmocom/core/bits.h> #include <osmocom/core/utils.h> -#include <osmocom/gsm/comp128v23.h> #include <osmocom/crypt/auth.h> static struct osmo_sub_auth_data test_aux2 = { -- 2.1.4

1 0

[PATCH] Remove osmo_a5_1 and osmo_a5_2 from public API - use generic osmo_a5() instead
by Max 02 Jun '15

02 Jun '15

Signed-off-by: Max <max.suraev(a)fairwaves.co> --- TODO-RELEASE | 1 + include/osmocom/gsm/a5.h | 2 - src/gsm/a5.c | 98 ++++++++++++++++++++++++------------------------ src/gsm/libosmogsm.map | 2 - 4 files changed, 49 insertions(+), 54 deletions(-) diff --git a/TODO-RELEASE b/TODO-RELEASE index d03aa49..ddae4c9 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -1,2 +1,3 @@ #library what description / commit summary line +libosmogsm api-change remove osmo_a5_1 and osmo_a5_2 - generic osmo_a5 should suffice for all use cases libosmogb abi-change bssgp: Fix bssgp_tx_fc_bvc parameter type diff --git a/include/osmocom/gsm/a5.h b/include/osmocom/gsm/a5.h index d22cdbb..9d12b03 100644 --- a/include/osmocom/gsm/a5.h +++ b/include/osmocom/gsm/a5.h @@ -54,7 +54,5 @@ osmo_a5_fn_count(uint32_t fn) * (converted internally to fn_count) */ int osmo_a5(int n, const uint8_t *key, uint32_t fn, ubit_t *dl, ubit_t *ul); -void osmo_a5_1(const uint8_t *key, uint32_t fn, ubit_t *dl, ubit_t *ul); -void osmo_a5_2(const uint8_t *key, uint32_t fn, ubit_t *dl, ubit_t *ul); /*! @} */ diff --git a/src/gsm/a5.c b/src/gsm/a5.c index d0c7c5f..225ff87 100644 --- a/src/gsm/a5.c +++ b/src/gsm/a5.c @@ -101,54 +101,6 @@ _a5_3(const uint8_t *key, uint32_t fn, ubit_t *dl, ubit_t *ul, bool fn_correct) _a5_4(ck, fn, dl, ul, fn_correct); } -/*! \brief Main method to generate a A5/x cipher stream - * \param[in] n Which A5/x method to use - * \param[in] key 8 or 16 (for a5/4) byte array for the key (as received from the SIM) - * \param[in] fn Frame number - * \param[out] dl Pointer to array of ubits to return Downlink cipher stream - * \param[out] ul Pointer to array of ubits to return Uplink cipher stream - * \returns 0 for success, -ENOTSUP for invalid cipher selection. - * - * Currently A5/[0-4] are supported. - * Either (or both) of dl/ul can be NULL if not needed. - */ -int -osmo_a5(int n, const uint8_t *key, uint32_t fn, ubit_t *dl, ubit_t *ul) -{ - switch (n) - { - case 0: - if (dl) - memset(dl, 0x00, 114); - if (ul) - memset(ul, 0x00, 114); - break; - - case 1: - osmo_a5_1(key, fn, dl, ul); - break; - - case 2: - osmo_a5_2(key, fn, dl, ul); - break; - - case 3: - _a5_3(key, fn, dl, ul, true); - break; - - case 4: - _a5_4(key, fn, dl, ul, true); - break; - - default: - /* a5/[5..7] not supported here/yet */ - return -ENOTSUP; - } - - return 0; -} - - /* ------------------------------------------------------------------------ */ /* A5/1&2 common stuff */ /* ------------------------------------------------------------------------ */ @@ -261,7 +213,7 @@ _a5_1_get_output(uint32_t r[]) * Either (or both) of dl/ul can be NULL if not needed. */ void -osmo_a5_1(const uint8_t *key, uint32_t fn, ubit_t *dl, ubit_t *ul) +_a5_1(const uint8_t *key, uint32_t fn, ubit_t *dl, ubit_t *ul) { uint32_t r[3] = {0, 0, 0}; uint32_t fn_count; @@ -378,7 +330,7 @@ _a5_2_get_output(uint32_t r[]) * Either (or both) of dl/ul can be NULL if not needed. */ void -osmo_a5_2(const uint8_t *key, uint32_t fn, ubit_t *dl, ubit_t *ul) +_a5_2(const uint8_t *key, uint32_t fn, ubit_t *dl, ubit_t *ul) { uint32_t r[4] = {0, 0, 0, 0}; uint32_t fn_count; @@ -437,5 +389,51 @@ osmo_a5_2(const uint8_t *key, uint32_t fn, ubit_t *dl, ubit_t *ul) ul[i] = _a5_2_get_output(r); } } +/*! \brief Main method to generate a A5/x cipher stream + * \param[in] n Which A5/x method to use + * \param[in] key 8 or 16 (for a5/4) byte array for the key (as received from the SIM) + * \param[in] fn Frame number + * \param[out] dl Pointer to array of ubits to return Downlink cipher stream + * \param[out] ul Pointer to array of ubits to return Uplink cipher stream + * \returns 0 for success, -ENOTSUP for invalid cipher selection. + * + * Currently A5/[0-4] are supported. + * Either (or both) of dl/ul can be NULL if not needed. + */ +int +osmo_a5(int n, const uint8_t *key, uint32_t fn, ubit_t *dl, ubit_t *ul) +{ + switch (n) + { + case 0: + if (dl) + memset(dl, 0x00, 114); + if (ul) + memset(ul, 0x00, 114); + break; + + case 1: + _a5_1(key, fn, dl, ul); + break; + + case 2: + _a5_2(key, fn, dl, ul); + break; + + case 3: + _a5_3(key, fn, dl, ul, true); + break; + + case 4: + _a5_4(key, fn, dl, ul, true); + break; + + default: + /* a5/[5..7] not supported here/yet */ + return -ENOTSUP; + } + + return 0; +} /*! @} */ diff --git a/src/gsm/libosmogsm.map b/src/gsm/libosmogsm.map index 22428a2..56f33d9 100644 --- a/src/gsm/libosmogsm.map +++ b/src/gsm/libosmogsm.map @@ -201,8 +201,6 @@ ms_pwr_ctl_lvl; ms_pwr_dbm; osmo_a5; -osmo_a5_1; -osmo_a5_2; osmo_auth_alg_name; osmo_auth_alg_parse; -- 2.1.4

1 0

[PATCH] ignore .deb build logs
by Max 02 Jun '15

02 Jun '15

Signed-off-by: Max <max.suraev(a)fairwaves.co> --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 24c3af7..56133da 100644 --- a/.gitignore +++ b/.gitignore @@ -41,6 +41,7 @@ debian/tmp/ debian/libosmocore*.substvars debian/libosmocore/ debian/libosmocore.post*.debhelper +debian/*.log .tarball-version .version -- 2.1.4

1 0

Baseband: MS '1' is up, service is limited
by Hoàng Mạnh Hùng 23 May '15

23 May '15

Hi all, *I connected, sent and made call successful with osmocombb (with real IMSI and IMEI). But, now, I get error, always be rejected:* OsmocomBB# show ms MS '1' is up, service is limited IMEI: 357337016773249 IMEISV: 3573370167732490 IMEI generation: fixed automatic network selection state: A0 null cell selection state: PLMN search radio ressource layer state: idle mobility management layer state: MM idle, PLMN search OsmocomBB# % (MS 1) % Trying to registering with network... *in my config file (/root/.osmocom/bb/mobile.cfg)**:* ! ! OsmocomBB () configuration saved from vty !! ! line vty no login ! gps device /dev/ttyACM0 gps baudrate default no gps enable ! no hide-default ! ms 1 layer2-socket /tmp/osmocom_l2 sap-socket /tmp/osmocom_sap sim reader network-selection-mode auto imei 357337016773249 0 imei-fixed emergency-imsi 452040399998391 sms-service-center +84980200030 no call-waiting no auto-answer no force-rekey no clip no clir tx-power auto no simulated-delay no stick location-updating neighbour-measurement codec full-speed prefer codec half-speed no abbrev support sms a5/1 a5/2 p-gsm e-gsm r-gsm gsm-850 dcs pcs class-900 4 class-850 4 class-dcs 1 class-pcs 1 channel-capability sdcch+tchf+tchh full-speech-v1 full-speech-v2 half-speech-v1 min-rxlev -106 dsc-max 90 no skip-max-per-band exit test-sim imsi 001010000000000 ki xor 00 00 00 00 00 00 00 00 00 00 00 00 no barred-access no rplmn hplmn-search foreign-country exit no shutdown exit ! Anyone help me???, thanks a lot! -- Thanks and Best Regards -- From: Hoàng Mạnh Hùng

5 10

c139 nuttx bringup - irq problem?
by Craig Comstock 12 May '15

12 May '15

Hi, I'm working on bringing up nuttx on the c139. I am running this as I described previously by jumping from 0x2000 to 0x10000 with a small firmware image there and then nuttx is configured to run from flash at 0x10000. I configured nuttx RAM to live at 0x800100 to skip the exception vectors area that the compal loader sets up. NuttX is coming up somewhat but getting stuck on an unregistered interrupt #21 which seems strange since there are 21 interrupts and I thought they might be 0-based so not sure what's going on here. Was wondering if there was some state that the compal loader setup that is giving me problems or if there is some other issue going on. If anyone has an idea off-hand let me know. If I take a DEBUGASSERT() out is when I get the info about irq 21. With the DEBUGASSERT() in it seems I'm trying to do initialization during interrupt handling somehow? "This API should not be called from interrupt handlers" is the comment near the assert in sem_wait(). Attached is a serial log from the phone booting up. I've added a lot of debug logging beyond what is normally in NuttX. I included first a log with DEBUGASSERT() included and then one without. Thanks,Craig

1 0

patch on jolly/menu for jumper app
by Craig Comstock 08 May '15

08 May '15

Here is a patch for a simple "jumper" app which loads at 0x2000 and which disables the irqs (thought it might help with the nuttx startup error I have) and jumps to 0x10000 (where I have flashed nuttx). I'm submitting a patch to nuttx as well for building nuttx.bin for running in compal_e86 flash. I may have fouled up the patch due to being on jolly/menu. Wasn't sure if you wanted to pull in those changes as well? I've certainly used the menu app with the flashing_new instructions and it seems to work great on my c139. -Craig

1 0

nuttx, menu, loader, running from flash
by Craig Comstock 08 May '15

08 May '15

Hi, I'm trying to get nuttx running on my C139 compal_e86(88?) phone. I have been reading some emails and loader scripts but am a bit unexperienced with this area of software. I've managed to use the "menu" app with flashing successfully but so far am unable to get nuttx to run either due to the compal loader not letting me load more than 128k into highram or the flash setup not being quite right in terms of loader scripts. I think what I would like is this (based loosely on LINKAGE.txt in osmocom-bb/.../compal_e88) - keep compal loader at 0x0- put something custom at 0x2000, either the menu app or a simple 2nd stage loader- put nuttx at 0x10000 The "menu" app option (http://bb.osmocom.org/trac/wiki/flashing_new) would require me to modify that code a bit so that I wasn't copying nuttx into highram but instead just running it "in-place" in flash. So maybe two header options: "highram:APPNAME" and "flash:APPNAME"? I suppose I could try running nuttx in highram as menu currently intends, by copying it from flash to ram but that seems sort of "wrong" if nuttx is my main goal. The "other" option would be to write some simple loader for 0x2000 which did whatever setup might be required (none?) and simply jump to 0x10000. That way the ideas in LINKAGE.txt about safety and what-not are preserved. If I need to flash a new nuttx image I don't have to worry about ruining page 0 and compal loader and bricking the phone. Another option would be to replace the compal loader but I'd rather get to nuttx sooner than later and don't see much immediate advantage to an entirely custom bootloader. If I preserve the compal loader then all the normal osmocom-bb functionality is preserved in terms of being able to load layer1, rssi if you want to in highram while nuttx could be living in flash for booting into "normally" to use as a consumer-style device. I think I prefer the "other" option I mention above to keep things fairly simple. Do you think I can just use the flash.lds from compal_e88, modify slightly for e86 (bigger IRAM I think is the only change) and simply put a jump at 0x2000 to 0x10000? Would that take care of exception vectors, setup and all the other stuff I don't currently understand about bringing things "up"? Just FYI, I am working off the latest nuttx code and not nuttx-bb since nuttx-bb seems pretty out of date. Not sure what folks want to do with that. Thanks,Craig

1 1

Osmocom-bb cell sync problem in my version without HW
by Miroslav Babjak 29 Apr '15

29 Apr '15

Hi everyone, I am working on modification the osmocom-bb project. I try modified the osmocom-bb which could communicate with BTS via UDP sockets. Here you can find the project: https://github.com/clovnrian/osmocom-bb-gprs-no-hw I have problem with cell syncing. This is output from mobile: <0003> gsm322.c:2947 Channel synched. (ARFCN=17, snr=0, BSIC=0) <0003> gsm322.c:698 Starting CS timer with 4 seconds. <0001> gsm322.c:2968 using DSC of 90 The CS timer always timeout. On github you can see what messages BTS sends to mobile. Does anybody know what I have to do to or what message I have to send to mobile? I will be grateful for any help With regards Miroslav Babják

1 0

[PATCH] SAP client - revisited
by Tomcsányi, Domonkos 28 Apr '15

28 Apr '15

Hi everyone, I'm following up on this conversation: http://comments.gmane.org/gmane.comp.mobile.osmocom.baseband.devel/1796 It seems like there was no movement in this topic in the last couple of years, so I decided to go ahead and integrate Nico's SAP client into the current master branch and created a patch from it. I tested it (with Kevin's softSIM and a pcsc reader), it worked for me, however it is currently quite ugly: it kind of hand crafts the msgb structure (in l1ctl.c, patch line 121), sorry for that, but I kept getting extra bytes stuffed into the msg that was passed to the sap_interface so I decided to manually go around the problem. I'm of course open to any suggestions to get it cleaner, and then if you think and decide so it could be merged into the master (as far as I see. One thing however that I think is strange, and worth mentioning: I'm not sure why Nico decided to implement the switch between phone and SAP-client inside of l1ctl.c, for me it would feel better to do it in sim.c (since sim.c deals with SIM activities, l1ctl should deal only with L1 stuff...also the current SAP client calls back to sim.c, but receives data from l1ctl - little bit confusing), but I left it as is because of not knowing exactly the thoughts behind it. Regards, Domi

3 3

nuttx-bb?
by Craig Comstock 17 Apr '15

17 Apr '15

Hi all, Was starting to work on making a usable phone again and wondered about the status of nuttx-bb git on osmocom.org versus nuttx source. It seems nuttx source is more up-to-date and has configs for my device: compal_e86/c139. Wondering if there is something in nuttx-bb that is unique that I should pay attention to? Should nuttx-bb be rebased from nuttx upstream? I was able to cobble together a nuttx.bin but on loading it always stops at 88% with the chainloader. The nuttx.bin is 148K which would seem plenty of room since the C139 has 4000K flash (32MBit) (am I doing that calculation correctly)? I had to fiddle with the MEMORY section of the ld.script in order to make space for nuttx, I'm not too familiar with this sort of thing so may have done something wrong... /* E86 stacked flash 32mbit flash, 4mbit sram, DBB internal 256kb SRAM */ /* 0x800000-0x87ffff */ /* bump up because we have 32mbit instead of 16mbit */ /* compal-loaded binary: our text, initialized data */ LRAM (rw) : ORIGIN = 0x00800000, LENGTH = 0x00020000 TRAM (rw) : ORIGIN = 0x00820000, LENGTH = 0x00040000 /* compal-loaded binary: our unitialized data, stacks, heap */ IRAM (rw) : ORIGIN = 0x00860000, LENGTH = 0x00020000 Originally TRAM was 20000 long and gave me an error on building. Not sure if I can fiddle with these values or not. Thanks,Craig

1 2

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

baseband-devel