22 Nov
2012
22 Nov
'12
4:07 p.m.
Harald Welte wrote:
On Wed, Nov 21, 2012 at 01:34:27PM +0100, Andreas
Eversberg wrote:
hi harald,
yes, i just did (pushed) . also i was wrong that l1ctl_tx_fbdb_req of
"mobile" requires conversion. it is already in correct range format. i
fixed names and signess of rxlev / rxlev_dbm now.
regards,
andreas
please note that cell_log.c and mobile (gsm322.c)
use signed uint8_t
for real rx-level (dbm). i think you should use dbm2rxlev() before
handing it to l1ctl_tx_fbsb_req().
thanks, fix pushed. It would be a good idea to not call those fields
'rxlev' if they actually contain a 'receive level in dbm' but not a
'rxlev' value like in the specs.