Re: osmocom-commitlog Digest, Vol 551, Issue 1
osmocom-commitlog-request@lists.osmocom.org wrote:
commit 73a809e57b8a531b9b8a33b6841ed3df2ea22620 Author: Harald Welte<laforge@gnumonks.org> Date: Tue Nov 20 10:13:44 2012 +0100
Tell L1CTL_FBSB_REQ the expected received signal level
hi harald, please note that cell_log.c and mobile (gsm322.c) use signed uint8_t for real rx-level (dbm). i think you should use dbm2rxlev() before handing it to l1ctl_tx_fbsb_req(). regards, andreas
On Wed, Nov 21, 2012 at 01:34:27PM +0100, Andreas Eversberg wrote:
please note that cell_log.c and mobile (gsm322.c) use signed uint8_t for real rx-level (dbm). i think you should use dbm2rxlev() before handing it to l1ctl_tx_fbsb_req().
thanks, fix pushed. It would be a good idea to not call those fields 'rxlev' if they actually contain a 'receive level in dbm' but not a 'rxlev' value like in the specs. -- - Harald Welte <laforge@gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)
Harald Welte wrote:
On Wed, Nov 21, 2012 at 01:34:27PM +0100, Andreas Eversberg wrote:
please note that cell_log.c and mobile (gsm322.c) use signed uint8_t for real rx-level (dbm). i think you should use dbm2rxlev() before handing it to l1ctl_tx_fbsb_req().
thanks, fix pushed. It would be a good idea to not call those fields 'rxlev' if they actually contain a 'receive level in dbm' but not a 'rxlev' value like in the specs.
hi harald, yes, i just did (pushed) . also i was wrong that l1ctl_tx_fbdb_req of "mobile" requires conversion. it is already in correct range format. i fixed names and signess of rxlev / rxlev_dbm now. regards, andreas
participants (3)
-
Andreas Eversberg -
Harald Welte -
jolly