- gerrit-log - lists.osmocom.org

[S] Change in ...pyosmocom[master]: Fix lint errors: don't use star imports
by laforge 11 Mar '26

11 Mar '26

Attention is currently required from: osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/41384?usp=email ) Change subject: Fix lint errors: don't use star imports ...................................................................... Patch Set 2: (1 comment) File tests/test_construct.py: https://gerrit.osmocom.org/c/python/pyosmocom/+/41384/comment/7ba59e6b_487c… : PS2, Line 8: DnsAdapter, > @laforge@osmocom. […] The usual approach in our code would be to simply have two (or more) lines starting with "from osmocom.construct import ...". See https://gitea.osmocom.org/osmocom/pyosmocom/src/commit/a5bc2a20f439f2ab309a… for example, where we have three lines doing "from construct import ..." I often even group the imported symbols logically in such situations. I personally think one line per symbol is wasteful of my screen real-esetate. If there's a standard to do it differently, but then we should convert the entire codebase to that style, and not do it one way in one file and another way in another file. PEP8 doesn't seem to cover that situation, at least I couldn't find it in my reading of the "Imports" section. -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/41384?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I0ca76a40d47f72635682de9303ff73e9b2197266 Gerrit-Change-Number: 41384 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Mar 2026 16:31:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[M] Change in libosmocore[master]: core: fix config.h
by pespin 11 Mar '26

11 Mar '26

Attention is currently required from: Hoernchen, fixeria, laforge. pespin has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/libosmocore/+/42205?usp=email ) Change subject: core: fix config.h ...................................................................... Patch Set 6: (1 comment) File src/core/msgb.c: https://gerrit.osmocom.org/c/libosmocore/+/42205/comment/09aeda5c_b9b8e008?… : PS6, Line 206: const char *m_dump __attribute__((unused)); This looks unrelated to this patch? Also, why not removing it (in a separate patch)? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42205?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic2cf52a3b60f43a2f5d3fe01c41a41f6fd9a8000 Gerrit-Change-Number: 42205 Gerrit-PatchSet: 6 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Mar 2026 16:30:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in pysim[master]: tester: temporarily disable physical tests
by Hoernchen 11 Mar '26

11 Mar '26

Hoernchen has abandoned this change. ( https://gerrit.osmocom.org/c/pysim/+/40577?usp=email ) Change subject: tester: temporarily disable physical tests ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40577?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I395adbcc9c0559e782c8bec64173def3deaa0084 Gerrit-Change-Number: 40577 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[M] Change in libosmocore[master]: core: fix config.h
by Hoernchen 11 Mar '26

11 Mar '26

Attention is currently required from: Hoernchen, fixeria, laforge, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/42205?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: core: fix config.h ...................................................................... core: fix config.h While exploring why logging is disabled but still shows up in the binaries I kind of wondered how all the config.h HAVE_XX checks we have everwhere work. Apparently they do not work at all, due to missing or misplaced include of config.h. This affects tons of other checks as well. The jenkins hook ensures the include order is checked to ensure config.h does not get misplaced or lost in the future. Change-Id: Ic2cf52a3b60f43a2f5d3fe01c41a41f6fd9a8000 --- M contrib/jenkins_common.sh M src/core/application.c M src/core/backtrace.c M src/core/base64.c M src/core/bitcomp.c M src/core/bits.c M src/core/bitvec.c M src/core/context.c M src/core/conv_acc_generic.c M src/core/counter.c M src/core/crc16.c M src/core/crcXXgen.c.tpl M src/core/fsm.c M src/core/isdnhdlc.c M src/core/logging_emscripten.c M src/core/logging_systemd.c M src/core/loggingrb.c M src/core/mnl.c M src/core/msgb.c M src/core/msgfile.c M src/core/panic.c M src/core/prbs.c M src/core/prim.c M src/core/rate_ctr.c M src/core/rbtree.c M src/core/select.c M src/core/serial.c M src/core/signal.c M src/core/soft_uart.c M src/core/stat_item.c M src/core/strrb.c M src/core/tdef.c M src/core/timer.c M src/core/timer_gettimeofday.c M src/core/use_count.c M src/core/utils.c M src/core/write_queue.c 37 files changed, 66 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/05/42205/6 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42205?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic2cf52a3b60f43a2f5d3fe01c41a41f6fd9a8000 Gerrit-Change-Number: 42205 Gerrit-PatchSet: 6 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ccid-firmware[master]: ccid: Fix [unused] RDR_to_PC_Hardware_Error struct definition
by laforge 11 Mar '26

11 Mar '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42303?usp=email ) Change subject: ccid: Fix [unused] RDR_to_PC_Hardware_Error struct definition ...................................................................... ccid: Fix [unused] RDR_to_PC_Hardware_Error struct definition Our definition of the message was wrong; it is an interrupt endpoint message without the full header of the bulk-in endpoint. Luckily the definition was not used in the code base, so this is not fixing any problem visible on the protocol level. Change-Id: Ieb756c37402c4ebea32cc3cd23ba3842f4c0df3e --- M ccid_common/ccid_proto.h 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: lynxis lazus: Looks good to me, approved laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/ccid_common/ccid_proto.h b/ccid_common/ccid_proto.h index ac03938..19f1333 100644 --- a/ccid_common/ccid_proto.h +++ b/ccid_common/ccid_proto.h @@ -402,9 +402,11 @@ uint8_t bmSlotCCState[0]; /* as long as bNumSlots/4 padded to next byte */ } __attribute__ ((packed)); -/* Section 6.3.1 */ +/* Section 6.3.2 - Interrupt IN message (4 bytes, NOT bulk header format) */ struct ccid_rdr_to_pc_hardware_error { - struct ccid_header hdr; + uint8_t bMessageType; /* 0x51 */ + uint8_t bSlot; + uint8_t bSeq; uint8_t bHardwareErrorCode; } __attribute__ ((packed)); -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42303?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Ieb756c37402c4ebea32cc3cd23ba3842f4c0df3e Gerrit-Change-Number: 42303 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Hoernchen <ewild(a)sysmocom.de>

1 0

[S] Change in osmo-ccid-firmware[master]: ccid: Fix CCID RDR_to_PC_Parameters (missing bProtocolNum)
by laforge 11 Mar '26

11 Mar '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42157?usp=email ) Change subject: ccid: Fix CCID RDR_to_PC_Parameters (missing bProtocolNum) ...................................................................... ccid: Fix CCID RDR_to_PC_Parameters (missing bProtocolNum) Our RDR_to_PC_Parameters message was broken, as it was missing the bProtocolNum value after the header. Let's fix that. Change-Id: I67d5cb876d20b29f4759d5b194606f34b8b966c4 --- M ccid_common/ccid_device.c M ccid_common/ccid_proto.h 2 files changed, 7 insertions(+), 4 deletions(-) Approvals: lynxis lazus: Looks good to me, approved laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/ccid_common/ccid_device.c b/ccid_common/ccid_device.c index bf131a9..8a53860 100644 --- a/ccid_common/ccid_device.c +++ b/ccid_common/ccid_device.c @@ -264,11 +264,12 @@ const struct ccid_pars_decoded *dec_par) { struct msgb *msg = ccid_msgb_alloc(); - struct ccid_rdr_to_pc_parameters *par = - (struct ccid_rdr_to_pc_parameters *) msgb_put(msg, sizeof(par->hdr)+sizeof(par->abProtocolData.t0)); + struct ccid_rdr_to_pc_parameters *par = (struct ccid_rdr_to_pc_parameters *)msgb_put( + msg, sizeof(par->hdr) + sizeof(par->bProtocolNum) + sizeof(par->abProtocolData.t0)); uint8_t sts = (cmd_sts & CCID_CMD_STATUS_MASK) | icc_status; SET_HDR_IN(par, RDR_to_PC_Parameters, slot_nr, seq, sts, err); + par->bProtocolNum = CCID_PROTOCOL_NUM_T0; if (dec_par) { osmo_store32le(sizeof(par->abProtocolData.t0), &par->hdr.hdr.dwLength); encode_ccid_pars_t0(&par->abProtocolData.t0, dec_par); @@ -286,11 +287,12 @@ const struct ccid_pars_decoded *dec_par) { struct msgb *msg = ccid_msgb_alloc(); - struct ccid_rdr_to_pc_parameters *par = - (struct ccid_rdr_to_pc_parameters *) msgb_put(msg, sizeof(par->hdr)+sizeof(par->abProtocolData.t1)); + struct ccid_rdr_to_pc_parameters *par = (struct ccid_rdr_to_pc_parameters *)msgb_put( + msg, sizeof(par->hdr) + sizeof(par->bProtocolNum) + sizeof(par->abProtocolData.t1)); uint8_t sts = (cmd_sts & CCID_CMD_STATUS_MASK) | icc_status; SET_HDR_IN(par, RDR_to_PC_Parameters, slot_nr, seq, sts, err); + par->bProtocolNum = CCID_PROTOCOL_NUM_T1; if (dec_par) { osmo_store32le(sizeof(par->abProtocolData.t1), &par->hdr.hdr.dwLength); encode_ccid_pars_t1(&par->abProtocolData.t1, dec_par); diff --git a/ccid_common/ccid_proto.h b/ccid_common/ccid_proto.h index e26a051..ac03938 100644 --- a/ccid_common/ccid_proto.h +++ b/ccid_common/ccid_proto.h @@ -333,6 +333,7 @@ /* Section 6.2.3 RDR_to_PC_Parameters */ struct ccid_rdr_to_pc_parameters { struct ccid_header_in hdr; + uint8_t bProtocolNum; union { struct ccid_proto_data_t0 t0; struct ccid_proto_data_t1 t1; -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42157?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I67d5cb876d20b29f4759d5b194606f34b8b966c4 Gerrit-Change-Number: 42157 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ccid-firmware[master]: ccid: Fix CCID RDR_to_PC_Parameters (missing bProtocolNum)
by laforge 11 Mar '26

11 Mar '26

Attention is currently required from: Hoernchen, pespin. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42157?usp=email ) Change subject: ccid: Fix CCID RDR_to_PC_Parameters (missing bProtocolNum) ...................................................................... Patch Set 3: (2 comments) Patchset: PS2: > @ewild@sysmocom. […] Done Commit Message: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42157/comment/4043042e_3b… : PS1, Line 8: > as ewild has been sick, I've quickly split the patch in two parts. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42157?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I67d5cb876d20b29f4759d5b194606f34b8b966c4 Gerrit-Change-Number: 42157 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Mar 2026 16:27:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in pysim[master]: pySim-shell/cosmetic: remove semicolon
by laforge 11 Mar '26

11 Mar '26

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42311?usp=email ) Change subject: pySim-shell/cosmetic: remove semicolon ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42311?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I629bacd432491211b939fcd2bed554b44ef441bc Gerrit-Change-Number: 42311 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Mar 2026 16:23:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: pySim-prog/pySim-read: add pySimLogger and verbose cmdline argument
by laforge 11 Mar '26

11 Mar '26

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42305?usp=email ) Change subject: pySim-prog/pySim-read: add pySimLogger and verbose cmdline argument ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42305?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia2fa535fd9ce4ffa301c3f5d6f98c1f7a4716c74 Gerrit-Change-Number: 42305 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Mar 2026 16:21:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ccid-firmware[master]: ccid: properly reject PC_to_RDR_{ResetParameters,SetParameters}
by laforge 11 Mar '26

11 Mar '26

Attention is currently required from: Hoernchen. laforge has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42312?usp=email ) Change subject: ccid: properly reject PC_to_RDR_{ResetParameters,SetParameters} ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Patchset: PS3: I agre this should be merged in general, but let's slightly delay it until we have merged all the more critical patches right now and tagged a new release. -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42312?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I4d0671c160e9028097397ec47982bafbfdc24f24 Gerrit-Change-Number: 42312 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Mar 2026 16:20:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log