- gerrit-log - lists.osmocom.org

[M] Change in osmo-trx[master]: build: install common/GSM/transceiver libraries for emscripten and ad...
by pespin 11 Mar '26

11 Mar '26

Attention is currently required from: Hoernchen, Timur Davydov, fixeria, laforge, osmith. pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42243?usp=email ) Change subject: build: install common/GSM/transceiver libraries for emscripten and add pkg-config files ...................................................................... Patch Set 4: (1 comment) File configure.ac: https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/c2d3cbb2_4db8dcba?usp… : PS3, Line 307: PKG_CHECK_MODULES(FFTWF, fftw3f) > It isn't — and it doesn't need to be. […] So IMHO what this patch would need to do instead is to add a new --disable-multi-arfcn configure flag, which would then avoid compiling RadioInterfaceMulti and any of the required dependencies, fft.c included. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42243?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I2495c5b5c79f2fe74bef83902058e1d2207c1f3c Gerrit-Change-Number: 42243 Gerrit-PatchSet: 4 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Tue, 10 Mar 2026 14:39:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: Timur Davydov <dtv.comp(a)gmail.com>

1 0

[S] Change in pysim[master]: global_platform: install_cap_parser: argument groups cannot be nested
by fixeria 11 Mar '26

11 Mar '26

Attention is currently required from: dexter, laforge. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42310?usp=email ) Change subject: global_platform: install_cap_parser: argument groups cannot be nested ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Please note that I haven't tested this patch. @pmaier@sysmocom.de If you can test it, it would be appreciated. Thanks! -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42310?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Idddf72d5a745345e134b23f2f01e0257d0667579 Gerrit-Change-Number: 42310 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Mar 2026 14:33:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in pysim[master]: pySim-shell/cosmetic: remove semicolon
by dexter 11 Mar '26

11 Mar '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/42311?usp=email ) Change subject: pySim-shell/cosmetic: remove semicolon ...................................................................... pySim-shell/cosmetic: remove semicolon Change-Id: I629bacd432491211b939fcd2bed554b44ef441bc --- M pySim-shell.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/11/42311/1 diff --git a/pySim-shell.py b/pySim-shell.py index 89d011f..371a24f 100755 --- a/pySim-shell.py +++ b/pySim-shell.py @@ -108,7 +108,7 @@ self.verbose = verbose PySimLogger.setup(self.poutput, {logging.WARN: YELLOW}) - self._onchange_verbose('verbose', False, self.verbose); + self._onchange_verbose('verbose', False, self.verbose) # pylint: disable=unexpected-keyword-arg super().__init__(persistent_history_file='~/.pysim_shell_history', allow_cli_args=False, -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42311?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I629bacd432491211b939fcd2bed554b44ef441bc Gerrit-Change-Number: 42311 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in pysim[master]: pySim-prog/pySim-read: add pySimLogger and verbose cmdline argument
by dexter 11 Mar '26

11 Mar '26

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/42305?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: pySim-prog/pySim-read: add pySimLogger and verbose cmdline argument ...................................................................... pySim-prog/pySim-read: add pySimLogger and verbose cmdline argument pySim-prog and pySim-read do not integrate the pySimLogger yet. As we may add more debug output that should not be visible on normal use, we should ensure that the pySimLogger is correctly set up. Change-Id: Ia2fa535fd9ce4ffa301c3f5d6f98c1f7a4716c74 --- M pySim-prog.py M pySim-read.py 2 files changed, 19 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/05/42305/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42305?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia2fa535fd9ce4ffa301c3f5d6f98c1f7a4716c74 Gerrit-Change-Number: 42305 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org>

1 0

[S] Change in pysim[master]: pySim-prog/pySim-read: add pySimLogger and verbose cmdline argument
by dexter 11 Mar '26

11 Mar '26

Attention is currently required from: laforge. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42305?usp=email ) Change subject: pySim-prog/pySim-read: add pySimLogger and verbose cmdline argument ...................................................................... Patch Set 2: (1 comment) File pySim-read.py: https://gerrit.osmocom.org/c/pysim/+/42305/comment/dfa3d055_43f41b43?usp=em… : PS1, Line 84: # Setup logger : PySimLogger.setup(print, {logging.WARN: "\033[33m"}) : if (opts.verbose): : PySimLogger.set_verbose(True) : PySimLogger.set_level(logging.DEBUG) : else: : PySimLogger.set_verbose(False) : PySimLogger.set_level(logging.INFO) > it looks like this should go in some generic helper function that we call from all the programs, sim […] Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42305?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia2fa535fd9ce4ffa301c3f5d6f98c1f7a4716c74 Gerrit-Change-Number: 42305 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 10 Mar 2026 14:29:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[S] Change in pysim[master]: PySimLogger: add parameter to set initial log-level/verbosity
by dexter 11 Mar '26

11 Mar '26

Attention is currently required from: dexter, laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/42304?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified-1 by Jenkins Builder Change subject: PySimLogger: add parameter to set initial log-level/verbosity ...................................................................... PySimLogger: add parameter to set initial log-level/verbosity When we initialize a new PySimLogger, we always call the setup method first and then use the set_verbose and set_level method to configure the initial log level and the initial log verbosity. However, we initialize the PySimLogger in all our programs the same way and we end up with the same boilerplate code every time. Let's add a keyword parameter to the setup method where we can pass our opts.verbose (bool) parameter so that the setup method can do the work for the main program. In case the caller wants a different default configuration he still can call set_verbose and set_level methods as needed. Change-Id: I4b8ef1e203186878910c9614a1d900d5759236a8 --- M contrib/csv-to-pgsql.py M pySim-shell.py M pySim/log.py 3 files changed, 14 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/04/42304/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42304?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4b8ef1e203186878910c9614a1d900d5759236a8 Gerrit-Change-Number: 42304 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in osmo-ccid-firmware[master]: ccid: Fix CCID RDR_to_PC_Parameters (missing bProtocolNum)
by lynxis lazus 11 Mar '26

11 Mar '26

Attention is currently required from: Hoernchen, laforge, pespin. lynxis lazus has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42157?usp=email ) Change subject: ccid: Fix CCID RDR_to_PC_Parameters (missing bProtocolNum) ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42157?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I67d5cb876d20b29f4759d5b194606f34b8b966c4 Gerrit-Change-Number: 42157 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Mar 2026 14:23:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: cdma_ruim: fix copy-pasted desc for EF.AD
by fixeria 11 Mar '26

11 Mar '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/42309?usp=email ) Change subject: cdma_ruim: fix copy-pasted desc for EF.AD ...................................................................... cdma_ruim: fix copy-pasted desc for EF.AD Change-Id: I2338f35c21978dd6b8916c0abd57b94f5e087655 --- M pySim/cdma_ruim.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/09/42309/1 diff --git a/pySim/cdma_ruim.py b/pySim/cdma_ruim.py index 0aac683..7bfebae 100644 --- a/pySim/cdma_ruim.py +++ b/pySim/cdma_ruim.py @@ -128,7 +128,7 @@ cell_test = 0x04 def __init__(self, fid='6f43', sfid=None, name='EF.AD', - desc='Service Provider Name', size=(3, None), **kwargs): + desc='Administrative Data', size=(3, None), **kwargs): super().__init__(fid, sfid=sfid, name=name, desc=desc, size=size, **kwargs) self._construct = Struct( # Byte 1: Display Condition -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42309?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2338f35c21978dd6b8916c0abd57b94f5e087655 Gerrit-Change-Number: 42309 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in pysim[master]: global_platform: install_cap_parser: argument groups cannot be nested
by fixeria 11 Mar '26

11 Mar '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/42310?usp=email ) Change subject: global_platform: install_cap_parser: argument groups cannot be nested ...................................................................... global_platform: install_cap_parser: argument groups cannot be nested pySim-shell currently does not work on systems with Python 3.14+: File ".../pysim/pySim/global_platform/__init__.py", line 868, in AddlShellCommands install_cap_parser_inst_prm_g_grp = install_cap_parser_inst_prm_g.add_argument_group() File "/usr/lib/python3.14/argparse.py", line 1794, in add_argument_group raise ValueError('argument groups cannot be nested') ValueError('argument groups cannot be nested') The problem is that install_cap_parser creates a nested group inside of mutually exclusive group. argparse never supported group nesting properly, so it has been deprecated since Python 3.11, and eventually got removed in Python 3.14. Remove group nesting, adjust the usage string, and implement the mutual exclusiveness/inclusiveness manually in do_install_cap(). Change-Id: Idddf72d5a745345e134b23f2f01e0257d0667579 --- M pySim/global_platform/__init__.py 1 file changed, 27 insertions(+), 15 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/10/42310/1 diff --git a/pySim/global_platform/__init__.py b/pySim/global_platform/__init__.py index 8a99677..1c0d521 100644 --- a/pySim/global_platform/__init__.py +++ b/pySim/global_platform/__init__.py @@ -859,22 +859,28 @@ _rsp_hex, _sw = self._cmd.lchan.scc.send_apdu_checksw(cmd_hex) self._cmd.poutput("Loaded a total of %u bytes in %u blocks. Don't forget install_for_install (and make selectable) now!" % (total_size, block_nr)) - install_cap_parser = argparse.ArgumentParser() + install_cap_parser = argparse.ArgumentParser(usage='%(prog)s FILE (--install-parameters | --install-parameters-*)') install_cap_parser.add_argument('cap_file', type=str, metavar='FILE', help='JAVA-CARD CAP file to install') - install_cap_parser_inst_prm_g = install_cap_parser.add_mutually_exclusive_group() - install_cap_parser_inst_prm_g.add_argument('--install-parameters', type=is_hexstr, default=None, - help='install Parameters (GPC_SPE_034, section 11.5.2.3.7, table 11-49)') - install_cap_parser_inst_prm_g_grp = install_cap_parser_inst_prm_g.add_argument_group() - install_cap_parser_inst_prm_g_grp.add_argument('--install-parameters-volatile-memory-quota', - type=int, default=None, - help='volatile memory quota (GPC_SPE_034, section 11.5.2.3.7, table 11-49)') - install_cap_parser_inst_prm_g_grp.add_argument('--install-parameters-non-volatile-memory-quota', - type=int, default=None, - help='non volatile memory quota (GPC_SPE_034, section 11.5.2.3.7, table 11-49)') - install_cap_parser_inst_prm_g_grp.add_argument('--install-parameters-stk', - type=is_hexstr, default=None, - help='Load Parameters (ETSI TS 102 226, section 8.2.1.3.2.1)') + # Ideally, the parser should enforce that: + # * either the `--install-parameters` is given alone, + # * or all `--install-parameters-*` are given together. + # We tried to achieve this using mutually exclusive groups (add_mutually_exclusive_group). + # However, group nesting was never supported, often failed to work correctly, and was unintentionally + # exposed through inheritance. It has been deprecated since version 3.11, removed in version 3.14. + # Hence, we have to implement the enforcement manually. + install_cap_parser_inst_prm_grp = install_cap_parser.add_argument_group('Install Parameters') + install_cap_parser_inst_prm_grp.add_argument('--install-parameters', type=is_hexstr, default=None, + help='install Parameters (GPC_SPE_034, section 11.5.2.3.7, table 11-49)') + install_cap_parser_inst_prm_grp.add_argument('--install-parameters-volatile-memory-quota', + type=int, default=None, + help='volatile memory quota (GPC_SPE_034, section 11.5.2.3.7, table 11-49)') + install_cap_parser_inst_prm_grp.add_argument('--install-parameters-non-volatile-memory-quota', + type=int, default=None, + help='non volatile memory quota (GPC_SPE_034, section 11.5.2.3.7, table 11-49)') + install_cap_parser_inst_prm_grp.add_argument('--install-parameters-stk', + type=is_hexstr, default=None, + help='Load Parameters (ETSI TS 102 226, section 8.2.1.3.2.1)') @cmd2.with_argparser(install_cap_parser) def do_install_cap(self, opts): @@ -888,9 +894,15 @@ load_file_aid = cap.get_loadfile_aid() module_aid = cap.get_applet_aid() application_aid = module_aid - if opts.install_parameters: + # `--install-parameters` and `--install-parameters-*` are mutually exclusive + if opts.install_parameters is not None: install_parameters = opts.install_parameters; else: + # `--install-parameters-*` are mutually inclusive + if opts.install_parameters_non_volatile_memory_quota is None or \ + opts.install_parameters_volatile_memory_quota is None or \ + opts.install_parameters_stk is None: + raise ValueError("Either --install-parameters alone, or all --install-parameters-* must be specified") install_parameters = gen_install_parameters(opts.install_parameters_non_volatile_memory_quota, opts.install_parameters_volatile_memory_quota, opts.install_parameters_stk) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42310?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Idddf72d5a745345e134b23f2f01e0257d0667579 Gerrit-Change-Number: 42310 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-ccid-firmware[master]: ccid: Fix [unused] RDR_to_PC_Hardware_Error struct definition
by lynxis lazus 11 Mar '26

11 Mar '26

Attention is currently required from: laforge, pespin. lynxis lazus has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42303?usp=email ) Change subject: ccid: Fix [unused] RDR_to_PC_Hardware_Error struct definition ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42303?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: Ieb756c37402c4ebea32cc3cd23ba3842f4c0df3e Gerrit-Change-Number: 42303 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 Mar 2026 14:18:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log