Attention is currently required from: Hoernchen, Timur Davydov, fixeria, laforge, osmith.
pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42243?usp=email )
Change subject: build: install common/GSM/transceiver libraries for emscripten and add pkg-config files
......................................................................
Patch Set 4:
(1 comment)
File configure.ac:
https://gerrit.osmocom.org/c/osmo-trx/+/42243/comment/bfe5c112_88e4c0ac?usp… :
PS3, Line 307: PKG_CHECK_MODULES(FFTWF, fftw3f)
> I still fail to see how you can build the files above without including fft.c. […]
How is for instance
cxvec_fft() linked in Transceiver52M/Synthesis.cpp or Transceiver52M/Channelizer.cpp without fft.c being compiled?
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42243?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I2495c5b5c79f2fe74bef83902058e1d2207c1f3c
Gerrit-Change-Number: 42243
Gerrit-PatchSet: 4
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Comment-Date: Tue, 10 Mar 2026 10:39:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: Timur Davydov <dtv.comp(a)gmail.com>
Attention is currently required from: Hoernchen, lynxis lazus, pespin.
laforge has uploaded a new patch set (#3) to the change originally created by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42157?usp=email )
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: ccid: Fix CCID RDR_to_PC_Parameters (missing bProtocolNum)
......................................................................
ccid: Fix CCID RDR_to_PC_Parameters (missing bProtocolNum)
Our RDR_to_PC_Parameters message was broken, as it was missing
the bProtocolNum value after the header. Let's fix that.
Change-Id: I67d5cb876d20b29f4759d5b194606f34b8b966c4
---
M ccid_common/ccid_device.c
M ccid_common/ccid_proto.h
2 files changed, 7 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/57/42157/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42157?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: I67d5cb876d20b29f4759d5b194606f34b8b966c4
Gerrit-Change-Number: 42157
Gerrit-PatchSet: 3
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42303?usp=email )
Change subject: ccid: Fix [unused] RDR_to_PC_Hardware_Error struct definition
......................................................................
ccid: Fix [unused] RDR_to_PC_Hardware_Error struct definition
Our definition of the message was wrong; it is an interrupt endpoint
message without the full header of the bulk-in endpoint. Luckily the
definition was not used in the code base, so this is not fixing any
problem visible on the protocol level.
Change-Id: Ieb756c37402c4ebea32cc3cd23ba3842f4c0df3e
---
M ccid_common/ccid_proto.h
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/03/42303/1
diff --git a/ccid_common/ccid_proto.h b/ccid_common/ccid_proto.h
index ac03938..19f1333 100644
--- a/ccid_common/ccid_proto.h
+++ b/ccid_common/ccid_proto.h
@@ -402,9 +402,11 @@
uint8_t bmSlotCCState[0]; /* as long as bNumSlots/4 padded to next byte */
} __attribute__ ((packed));
-/* Section 6.3.1 */
+/* Section 6.3.2 - Interrupt IN message (4 bytes, NOT bulk header format) */
struct ccid_rdr_to_pc_hardware_error {
- struct ccid_header hdr;
+ uint8_t bMessageType; /* 0x51 */
+ uint8_t bSlot;
+ uint8_t bSeq;
uint8_t bHardwareErrorCode;
} __attribute__ ((packed));
--
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42303?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: Ieb756c37402c4ebea32cc3cd23ba3842f4c0df3e
Gerrit-Change-Number: 42303
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-CC: Hoernchen <ewild(a)sysmocom.de>
Attention is currently required from: lynxis lazus.
laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42302?usp=email )
Change subject: Errata 2.6.10: enable watchdog on boot
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
what kind of delay do we have configured until the watchdog triggers? I don't see that in the comments, and it is of course rather critical to understand the order of magnitude in comparison to e.g. the worst case timing of a flash write/erase command.
--
To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42302?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-asf4-dfu
Gerrit-Branch: master
Gerrit-Change-Id: I581037724d19fb5abd0c5067f16a5769f9e264a7
Gerrit-Change-Number: 42302
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Tue, 10 Mar 2026 09:56:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: lynxis lazus.
laforge has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42273?usp=email )
Change subject: dfu-download: flash the first block in manifest phase
......................................................................
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42273?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-asf4-dfu
Gerrit-Branch: master
Gerrit-Change-Id: I894f3ee71587ccb287e92d7025039954991c631f
Gerrit-Change-Number: 42273
Gerrit-PatchSet: 5
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Tue, 10 Mar 2026 09:48:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes