August 2023 - gerrit-log - lists.osmocom.org

[L] Change in libosmo-netif[master]: stream tests: Eliminate timestamps from output

by arehbein

Attention is currently required from: pespin, daniel. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/34224 ) Change subject: stream tests: Eliminate timestamps from output ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Simply and plain for me: I just submitted a test patch based on libosmo-netif master and it's passin […] This doesn't prove that the problem is local or related to my patch. The problems have been that for two patches (see above text, "Add ... support for IPA", for the server side patch I found a workaround by using a different local port), timestamps all of a sudden stopped being predictable and hence tests failed with these patches (.ok-output not matching). The test code itself has not been changed and you can read above what commits are causing this deviation in timestamps (I haven't yet busied myself with identifying the exact reason or commit, my guess is it doesn't matter in the end). If you were to rebase https://gerrit.osmocom.org/c/libosmo-netif/+/33198/19 on libosmo-netif master - I gave the then-HEAD commit hash for reference - , you should be able see what I'm talking about (the lastest revision - 20 - was uploaded together with this change and doesn't use timestamps, so it would fail for other discrepancies in stdout output). -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/34224 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I7faed932927d4f6e328a28c7f30a647a7272e89c Gerrit-Change-Number: 34224 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 31 Aug 2023 19:07:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

8 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: NAS_Templates: add template for Tracking Area Update Request

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34271 ) Change subject: NAS_Templates: add template for Tracking Area Update Request ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34271 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I66843f30f70d73ff233b0da0680cbaba08838227 Gerrit-Change-Number: 34271 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 31 Aug 2023 17:00:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

8 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: NAS_Templates: add template for NAS key set identifier

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34270 ) Change subject: NAS_Templates: add template for NAS key set identifier ...................................................................... Patch Set 1: (1 comment) File library/NAS_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34270/comment/1b8aba22_994c… PS1, Line 330: const BIT3 c_NAS_KEY_SET_ID_NO_KEY := '111'B; enum -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34270 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2df0c9d1bf4bf0073b5f7b77708b8de59f96a639 Gerrit-Change-Number: 34270 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 31 Aug 2023 16:59:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

8 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: NAS_Templates: add template for EPS update type

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34269 ) Change subject: NAS_Templates: add template for EPS update type ...................................................................... Patch Set 1: (1 comment) File library/NAS_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34269/comment/3bc54388_20e7… PS1, Line 320: const BIT3 c_EPS_UPD_TYPE_TA_UPD := '000'B; this should be an enum afaiu. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34269 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6ffac88cc1d3967dc8000e17a65cdba79a013cf7 Gerrit-Change-Number: 34269 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 31 Aug 2023 16:59:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

8 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: NAS_Templates: add templates for EPS_Mobile_ID_IMSI/IMEI/GUTI

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34268 ) Change subject: NAS_Templates: add templates for EPS_Mobile_ID_IMSI/IMEI/GUTI ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34268 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1adf8c652530904a8e9bd988e78c995c75bb49ab Gerrit-Change-Number: 34268 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 31 Aug 2023 16:59:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

8 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: NAS_Templates: fix ts_NAS_GUTI

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34267 ) Change subject: NAS_Templates: fix ts_NAS_GUTI ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: So what you are saying is that ts_NAS_GUTI was wrong? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34267 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9546993987b873e8ae921664238b234608e37bba Gerrit-Change-Number: 34267 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 31 Aug 2023 16:58:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

8 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: MME_Tests: Add S11/GTPv2 interface

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34266 ) Change subject: MME_Tests: Add S11/GTPv2 interface ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34266 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I545dd6cef3cef7283f2e04c2406a2703c2fdd01a Gerrit-Change-Number: 34266 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 31 Aug 2023 16:57:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

8 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: GTPv2_Emulation: make sure g_uecups_conn_id is populated.

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34265 ) Change subject: GTPv2_Emulation: make sure g_uecups_conn_id is populated. ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34265 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifc2e8d9de13d5d183d6f052b2092c356ab4973d1 Gerrit-Change-Number: 34265 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 31 Aug 2023 16:55:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

8 months

1
0
0 0

[S] Change in libosmo-sccp[master]: ipa: use LSBs of file descriptor as SLS in IPA->M3UA direction

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34264 ) Change subject: ipa: use LSBs of file descriptor as SLS in IPA->M3UA direction ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: Why not have a global variable incrementing with each new conn instead of taking it from fd? That would improve a lot the equal distribution. Depending on how fds are allocated they can end up with most ASPs using the same SLS. File src/ipa.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/34264/comment/c12cd83b_358ffdf4 PS1, Line 295: * \param[in] msg received message buffer. Callee takes ownership! missing new param documentation -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34264 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ice7bab997b84cfed00c7d6d780c70f4e9fac6002 Gerrit-Change-Number: 34264 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 31 Aug 2023 16:55:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

8 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: stp: Don't expect a fixed SLS in IPA -> M3UA case

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34263 ) Change subject: stp: Don't expect a fixed SLS in IPA -> M3UA case ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34263 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib70322b80a72e3e7dc3155bca9e67b03efb413e0 Gerrit-Change-Number: 34263 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 31 Aug 2023 16:48:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

8 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: GTP_Templates: Fix several template type incongruencies

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34261 ) Change subject: GTP_Templates: Fix several template type incongruencies ...................................................................... GTP_Templates: Fix several template type incongruencies This fixes following error while running test GGSN_Tests.TC_pdp46_act_deact_apn4: "GTP_Templates.ttcn:315 Dynamic test case error: Restriction `omit' on template of type octetstring violated." Change-Id: I3846d2a077e4bc53a772e354fcc3c38ca952b38f --- M library/GTP_Templates.ttcn 1 file changed, 24 insertions(+), 9 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/library/GTP_Templates.ttcn b/library/GTP_Templates.ttcn index 8ab830e..06ba208 100644 --- a/library/GTP_Templates.ttcn +++ b/library/GTP_Templates.ttcn @@ -241,7 +241,7 @@ gtpc := ts_GTP1C_PDU(echoRequest, '00000000'O, valueof(ts_EchoReqPDU), seq) } - private function f_eua_ipv4_len(template (present) OCT4 ip_addr) return template integer { + private function f_eua_ipv4_len(template OCT4 ip_addr) return template (present) integer { if (istemplatekind(ip_addr, "omit")) { return 2; } else if (istemplatekind(ip_addr, "*")) { @@ -252,7 +252,7 @@ return 6; } - private function f_eua_ipv6_len(template (omit) OCT16 ip_addr) return template (present) integer { + private function f_eua_ipv6_len(template OCT16 ip_addr) return template (present) integer { if (istemplatekind(ip_addr, "omit")) { return 2; } else if (istemplatekind(ip_addr, "*")) { @@ -263,7 +263,7 @@ return 18; } - private function f_eua_ipv4v6_len(template (omit) OCT4 ip_addr4, template (omit) OCT16 ip_addr6) return template (present) integer { + private function f_eua_ipv4v6_len(template OCT4 ip_addr4, template OCT16 ip_addr6) return template (present) integer { var integer len := 2; if (istemplatekind(ip_addr4, "*") or istemplatekind(ip_addr6, "*")) { @@ -278,7 +278,7 @@ return len; } - template EndUserAddress t_EuaIPv4(template OCT4 ip_addr) := { + template (present) EndUserAddress t_EuaIPv4(template OCT4 ip_addr) := { type_gtpc := '80'O, endUserAddress := { endUserAddressIPv4 := { @@ -290,7 +290,7 @@ } } } - template EndUserAddress t_EuaIPv4Dyn := t_EuaIPv4(omit); + template (present) EndUserAddress t_EuaIPv4Dyn := t_EuaIPv4(omit); template (present) EndUserAddress tr_EuaIPv4(template (present) OCT4 ip_addr) modifies t_EuaIPv4 := { endUserAddress := { endUserAddressIPv4 := { @@ -299,7 +299,7 @@ } } - template EndUserAddress t_EuaIPv6(template OCT16 ip_addr) := { + template (present) EndUserAddress t_EuaIPv6(template OCT16 ip_addr) := { type_gtpc := '80'O, endUserAddress := { endUserAddressIPv6 := { @@ -311,7 +311,7 @@ } } } - template EndUserAddress t_EuaIPv6Dyn := t_EuaIPv6(omit); + template (present) EndUserAddress t_EuaIPv6Dyn := t_EuaIPv6(omit); template (present) EndUserAddress tr_EuaIPv6(template (present) OCT16 ip_addr) modifies t_EuaIPv6 := { endUserAddress := { endUserAddressIPv6 := { @@ -321,7 +321,7 @@ } /* 3GPP TS 29.060 Figure 37A: End User Address Information Element for IPv4v6 (both static) */ - template EndUserAddress t_EuaIPv4v6(template OCT4 ip_addr4, template OCT16 ip_addr6) := { + template (present) EndUserAddress t_EuaIPv4v6(template OCT4 ip_addr4, template OCT16 ip_addr6) := { type_gtpc := '80'O, endUserAddress := { endUserAddressIPv4andIPv6 := { @@ -334,7 +334,7 @@ } } } - template EndUserAddress t_EuaIPv4Dynv6Dyn := t_EuaIPv4v6(omit, omit); + template (present) EndUserAddress t_EuaIPv4Dynv6Dyn := t_EuaIPv4v6(omit, omit); template (present) EndUserAddress tr_EuaIPv4v6(template (present) OCT4 ip_addr4, template (present) OCT16 ip_addr6) modifies t_EuaIPv4v6 := { endUserAddress := { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34261 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3846d2a077e4bc53a772e354fcc3c38ca952b38f Gerrit-Change-Number: 34261 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

8 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: GTP_Templates: Fix several template type incongruencies

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34261 ) Change subject: GTP_Templates: Fix several template type incongruencies ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34261 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3846d2a077e4bc53a772e354fcc3c38ca952b38f Gerrit-Change-Number: 34261 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 31 Aug 2023 16:47:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

8 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: GTPv2_Emulation: make sure g_uecups_conn_id is populated.

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34265 ) Change subject: GTPv2_Emulation: make sure g_uecups_conn_id is populated. ...................................................................... GTPv2_Emulation: make sure g_uecups_conn_id is populated. In function f_init, we activate altstep as_uecups_ind at the end of the function. In as_uecups we use the template generator function tr_UECUPS_RecvFrom_R(). In this function we use g_uecups_conn_id, which is only populated when use_gtpu_daemon is set to true. When use_gtpu_daemon is false g_uecups_conn_id will be <unbound>, which leads into an error. Related: OS#5760 Change-Id: Ifc2e8d9de13d5d183d6f052b2092c356ab4973d1 --- M library/GTPv2_Emulation.ttcn 1 file changed, 19 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/65/34265/1 diff --git a/library/GTPv2_Emulation.ttcn b/library/GTPv2_Emulation.ttcn index 5bb3b1e..ff6a60a 100644 --- a/library/GTPv2_Emulation.ttcn +++ b/library/GTPv2_Emulation.ttcn @@ -389,6 +389,8 @@ remPort := g_gtp2_cfg.gtpc_remote_port } + g_uecups_conn_id := res.connId; + if (g_gtp2_cfg.use_gtpu_daemon) { map(self:UECUPS, system:UECUPS); res := UECUPS_CodecPort_CtrlFunct.f_IPL4_connect(UECUPS, mp_uecups_host, mp_uecups_port, "", -1, -1, { sctp := valueof(ts_SCTP) }); @@ -396,7 +398,6 @@ setverdict(fail, "Could not connect UECUPS socket, check your configuration"); testcase.stop; } - g_uecups_conn_id := res.connId; /* clear all tunnel state in the daemon at start */ f_uecups_xceive({reset_all_state := {}}, {reset_all_state_res:=?}, 30.0); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34265 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifc2e8d9de13d5d183d6f052b2092c356ab4973d1 Gerrit-Change-Number: 34265 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

8 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: MME_Tests: Add S11/GTPv2 interface

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34266 ) Change subject: MME_Tests: Add S11/GTPv2 interface ...................................................................... MME_Tests: Add S11/GTPv2 interface The S11 interface is used by the MME to talk to the SGW-C. At the moment we do not simulate the S11 interface in our testcases. This is in particular a problem for TC_s1ap_attach, which needs to answer the Create Session Request, comming from the MME in order to continue. As a first step, lets add evrything that is required to run an S11 interface in the testsuite. Change-Id: I545dd6cef3cef7283f2e04c2406a2703c2fdd01a Related: OS#5760 --- M mme/MME_Tests.ttcn M mme/gen_links.sh M mme/regen_makefile.sh 3 files changed, 67 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/66/34266/1 diff --git a/mme/MME_Tests.ttcn b/mme/MME_Tests.ttcn index cc75377..7a709fd 100644 --- a/mme/MME_Tests.ttcn +++ b/mme/MME_Tests.ttcn @@ -44,6 +44,10 @@ import from Osmocom_Types all; import from Osmocom_Gb_Types all; +import from GTPv2_Types all; +import from GTPv2_Templates all; +import from GTPv2_Emulation all; + friend module MME_Tests_SGsAP; /* (maximum) number of emulated eNBs */ @@ -84,6 +88,10 @@ /* Gn interface (GTPv1C) of emulated SGSN (Rel. 7) */ var GTP_Emulation_CT vc_GTP; + /* S11 interface (GTPv2C) of emulated SGW-C */ + var GTPv2_Emulation_CT vc_GTP2; + port GTP2EM_PT TEID0; + var UeParams g_ue_pars[NUM_UE]; } @@ -116,7 +124,7 @@ return substr(encoded, 11, global_enb_id_len); } -type component ConnHdlr extends S1AP_ConnHdlr, SGsAP_ConnHdlr, DIAMETER_ConnHdlr, GTP_ConnHdlr { +type component ConnHdlr extends S1AP_ConnHdlr, SGsAP_ConnHdlr, DIAMETER_ConnHdlr, GTP_ConnHdlr, GTP2_ConnHdlr { var ConnHdlrPars g_pars; timer g_Tguard := 30.0; @@ -153,6 +161,12 @@ charstring mp_gn_local_ip := "127.0.0.22"; integer mp_gn_local_port := 2123; charstring mp_gn_remote_ip := "127.0.0.2"; + + /* S11 interface (GTPv2C, interface between MME and SGW) */ + charstring mp_s11_local_ip := "127.0.0.3"; + integer mp_s11_local_port := 2123; + charstring mp_s11_remote_ip := "127.0.0.2"; + integer mp_s11_remote_port := 2123; } /* send incoming unit data messages (like reset) to global SGsAP_UNIT port */ @@ -290,7 +304,25 @@ vc_GTP.start(GTP_Emulation.main(gtp_cfg)); } -friend template (value) TAI ts_enb_S1AP_TAI(EnbParams enb) := { +friend function f_init_gtpv2_s11(charstring id) runs on MTC_CT { + id := id & "-GTPV2"; + + var Gtp2EmulationCfg cfg := { + gtpc_bind_ip := mp_s11_local_ip, + gtpc_bind_port := mp_s11_local_port, + gtpc_remote_ip := mp_s11_remote_ip, + gtpc_remote_port := mp_s11_remote_port, + sgw_role := true, + use_gtpu_daemon := false + }; + + vc_GTP2 := GTPv2_Emulation_CT.create(id); + map(vc_GTP2:GTP2C, system:GTP2C); + connect(vc_GTP2:TEID0, self:TEID0); + vc_GTP2.start(GTPv2_Emulation.main(cfg)); +} + +friend template (value) S1AP_IEs.TAI ts_enb_S1AP_TAI(EnbParams enb) := { pLMNidentity := enb.global_enb_id.pLMNidentity, tAC := enb.supported_tas[0].tAC, iE_Extensions := omit @@ -371,8 +403,8 @@ -friend function f_s1ap_setup(integer idx := 0, template Cause cause := omit) runs on MTC_CT { - var template (present) Cause exp_cause; +friend function f_s1ap_setup(integer idx := 0, template S1AP_IEs.Cause cause := omit) runs on MTC_CT { + var template (present) S1AP_IEs.Cause exp_cause; var boolean exp_fail := false; timer T := 5.0; if (not istemplatekind(cause, "omit")) { @@ -911,7 +943,7 @@ f_init_s1ap(id, 3); f_s1ap_setup(0); - var template (value) Cause reset_cause := {misc := om_intervention}; + var template (value) S1AP_IEs.Cause reset_cause := {misc := om_intervention}; var template (value) ResetType reset_type := {s1_Interface := reset_all}; timer T := 5.0; diff --git a/mme/gen_links.sh b/mme/gen_links.sh index e0a038b..f10a161 100755 --- a/mme/gen_links.sh +++ b/mme/gen_links.sh @@ -51,6 +51,14 @@ FILES="BSSGP_EncDec.cc BSSGP_Types.ttcn" gen_links $DIR $FILES +DIR=$BASEDIR/titan.ProtocolModules.GTPv2_v13.7.0/src +FILES="GTPv2_Types.ttcn" +gen_links $DIR $FILES + +DIR=$BASEDIR/osmo-uecups/ttcn3 +FILES="UECUPS_CodecPort.ttcn UECUPS_CodecPort_CtrlFunct.ttcn UECUPS_CodecPort_CtrlFunctDef.cc UECUPS_Types.ttcn " +gen_links $DIR $FILES + DIR=$BASEDIR/titan.ProtocolModules.DIAMETER_ProtocolModule_Generator/src FILES="DIAMETER_EncDec.cc" gen_links $DIR $FILES @@ -69,6 +77,8 @@ FILES+="NAS_Templates.ttcn GTPv2_PrivateExtensions.ttcn GTPv2_Templates.ttcn " FILES+="DIAMETER_Types.ttcn DIAMETER_CodecPort.ttcn DIAMETER_CodecPort_CtrlFunct.ttcn DIAMETER_CodecPort_CtrlFunctDef.cc DIAMETER_Emulation.ttcn DIAMETER_Templates.ttcn " FILES+="GTP_CodecPort.ttcn GTP_CodecPort_CtrlFunct.ttcn GTP_CodecPort_CtrlFunctDef.cc GTP_Emulation.ttcn GTP_Templates.ttcn Osmocom_Gb_Types.ttcn " +FILES+="GTPv2_PrivateExtensions.ttcn GTPv2_Templates.ttcn " +FILES+="GTPv2_CodecPort.ttcn GTPv2_CodecPort_CtrlFunctDef.cc GTPv2_CodecPort_CtrlFunct.ttcn GTPv2_Emulation.ttcn " FILES+="BSSGP_Emulation.ttcnpp Osmocom_Gb_Types.ttcn " gen_links $DIR $FILES diff --git a/mme/regen_makefile.sh b/mme/regen_makefile.sh index df5151e..e153d35 100755 --- a/mme/regen_makefile.sh +++ b/mme/regen_makefile.sh @@ -12,6 +12,7 @@ GTPC_EncDec.cc GTPU_EncDec.cc GTP_CodecPort_CtrlFunctDef.cc + GTPv2_CodecPort_CtrlFunctDef.cc IPL4asp_PT.cc IPL4asp_discovery.cc LTE_CryptoFunctionDefs.cc @@ -23,6 +24,7 @@ TCCEncoding.cc TCCInterface.cc TELNETasp_PT.cc + UECUPS_CodecPort_CtrlFunctDef.cc " -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34266 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I545dd6cef3cef7283f2e04c2406a2703c2fdd01a Gerrit-Change-Number: 34266 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

8 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: NAS_Templates: fix ts_NAS_GUTI

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34267 ) Change subject: NAS_Templates: fix ts_NAS_GUTI ...................................................................... NAS_Templates: fix ts_NAS_GUTI The template ts_NAS_GUTI permutates the MCC/MNC digits in a weird way, which seems to map to a format that is not used anywhere else. Also the template is not used anywhere yet. Let's not permutate the MCC/MNC digit, instead let's put a comment that makes clear which format has to be used. Change-Id: I9546993987b873e8ae921664238b234608e37bba Related: OS#5760 --- M library/NAS_Templates.ttcn 1 file changed, 23 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/67/34267/1 diff --git a/library/NAS_Templates.ttcn b/library/NAS_Templates.ttcn index f819862..bbe7237 100644 --- a/library/NAS_Templates.ttcn +++ b/library/NAS_Templates.ttcn @@ -111,13 +111,15 @@ template (value) GUTI ts_NAS_GUTI(hexstring mcc_mnc, OCT2 mmegi, OCT1 mmec, OCT4 tmsi) := { oddevenIndicator := '0'B, spare := '1111'B, - /* mcc_mnc specified in format 262f42 */ + /* use the mcc_mnc format as specified in 3GPP TS 24.301, figure 9.9.3.12.1. + * Example: mcc=262, mnc=42 => 262f42. + * mcc=001, mnc=01 => 001f01. */ mccDigit1 := mcc_mnc[0], mccDigit2 := mcc_mnc[1], mccDigit3 := mcc_mnc[2], - mncDigit3 := mcc_mnc[5], - mncDigit1 := mcc_mnc[3], - mncDigit2 := mcc_mnc[4], + mncDigit3 := mcc_mnc[3], + mncDigit1 := mcc_mnc[4], + mncDigit2 := mcc_mnc[5], mMEGI := mmegi, mMEC := mmec, mTMSI := tmsi -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34267 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9546993987b873e8ae921664238b234608e37bba Gerrit-Change-Number: 34267 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

8 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: NAS_Templates: add templates for EPS_Mobile_ID_IMSI/IMEI/GUTI

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34268 ) Change subject: NAS_Templates: add templates for EPS_Mobile_ID_IMSI/IMEI/GUTI ...................................................................... NAS_Templates: add templates for EPS_Mobile_ID_IMSI/IMEI/GUTI We do have ts_NAS_MobileId_IMSI/IMEI/GUTI, those can not be used when crafting EPS messages. However, we can use them to craft ts_EPS_MobileId_IMSI/IMEI/GUTI templates. Related: OS#5760 Change-Id: I1adf8c652530904a8e9bd988e78c995c75bb49ab --- M library/NAS_Templates.ttcn 1 file changed, 30 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/68/34268/1 diff --git a/library/NAS_Templates.ttcn b/library/NAS_Templates.ttcn index bbe7237..97469d9 100644 --- a/library/NAS_Templates.ttcn +++ b/library/NAS_Templates.ttcn @@ -149,6 +149,22 @@ } } +/* 9.9.3.12 EPS mobile identity */ +template (value) EPS_MobileIdentityLV +ts_EPS_MobileId_IMSI(hexstring imsi) := { + ePS_MobileIdentity := ts_NAS_MobileId_IMSI(imsi) +} + +template (value) EPS_MobileIdentityLV +ts_EPS_MobileId_IMEI(hexstring imei) := { + ePS_MobileIdentity := ts_NAS_MobileId_IMEI(imei) +} + +template (value) EPS_MobileIdentityLV +ts_EPS_MobileId_GUTI(hexstring mcc_mnc, OCT2 mmegi, OCT1 mmec, OCT4 tmsi) := { + ePS_MobileIdentity := ts_NAS_MobileId_GUTI(mcc_mnc, mmegi, mmec, tmsi) +} + template (value) PDU_NAS_EPS ts_NAS_EMM_SecurityProtected(BIT4 sec_hdr_t, integer seq_nr, octetstring inner_nas) := { protocolDiscriminator := c_EPS_NAS_PD_EMM, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34268 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1adf8c652530904a8e9bd988e78c995c75bb49ab Gerrit-Change-Number: 34268 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

8 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: NAS_Templates: add template for EPS update type

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34269 ) Change subject: NAS_Templates: add template for EPS update type ...................................................................... NAS_Templates: add template for EPS update type Related: OS#5760 Change-Id: I6ffac88cc1d3967dc8000e17a65cdba79a013cf7 --- M library/NAS_Templates.ttcn 1 file changed, 19 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/69/34269/1 diff --git a/library/NAS_Templates.ttcn b/library/NAS_Templates.ttcn index 97469d9..2e8be0e 100644 --- a/library/NAS_Templates.ttcn +++ b/library/NAS_Templates.ttcn @@ -316,6 +316,15 @@ } } +/* 9.9.3.14 EPS update type */ +const BIT3 c_EPS_UPD_TYPE_TA_UPD := '000'B; +const BIT3 c_EPS_UPD_TYPE_COMB_TA_LA_UPD := '001'B; +const BIT3 c_EPS_UPD_TYPE_COMB_TA_LA_UPD_IMSI_ATTACH := '010'B; +const BIT3 c_EPS_UPD_TYPE_TA_UPD_PERIODIC := '011'B; +template (value) EPS_UpdateTypeV ts_EPS_UpdateTypeV(BIT3 typeOfUpdate := c_EPS_UPD_TYPE_TA_UPD, BIT1 activeFlag := '0'B) := { + typeOfUpdate := typeOfUpdate, + activeFlag := activeFlag +} /* 8.2.3 Attach Reject */ template (value) PDU_NAS_EPS -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34269 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6ffac88cc1d3967dc8000e17a65cdba79a013cf7 Gerrit-Change-Number: 34269 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

8 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: NAS_Templates: add template for NAS key set identifier

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34270 ) Change subject: NAS_Templates: add template for NAS key set identifier ...................................................................... NAS_Templates: add template for NAS key set identifier Related: OS#5760 Change-Id: I2df0c9d1bf4bf0073b5f7b77708b8de59f96a639 --- M library/NAS_Templates.ttcn 1 file changed, 19 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/70/34270/1 diff --git a/library/NAS_Templates.ttcn b/library/NAS_Templates.ttcn index 2e8be0e..f132c4e 100644 --- a/library/NAS_Templates.ttcn +++ b/library/NAS_Templates.ttcn @@ -326,6 +326,15 @@ activeFlag := activeFlag } +/* 9.9.3.21 NAS key set identifier */ +const BIT3 c_NAS_KEY_SET_ID_NO_KEY := '111'B; +const BIT1 c_NAS_TSC_NATIVE_SEC_CTX := '0'B; +const BIT1 c_NAS_TSC_MAPPED_SEC_CTX := '1'B; +template (value) NAS_KeySetIdentifierV ts_NAS_KeySetIdentifierV(BIT3 identifier := c_NAS_KEY_SET_ID_NO_KEY, BIT1 tSC := c_NAS_TSC_NATIVE_SEC_CTX) := { + identifier := identifier, + tSC := tSC +} + /* 8.2.3 Attach Reject */ template (value) PDU_NAS_EPS ts_NAS_AttachReject(template (value) EMM_CauseV cause) := { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34270 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2df0c9d1bf4bf0073b5f7b77708b8de59f96a639 Gerrit-Change-Number: 34270 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

8 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: NAS_Templates: add template for Tracking Area Update Request

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34271 ) Change subject: NAS_Templates: add template for Tracking Area Update Request ...................................................................... NAS_Templates: add template for Tracking Area Update Request Change-Id: I66843f30f70d73ff233b0da0680cbaba08838227 Related: OS#5760 --- M library/NAS_Templates.ttcn 1 file changed, 54 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/71/34271/1 diff --git a/library/NAS_Templates.ttcn b/library/NAS_Templates.ttcn index f132c4e..4b98ee8 100644 --- a/library/NAS_Templates.ttcn +++ b/library/NAS_Templates.ttcn @@ -335,6 +335,50 @@ tSC := tSC } +/* 8.2.29 Tracking Area Update Request */ +template (value) PDU_NAS_EPS +ts_PDU_NAS_EPS_TrackingAreaUpdateRequest(EPS_MobileIdentityLV old_guti) := { + protocolDiscriminator := c_EPS_NAS_PD_EMM, + ePS_messages := { + ePS_MobilityManagement := { + pDU_NAS_EPS_TrackingAreaUpdateRequest := { + securityHeaderType := c_EPS_SEC_NONE, + messageType := '01001000'B, + ePSupdateType := ts_EPS_UpdateTypeV, + nasKeySetId := ts_NAS_KeySetIdentifierV, + oldGUTI := old_guti, + nonCurrentNative_nasKeySetId := omit, + gprsCipheringKeySequenceNumber := omit, + old_P_TMSISignature := omit, + additionalGUTI := omit, + nonce := omit, + uENetworkCapability := omit, + lastVisitedRegisteredTAI := omit, + dRXParameter := omit, + uE_RadioCapabilityInfoUpdateNeeded := omit, + ePSBearerContextStatus := omit, + mSNetworkCapability := omit, + oldLocationAreaIdentification := omit, + tMSIStatusTV := omit, + mobileStationClassmark2 := omit, + mobileStationClassmark3 := omit, + supportedCodecList := omit, + additionalUpdateType := omit, + voiceDomainPrefandUEsettings := omit, + oldGUTI_Type := omit, + deviceProperties := omit, + mS_NetworkFeatureSupport := omit, + tMSIBasedNRIContainer := omit, + t3324 := omit, + t3412_Extended := omit, + extendedDRXParameters := omit, + uEAdditionalSecurityCapability := omit, + uEStatus := omit + } + } + } +} + /* 8.2.3 Attach Reject */ template (value) PDU_NAS_EPS ts_NAS_AttachReject(template (value) EMM_CauseV cause) := { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34271 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I66843f30f70d73ff233b0da0680cbaba08838227 Gerrit-Change-Number: 34271 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

8 months

1
0
0 0

[S] Change in osmo-trx[master]: ms: bump osmocom-bb submodule to current head

by Hoernchen

Hoernchen has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/34262 ) Change subject: ms: bump osmocom-bb submodule to current head ...................................................................... ms: bump osmocom-bb submodule to current head Change-Id: I9a16de0dce2e89fb522271ba63d908e33a1d7cde --- M osmocom-bb 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified Hoernchen: Looks good to me, approved diff --git a/osmocom-bb b/osmocom-bb index fb38499..096a3cc 160000 --- a/osmocom-bb +++ b/osmocom-bb @@ -1 +1 @@ -Subproject commit fb384998fbddcc545eec76da41db1aa41b583aa9 +Subproject commit 096a3cc6f3e982df09836b70a5adcd57a4b93ab9 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/34262 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I9a16de0dce2e89fb522271ba63d908e33a1d7cde Gerrit-Change-Number: 34262 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: merged

8 months

1
0
0 0

[S] Change in osmo-trx[master]: ms: bump osmocom-bb submodule to current head

by Hoernchen

Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/34262 ) Change subject: ms: bump osmocom-bb submodule to current head ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/34262 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I9a16de0dce2e89fb522271ba63d908e33a1d7cde Gerrit-Change-Number: 34262 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Thu, 31 Aug 2023 15:53:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

8 months

1
0
0 0

[S] Change in libosmo-sccp[master]: ipa: use LSBs of file descriptor as SLS in IPA->M3UA direction

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34264 ) Change subject: ipa: use LSBs of file descriptor as SLS in IPA->M3UA direction ...................................................................... ipa: use LSBs of file descriptor as SLS in IPA->M3UA direction when IPA/SCCPlite traffic traverses the osmo_ss7 stack, so far the SLS of the MTP3 label was always set to 0 (default initialization). However, in order to achieve a better distribution of signaling traffic in SS7 networks that actually utilize the SLS to select any links (or ASPs), it makes sense to use non-zero values. Instead of introducing some kind of new, configurable attribute for each ASP (IPA client connection), let's simply use the lower 4 bits of the file descriptor integer. Those file descriptors should have a roughly equal distribution, resulting in traffic (from multiple IPA clients) to be spread across the 4-bit SLS number space. Also, this mechanism ensures that traffic from one IPA client will always get the same SLS and hence routed the same way in any underlying CS7/SS7 network. Change-Id: Ice7bab997b84cfed00c7d6d780c70f4e9fac6002 Related: SYS#6543 --- M src/ipa.c M src/osmo_ss7.c M src/xua_internal.h 3 files changed, 34 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/64/34264/1 diff --git a/src/ipa.c b/src/ipa.c index 8daa5e0..874879e 100644 --- a/src/ipa.c +++ b/src/ipa.c @@ -211,7 +211,7 @@ return sccp_msg_out; } -static int ipa_rx_msg_sccp(struct osmo_ss7_asp *asp, struct msgb *msg) +static int ipa_rx_msg_sccp(struct osmo_ss7_asp *asp, struct msgb *msg, uint8_t sls) { int rc; struct m3ua_data_hdr data_hdr; @@ -276,6 +276,7 @@ data_hdr.si = MTP_SI_SCCP; data_hdr.opc = osmo_htonl(opc); data_hdr.dpc = osmo_htonl(dpc); + data_hdr.sls = sls; data_hdr.ni = as->inst->cfg.network_indicator; /* Create M3UA message in XUA structure */ xua = m3ua_xfer_from_data(&data_hdr, msgb_l2(msg), msgb_l2len(msg)); @@ -293,7 +294,7 @@ * \param[in] asp Application Server Process receiving \a msg * \param[in] msg received message buffer. Callee takes ownership! * \returns 0 on success; negative on error */ -int ipa_rx_msg(struct osmo_ss7_asp *asp, struct msgb *msg) +int ipa_rx_msg(struct osmo_ss7_asp *asp, struct msgb *msg, uint8_t sls) { struct ipaccess_head *hh; int rc; @@ -309,7 +310,7 @@ rc = ipa_rx_msg_ccm(asp, msg); break; case IPAC_PROTO_SCCP: - rc = ipa_rx_msg_sccp(asp, msg); + rc = ipa_rx_msg_sccp(asp, msg, sls); break; default: rc = ss7_asp_rx_unknown(asp, hh->proto, msg); diff --git a/src/osmo_ss7.c b/src/osmo_ss7.c index b8124d1..440014a 100644 --- a/src/osmo_ss7.c +++ b/src/osmo_ss7.c @@ -2046,7 +2046,7 @@ } msg->dst = asp; - return ipa_rx_msg(asp, msg); + return ipa_rx_msg(asp, msg, ofd->fd & 0xf); } /* netif code tells us we can read something from the socket */ @@ -2194,7 +2194,7 @@ } msg->dst = asp; rate_ctr_inc2(asp->ctrg, SS7_ASP_CTR_PKT_RX_TOTAL); - return ipa_rx_msg(asp, msg); + return ipa_rx_msg(asp, msg, ofd->fd & 0xf); } static int xua_cli_read_cb(struct osmo_stream_cli *conn) diff --git a/src/xua_internal.h b/src/xua_internal.h index 26cb3fc..93f6140 100644 --- a/src/xua_internal.h +++ b/src/xua_internal.h @@ -116,7 +116,7 @@ const struct xua_msg_part *rctx_ie); int ipa_tx_xua_as(struct osmo_ss7_as *as, struct xua_msg *xua); -int ipa_rx_msg(struct osmo_ss7_asp *asp, struct msgb *msg); +int ipa_rx_msg(struct osmo_ss7_asp *asp, struct msgb *msg, uint8_t sls); int osmo_isup_party_parse(char *out_digits, const uint8_t *in, unsigned int in_num_bytes, bool odd); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34264 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ice7bab997b84cfed00c7d6d780c70f4e9fac6002 Gerrit-Change-Number: 34264 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

8 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: stp: Don't expect a fixed SLS in IPA -> M3UA case

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34263 ) Change subject: stp: Don't expect a fixed SLS in IPA -> M3UA case ...................................................................... stp: Don't expect a fixed SLS in IPA -> M3UA case We are about to introduce a feature for SLS "randomization" in osmo-stp, so let's modifiy our STP tests to permit any SLS in the M3UA messages after IPA -> M3UA conversion. Change-Id: Ib70322b80a72e3e7dc3155bca9e67b03efb413e0 Related: SYS#6543 --- M stp/STP_Tests.ttcn 1 file changed, 17 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/63/34263/1 diff --git a/stp/STP_Tests.ttcn b/stp/STP_Tests.ttcn index 48214be..e2e5336 100644 --- a/stp/STP_Tests.ttcn +++ b/stp/STP_Tests.ttcn @@ -114,7 +114,7 @@ /* expect to receive it via M3UA */ var template (present) M3UA_Protocol_Data rx_pd; - rx_pd := tr_M3UA_protocol_data(pc_sender, pc_receiver, c_M3UA_SI_SCCP, '00'O, '00'O, '00'O, sccp_enc); + rx_pd := tr_M3UA_protocol_data(pc_sender, pc_receiver, c_M3UA_SI_SCCP, '00'O, '00'O, ?, sccp_enc); f_M3UA_exp(0, tr_M3UA_DATA(rctx_receiver, rx_pd)); f_clear_m3ua(); @@ -148,7 +148,7 @@ /* expect to receive it via M3UA */ var template (present) M3UA_Protocol_Data rx_pd; rx_pd := tr_M3UA_protocol_data(pc_sender, pc_receiver, c_M3UA_SI_SCCP, c_M3UA_NI_NATIONAL, - '00'O, '00'O, sccp_enc); + '00'O, ?, sccp_enc); f_M3UA_exp(0, tr_M3UA_DATA(rctx_receiver, rx_pd)); f_vty_config2(VTY, {"cs7 instance 0"}, "network-indicator international"); f_clear_m3ua(); @@ -185,7 +185,7 @@ /* expect to receive it via M3UA */ var template (present) M3UA_Protocol_Data rx_pd; - rx_pd := tr_M3UA_protocol_data(pc_sender, pc_receiver, c_M3UA_SI_SCCP, '00'O, '00'O, '00'O, + rx_pd := tr_M3UA_protocol_data(pc_sender, pc_receiver, c_M3UA_SI_SCCP, '00'O, '00'O, ?, enc_PDU_SCCP(sccp_exp)); f_M3UA_exp(0, tr_M3UA_DATA(rctx_receiver, rx_pd)); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34263 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib70322b80a72e3e7dc3155bca9e67b03efb413e0 Gerrit-Change-Number: 34263 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

8 months

1
0
0 0

[S] Change in osmo-trx[master]: ms: bump osmocom-bb submodule to current head

by Hoernchen

Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/34262 ) Change subject: ms: bump osmocom-bb submodule to current head ...................................................................... ms: bump osmocom-bb submodule to current head Change-Id: I9a16de0dce2e89fb522271ba63d908e33a1d7cde --- M osmocom-bb 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/62/34262/1 diff --git a/osmocom-bb b/osmocom-bb index fb38499..096a3cc 160000 --- a/osmocom-bb +++ b/osmocom-bb @@ -1 +1 @@ -Subproject commit fb384998fbddcc545eec76da41db1aa41b583aa9 +Subproject commit 096a3cc6f3e982df09836b70a5adcd57a4b93ab9 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/34262 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I9a16de0dce2e89fb522271ba63d908e33a1d7cde Gerrit-Change-Number: 34262 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-MessageType: newchange

8 months

1
0
0 0

[S] Change in osmo-trx[master]: ms: fix a few coverity complaints related to initialization

by Hoernchen

Hoernchen has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/34251 ) Change subject: ms: fix a few coverity complaints related to initialization ...................................................................... ms: fix a few coverity complaints related to initialization Change-Id: I203f4da7a4418fc5053d26901bec649d04fad096 --- M Transceiver52M/ms/ms.h M Transceiver52M/ms/ms_upper.h M Transceiver52M/ms/threadpool.h 3 files changed, 18 insertions(+), 8 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/Transceiver52M/ms/ms.h b/Transceiver52M/ms/ms.h index e6dbe4e..4d0f0cd 100644 --- a/Transceiver52M/ms/ms.h +++ b/Transceiver52M/ms/ms.h @@ -50,7 +50,7 @@ template <typename T> void clamp_array(T *start2, unsigned int len, T max) { - for (int i = 0; i < len; i++) { + for (unsigned int i = 0; i < len; i++) { const T t1 = start2[i] < -max ? -max : start2[i]; const T t2 = t1 > max ? max : t1; start2[i] = t2; @@ -263,7 +263,6 @@ std::thread lower_rx_task; std::thread lower_tx_task; - std::thread *calcrval_task; // provides bursts to upper rx thread rx_queue_t rxqueue; @@ -300,10 +299,12 @@ void maybe_update_gain(one_burst &brst); ms_trx() - : timing_advance(0), do_auto_gain(false), rxqueue(), first_sch_buf(new blade_sample_type[SCH_LEN_SPS]), - burst_copy_buffer(new blade_sample_type[ONE_TS_BURST_LEN]), rcv_done{ false }, - sch_thread_done{ false }, hw_cpus(std::thread::hardware_concurrency()), - hw_target(hw_cpus > 4 ? sched_params::target::ODROID : sched_params::target::PI4) + : mTSC(0), mBSIC(0), timing_advance(0), do_auto_gain(false), rxqueue(), + first_sch_buf(new blade_sample_type[SCH_LEN_SPS]), + burst_copy_buffer(new blade_sample_type[ONE_TS_BURST_LEN]), first_sch_buf_rcv_ts(0), + rcv_done{ false }, sch_thread_done{ false }, hw_cpus(std::thread::hardware_concurrency()), + hw_target(hw_cpus > 4 ? sched_params::target::ODROID : sched_params::target::PI4), + upper_is_ready(false) { std::cerr << "scheduling for: " << (hw_cpus > 4 ? "odroid" : "pi4") << std::endl; set_name_aff_sched(worker_thread.get_handle(), sched_params::thread_names::SCH_SEARCH); diff --git a/Transceiver52M/ms/ms_upper.h b/Transceiver52M/ms/ms_upper.h index 0c430de..06f7c54 100644 --- a/Transceiver52M/ms/ms_upper.h +++ b/Transceiver52M/ms/ms_upper.h @@ -44,5 +44,5 @@ void driveReceiveFIFO(); void driveTx(); - upper_trx(){}; + upper_trx() : mOn(false){}; }; diff --git a/Transceiver52M/ms/threadpool.h b/Transceiver52M/ms/threadpool.h index a5dec97..2180c68 100644 --- a/Transceiver52M/ms/threadpool.h +++ b/Transceiver52M/ms/threadpool.h @@ -45,7 +45,7 @@ return; } - single_thread_pool() : worker_thread(std::thread([this] { thread_loop(); })) + single_thread_pool() : stop_flag(false), is_ready(false), worker_thread(std::thread([this] { thread_loop(); })) { } ~single_thread_pool() -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/34251 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I203f4da7a4418fc5053d26901bec649d04fad096 Gerrit-Change-Number: 34251 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

8 months

1
0
0 0

[M] Change in osmo-trx[master]: ms: fix thread prio startup issue

by Hoernchen

Hoernchen has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/34250 ) Change subject: ms: fix thread prio startup issue ...................................................................... ms: fix thread prio startup issue This fixes the 20 second startup delay caused by tx/control threads getting temporarily stuck while trying to set their own priority. Apparently the only sane way for core affinity+priority is to set both as attributes during thread creation using pthreads. This switches the cmd queue to the timeout version, too, to ensure the thread doesn't get stuck waiting for messages, and allows cleaner exits. Change-Id: I7e2f83a9b9df024acaf9076c58189cb6b7bcc34b --- M Transceiver52M/ms/ms.h M Transceiver52M/ms/ms_trxcon_if.h M Transceiver52M/ms/ms_upper.cpp M Transceiver52M/ms/ms_upper.h M osmocom-bb 5 files changed, 111 insertions(+), 31 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve Hoernchen: Looks good to me, approved diff --git a/Transceiver52M/ms/ms.h b/Transceiver52M/ms/ms.h index 1c210b0..e6dbe4e 100644 --- a/Transceiver52M/ms/ms.h +++ b/Transceiver52M/ms/ms.h @@ -336,6 +336,15 @@ set_name_aff_sched(h, tgt.name, tgt.core, tgt.schedtype, tgt.prio); } + using pt_sig = void *(*)(void *); + + pthread_t spawn_worker_thread(sched_params::thread_names name, pt_sig fun, void *arg) + { + auto tgt = schdp[hw_target][name]; + // std::cerr << "scheduling for: " << tgt.name << ":" << tgt.core << " prio:" << tgt.prio << std::endl; + return do_spawn_thr(tgt.name, tgt.core, tgt.schedtype, tgt.prio, fun, arg); + } + private: void set_name_aff_sched(std::thread::native_handle_type h, const char *name, int cpunum, int schedtype, int prio) @@ -359,4 +368,28 @@ return exit(0); } } + + pthread_t do_spawn_thr(const char *name, int cpunum, int schedtype, int prio, pt_sig fun, void *arg) + { + pthread_t thread; + + pthread_attr_t attr; + pthread_attr_init(&attr); + + sched_param sch_params; + sch_params.sched_priority = prio; + cpu_set_t cpuset; + CPU_ZERO(&cpuset); + CPU_SET(cpunum, &cpuset); + auto a = pthread_attr_setaffinity_np(&attr, sizeof(cpu_set_t), &cpuset); + a |= pthread_attr_setschedpolicy(&attr, schedtype); + a |= pthread_attr_setschedparam(&attr, &sch_params); + a |= pthread_attr_setinheritsched(&attr, PTHREAD_EXPLICIT_SCHED); + if(a) + std::cerr << "thread arg rc:" << a << std::endl; + pthread_create(&thread, &attr, fun, arg); + pthread_setname_np(thread, name); + pthread_attr_destroy(&attr); + return thread; + } }; diff --git a/Transceiver52M/ms/ms_trxcon_if.h b/Transceiver52M/ms/ms_trxcon_if.h index 9879d1a..0928d40 100644 --- a/Transceiver52M/ms/ms_trxcon_if.h +++ b/Transceiver52M/ms/ms_trxcon_if.h @@ -38,5 +38,5 @@ } }; using tx_queue_t = spsc_cond<8 * 1, internal_q_tx_buf, true, false>; -using cmd_queue_t = spsc_cond<8 * 1, trxcon_phyif_cmd, true, false>; +using cmd_queue_t = spsc_cond_timeout<8 * 1, trxcon_phyif_cmd, true, false>; using cmdr_queue_t = spsc_cond<8 * 1, trxcon_phyif_rsp, false, false>; diff --git a/Transceiver52M/ms/ms_upper.cpp b/Transceiver52M/ms/ms_upper.cpp index 3c34efe..b161f4a 100644 --- a/Transceiver52M/ms/ms_upper.cpp +++ b/Transceiver52M/ms/ms_upper.cpp @@ -27,6 +27,8 @@ #include <radioInterface.h> #include <grgsm_vitac/grgsm_vitac.h> +// #define TXDEBUG + extern "C" { #include "sch.h" @@ -66,29 +68,54 @@ { g_exit_flag = true; - if (thr_control.joinable()) - thr_control.join(); - if (thr_rx.joinable()) - thr_rx.join(); - if (thr_tx.joinable()) - thr_tx.join(); + pthread_join(thr_control, NULL); + pthread_join(thr_tx, NULL); } + void upper_trx::start_threads() { - thr_control = std::thread([this] { - set_name_aff_sched(sched_params::thread_names::U_CTL); - while (!g_exit_flag) { - driveControl(); - } - std::cerr << "exit U control!" << std::endl; - }); - thr_tx = std::thread([this] { - set_name_aff_sched(sched_params::thread_names::U_TX); - while (!g_exit_flag) { - driveTx(); - } - std::cerr << "exit U tx!" << std::endl; - }); + DBGLG(...) << "spawning threads.." << std::endl; + + thr_control = spawn_worker_thread( + sched_params::thread_names::U_CTL, + [](void *args) -> void * { + upper_trx *t = reinterpret_cast<upper_trx *>(args); +#ifdef TXDEBUG + struct sched_param param; + int policy; + pthread_getschedparam(pthread_self(), &policy, &param); + printf("ID: %lu, CPU: %d policy = %d priority = %d\n", pthread_self(), sched_getcpu(), policy, + param.sched_priority); +#endif + std::cerr << "started U control!" << std::endl; + while (!g_exit_flag) { + t->driveControl(); + } + std::cerr << "exit U control!" << std::endl; + + return 0; + }, + this); + thr_tx = spawn_worker_thread( + sched_params::thread_names::U_TX, + [](void *args) -> void * { + upper_trx *t = reinterpret_cast<upper_trx *>(args); +#ifdef TXDEBUG + struct sched_param param; + int policy; + pthread_getschedparam(pthread_self(), &policy, &param); + printf("ID: %lu, CPU: %d policy = %d priority = %d\n", pthread_self(), sched_getcpu(), policy, + param.sched_priority); +#endif + std::cerr << "started U tx!" << std::endl; + while (!g_exit_flag) { + t->driveTx(); + } + std::cerr << "exit U tx!" << std::endl; + + return 0; + }, + this); #ifdef LSANDEBUG std::thread([this] { @@ -251,7 +278,7 @@ internal_q_tx_buf *burst = &e; -#ifdef TXDEBUG +#ifdef TXDEBUG2 DBGLG() << "got burst!" << burst->r.fn << ":" << burst->ts << " current: " << timekeeper.gsmtime().FN() << " dff: " << (int64_t)((int64_t)timekeeper.gsmtime().FN() - (int64_t)burst->r.fn) << std::endl; #endif @@ -270,7 +297,7 @@ // float -> int16 blade_sample_type burst_buf[txburst->size()]; convert_and_scale(burst_buf, txburst->begin(), txburst->size() * 2, 1); -#ifdef TXDEBUG +#ifdef TXDEBUG2 auto check = signalVector(txburst->size(), 40); convert_and_scale(check.begin(), burst_buf, txburst->size() * 2, 1); estim_burst_params ebp; @@ -313,7 +340,7 @@ static void print_cmd(trxcon_phyif_cmd_type c) { - DBGLG() << cmd2str(c) << std::endl; + DBGLG() << "handling " << cmd2str(c) << std::endl; } #endif @@ -323,6 +350,8 @@ trxcon_phyif_cmd cmd; while (!cmdq_to_phy.spsc_pop(&cmd)) { cmdq_to_phy.spsc_prep_pop(); + if (g_exit_flag) + return false; } if (g_exit_flag) diff --git a/Transceiver52M/ms/ms_upper.h b/Transceiver52M/ms/ms_upper.h index 2362365..0c430de 100644 --- a/Transceiver52M/ms/ms_upper.h +++ b/Transceiver52M/ms/ms_upper.h @@ -27,22 +27,22 @@ #include "ms.h" class upper_trx : public ms_trx { - bool mOn; + volatile bool mOn; char demodded_softbits[444]; // void driveControl(); - bool driveControl(); - void driveReceiveFIFO(); - void driveTx(); - bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset); - std::thread thr_control, thr_rx, thr_tx; + pthread_t thr_control, thr_tx; public: void start_threads(); void main_loop(); void stop_upper_threads(); + bool driveControl(); + void driveReceiveFIFO(); + void driveTx(); + upper_trx(){}; }; diff --git a/osmocom-bb b/osmocom-bb index 3f409eb..fb38499 160000 --- a/osmocom-bb +++ b/osmocom-bb @@ -1 +1 @@ -Subproject commit 3f409eb94eac9ffa67a7528f29f58275f0b836b8 +Subproject commit fb384998fbddcc545eec76da41db1aa41b583aa9 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/34250 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I7e2f83a9b9df024acaf9076c58189cb6b7bcc34b Gerrit-Change-Number: 34250 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: merged

8 months

1
0
0 0

[M] Change in osmo-trx[master]: ms: fix thread prio startup issue

by Hoernchen

Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/34250 ) Change subject: ms: fix thread prio startup issue ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/34250 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I7e2f83a9b9df024acaf9076c58189cb6b7bcc34b Gerrit-Change-Number: 34250 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 31 Aug 2023 15:18:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

8 months

1
0
0 0

[M] Change in osmo-bts[master]: pcu_sock: use PCU_IF_SAPI_AGCH_2 instead PCU_IF_SAPI_AGCH

by fixeria

Attention is currently required from: dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34059 ) Change subject: pcu_sock: use PCU_IF_SAPI_AGCH_2 instead PCU_IF_SAPI_AGCH ...................................................................... Patch Set 5: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-bts/+/34059/comment/f823304c_8e9ec908 PS4, Line 14: CAUTION: This patch breaks compatibility to current master osmo-pcu (See : also "Depends") > What do you think? Shall we bump the version to v.12 here now (osmo-ttcn3-hacks would require a follow up patch) Ideally, yes. But there have already been some turbulence within PCUIFv11, so I guess it's too late and bumping the version [again] would create even more turbulence/confusion. > [...] in the future apply the policy that the version number must be bumped as soon as a detail in PCUIF changes I believe this policy is not new and was followed before PCUIFv11. But yes, we should definitely stick to this policy. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34059 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I29858fa20ad8bd0aefe81a5c40ad77a2559a8c10 Gerrit-Change-Number: 34059 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 31 Aug 2023 15:05:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

8 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: GTP_Templates: Fix several template type incongruencies

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34261 ) Change subject: GTP_Templates: Fix several template type incongruencies ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34261 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3846d2a077e4bc53a772e354fcc3c38ca952b38f Gerrit-Change-Number: 34261 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 31 Aug 2023 14:40:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

8 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: GTP_Templates: Fix several template type incongruencies

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34261 ) Change subject: GTP_Templates: Fix several template type incongruencies ...................................................................... Patch Set 1: (3 comments) File library/GTP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34261/comment/8caeb75e_93a1… PS1, Line 285: lengthf := 2 As I said in the IRC, hard-coding `lengthf` to 2 is wrong. It's only valid if `ip_addr` is `omit`, and would not match otherwise. I suggest to use `f_eua_ipv4_len()` here and drop `tr_EuaIPv4`. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34261/comment/933c7df9_b28e… PS1, Line 306: lengthf := 2, Same here. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34261/comment/f4fd442f_72d7… PS1, Line 328: lengthf := 2, Same here. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34261 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3846d2a077e4bc53a772e354fcc3c38ca952b38f Gerrit-Change-Number: 34261 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 31 Aug 2023 14:39:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

8 months

1
0
0 0

[S] Change in libosmocore[master]: osmo_io: Change parent of msghdr to iofd (instead of msg)

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34256 ) Change subject: osmo_io: Change parent of msghdr to iofd (instead of msg) ...................................................................... osmo_io: Change parent of msghdr to iofd (instead of msg) msg was made a parent of msghdr after discussion in change I3a279b55a3adff96948120683c844e1508d0ba94 It turns out this violates some assumptions made in osmo_io, specifically that the user read callback shall free msg, but we expect msghdr to remain valid until after that callback returns. In general I think it is cleaner to make iofd a parent of msghdr. Change-Id: I41277190e3020cd8fa625bd57a743973e2a65c4b --- M src/core/osmo_io.c 1 file changed, 19 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/core/osmo_io.c b/src/core/osmo_io.c index e176099..c67787b 100644 --- a/src/core/osmo_io.c +++ b/src/core/osmo_io.c @@ -120,7 +120,7 @@ talloc_steal(iofd, msg); } - hdr = talloc_zero(msg, struct iofd_msghdr); + hdr = talloc_zero(iofd, struct iofd_msghdr); if (!hdr) { if (free_msg) talloc_free(msg); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34256 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I41277190e3020cd8fa625bd57a743973e2a65c4b Gerrit-Change-Number: 34256 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

8 months

1
0
0 0

[S] Change in libosmocore[master]: osmo_io: Use local variable to reference msghdr->msg

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34257 ) Change subject: osmo_io: Use local variable to reference msghdr->msg ...................................................................... osmo_io: Use local variable to reference msghdr->msg Change-Id: I336ef7a5460dd18bf8e0f4ac5e97747f9fec5a35 --- M src/core/osmo_io_uring.c 1 file changed, 17 insertions(+), 7 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/core/osmo_io_uring.c b/src/core/osmo_io_uring.c index 84b7b4c..a6395fe 100644 --- a/src/core/osmo_io_uring.c +++ b/src/core/osmo_io_uring.c @@ -182,6 +182,7 @@ static void iofd_uring_handle_tx(struct iofd_msghdr *msghdr, int rc) { struct osmo_io_fd *iofd = msghdr->iofd; + struct msgb *msg = msghdr->msg; if (IOFD_FLAG_ISSET(iofd, IOFD_FLAG_CLOSED)) goto out_free; @@ -189,27 +190,27 @@ /* Error during write */ if (rc < 0) { if (msghdr->action == IOFD_ACT_WRITE) - iofd->io_ops.write_cb(iofd, rc, msghdr->msg); + iofd->io_ops.write_cb(iofd, rc, msg); else if (msghdr->action == IOFD_ACT_SENDTO) - iofd->io_ops.sendto_cb(iofd, rc, msghdr->msg, &msghdr->osa); + iofd->io_ops.sendto_cb(iofd, rc, msg, &msghdr->osa); else OSMO_ASSERT(0); goto out_free; } /* Incomplete write */ - if (rc < msgb_length(msghdr->msg)) { + if (rc < msgb_length(msg)) { /* Re-enqueue remaining data */ - msgb_pull(msghdr->msg, rc); - msghdr->iov[0].iov_len = msgb_length(msghdr->msg); + msgb_pull(msg, rc); + msghdr->iov[0].iov_len = msgb_length(msg); iofd_txqueue_enqueue_front(iofd, msghdr); goto out; } if (msghdr->action == IOFD_ACT_WRITE) - iofd->io_ops.write_cb(iofd, rc, msghdr->msg); + iofd->io_ops.write_cb(iofd, rc, msg); else if (msghdr->action == IOFD_ACT_SENDTO) - iofd->io_ops.sendto_cb(iofd, rc, msghdr->msg, &msghdr->osa); + iofd->io_ops.sendto_cb(iofd, rc, msg, &msghdr->osa); else OSMO_ASSERT(0); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34257 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I336ef7a5460dd18bf8e0f4ac5e97747f9fec5a35 Gerrit-Change-Number: 34257 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

8 months

1
0
0 0

[S] Change in libosmocore[master]: osmo_io: Use local variable to reference msghdr->msg

by laforge

Attention is currently required from: daniel. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34257 ) Change subject: osmo_io: Use local variable to reference msghdr->msg ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34257 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I336ef7a5460dd18bf8e0f4ac5e97747f9fec5a35 Gerrit-Change-Number: 34257 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 31 Aug 2023 14:28:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

8 months

1
0
0 0

[S] Change in libosmocore[master]: osmo_io: Change parent of msghdr to iofd (instead of msg)

by laforge

Attention is currently required from: daniel. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34256 ) Change subject: osmo_io: Change parent of msghdr to iofd (instead of msg) ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34256 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I41277190e3020cd8fa625bd57a743973e2a65c4b Gerrit-Change-Number: 34256 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 31 Aug 2023 14:28:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

8 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: GTP_Templates: Fix several template type incongruencies

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34261 ) Change subject: GTP_Templates: Fix several template type incongruencies ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34261 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3846d2a077e4bc53a772e354fcc3c38ca952b38f Gerrit-Change-Number: 34261 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 31 Aug 2023 14:27:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

8 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: GTP_Templates: Fix several template type incongruencies

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34261 ) Change subject: GTP_Templates: Fix several template type incongruencies ...................................................................... GTP_Templates: Fix several template type incongruencies This fixes following error while running test GGSN_Tests.TC_pdp46_act_deact_apn4: "GTP_Templates.ttcn:315 Dynamic test case error: Restriction `omit' on template of type octetstring violated." Change-Id: I3846d2a077e4bc53a772e354fcc3c38ca952b38f --- M library/GTP_Templates.ttcn 1 file changed, 24 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/61/34261/1 diff --git a/library/GTP_Templates.ttcn b/library/GTP_Templates.ttcn index 8ab830e..06ba208 100644 --- a/library/GTP_Templates.ttcn +++ b/library/GTP_Templates.ttcn @@ -241,7 +241,7 @@ gtpc := ts_GTP1C_PDU(echoRequest, '00000000'O, valueof(ts_EchoReqPDU), seq) } - private function f_eua_ipv4_len(template (present) OCT4 ip_addr) return template integer { + private function f_eua_ipv4_len(template OCT4 ip_addr) return template (present) integer { if (istemplatekind(ip_addr, "omit")) { return 2; } else if (istemplatekind(ip_addr, "*")) { @@ -252,7 +252,7 @@ return 6; } - private function f_eua_ipv6_len(template (omit) OCT16 ip_addr) return template (present) integer { + private function f_eua_ipv6_len(template OCT16 ip_addr) return template (present) integer { if (istemplatekind(ip_addr, "omit")) { return 2; } else if (istemplatekind(ip_addr, "*")) { @@ -263,7 +263,7 @@ return 18; } - private function f_eua_ipv4v6_len(template (omit) OCT4 ip_addr4, template (omit) OCT16 ip_addr6) return template (present) integer { + private function f_eua_ipv4v6_len(template OCT4 ip_addr4, template OCT16 ip_addr6) return template (present) integer { var integer len := 2; if (istemplatekind(ip_addr4, "*") or istemplatekind(ip_addr6, "*")) { @@ -278,7 +278,7 @@ return len; } - template EndUserAddress t_EuaIPv4(template OCT4 ip_addr) := { + template (present) EndUserAddress t_EuaIPv4(template OCT4 ip_addr) := { type_gtpc := '80'O, endUserAddress := { endUserAddressIPv4 := { @@ -290,7 +290,7 @@ } } } - template EndUserAddress t_EuaIPv4Dyn := t_EuaIPv4(omit); + template (present) EndUserAddress t_EuaIPv4Dyn := t_EuaIPv4(omit); template (present) EndUserAddress tr_EuaIPv4(template (present) OCT4 ip_addr) modifies t_EuaIPv4 := { endUserAddress := { endUserAddressIPv4 := { @@ -299,7 +299,7 @@ } } - template EndUserAddress t_EuaIPv6(template OCT16 ip_addr) := { + template (present) EndUserAddress t_EuaIPv6(template OCT16 ip_addr) := { type_gtpc := '80'O, endUserAddress := { endUserAddressIPv6 := { @@ -311,7 +311,7 @@ } } } - template EndUserAddress t_EuaIPv6Dyn := t_EuaIPv6(omit); + template (present) EndUserAddress t_EuaIPv6Dyn := t_EuaIPv6(omit); template (present) EndUserAddress tr_EuaIPv6(template (present) OCT16 ip_addr) modifies t_EuaIPv6 := { endUserAddress := { endUserAddressIPv6 := { @@ -321,7 +321,7 @@ } /* 3GPP TS 29.060 Figure 37A: End User Address Information Element for IPv4v6 (both static) */ - template EndUserAddress t_EuaIPv4v6(template OCT4 ip_addr4, template OCT16 ip_addr6) := { + template (present) EndUserAddress t_EuaIPv4v6(template OCT4 ip_addr4, template OCT16 ip_addr6) := { type_gtpc := '80'O, endUserAddress := { endUserAddressIPv4andIPv6 := { @@ -334,7 +334,7 @@ } } } - template EndUserAddress t_EuaIPv4Dynv6Dyn := t_EuaIPv4v6(omit, omit); + template (present) EndUserAddress t_EuaIPv4Dynv6Dyn := t_EuaIPv4v6(omit, omit); template (present) EndUserAddress tr_EuaIPv4v6(template (present) OCT4 ip_addr4, template (present) OCT16 ip_addr6) modifies t_EuaIPv4v6 := { endUserAddress := { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34261 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3846d2a077e4bc53a772e354fcc3c38ca952b38f Gerrit-Change-Number: 34261 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

8 months

1
0
0 0

[S] Change in libosmocore[master]: debian: fix build on ubuntu 20.04 without liburing

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34260 ) Change subject: debian: fix build on ubuntu 20.04 without liburing ...................................................................... debian: fix build on ubuntu 20.04 without liburing Ubuntu 20.04 is based on debian 11, but does not have liburing. Extend the logic to cover this distribution too, so building packages for it isn't stuck anymore on libosmocore not being able to resolve the liburing-dev dependency. I have verified that this makes libosmocore properly build with/without liburing on debian 10, 11 and ubuntu 20.04 and 22.04. Fixes: e486e012 ("debian: depend on liburing-dev for debian >= 11") Change-Id: If18d6543fae9537c8b188e90499491bda3fdfe59 --- M debian/control M debian/rules 2 files changed, 23 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/debian/control b/debian/control index 1f1975e..e6b96e1 100644 --- a/debian/control +++ b/debian/control @@ -2,6 +2,7 @@ Maintainer: Osmocom team <openbsc(a)lists.osmocom.org> Section: libs Priority: optional +# liburing-dev: don't try to install it on debian 10 and ubuntu 20.04 Build-Depends: debhelper (>= 10), autotools-dev, autoconf, @@ -19,7 +20,7 @@ libusb-1.0-0-dev, libmnl-dev, libsystemd-dev, - base-files (<< 11) | liburing-dev, + liburing-dev | base-files (<< 11) | ubuntu-keyring (<< 2021), python3:native Standards-Version: 3.9.8 Vcs-Git: https://gitea.osmocom.org/osmocom/libosmocore diff --git a/debian/rules b/debian/rules index efa5adc..f0105b4 100755 --- a/debian/rules +++ b/debian/rules @@ -25,7 +25,7 @@ override_dh_auto_test: dh_auto_test || (find . -name testsuite.log -exec cat {} \; ; false) -# Set --disable-uring for debian < 11 based distributions +# Set --disable-uring for debian 10 and ubuntu 20.04 override_dh_auto_configure: set -x && \ CONFIGURE_FLAGS=" \ @@ -33,8 +33,8 @@ --enable-static \ --enable-systemd-logging \ "; \ - base_ver="$$(dpkg -l base-files | grep "^ii" | awk '{print $$3}')"; \ - if dpkg --compare-versions "$$base_ver" lt 11; then \ + distro_v=$$(. /etc/os-release && echo $$VERSION_ID); \ + if [ "$$distro_v" = 10 ] || [ "$$distro_v" = 20.04 ]; then \ CONFIGURE_FLAGS="$$CONFIGURE_FLAGS --disable-uring"; \ fi; \ dh_auto_configure -- $$CONFIGURE_FLAGS -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34260 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If18d6543fae9537c8b188e90499491bda3fdfe59 Gerrit-Change-Number: 34260 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

8 months

1
0
0 0

[S] Change in libosmocore[master]: debian: fix build on ubuntu 20.04 without liburing

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34260 ) Change subject: debian: fix build on ubuntu 20.04 without liburing ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: > Seeing how much fallout we had after making libosmocore depend on liburing by default (unless `--dis […] FWIW we would still have required this logic for the debian packaging, it would just be in reverse. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34260 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If18d6543fae9537c8b188e90499491bda3fdfe59 Gerrit-Change-Number: 34260 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 31 Aug 2023 14:19:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

8 months

1
0
0 0

[S] Change in libosmocore[master]: debian: fix build on ubuntu 20.04 without liburing

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34260 ) Change subject: debian: fix build on ubuntu 20.04 without liburing ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: Seeing how much fallout we had after making libosmocore depend on liburing by default (unless `--disable-uring` is specified), I am again starting to think that it would have been safer to not require this problematic dependency unless explicitly configured (i.e. by passing `--enable-uring`). This way we could enable it only when building for known-to-have-it distributions. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34260 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If18d6543fae9537c8b188e90499491bda3fdfe59 Gerrit-Change-Number: 34260 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 31 Aug 2023 14:17:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

8 months

1
0
0 0

[S] Change in osmo-bts[master]: pcu_sock: print SAPI and msg_id when sending confirmation

by fixeria

Attention is currently required from: dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34240 ) Change subject: pcu_sock: print SAPI and msg_id when sending confirmation ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34240 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ibd5b4225e597b69eaabaeee437fb637943a55602 Gerrit-Change-Number: 34240 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 31 Aug 2023 13:35:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

8 months

1
0
0 0

[M] Change in osmo-bsc[master]: pcu_sock: use PCU_IF_SAPI_AGCH_2 instead PCU_IF_SAPI_AGCH

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34060 ) Change subject: pcu_sock: use PCU_IF_SAPI_AGCH_2 instead PCU_IF_SAPI_AGCH ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34060 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I709c27adaf09a6766cfde4d76d878626d30ebb3c Gerrit-Change-Number: 34060 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 31 Aug 2023 13:24:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

8 months

1
0
0 0

[M] Change in osmo-bsc[master]: pcu_sock: use PCU_IF_SAPI_AGCH_2 instead PCU_IF_SAPI_AGCH

by fixeria

Attention is currently required from: pespin, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34060 ) Change subject: pcu_sock: use PCU_IF_SAPI_AGCH_2 instead PCU_IF_SAPI_AGCH ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34060 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I709c27adaf09a6766cfde4d76d878626d30ebb3c Gerrit-Change-Number: 34060 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 31 Aug 2023 13:20:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

8 months

1
0
0 0

[S] Change in libosmocore[master]: debian: fix build on ubuntu 20.04 without liburing

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34260 ) Change subject: debian: fix build on ubuntu 20.04 without liburing ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34260 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If18d6543fae9537c8b188e90499491bda3fdfe59 Gerrit-Change-Number: 34260 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 31 Aug 2023 13:06:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

8 months

1
0
0 0

[S] Change in libosmocore[master]: debian: fix build on ubuntu 20.04 without liburing

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/34260 ) Change subject: debian: fix build on ubuntu 20.04 without liburing ...................................................................... debian: fix build on ubuntu 20.04 without liburing Ubuntu 20.04 is based on debian 11, but does not have liburing. Extend the logic to cover this distribution too, so building packages for it isn't stuck anymore on libosmocore not being able to resolve the liburing-dev dependency. I have verified that this makes libosmocore properly build with/without liburing on debian 10, 11 and ubuntu 20.04 and 22.04. Fixes: e486e012 ("debian: depend on liburing-dev for debian >= 11") Change-Id: If18d6543fae9537c8b188e90499491bda3fdfe59 --- M debian/control M debian/rules 2 files changed, 23 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/60/34260/1 diff --git a/debian/control b/debian/control index 1f1975e..e6b96e1 100644 --- a/debian/control +++ b/debian/control @@ -2,6 +2,7 @@ Maintainer: Osmocom team <openbsc(a)lists.osmocom.org> Section: libs Priority: optional +# liburing-dev: don't try to install it on debian 10 and ubuntu 20.04 Build-Depends: debhelper (>= 10), autotools-dev, autoconf, @@ -19,7 +20,7 @@ libusb-1.0-0-dev, libmnl-dev, libsystemd-dev, - base-files (<< 11) | liburing-dev, + liburing-dev | base-files (<< 11) | ubuntu-keyring (<< 2021), python3:native Standards-Version: 3.9.8 Vcs-Git: https://gitea.osmocom.org/osmocom/libosmocore diff --git a/debian/rules b/debian/rules index efa5adc..f0105b4 100755 --- a/debian/rules +++ b/debian/rules @@ -25,7 +25,7 @@ override_dh_auto_test: dh_auto_test || (find . -name testsuite.log -exec cat {} \; ; false) -# Set --disable-uring for debian < 11 based distributions +# Set --disable-uring for debian 10 and ubuntu 20.04 override_dh_auto_configure: set -x && \ CONFIGURE_FLAGS=" \ @@ -33,8 +33,8 @@ --enable-static \ --enable-systemd-logging \ "; \ - base_ver="$$(dpkg -l base-files | grep "^ii" | awk '{print $$3}')"; \ - if dpkg --compare-versions "$$base_ver" lt 11; then \ + distro_v=$$(. /etc/os-release && echo $$VERSION_ID); \ + if [ "$$distro_v" = 10 ] || [ "$$distro_v" = 20.04 ]; then \ CONFIGURE_FLAGS="$$CONFIGURE_FLAGS --disable-uring"; \ fi; \ dh_auto_configure -- $$CONFIGURE_FLAGS -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34260 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If18d6543fae9537c8b188e90499491bda3fdfe59 Gerrit-Change-Number: 34260 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

8 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: dia2gsup: initial refactoring

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34254 ) Change subject: dia2gsup: initial refactoring ...................................................................... dia2gsup: initial refactoring Do some refactoring to the core infrastructure of the tests before adding new testsi. Among others: - Move Tguard to main component - Avoid having to call f_init_handler in each handler (do it automatically during f_start_handler()). Change-Id: I4a1bf6ca03549688704815e3fec4e5152d0181a6 --- M dia2gsup/DIA2GSUP_Tests.ttcn 1 file changed, 40 insertions(+), 21 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/dia2gsup/DIA2GSUP_Tests.ttcn b/dia2gsup/DIA2GSUP_Tests.ttcn index d709512..6a3f85c 100644 --- a/dia2gsup/DIA2GSUP_Tests.ttcn +++ b/dia2gsup/DIA2GSUP_Tests.ttcn @@ -1,5 +1,6 @@ module DIA2GSUP_Tests { +import from Misc_Helpers all; import from General_Types all; import from Osmocom_Types all; import from L3_Common all; @@ -21,11 +22,11 @@ var IPA_Emulation_CT vc_GSUP_IPA; port IPA_CTRL_PT GSUP_IPA_EVENT; + timer g_Tguard; }; type component D2G_ConnHdlr extends DIAMETER_ConnHdlr, GSUP_ConnHdlr { var D2G_ConnHdlrPars g_pars; - timer g_Tguard := 30.0; }; type record D2G_ConnHdlrPars { @@ -33,7 +34,7 @@ AuthVector vec optional }; -private function f_init_pars(integer imsi_suffix) +private function f_init_pars(integer imsi_suffix := 1) runs on MTC_CT return D2G_ConnHdlrPars { var D2G_ConnHdlrPars pars := { imsi := f_gen_imsi(imsi_suffix), @@ -59,10 +60,9 @@ charstring mp_diam_realm := "localdomain"; } -private altstep as_Tguard() runs on D2G_ConnHdlr { +private altstep as_Tguard() runs on MTC_CT { [] g_Tguard.timeout { - setverdict(fail, "Tguard timeout"); - mtc.stop; + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Tguard timeout"); } } @@ -95,18 +95,18 @@ } } -private function f_init_handler(D2G_ConnHdlrPars pars, float t_guard := 20.0) runs on D2G_ConnHdlr { +private type function void_fn(charstring id) runs on D2G_ConnHdlr; + +private function f_init_handler(void_fn fn, charstring id, D2G_ConnHdlrPars pars) runs on D2G_ConnHdlr { g_pars := pars; - activate(as_Tguard()); - g_Tguard.start(t_guard); /* tell GSUP dispatcher to send this IMSI to us */ f_create_gsup_expect(hex2str(g_pars.imsi)); + + fn.apply(id); } -private type function void_fn(charstring id, D2G_ConnHdlrPars pars) runs on D2G_ConnHdlr; - -private function f_start_handler_with_pars(void_fn fn, D2G_ConnHdlrPars pars) +private function f_start_handler(void_fn fn, D2G_ConnHdlrPars pars) runs on MTC_CT return D2G_ConnHdlr { var D2G_ConnHdlr vc_conn; var charstring id := testcasename(); @@ -121,7 +121,7 @@ DIAMETER_UNIT.receive(DiameterCapabilityExchgInd:?); - vc_conn.start(derefers(fn)(id, pars)); + vc_conn.start(f_init_handler(fn, id, pars)); return vc_conn; } @@ -154,13 +154,17 @@ vc_DIAMETER.start(DIAMETER_Emulation.main(ops, pars, id)); } -private function f_init() runs on MTC_CT { +private function f_init(float t_guard := 40.0) runs on MTC_CT { + + g_Tguard.start(t_guard); + activate(as_Tguard()); + f_init_gsup(testcasename()); f_init_diameter(testcasename()); } -private function f_DIA_AI() runs on D2G_ConnHdlr { +private function f_DIA_AI_success() runs on D2G_ConnHdlr { var PDU_DIAMETER rx_dia; var UINT32 hbh_id := f_rnd_octstring(4); var UINT32 ete_id := f_rnd_octstring(4); @@ -191,25 +195,25 @@ [] DIAMETER.receive(tr_DIA_AIA) { setverdict(pass); } + [] DIAMETER.receive(PDU_DIAMETER:?) -> value rx_dia { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, log2str("Unexpected Diameter msg rx: ", rx_dia)); + } } } -private function f_TC_authinfo_normal(charstring id, D2G_ConnHdlrPars pars) runs on D2G_ConnHdlr { - f_init_handler(pars); - f_DIA_AI(); +private function f_TC_authinfo_normal(charstring id) runs on D2G_ConnHdlr { + f_DIA_AI_success(); } testcase TC_authinfo_normal() runs on MTC_CT { - var D2G_ConnHdlrPars pars := f_init_pars(1); + var D2G_ConnHdlrPars pars := f_init_pars(); var D2G_ConnHdlr vc_conn; f_init(); - f_sleep(10.0); - vc_conn := f_start_handler_with_pars(refers(f_TC_authinfo_normal), pars); + vc_conn := f_start_handler(refers(f_TC_authinfo_normal), pars); vc_conn.done; setverdict(pass); } - control { execute ( TC_authinfo_normal() ); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34254 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4a1bf6ca03549688704815e3fec4e5152d0181a6 Gerrit-Change-Number: 34254 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

8 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: dia2gsup: initial refactoring

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34254 ) Change subject: dia2gsup: initial refactoring ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34254 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4a1bf6ca03549688704815e3fec4e5152d0181a6 Gerrit-Change-Number: 34254 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 31 Aug 2023 11:50:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

8 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: dia2gsup: initial refactoring

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34254 ) Change subject: dia2gsup: initial refactoring ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34254 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4a1bf6ca03549688704815e3fec4e5152d0181a6 Gerrit-Change-Number: 34254 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 31 Aug 2023 09:39:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

8 months

1
0
0 0

[S] Change in docker-playground[master]: ttcn3-dia2gsup: Avoid retrieving unexisting talloc report

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/34253 ) Change subject: ttcn3-dia2gsup: Avoid retrieving unexisting talloc report ...................................................................... ttcn3-dia2gsup: Avoid retrieving unexisting talloc report The OSMO_SUT_{HOST,PORT} envvars are used to trigger retrieving of talloc reportes from the VTY port in osmo-ttcn3-hacks.git ttcn3-tcpdump-stop.sh. osmo_dia2gsup is an erland app and hence it makes no sense trying to retrieve such information. Change-Id: I6ee3fa83758e09898d1cd05bf15bc3428e2ffd11 --- M ttcn3-dia2gsup-test/jenkins.sh 1 file changed, 15 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/ttcn3-dia2gsup-test/jenkins.sh b/ttcn3-dia2gsup-test/jenkins.sh index d8acc43..87eea24 100755 --- a/ttcn3-dia2gsup-test/jenkins.sh +++ b/ttcn3-dia2gsup-test/jenkins.sh @@ -33,8 +33,6 @@ $(docker_network_params $SUBNET 103) \ --ulimit core=-1 \ -e "TTCN3_PCAP_PATH=/data" \ - -e "OSMO_SUT_HOST=172.18.$SUBNET.20" \ - -e "OSMO_SUT_PORT=4258" \ -v $VOL_BASE_DIR/dia2gsup-tester:/data \ --name ${BUILD_TAG}-ttcn3-dia2gsup-test \ $DOCKER_ARGS \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/34253 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I6ee3fa83758e09898d1cd05bf15bc3428e2ffd11 Gerrit-Change-Number: 34253 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

8 months

1
0
0 0

[M] Change in osmo-bsc[master]: pcuif_proto: check confirm flag in struct gsm_pcu_if_pch

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34192 ) Change subject: pcuif_proto: check confirm flag in struct gsm_pcu_if_pch ...................................................................... Patch Set 6: (1 comment) File src/osmo-bsc/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bsc/+/34192/comment/eed2ee66_fde2d946 PS1, Line 552: if (pch->confirmed_imm_ass) > I take your criticism seriously. […] My sincere opinion here is that we are really taking much more time than initially expected to apply all these changes, specially because some changes have been made which had to be reverted/redone since stuff was not looked at with enough detail or long vision back then. I am also not happy with how the change process have been done but here we are. Let's try at least to be clear and compile the different changes that were made v10->v11, since it's right now quite difficult to gasp due to all the different patchsets. That's really the problem imho, not the fact that we need to bump the PCUIF N times imho. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34192 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3d2842626b7e8325860ea3160c7d900d39e953a0 Gerrit-Change-Number: 34192 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 31 Aug 2023 09:11:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

8 months

1
0
0 0

[S] Change in osmo-bts[master]: pcu_sock: print SAPI and msg_id when sending confirmation

by pespin

Attention is currently required from: fixeria, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34240 ) Change subject: pcu_sock: print SAPI and msg_id when sending confirmation ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34240 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ibd5b4225e597b69eaabaeee437fb637943a55602 Gerrit-Change-Number: 34240 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 31 Aug 2023 09:07:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

8 months

1
0
0 0

2024

2023

2022

gerrit-log August 2023