Attention is currently required from: pespin, daniel.
arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/34224 )
Change subject: stream tests: Eliminate timestamps from output
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> Simply and plain for me: I just submitted a test patch based on libosmo-netif master and it's passin […]
This doesn't prove that the problem is local or related to my patch.
The problems have been that for two patches (see above text, "Add ... support for IPA", for the server side patch I found a workaround by using a different local port), timestamps all of a sudden stopped being predictable and hence tests failed with these patches (.ok-output not matching).
The test code itself has not been changed and you can read above what commits are causing this deviation in timestamps (I haven't yet busied myself with identifying the exact reason or commit, my guess is it doesn't matter in the end).
If you were to rebase https://gerrit.osmocom.org/c/libosmo-netif/+/33198/19 on libosmo-netif master - I gave the then-HEAD commit hash for reference - , you should be able see what I'm talking about (the lastest revision - 20 - was uploaded together with this change and doesn't use timestamps, so it would fail for other discrepancies in stdout output).
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/34224
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I7faed932927d4f6e328a28c7f30a647a7272e89c
Gerrit-Change-Number: 34224
Gerrit-PatchSet: 2
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 31 Aug 2023 19:07:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: dexter.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34269 )
Change subject: NAS_Templates: add template for EPS update type
......................................................................
Patch Set 1:
(1 comment)
File library/NAS_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34269/comment/3bc54388_20e7…
PS1, Line 320: const BIT3 c_EPS_UPD_TYPE_TA_UPD := '000'B;
this should be an enum afaiu.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34269
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I6ffac88cc1d3967dc8000e17a65cdba79a013cf7
Gerrit-Change-Number: 34269
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 31 Aug 2023 16:59:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: dexter.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34267 )
Change subject: NAS_Templates: fix ts_NAS_GUTI
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
So what you are saying is that ts_NAS_GUTI was wrong?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34267
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I9546993987b873e8ae921664238b234608e37bba
Gerrit-Change-Number: 34267
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 31 Aug 2023 16:58:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: dexter.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34265 )
Change subject: GTPv2_Emulation: make sure g_uecups_conn_id is populated.
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34265
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ifc2e8d9de13d5d183d6f052b2092c356ab4973d1
Gerrit-Change-Number: 34265
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 31 Aug 2023 16:55:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34264 )
Change subject: ipa: use LSBs of file descriptor as SLS in IPA->M3UA direction
......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
Why not have a global variable incrementing with each new conn instead of taking it from fd? That would improve a lot the equal distribution. Depending on how fds are allocated they can end up with most ASPs using the same SLS.
File src/ipa.c:
https://gerrit.osmocom.org/c/libosmo-sccp/+/34264/comment/c12cd83b_358ffdf4
PS1, Line 295: * \param[in] msg received message buffer. Callee takes ownership!
missing new param documentation
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34264
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Ice7bab997b84cfed00c7d6d780c70f4e9fac6002
Gerrit-Change-Number: 34264
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Thu, 31 Aug 2023 16:55:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34263 )
Change subject: stp: Don't expect a fixed SLS in IPA -> M3UA case
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34263
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib70322b80a72e3e7dc3155bca9e67b03efb413e0
Gerrit-Change-Number: 34263
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Thu, 31 Aug 2023 16:48:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment