Attention is currently required from: Sebastian Schmidt.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34600?usp=email )
Change subject: Add swig to Debian installation instructions
......................................................................
Patch Set 1: Code-Review-2
(1 comment)
Patchset:
PS1:
pySim is not using `swig` directly, so I don't see why would we want to have this dependency, sorry. It's a dependency of `pyscard`, so your package manager should pull `swig` when installing it automatically? I cannot reproduce this in a virtual env with python 3.11.5 and pip 23.2, `pyscard 2.0.7` installs without `swig` just fine.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/34600?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I989dd8ccf8d089c784d566fe0359b85df7575fc3
Gerrit-Change-Number: 34600
Gerrit-PatchSet: 1
Gerrit-Owner: Sebastian Schmidt <yath+osmocom(a)yath.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: Sebastian Schmidt <yath+osmocom(a)yath.de>
Gerrit-Comment-Date: Sat, 30 Sep 2023 16:36:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Sebastian Schmidt.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34601?usp=email )
Change subject: Add pyshark to requirements.
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Hello and thanks for your contribution!
Unfortunately, we cannot merge this patch. There has already been a discussion on this and we decided to not require `pyshark` dependency. Please see:
https://gerrit.osmocom.org/c/pysim/+/33831https://gerrit.osmocom.org/c/pysim/+/33834
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/34601?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ic93e83195feb7ada3b364bae86442dae90d81d90
Gerrit-Change-Number: 34601
Gerrit-PatchSet: 1
Gerrit-Owner: Sebastian Schmidt <yath+osmocom(a)yath.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: Sebastian Schmidt <yath+osmocom(a)yath.de>
Gerrit-Comment-Date: Sat, 30 Sep 2023 16:27:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/34599?usp=email )
Change subject: stream_test: Disable nagling
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
TCP_NODELAY was never set for the preexisting test (`test_recon()`), but I suppose that never caused timestamp problems there, because the server side isn't sending any TCP data in this test that could be nagled; it's only reconnects initiated by the client side.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/34599?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I7e8f6851df28e006fcb714673b97cf7b6be367bf
Gerrit-Change-Number: 34599
Gerrit-PatchSet: 1
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Sat, 30 Sep 2023 13:43:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
arehbein has abandoned this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33196?usp=email )
Change subject: stream: Fix endless loop on server on client disconnect
......................................................................
Abandoned
Alternate patch created by daniel
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33196?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I012ddf14ae17642a52d34026d85ab6958cf488a1
Gerrit-Change-Number: 33196
Gerrit-PatchSet: 3
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: abandon
Attention is currently required from: arehbein, fixeria, pespin.
Hello Jenkins Builder, fixeria, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-netif/+/33201?usp=email
to look at the new patch set (#20).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: stream: Add and use IPA send function
......................................................................
stream: Add and use IPA send function
Related OS#5753, OS#5751
Change-Id: I61e1fe59166c46595efe8c1f32b8f2607cb6c529
---
M examples/ipa-stream-client.c
M examples/ipa-stream-server.c
M include/osmocom/netif/ipa.h
M src/ipa.c
M tests/stream/stream_test.c
5 files changed, 68 insertions(+), 14 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/01/33201/20
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33201?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I61e1fe59166c46595efe8c1f32b8f2607cb6c529
Gerrit-Change-Number: 33201
Gerrit-PatchSet: 20
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: arehbein <arehbein(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: newpatchset
jolly has abandoned this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34556?usp=email )
Change subject: fixup ASCI: Add group receive and transmit mode support to MM laye
......................................................................
Abandoned
Patch from work in progress.
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34556?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Ia6d0ac341b4b80199b344e04068ac152d7cc2ee7
Gerrit-Change-Number: 34556
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: abandon
Attention is currently required from: jolly, laforge, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34492?usp=email )
Change subject: ASCI: Add group receive and transmit mode support to MM layer
......................................................................
Patch Set 13:
(1 comment)
File src/host/layer23/src/mobile/gsm48_mm.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/34492/comment/f45e4363_881815b3
PS10, Line 4854: // There are event handlers for group call in this implementation.
> v13 still hasn't this rephreased afaict.
Fixed in https://gerrit.osmocom.org/c/osmocom-bb/+/34556, which should be squashed here.
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34492?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I05957182a57423ad947ab200b52f65fde859e110
Gerrit-Change-Number: 34492
Gerrit-PatchSet: 13
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 30 Sep 2023 09:17:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: jolly <andreas(a)eversberg.eu>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment