September 2023 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-sccp[master]: m3ua: Add some TODO comments on where we fall short of our potential
by laforge 01 Sep '23

01 Sep '23

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34273 ) Change subject: m3ua: Add some TODO comments on where we fall short of our potential ...................................................................... m3ua: Add some TODO comments on where we fall short of our potential Change-Id: I75d7b8f3fb6a06f6941b6dff4072287fdbb1d33e --- M src/m3ua.c M src/xua_as_fsm.c 2 files changed, 15 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/73/34273/1 diff --git a/src/m3ua.c b/src/m3ua.c index 85ac974..f4dbf76 100644 --- a/src/m3ua.c +++ b/src/m3ua.c @@ -462,9 +462,11 @@ return NULL; } - if (xua->hdr.msg_class == M3UA_MSGC_XFER) + if (xua->hdr.msg_class == M3UA_MSGC_XFER) { + /* TODO: M3UA RFC says that multiple different streams within the SCTP association + * *may* be used, for example, by using the SLS value. Not required but makes sense. */ msgb_sctp_stream(msg) = 1; - else + } else msgb_sctp_stream(msg) = 0; msgb_sctp_ppid(msg) = M3UA_PPID; diff --git a/src/xua_as_fsm.c b/src/xua_as_fsm.c index 2b16139..e239c74 100644 --- a/src/xua_as_fsm.c +++ b/src/xua_as_fsm.c @@ -158,6 +158,8 @@ asp = xua_as_select_asp_override(as); break; case OSMO_SS7_AS_TMOD_LOADSHARE: + /* TODO: actually use the SLS value to ensure same SLS goes through same ASP. Not + * strictly required by M3UA RFC, but would fit the overall principle. */ case OSMO_SS7_AS_TMOD_ROUNDROBIN: asp = xua_as_select_asp_roundrobin(as); break; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34273 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I75d7b8f3fb6a06f6941b6dff4072287fdbb1d33e Gerrit-Change-Number: 34273 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ttcn3-hacks[master]: stp: Don't expect a fixed SLS in IPA -> M3UA case
by laforge 01 Sep '23

01 Sep '23

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34263 ) Change subject: stp: Don't expect a fixed SLS in IPA -> M3UA case ...................................................................... stp: Don't expect a fixed SLS in IPA -> M3UA case We are about to introduce a feature for SLS "randomization" in osmo-stp, so let's modifiy our STP tests to permit any SLS in the M3UA messages after IPA -> M3UA conversion. Change-Id: Ib70322b80a72e3e7dc3155bca9e67b03efb413e0 Related: SYS#6543 --- M stp/STP_Tests.ttcn 1 file changed, 17 insertions(+), 3 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/stp/STP_Tests.ttcn b/stp/STP_Tests.ttcn index 48214be..e2e5336 100644 --- a/stp/STP_Tests.ttcn +++ b/stp/STP_Tests.ttcn @@ -114,7 +114,7 @@ /* expect to receive it via M3UA */ var template (present) M3UA_Protocol_Data rx_pd; - rx_pd := tr_M3UA_protocol_data(pc_sender, pc_receiver, c_M3UA_SI_SCCP, '00'O, '00'O, '00'O, sccp_enc); + rx_pd := tr_M3UA_protocol_data(pc_sender, pc_receiver, c_M3UA_SI_SCCP, '00'O, '00'O, ?, sccp_enc); f_M3UA_exp(0, tr_M3UA_DATA(rctx_receiver, rx_pd)); f_clear_m3ua(); @@ -148,7 +148,7 @@ /* expect to receive it via M3UA */ var template (present) M3UA_Protocol_Data rx_pd; rx_pd := tr_M3UA_protocol_data(pc_sender, pc_receiver, c_M3UA_SI_SCCP, c_M3UA_NI_NATIONAL, - '00'O, '00'O, sccp_enc); + '00'O, ?, sccp_enc); f_M3UA_exp(0, tr_M3UA_DATA(rctx_receiver, rx_pd)); f_vty_config2(VTY, {"cs7 instance 0"}, "network-indicator international"); f_clear_m3ua(); @@ -185,7 +185,7 @@ /* expect to receive it via M3UA */ var template (present) M3UA_Protocol_Data rx_pd; - rx_pd := tr_M3UA_protocol_data(pc_sender, pc_receiver, c_M3UA_SI_SCCP, '00'O, '00'O, '00'O, + rx_pd := tr_M3UA_protocol_data(pc_sender, pc_receiver, c_M3UA_SI_SCCP, '00'O, '00'O, ?, enc_PDU_SCCP(sccp_exp)); f_M3UA_exp(0, tr_M3UA_DATA(rctx_receiver, rx_pd)); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34263 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib70322b80a72e3e7dc3155bca9e67b03efb413e0 Gerrit-Change-Number: 34263 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 0

[S] Change in osmo-ttcn3-hacks[master]: stp: Don't expect a fixed SLS in IPA -> M3UA case
by laforge 01 Sep '23

01 Sep '23

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34263 ) Change subject: stp: Don't expect a fixed SLS in IPA -> M3UA case ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34263 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib70322b80a72e3e7dc3155bca9e67b03efb413e0 Gerrit-Change-Number: 34263 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Sep 2023 08:28:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in libosmo-sccp[master]: ipa: use LSBs of file descriptor as SLS in IPA->M3UA direction
by laforge 01 Sep '23

01 Sep '23

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34264 ) Change subject: ipa: use LSBs of file descriptor as SLS in IPA->M3UA direction ...................................................................... Patch Set 2: (1 comment) File src/ipa.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/34264/comment/aa76543d_59939b31 PS1, Line 295: * \param[in] msg received message buffer. Callee takes ownership! > missing new param documentation Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34264 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ice7bab997b84cfed00c7d6d780c70f4e9fac6002 Gerrit-Change-Number: 34264 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Sep 2023 08:28:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in libosmo-sccp[master]: ipa: use LSBs of file descriptor as SLS in IPA->M3UA direction
by laforge 01 Sep '23

01 Sep '23

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34264 to look at the new patch set (#2). Change subject: ipa: use LSBs of file descriptor as SLS in IPA->M3UA direction ...................................................................... ipa: use LSBs of file descriptor as SLS in IPA->M3UA direction when IPA/SCCPlite traffic traverses the osmo_ss7 stack, so far the SLS of the MTP3 label was always set to 0 (default initialization). However, in order to achieve a better distribution of signaling traffic in SS7 networks that actually utilize the SLS to select any links (or ASPs), it makes sense to use non-zero values. Instead of introducing some kind of new, configurable attribute for each ASP (IPA client connection), let's simply use the lower 4 bits of the file descriptor integer. Those file descriptors should have a roughly equal distribution, resulting in traffic (from multiple IPA clients) to be spread across the 4-bit SLS number space. Also, this mechanism ensures that traffic from one IPA client will always get the same SLS and hence routed the same way in any underlying CS7/SS7 network. Change-Id: Ice7bab997b84cfed00c7d6d780c70f4e9fac6002 Related: SYS#6543 --- M src/ipa.c M src/osmo_ss7.c M src/xua_internal.h 3 files changed, 35 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/64/34264/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34264 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ice7bab997b84cfed00c7d6d780c70f4e9fac6002 Gerrit-Change-Number: 34264 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in libosmo-sccp[master]: ipa: use LSBs of file descriptor as SLS in IPA->M3UA direction
by laforge 01 Sep '23

01 Sep '23

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34264 ) Change subject: ipa: use LSBs of file descriptor as SLS in IPA->M3UA direction ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Why not have a global variable incrementing with each new conn instead of taking it from fd? That wo […] I am not sure a global variable would lead to better distribution, given that that would be one range split over all AS. So if you have an even number of ASs with an even number of ASPs and a fairly determinstic bring-up after restart / link-failure, you might end up having all of the ASPs within one AS in the same bucket. If you really wanted to do better, you'd need a per-AS variable, not a global one. And this would break both ABI + API (due to all related structs being public) and I thought it's not worth going there *just* for that. Chances are high that this patch improves the situation significantly. If it's still creating problems to users, we can always improve later. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34264 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ice7bab997b84cfed00c7d6d780c70f4e9fac6002 Gerrit-Change-Number: 34264 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Sep 2023 08:26:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0

[S] Change in osmo-ttcn3-hacks[master]: NAS_Templates: fix ts_NAS_GUTI
by dexter 01 Sep '23

01 Sep '23

Attention is currently required from: pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34267 ) Change subject: NAS_Templates: fix ts_NAS_GUTI ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > So what you are saying is that ts_NAS_GUTI was wrong? The resulting MCC/MNC digits appear in a strange order I can not make sense of. The template is nowhere used yet, so I think something must be wrong. Also I think that the templates should not do format conversions of the MCC/MNC digits. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34267 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9546993987b873e8ae921664238b234608e37bba Gerrit-Change-Number: 34267 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Sep 2023 07:35:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 0