laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35462?usp=email )
Change subject: Introduce GlobalPlatform SCP02 implementation
......................................................................
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/35462?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I56020382b9dfe8ba0f7c1c9f71eb1a9746bc5a27
Gerrit-Change-Number: 35462
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Wed, 31 Jan 2024 21:45:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/pysim/+/35756?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: global_platform: implement GET STATUS command
......................................................................
global_platform: implement GET STATUS command
The GlobalPlatform GET STATUS command is used to display information
about ISD / Applications / ExecutabLoad Files / Modules on the card.
Change-Id: Ic92f96c1c6a569aebc93a906c62a43b86fe3b811
---
M docs/shell.rst
M pySim/global_platform.py
2 files changed, 107 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/56/35756/2
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/35756?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ic92f96c1c6a569aebc93a906c62a43b86fe3b811
Gerrit-Change-Number: 35756
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/35763?usp=email )
Change subject: move global_platform.py to global_platform/__init__.py
......................................................................
move global_platform.py to global_platform/__init__.py
This will allow us to have multiple different modules for different
aspects of global_platform.
Change-Id: Ieca0b20c26a2e41eb11455941164474b76eb3c7a
---
R pySim/global_platform/__init__.py
1 file changed, 12 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/63/35763/1
diff --git a/pySim/global_platform.py b/pySim/global_platform/__init__.py
similarity index 100%
rename from pySim/global_platform.py
rename to pySim/global_platform/__init__.py
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/35763?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ieca0b20c26a2e41eb11455941164474b76eb3c7a
Gerrit-Change-Number: 35763
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newchange
Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/35761?usp=email )
Change subject: ms: do not set the blade tuning mode
......................................................................
ms: do not set the blade tuning mode
Sophisticated users can export BLADERF_DEFAULT_TUNING_MODE=fpga which
reduces the startup time to 1 second, or
BLADERF_DEFAULT_TUNING_MODE=fpga which always works.
Defaulting to fpga mode has the unfortunate side effect that the blade
can get stuck in a weird invalid mode when supplying wrong parameters
that breaks sample streaming until it is power cycled or "reset" by
using host tuning once. So, let's do the safe thing, and not default to
fpga mode.
Change-Id: I109f925f07a198d1fb33fe793e91e455fea05a96
---
M Transceiver52M/ms/bladerf_specific.h
1 file changed, 19 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/61/35761/1
diff --git a/Transceiver52M/ms/bladerf_specific.h b/Transceiver52M/ms/bladerf_specific.h
index e9245d4..57aae75 100644
--- a/Transceiver52M/ms/bladerf_specific.h
+++ b/Transceiver52M/ms/bladerf_specific.h
@@ -255,7 +255,6 @@
bladerf_log_set_verbosity(BLADERF_LOG_LEVEL_DEBUG);
bladerf_set_usb_reset_on_open(true);
- setenv("BLADERF_DEFAULT_TUNING_MODE","fpga",1); // ensure blade 2 does not spend 10 seconds initializing host control
blade_check(bladerf_open, &dev, "");
if (!dev) {
std::cerr << "open failed, device missing?" << std::endl;
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/35761?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I109f925f07a198d1fb33fe793e91e455fea05a96
Gerrit-Change-Number: 35761
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-MessageType: newchange
Attention is currently required from: fixeria, pespin.
Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/35757?usp=email )
Change subject: ms: conditionally override the tuning mode
......................................................................
Patch Set 1:
(1 comment)
File Transceiver52M/ms/bladerf_specific.h:
https://gerrit.osmocom.org/c/osmo-trx/+/35757/comment/7ec7dd40_2e6606cf
PS1, Line 258: if (getenv("BLADERF_DEFAULT_TUNING_MODE") == NULL)
> This probably deserves some sort of comment here explaining why one may want to set this.
If running modem without parameters somehow gets the blade into a stuck state. That is only occurence so far, to be fixed by my config file patch that properly overrides the arfc/settings on the transceiver, since the whole thing is supposed to only work with ham radio frequencies anyway and should mostly ignore what the upper layer wants.
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/35757?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I11f2ecc50b480d71736a7f224295e5e37745385e
Gerrit-Change-Number: 35757
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 31 Jan 2024 18:46:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: Hoernchen, fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/35757?usp=email )
Change subject: ms: conditionally override the tuning mode
......................................................................
Patch Set 1:
(1 comment)
File Transceiver52M/ms/bladerf_specific.h:
https://gerrit.osmocom.org/c/osmo-trx/+/35757/comment/815c3f60_4ad89b5a
PS1, Line 258: if (getenv("BLADERF_DEFAULT_TUNING_MODE") == NULL)
This probably deserves some sort of comment here explaining why one may want to set this.
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/35757?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I11f2ecc50b480d71736a7f224295e5e37745385e
Gerrit-Change-Number: 35757
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 31 Jan 2024 18:39:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment