Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/27627 )
Change subject: WIP: llc: schedule frames to MS based on SAPI priority
......................................................................
Patch Set 1:
(3 comments)
File src/llc.h:
https://gerrit.osmocom.org/c/osmo-pcu/+/27627/comment/6d6517e7_94c95273
PS1, Line 37: union
This line as well as the address field can be moved out of the conditional block to avoid duplication.
File src/llc.c:
https://gerrit.osmocom.org/c/osmo-pcu/+/27627/comment/82fc5a97_ecf7b419
PS1, Line 99: int i
For the sake of consistency with llc_queue_clear(), it should be unsigned.
https://gerrit.osmocom.org/c/osmo-pcu/+/27627/comment/4f82228a_f118a575
PS1, Line 112:
Unusual formatting.
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/27627
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ie8bd91eeac4fa7487d4f11b808dea95737041c7e
Gerrit-Change-Number: 27627
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 31 Mar 2022 18:54:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/27623 )
Change subject: llc: Convert to C
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/27623
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I250680ba581167d7398b2f734769c756cbb61c48
Gerrit-Change-Number: 27623
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 31 Mar 2022 18:43:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: laforge.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27619 )
Change subject: fix bts_cbch_send_one(): use proper RSL Channel Number
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
> the question is whether it really matters, and whether it is really specified. 48.058 section 9.3. […]
This is a valid point. My intention is to make it work with osmo-bts, because currently SMSCB does not work if CBCH is allocated on Cn. Probably we need to fix osmo-bts instead? Would be good to know how commercial multi-trx BTS models handle this.
PS2:
Let's keep this patch WIP.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27619
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ib5fd00bfd5e762ce0a56e73816162d0555976f8d
Gerrit-Change-Number: 27619
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Thu, 31 Mar 2022 18:38:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment