Attention is currently required from: laforge, osmith, pespin.
Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/36836?usp=email )
Change subject: ttcn3-docker-run.sh: Fix dumpcap failing to access /data inside docker
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Patchset:
PS2:
I guess this is the obvious fix without messing with the id mappings and making everything even more complicated.,
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36836?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I1229a91cdbb1aa73fd94f1bf7e26f34086f06b25
Gerrit-Change-Number: 36836
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 15 May 2024 18:57:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Hoernchen, laforge, osmith.
Hello Hoernchen, Jenkins Builder, laforge, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/docker-playground/+/36836?usp=email
to look at the new patch set (#2).
Change subject: ttcn3-docker-run.sh: Fix dumpcap failing to access /data inside docker
......................................................................
ttcn3-docker-run.sh: Fix dumpcap failing to access /data inside docker
In docker, the /data dir is mapped to $VOL_BASE_DIR, which is created by
docker-playground.git jenkins-common.sh, hence as the user running
jenkins.sh in the host system.
As a result, when the dir is mapped to /data, inside the container it
will have the UID:GID of the outter user, not the one inside docker.
Before this patch, if a ttcn3 container was started in jenkins.sh with
--cap-add=NET_ADMIN, then osmo-ttcn3-hacks.git/ttcn3-tcpdump-start.sh
would select dumpcap instead of tcpdump, to attempt to record a pcap
file to /data/$testcase.pcap.
Due to some unknown way of dropping privileges done by dumpcap though,
it was unable to open the /data/$testcase.pcap due to /data being owned
to another user (tcpdump doesn't have this problem).
This patch fixes the above scenario by making sure /data is chowned to
the user running stuff inside docker. This is already kinda expected
since there's a fix_perms() script in jenkins-common.sh reverting files
created during the test so that they can be accessible by outter user
once everything is finished.
Change-Id: I1229a91cdbb1aa73fd94f1bf7e26f34086f06b25
---
M common/ttcn3-docker-run.sh
1 file changed, 32 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/36/36836/2
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36836?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I1229a91cdbb1aa73fd94f1bf7e26f34086f06b25
Gerrit-Change-Number: 36836
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newpatchset
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/36836?usp=email )
Change subject: ttcn3-docker-run.sh: Fix dumpcap failing to access /data inside docker
......................................................................
ttcn3-docker-run.sh: Fix dumpcap failing to access /data inside docker
In docker, the /data dir is mapped to $VOL_BASE_DIR, which is created by
docker-playground.git jenkins-common.sh, hence as the user running
jenkins.sh in the host system.
As a result, when the dir is mapped to /data, inside the container it
will have the UID:GID of the outter user, not the one inside docker.
Before this patch, if a ttcn3 container was started in jenkins.sh with
--cap-add=NET_ADMIN, then osmo-ttcn3-hacks.git/ttcn3-tcpdump-start.sh
would select dumpcap instead of tcpdump, to attempt to record a pcap
file to /data/$testcase.pcap.
Due to some unknown way of dropping privileges done by dumpcap though,
it was unable to open the /data/$testcase.pcap due to /data being owned
to another user (tcpdump doesn't have this problem).
This patch fixes the above scenario by making dure /data is chowned to
the user running stuff inside docker. This is already kinda expected
since there's a fix_perms() script in jenkins-common.sh reverting files
created during the test so that they can be accessible by outter user
once everything is finished.
Change-Id: I1229a91cdbb1aa73fd94f1bf7e26f34086f06b25
---
M common/ttcn3-docker-run.sh
1 file changed, 32 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/36/36836/1
diff --git a/common/ttcn3-docker-run.sh b/common/ttcn3-docker-run.sh
index c8c871e..60339c4 100755
--- a/common/ttcn3-docker-run.sh
+++ b/common/ttcn3-docker-run.sh
@@ -31,6 +31,9 @@
done
fi
+# Make sure /data is owned to the user running inside docker.
+# jenkins-commons.sh fix_perms() will fix back the permissions once done.
+chown -R "$(id -u):$(id -g)" /data
cd /data
# Use TEST_NAME to only run one test instead of all. Set it like this:
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/36836?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I1229a91cdbb1aa73fd94f1bf7e26f34086f06b25
Gerrit-Change-Number: 36836
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newchange
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/36834?usp=email )
Change subject: jobs/ttcn3: run ttcn3-msc-test earlier
......................................................................
jobs/ttcn3: run ttcn3-msc-test earlier
It seems like various tests are failing from time to time due to the
builder having a too high load. As several ttcn3 testsuites run around 4
am already, move ttcn3-msc-test to 1 hour earlier where we don't have
anything currently.
Change-Id: I8eaf058f13f4175a458e9abe544bfb21ace481b7
---
M jobs/README.adoc
M jobs/ttcn3-testsuites.yml
2 files changed, 17 insertions(+), 3 deletions(-)
Approvals:
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/jobs/README.adoc b/jobs/README.adoc
index eb14152..d403bff 100644
--- a/jobs/README.adoc
+++ b/jobs/README.adoc
@@ -139,7 +139,7 @@
02:XX registry-triggers
02:XX registry-rebuild-upload-fpga-build (weekly)
- 04:00 - 18:00 Jobs that need binary packages
+ 03:00 - 18:00 Jobs that need binary packages
ttcn3-testsuites
04:XX osmocom-release-manuals
05:XX osmocom-release-tarballs
diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml
index ac79f4d..f436e26 100644
--- a/jobs/ttcn3-testsuites.yml
+++ b/jobs/ttcn3-testsuites.yml
@@ -20,6 +20,8 @@
# timer: 10 per hour from 04:00 - 18:00, see jobs/README.adoc
job-name:
# debian nightly - order by time
+ - ttcn3-msc-test:
+ timer: H 03 * * *
- nplab-m3ua-test:
timer: H 04 * * *
- nplab-sua-test:
@@ -67,8 +69,6 @@
description: |
Test open5gs-smfd + open5gs-upfd main.
email: jenkins-notifications(a)lists.osmocom.org acetcom(a)gmail.com
- - ttcn3-msc-test:
- timer: H 04 * * *
- ttcn3-pcu-test:
timer: H 04 * * *
- ttcn3-pcu-test-sns:
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36834?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I8eaf058f13f4175a458e9abe544bfb21ace481b7
Gerrit-Change-Number: 36834
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged
Attention is currently required from: daniel, neels, pespin, tnt.
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/36787?usp=email )
Change subject: ranap_common: Implement support for missing procedures
......................................................................
Patch Set 2: Code-Review+1
(4 comments)
Patchset:
PS1:
> I don't really understand what this is about TBH, just doing a quick read of the code for "unexpecte […]
Done
Patchset:
PS2:
Looks logical to me.
File src/ranap_common_ran.c:
https://gerrit.osmocom.org/c/osmo-iuh/+/36787/comment/69e96e8c_19bd53ac
PS1, Line 196: static int ran_ranap_rx_unsuccessful_msg_co(RANAP_SuccessfulOutcome_t *imsg, ranap_message *message)
> ran_ranap_rx_unsuccessful_msg_co takes a RANAP_SuccessfulOutcome_t as param and not some RANAP_Unsuc […]
Done
https://gerrit.osmocom.org/c/osmo-iuh/+/36787/comment/300fccd4_2fecee0b
PS1, Line 247: rc = ran_ranap_rx_unsuccessful_msg_co(&pdu->choice.successfulOutcome, message);
> Not pdu->choice. […]
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/36787?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: I7dea74102da8b610ff2a310c5814f5c89f08e7a6
Gerrit-Change-Number: 36787
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: tnt <tnt(a)246tNt.com>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: tnt <tnt(a)246tNt.com>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 15 May 2024 15:15:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: tnt <tnt(a)246tNt.com>
Gerrit-MessageType: comment
Attention is currently required from: laforge.
Joey Berkovitz has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/36835?usp=email )
Change subject: user_ifdhandler: Fix segfault on startup
......................................................................
Patch Set 3:
(1 comment)
File src/client/user_ifdhandler.c:
https://gerrit.osmocom.org/c/osmo-remsim/+/36835/comment/08424d65_bc6da8f0
PS1, Line 374: ensure_osmo_ctx
> ensure_osmo_ctx() basically calls osmo_ctx_init() which is called just two lines below. […]
confirmed - moving osmo_select_init below the successful osmo_ctx_init fixes the issue
--
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/36835?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: I6e839b7772a9b176b972c5c0a01bb352a7a68923
Gerrit-Change-Number: 36835
Gerrit-PatchSet: 3
Gerrit-Owner: Joey Berkovitz <joey(a)berkovitz.us>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Wed, 15 May 2024 15:13:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment
Attention is currently required from: Joey Berkovitz.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-remsim/+/36835?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: user_ifdhandler: Fix segfault on startup
......................................................................
user_ifdhandler: Fix segfault on startup
Change-Id: I6e839b7772a9b176b972c5c0a01bb352a7a68923
---
M src/client/user_ifdhandler.c
1 file changed, 10 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-remsim refs/changes/35/36835/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/36835?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: I6e839b7772a9b176b972c5c0a01bb352a7a68923
Gerrit-Change-Number: 36835
Gerrit-PatchSet: 3
Gerrit-Owner: Joey Berkovitz <joey(a)berkovitz.us>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Joey Berkovitz <joey(a)berkovitz.us>
Gerrit-MessageType: newpatchset
Attention is currently required from: daniel, neels, pespin, tnt.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/36787?usp=email )
Change subject: ranap_common: Implement support for missing procedures
......................................................................
Patch Set 2:
(3 comments)
Patchset:
PS1:
> I don't really understand what this is about TBH, just doing a quick read of the code for "unexpecte […]
thanks, it was a simple copy+paste mistake.
File src/ranap_common_ran.c:
https://gerrit.osmocom.org/c/osmo-iuh/+/36787/comment/9f6380a6_a8ca699e
PS1, Line 196: static int ran_ranap_rx_unsuccessful_msg_co(RANAP_SuccessfulOutcome_t *imsg, ranap_message *message)
> ran_ranap_rx_unsuccessful_msg_co takes a RANAP_SuccessfulOutcome_t as param and not some RANAP_Unsuc […]
Done
https://gerrit.osmocom.org/c/osmo-iuh/+/36787/comment/80125f9e_14235a47
PS1, Line 247: rc = ran_ranap_rx_unsuccessful_msg_co(&pdu->choice.successfulOutcome, message);
> Not pdu->choice. […]
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/36787?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: I7dea74102da8b610ff2a310c5814f5c89f08e7a6
Gerrit-Change-Number: 36787
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: tnt <tnt(a)246tNt.com>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: tnt <tnt(a)246tNt.com>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 15 May 2024 15:10:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: tnt <tnt(a)246tNt.com>
Gerrit-MessageType: comment
Attention is currently required from: daniel, laforge, neels, pespin.
Hello Jenkins Builder, daniel, neels, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-iuh/+/36787?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by pespin, Verified+1 by Jenkins Builder
Change subject: ranap_common: Implement support for missing procedures
......................................................................
ranap_common: Implement support for missing procedures
Both the RAN and the CN side of ranap_common were missing support for
decoding requests and/or responses for a number of RANAP procedures.
This patch adds all of them a of TS 25.413 Release 12 except those
related to MBMS or SRVCC.
Related: SYS#6885
Change-Id: I7dea74102da8b610ff2a310c5814f5c89f08e7a6
---
M src/ranap_common_cn.c
M src/ranap_common_ran.c
2 files changed, 284 insertions(+), 25 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/87/36787/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/36787?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: I7dea74102da8b610ff2a310c5814f5c89f08e7a6
Gerrit-Change-Number: 36787
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: tnt <tnt(a)246tNt.com>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: daniel, laforge, neels.
tnt has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/36787?usp=email )
Change subject: ranap_common: Implement support for missing procedures
......................................................................
Patch Set 1:
(3 comments)
Patchset:
PS1:
I don't really understand what this is about TBH, just doing a quick read of the code for "unexpected" things and this seemed a bit weird to me, feel free to ignore if this is how it should be ...
File src/ranap_common_ran.c:
https://gerrit.osmocom.org/c/osmo-iuh/+/36787/comment/050f4484_42ff9ca5
PS1, Line 196: static int ran_ranap_rx_unsuccessful_msg_co(RANAP_SuccessfulOutcome_t *imsg, ranap_message *message)
ran_ranap_rx_unsuccessful_msg_co takes a RANAP_SuccessfulOutcome_t as param and not some RANAP_UnsuccessfulOutcome_t
https://gerrit.osmocom.org/c/osmo-iuh/+/36787/comment/38ab628c_4d80622b
PS1, Line 247: rc = ran_ranap_rx_unsuccessful_msg_co(&pdu->choice.successfulOutcome, message);
Not pdu->choice.unsuccessfulOutcome ?
--
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/36787?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: I7dea74102da8b610ff2a310c5814f5c89f08e7a6
Gerrit-Change-Number: 36787
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: tnt <tnt(a)246tNt.com>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 15 May 2024 15:04:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: dexter, fixeria, pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36832?usp=email )
Change subject: remsim: Move PIPEasp generic helper code to library/PIPEasp_Templates.ttcn
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
adding @pmaier@sysmocom.de as I know he also has been using PIPEasp recently in his eIM/IPAd tests
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36832?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I4a5ededbd958c87537f84155092b6a6cd715865a
Gerrit-Change-Number: 36832
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 15 May 2024 14:55:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Joey Berkovitz.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-remsim/+/36835?usp=email )
Change subject: user_ifdhandler: Fix segfault on startup
......................................................................
Patch Set 1:
(1 comment)
File src/client/user_ifdhandler.c:
https://gerrit.osmocom.org/c/osmo-remsim/+/36835/comment/c6824d93_206eb05a
PS1, Line 374: ensure_osmo_ctx
ensure_osmo_ctx() basically calls osmo_ctx_init() which is called just two lines below. Might it be that the existing code just needs to be re-ordered? Did you try the following:
* not adding ensure_osmo_ctx
* moving osmo_select_init below osmo_ctx_init
Thanks!
--
To view, visit https://gerrit.osmocom.org/c/osmo-remsim/+/36835?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-remsim
Gerrit-Branch: master
Gerrit-Change-Id: I6e839b7772a9b176b972c5c0a01bb352a7a68923
Gerrit-Change-Number: 36835
Gerrit-PatchSet: 1
Gerrit-Owner: Joey Berkovitz <joey(a)berkovitz.us>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Joey Berkovitz <joey(a)berkovitz.us>
Gerrit-Comment-Date: Wed, 15 May 2024 14:55:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ci/+/36834?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: jobs/ttcn3: run ttcn3-msc-test earlier
......................................................................
jobs/ttcn3: run ttcn3-msc-test earlier
It seems like various tests are failing from time to time due to the
builder having a too high load. As several ttcn3 testsuites run around 4
am already, move ttcn3-msc-test to 1 hour earlier where we don't have
anything currently.
Change-Id: I8eaf058f13f4175a458e9abe544bfb21ace481b7
---
M jobs/README.adoc
M jobs/ttcn3-testsuites.yml
2 files changed, 17 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/34/36834/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36834?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I8eaf058f13f4175a458e9abe544bfb21ace481b7
Gerrit-Change-Number: 36834
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset
osmith has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/36833?usp=email )
Change subject: lint: do "docker run --rm" check only in jenkins
......................................................................
Abandoned
submitted by accident, need to test more if this makes a difference
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36833?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I00a28a04b0fae8804846948a155c6214bf1aca00
Gerrit-Change-Number: 36833
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: abandon
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/36834?usp=email )
Change subject: jobs/ttcn3: run ttcn3-msc-test earlier
......................................................................
jobs/ttcn3: run ttcn3-msc-test earlier
It seems like various tests are failing from time to time due to the
builder having a too high load. As several ttcn3 testsuites run around 4
am already, move ttcn3-msc-test to 1 hour earlier where we don't have
anything currently.
Change-Id: I8eaf058f13f4175a458e9abe544bfb21ace481b7
---
M jobs/README.adoc
M jobs/ttcn3-testsuites.yml
2 files changed, 16 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/34/36834/1
diff --git a/jobs/README.adoc b/jobs/README.adoc
index eb14152..d403bff 100644
--- a/jobs/README.adoc
+++ b/jobs/README.adoc
@@ -139,7 +139,7 @@
02:XX registry-triggers
02:XX registry-rebuild-upload-fpga-build (weekly)
- 04:00 - 18:00 Jobs that need binary packages
+ 03:00 - 18:00 Jobs that need binary packages
ttcn3-testsuites
04:XX osmocom-release-manuals
05:XX osmocom-release-tarballs
diff --git a/jobs/ttcn3-testsuites.yml b/jobs/ttcn3-testsuites.yml
index ac79f4d..8d17938 100644
--- a/jobs/ttcn3-testsuites.yml
+++ b/jobs/ttcn3-testsuites.yml
@@ -68,7 +68,7 @@
Test open5gs-smfd + open5gs-upfd main.
email: jenkins-notifications(a)lists.osmocom.org acetcom(a)gmail.com
- ttcn3-msc-test:
- timer: H 04 * * *
+ timer: H 03 * * *
- ttcn3-pcu-test:
timer: H 04 * * *
- ttcn3-pcu-test-sns:
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36834?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I8eaf058f13f4175a458e9abe544bfb21ace481b7
Gerrit-Change-Number: 36834
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: newchange
Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/36830?usp=email )
Change subject: jobs/ttcn3-testsuites.yml: add ttcn3-bts-test-io_uring
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
This should probably also help a lot with TRXD and PCUIF once we move it to osmo_io.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/36830?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I3af791103d863290a53c9ce2d1a8d1d9e42e91c7
Gerrit-Change-Number: 36830
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 15 May 2024 12:15:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment