pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36126?usp=email )
Change subject: Split GTP_CodecPort/GTP_Templates into C and U variants
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
With this patch I can add GTPv1-U support to GTPv2C_Emulation without having to includes tons of GTPC related code.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36126?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic15c9a2e92828cbafb4dda7355ee534107051e2d
Gerrit-Change-Number: 36126
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Thu, 29 Feb 2024 19:56:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36126?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: Split GTP_CodecPort/GTP_Templates into C and U variants
......................................................................
Split GTP_CodecPort/GTP_Templates into C and U variants
The Types are already split in the dependent modules in GTPC_Types and
GTPU_Types.
There's no point in keeping them together in the same file since those 2
protocols are mostly independent.
Furthermore, testsuites using GTPv2C + GTPv1U don't need GTPv1C.
Change-Id: Ic15c9a2e92828cbafb4dda7355ee534107051e2d
---
M gbproxy/gen_links.sh
M gbproxy/regen_makefile.sh
M ggsn_tests/GGSN_Tests.default
M ggsn_tests/GGSN_Tests.ttcn
M ggsn_tests/gen_links.sh
M ggsn_tests/regen_makefile.sh
M hnodeb/HNBGW_ConnectionHandler.ttcn
M hnodeb/HNB_Tests.ttcn
M hnodeb/gen_links.sh
M hnodeb/regen_makefile.sh
M library/GTP_Emulation.ttcn
R library/GTPv1C_CodecPort.ttcn
R library/GTPv1C_CodecPort_CtrlFunct.ttcn
R library/GTPv1C_CodecPort_CtrlFunctDef.cc
R library/GTPv1C_Templates.ttcn
A library/GTPv1U_CodecPort.ttcn
A library/GTPv1U_CodecPort_CtrlFunct.ttcn
A library/GTPv1U_CodecPort_CtrlFunctDef.cc
A library/GTPv1U_Templates.ttcn
M library/GTPv2_CodecPort.ttcn
M library/GTPv2_Emulation.ttcn
M mme/MME_Tests.ttcn
M mme/gen_links.sh
M mme/regen_makefile.sh
M pgw/gen_links.sh
M pgw/regen_makefile.sh
M sgsn/SGSN_Tests.ttcn
M sgsn/gen_links.sh
M sgsn/regen_makefile.sh
29 files changed, 375 insertions(+), 294 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/26/36126/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36126?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic15c9a2e92828cbafb4dda7355ee534107051e2d
Gerrit-Change-Number: 36126
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36126?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: Split GTP_CodecPort/GTP_Templates into C and U variants
......................................................................
Split GTP_CodecPort/GTP_Templates into C and U variants
The Types are already split in the dependent modules in GTPC_Types and
GTPU_Types.
There's no point in keeping them together in the same file since those 2
protocols are mostly independent.
Furthermore, testsuites using GTPv2C + GTPv1U don't need GTPv1C.
Change-Id: Ic15c9a2e92828cbafb4dda7355ee534107051e2d
---
M gbproxy/gen_links.sh
M gbproxy/regen_makefile.sh
M ggsn_tests/GGSN_Tests.default
M ggsn_tests/GGSN_Tests.ttcn
M ggsn_tests/gen_links.sh
M ggsn_tests/regen_makefile.sh
M hnodeb/HNBGW_ConnectionHandler.ttcn
M hnodeb/HNB_Tests.ttcn
M hnodeb/gen_links.sh
M hnodeb/regen_makefile.sh
M library/GTP_Emulation.ttcn
R library/GTPv1C_CodecPort.ttcn
R library/GTPv1C_CodecPort_CtrlFunct.ttcn
R library/GTPv1C_CodecPort_CtrlFunctDef.cc
R library/GTPv1C_Templates.ttcn
A library/GTPv1U_CodecPort.ttcn
A library/GTPv1U_CodecPort_CtrlFunct.ttcn
A library/GTPv1U_CodecPort_CtrlFunctDef.cc
A library/GTPv1U_Templates.ttcn
M library/GTPv2_CodecPort.ttcn
M library/GTPv2_Emulation.ttcn
M mme/MME_Tests.ttcn
M mme/gen_links.sh
M mme/regen_makefile.sh
M pgw/gen_links.sh
M pgw/regen_makefile.sh
M sgsn/SGSN_Tests.ttcn
M sgsn/gen_links.sh
M sgsn/regen_makefile.sh
29 files changed, 377 insertions(+), 294 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/26/36126/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36126?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic15c9a2e92828cbafb4dda7355ee534107051e2d
Gerrit-Change-Number: 36126
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36126?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: Split GTP_CodecPort/GTP_Templates into C and U variants
......................................................................
Split GTP_CodecPort/GTP_Templates into C and U variants
The Types are already split in the dependent modules in GTPC_Types and
GTPU_Types.
There's no point in keeping them together in the same file since those 2
protocols are mostly independent.
Furthermore, testsuites using GTPv2C + GTPv1U don't need GTPv1C.
Change-Id: Ic15c9a2e92828cbafb4dda7355ee534107051e2d
---
M gbproxy/gen_links.sh
M gbproxy/regen_makefile.sh
M ggsn_tests/GGSN_Tests.default
M ggsn_tests/GGSN_Tests.ttcn
M ggsn_tests/gen_links.sh
M ggsn_tests/regen_makefile.sh
M hnodeb/HNBGW_ConnectionHandler.ttcn
M hnodeb/HNB_Tests.ttcn
M hnodeb/gen_links.sh
M hnodeb/regen_makefile.sh
M library/GTP_Emulation.ttcn
R library/GTPv1C_CodecPort.ttcn
R library/GTPv1C_CodecPort_CtrlFunct.ttcn
R library/GTPv1C_CodecPort_CtrlFunctDef.cc
R library/GTPv1C_Templates.ttcn
A library/GTPv1U_CodecPort.ttcn
A library/GTPv1U_CodecPort_CtrlFunct.ttcn
A library/GTPv1U_CodecPort_CtrlFunctDef.cc
A library/GTPv1U_Templates.ttcn
M library/GTPv2_CodecPort.ttcn
M library/GTPv2_Emulation.ttcn
M mme/MME_Tests.ttcn
M mme/gen_links.sh
M mme/regen_makefile.sh
M pgw/gen_links.sh
M pgw/regen_makefile.sh
M sgsn/SGSN_Tests.ttcn
M sgsn/gen_links.sh
M sgsn/regen_makefile.sh
29 files changed, 377 insertions(+), 294 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/26/36126/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36126?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic15c9a2e92828cbafb4dda7355ee534107051e2d
Gerrit-Change-Number: 36126
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36121?usp=email )
Change subject: osmo_io: Assign const name when stealing TX msg from iofd ctx
......................................................................
osmo_io: Assign const name when stealing TX msg from iofd ctx
All TX messages are moved from iofd instance to the user's context.
iofd may be destroyed, but the message is still available to the user.
To prevent a use-after-free bug, the context name must be changed from
iofd->name to a constant that does not belong to iofd.
Change-Id: Ib8dae924fa2d94a7f636136ba7279b965a18cf5b
---
M src/core/osmo_io.c
1 file changed, 15 insertions(+), 3 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/src/core/osmo_io.c b/src/core/osmo_io.c
index 7ea959b..33466e5 100644
--- a/src/core/osmo_io.c
+++ b/src/core/osmo_io.c
@@ -152,9 +152,7 @@
uint16_t headroom = iofd->msgb_alloc.headroom;
OSMO_ASSERT(iofd->msgb_alloc.size < 0xffff - headroom);
- return msgb_alloc_headroom_c(iofd,
- iofd->msgb_alloc.size + headroom, headroom,
- iofd->name ? : "iofd_msgb");
+ return msgb_alloc_headroom_c(iofd, iofd->msgb_alloc.size + headroom, headroom, "osmo_io_msgb");
}
/*! return the pending msgb in iofd or NULL if there is none*/
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36121?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib8dae924fa2d94a7f636136ba7279b965a18cf5b
Gerrit-Change-Number: 36121
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged
jolly has abandoned this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36056?usp=email )
Change subject: Make osmo-io compile without libsctp support (--disable-libsctp)
......................................................................
Abandoned
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36056?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ief8ca40c0e85efe340eaecb866a10f76ac2bfc98
Gerrit-Change-Number: 36056
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: abandon