October 2023 - gerrit-log - lists.osmocom.org

[M] Change in osmo-mgw[master]: client: collapse codecs[] and ptmap[]; allow codec variants

by neels

Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34899?usp=email ) Change subject: client: collapse codecs[] and ptmap[]; allow codec variants ...................................................................... Patch Set 5: (1 comment) File src/libosmo-mgcp-client/mgcp_client.c: https://gerrit.osmocom.org/c/osmo-mgw/+/34899/comment/0ae25fd3_33ed68ea PS5, Line 421: <= > oh my goodness, thx. […] Ah of course, it is the mgcp *client* library, which we use in osmo-bsc, -msg, -hnbgw, so I need to run *their* test suites to check this code. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/34899?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I798e02c6663376d3d52f4a74fc4b32411ce95bed Gerrit-Change-Number: 34899 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Oct 2023 23:52:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

5 months, 4 weeks

1
0
0 0

[M] Change in osmo-mgw[master]: client: collapse codecs[] and ptmap[]; allow codec variants

by neels

Attention is currently required from: fixeria. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34899?usp=email ) Change subject: client: collapse codecs[] and ptmap[]; allow codec variants ...................................................................... Patch Set 5: (1 comment) File src/libosmo-mgcp-client/mgcp_client.c: https://gerrit.osmocom.org/c/osmo-mgw/+/34899/comment/b88ccba1_6fa16c1b PS5, Line 421: <= > shouldn't this be `>=`? oh my goodness, thx. wait a minute, what does that say about our test suite. I did run these patches by ttcn3-hnbgw-tests! This code path should *always* fail, so how did I not catch it. Is this dead code? Do we not have a=rtpmap in our tests? i don't think that can be true. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/34899?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I798e02c6663376d3d52f4a74fc4b32411ce95bed Gerrit-Change-Number: 34899 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Oct 2023 23:51:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

5 months, 4 weeks

1
0
0 0

[M] Change in osmo-mgw[master]: client: collapse codecs[] and ptmap[]; allow codec variants

by neels

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34899?usp=email ) Change subject: client: collapse codecs[] and ptmap[]; allow codec variants ...................................................................... Patch Set 5: Code-Review-1 (1 comment) Patchset: PS5: I just realized an API compat problem, for example osmo-hnbgw uses the codecs[] array and fails to build with this patch. Any ideas? -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/34899?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I798e02c6663376d3d52f4a74fc4b32411ce95bed Gerrit-Change-Number: 34899 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Oct 2023 23:40:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

5 months, 4 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: sccp: Introduce test TC_cr_timeout_cc_too_late

by pespin

Attention is currently required from: daniel, fixeria, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34923?usp=email ) Change subject: sccp: Introduce test TC_cr_timeout_cc_too_late ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: For some reason this builds locally fine, but fails here or in docker: SCCP_Templates.ttcn:184.10-80: error: There is no local or imported definition with name `ConvertASPAddressToEncodedAddress_opt_itu' I'm doing the same as existing ConvertASPAddressToEncodedAddress_itu, so not sure what's going on :/ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34923?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If4b53565f1fa19894ca24fa71e02ae7b1941411e Gerrit-Change-Number: 34923 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Oct 2023 17:17:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

5 months, 4 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: sccp: Introduce test TC_cr_timeout_cc_too_late

by pespin

Attention is currently required from: daniel, osmith, pespin. Hello Jenkins Builder, daniel, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34923?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: sccp: Introduce test TC_cr_timeout_cc_too_late ...................................................................... sccp: Introduce test TC_cr_timeout_cc_too_late Related: SYS#6602 Change-Id: If4b53565f1fa19894ca24fa71e02ae7b1941411e --- M library/SCCP_Templates.ttcn M sccp/SCCP_Tests_RAW.ttcn 2 files changed, 104 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/23/34923/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34923?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If4b53565f1fa19894ca24fa71e02ae7b1941411e Gerrit-Change-Number: 34923 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newpatchset

5 months, 4 weeks

1
0
0 0

[S] Change in pysim[master]: runtime: fix tracking of selected_adf

by dexter

Attention is currently required from: laforge. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34897?usp=email ) Change subject: runtime: fix tracking of selected_adf ...................................................................... Patch Set 3: (2 comments) Patchset: PS3: > this fix works. […] I have had a closer look to select and select_file in runtime.py now. I really had problems to understand what really happens with select and select_file. I have cleaned up the code now: https://gerrit.osmocom.org/c/pysim/+/34932 PS3: > I now see that self.selected_adf refers to RuntimeState. […] The change I did in RuntimeState is wrong I think. What we do there is probing for the applications on a low level. This is in the startup phase where the file system is created. We do not have to maintain the lchan state in this phase. We also can not use select or select_file either. I think it is ok to access the card from here directly. Also accessing self.selected_adf should not work. It should be self.lchan[0].selected_adf. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34897?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4cc0c58ff887422b4f3954d35c8380ddc00baa1d Gerrit-Change-Number: 34897 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 31 Oct 2023 16:36:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

6 months

1
0
0 0

[S] Change in pysim[master]: filesystem: fix method build_select_path_to

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/34931?usp=email ) Change subject: filesystem: fix method build_select_path_to ...................................................................... filesystem: fix method build_select_path_to The method build_select_path_to chops off the first element of the current path. This is done to prevent re-selection of the first file in the current path. Unfortunately chopping off the first element in the current path does not work properly in a situation when the current path points to the MF. This would chop off the first and last element in the list and the for loop below would run 0 times. To fix this, let's keep the first element and chop it off from the resulting path. Related: OS#5418 Change-Id: Ia521a7ac4c25fd3a2bc8edffdc45ec89ba4b16eb --- M pySim/filesystem.py 1 file changed, 23 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/31/34931/1 diff --git a/pySim/filesystem.py b/pySim/filesystem.py index 5950ad1..800f2cc 100644 --- a/pySim/filesystem.py +++ b/pySim/filesystem.py @@ -143,7 +143,6 @@ cur_fqpath = self.fully_qualified_path_fobj() target_fqpath = target.fully_qualified_path_fobj() inter_path = [] - cur_fqpath.pop() # drop last element (currently selected file, doesn't need re-selection cur_fqpath.reverse() for ce in cur_fqpath: inter_path.append(ce) @@ -153,7 +152,7 @@ for te2 in target_fqpath[i+1:]: inter_path.append(te2) # we found our common ancestor - return inter_path + return inter_path[1:] return None def get_mf(self) -> Optional['CardMF']: -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34931?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia521a7ac4c25fd3a2bc8edffdc45ec89ba4b16eb Gerrit-Change-Number: 34931 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

6 months

1
0
0 0

[S] Change in pysim[master]: runtime: cosmetic: fix formatting of comment

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/34930?usp=email ) Change subject: runtime: cosmetic: fix formatting of comment ...................................................................... runtime: cosmetic: fix formatting of comment Change-Id: I4e949a08c1bfab413b82e958a64404390e58148f --- M pySim/runtime.py 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/30/34930/1 diff --git a/pySim/runtime.py b/pySim/runtime.py index a54a1b6..8660724 100644 --- a/pySim/runtime.py +++ b/pySim/runtime.py @@ -241,7 +241,7 @@ def probe_file(self, fid: str, cmd_app=None): """Blindly try to select a file and automatically add a matching file - object if the file actually exists.""" + object if the file actually exists.""" if not is_hex(fid, 4, 4): raise ValueError( "Cannot select unknown file by name %s, only hexadecimal 4 digit FID is allowed" % fid) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34930?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4e949a08c1bfab413b82e958a64404390e58148f Gerrit-Change-Number: 34930 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

6 months

1
0
0 0

[M] Change in pysim[master]: runtime: refactor file selection methods select and select_file

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/34932?usp=email ) Change subject: runtime: refactor file selection methods select and select_file ...................................................................... runtime: refactor file selection methods select and select_file The implementation of the methods select and select_file of class RuntimeLchan is a bit complex. We access the card directly in several places which makes it difficult to track the state changes. We should clean this up so that we call self.rs.card.select_adf_by_aid/ self.scc.select_file from a single place only. This means that the method select uses the method select_file. This results in a much cleaner implementation. We also should take care that the important states that we track (selected_file, selected_adf, etc.) are updated by a single private method. Since the update always must happen after a select _select_post is a good place to do this. Related: OS#6210 Change-Id: I9ae213f3b078983f3e6d4c11db38fdbe504c84f2 --- M pySim/runtime.py 1 file changed, 89 insertions(+), 41 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/32/34932/1 diff --git a/pySim/runtime.py b/pySim/runtime.py index 8660724..feaa355 100644 --- a/pySim/runtime.py +++ b/pySim/runtime.py @@ -64,7 +64,7 @@ self.mf.add_file(f) # go back to MF before the next steps (addon probing might have changed DF) - self.card._scc.select_file('3F00') + self.lchan[0].select('3F00') # add application ADFs + MF-files from profile apps = self._match_applications() @@ -110,6 +110,12 @@ # probe for those applications for f in sorted(set(apps_profile) - set(apps_taken), key=str): try: + # we can not use the lchan provided methods select, or select_file + # since those method work on an already finished file model. At + # this point we are still in the initialization process, so it is + # no problem when we access the card directly without caring about + # updating other states. For normal selects at runtime, the caller + # must use the lchan provided methods select or select_file! data, sw = self.card.select_adf_by_aid(f.aid) if sw == "9000": print(" %s: %s" % (f.name, f.aid)) @@ -163,11 +169,14 @@ def __init__(self, lchan_nr: int, rs: RuntimeState): self.lchan_nr = lchan_nr self.rs = rs + self.scc = self.rs.card._scc.fork_lchan(lchan_nr) + + # File reference data self.selected_file = self.rs.mf self.selected_adf = None self.selected_file_fcp = None self.selected_file_fcp_hex = None - self.scc = self.rs.card._scc.fork_lchan(lchan_nr) + def add_lchan(self, lchan_nr: int) -> 'RuntimeLchan': """Add a new logical channel from the current logical channel. Just affects @@ -246,9 +255,17 @@ raise ValueError( "Cannot select unknown file by name %s, only hexadecimal 4 digit FID is allowed" % fid) + self._select_pre(cmd_app) + try: + # We access the card through the select_file method of the scc object. + # If we succeed, we know that the file exists and we may proceed with + # creating a new file at run time. In case the file does not exist, we + # just abort. The state on the card (selected file/application) wont't + # be changed, so we do not have to update any state in that case. (data, sw) = self.scc.select_file(fid) except SwMatchError as swm: + self._select_post(cmd_app) k = self.interpret_sw(swm.sw_actual) if not k: raise(swm) @@ -267,8 +284,8 @@ desc="elementary file, manually added at runtime") self.selected_file.add_files([f]) - self.selected_file = f - return select_resp, data + + self._select_post(cmd_app, f, data) def _select_pre(self, cmd_app): # unregister commands of old file @@ -276,7 +293,17 @@ for c in self.selected_file.shell_commands: cmd_app.unregister_command_set(c) - def _select_post(self, cmd_app): + def _select_post(self, cmd_app, file:CardFile = None, select_resp_data = None): + # we store some reference data (see above) about the currently selected file. + # This data must be updated after every select. + if file: + self.selected_file = file + if isinstance(file, CardADF): + self.selected_adf = file + if select_resp_data: + self.selected_file_fcp_hex = select_resp_data + self.selected_file_fcp = self.selected_file.decode_select_response(select_resp_data) + # register commands of new file if cmd_app and self.selected_file.shell_commands: for c in self.selected_file.shell_commands: @@ -293,22 +320,31 @@ inter_path = self.selected_file.build_select_path_to(file) if not inter_path: raise RuntimeError('Cannot determine path from %s to %s' % (self.selected_file, file)) - self._select_pre(cmd_app) - for p in inter_path: + # be sure the variables that we pass to _select_post contain valid values. + selected_file = self.selected_file + data = self.selected_file_fcp_hex + + for f in inter_path: try: - if isinstance(p, CardADF): - (data, sw) = self.rs.card.select_adf_by_aid(p.aid, scc=self.scc) - self.selected_adf = p + # We now directly accessing the card to perform the selection. This + # will change the state of the card, so we must take care to update + # the local state (lchan) as well. This is done in the method + # _select_port. It should be noted that the caller must always use + # the methods select_file or select. The caller must not access the + # card directly since this would lead into an incoherence of the + # card state and the state of the lchan. + if isinstance(f, CardADF): + (data, sw) = self.rs.card.select_adf_by_aid(f.aid, scc=self.scc) else: - (data, sw) = self.scc.select_file(p.fid) - self.selected_file = p + (data, sw) = self.scc.select_file(f.fid) + selected_file = f except SwMatchError as swm: - self._select_post(cmd_app) + self._select_post(cmd_app, selected_file, data) raise(swm) - self._select_post(cmd_app) + self._select_post(cmd_app, f, data) def select(self, name: str, cmd_app=None): """Select a file (EF, DF, ADF, MF, ...). @@ -317,9 +353,11 @@ name : Name of file to select cmd_app : Command Application State (for unregistering old file commands) """ + # if any intermediate step failes, we must be able to go back where we were + prev_sel_file = self.selected_file + # handling of entire paths with multiple directories/elements if '/' in name: - prev_sel_file = self.selected_file pathlist = name.split('/') # treat /DF.GSM/foo like MF/DF.GSM/foo if pathlist[0] == '': @@ -327,41 +365,29 @@ try: for p in pathlist: self.select(p, cmd_app) - return + return self.selected_file_fcp except Exception as e: - # if any intermediate step fails, go back to where we were self.select_file(prev_sel_file, cmd_app) raise e + # we are now in the directory where the target file is located + # so we can now refer to the get_selectables() method to get the + # file object and select it using select_file() sels = self.selected_file.get_selectables() if is_hex(name): name = name.lower() - self._select_pre(cmd_app) + try: + if name in sels: + f = sels[name] + self.select_file(sels[name], cmd_app) + else: + self.probe_file(name, cmd_app) + except Exception as e: + self.select_file(prev_sel_file, cmd_app) + raise e - if name in sels: - f = sels[name] - try: - if isinstance(f, CardADF): - (data, sw) = self.rs.card.select_adf_by_aid(f.aid, scc=self.scc) - else: - (data, sw) = self.scc.select_file(f.fid) - self.selected_file = f - except SwMatchError as swm: - k = self.interpret_sw(swm.sw_actual) - if not k: - raise(swm) - raise RuntimeError("%s: %s - %s" % (swm.sw_actual, k[0], k[1])) - select_resp = f.decode_select_response(data) - else: - (select_resp, data) = self.probe_file(name, cmd_app) - - # store the raw + decoded FCP for later reference - self.selected_file_fcp_hex = data - self.selected_file_fcp = select_resp - - self._select_post(cmd_app) - return select_resp + return self.selected_file_fcp def status(self): """Request STATUS (current selected file FCP) from card.""" -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34932?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9ae213f3b078983f3e6d4c11db38fdbe504c84f2 Gerrit-Change-Number: 34932 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

6 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: sccp: Introduce test TC_cr_timeout_cc_too_late

by osmith

Attention is currently required from: daniel, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34923?usp=email ) Change subject: sccp: Introduce test TC_cr_timeout_cc_too_late ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File library/SCCP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34923/comment/7c543cad_07d2… PS1, Line 128: callingPAddress := ?, //FIXME: tr_Addr(calling), do you want to keep the fixme? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34923?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If4b53565f1fa19894ca24fa71e02ae7b1941411e Gerrit-Change-Number: 34923 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Oct 2023 16:04:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

6 months

1
0
0 0

[M] Change in ...osmo-epdg[master]: s2b: Implement GTPv2C DeleteBearerReq

by pespin

Attention is currently required from: fixeria, lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34896?usp=email ) Change subject: s2b: Implement GTPv2C DeleteBearerReq ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I plan to merge this soon if there's no review. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34896?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: I1e5af1ead17385d2e494f4c90ffe6455aee850da Gerrit-Change-Number: 34896 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 31 Oct 2023 15:52:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

6 months

1
0
0 0

[M] Change in libosmo-sccp[master]: sccp_scoc: Fix remote PC not assigned preventing RSLD to be sent in s...

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34921?usp=email ) Change subject: sccp_scoc: Fix remote PC not assigned preventing RSLD to be sent in st WAIT_CONN_CONF ...................................................................... sccp_scoc: Fix remote PC not assigned preventing RSLD to be sent in st WAIT_CONN_CONF Scenario: RUA Connect triggers SCCP CR towards peer, and we move to CONN_PEND_OUT state where we expect to receive CC. However, if some timer (like X31) times out before we receive CC (eg because CC takes a long time to come), we end up in state WAIT_CONN_CONF. In that state, according to Figure C.2/Q.714 (sheet 2 of 7), among other possibilite we wait for CC, and if it arrives, we send an RLSD to the peer to inform him that we released the conn, and wait for the peer to ack the RLSD, then release all state. Given the scenario above, scoc_fsm_wait_conn_conf() was not assigning the received OPC from the CC to the conn->remote_pc (unlike scoc_fsm_conn_pend_out() which does it properly). As a result, when trying to send teh RLSD it would fail and never transmit RLSD, taking then a long time to release through T(rel) (10-20 seconds), and probably longer in the peer (T(iar) or similar?). Rua Connect triggers tx of SCCP CC: Received SCCP User Primitive (N-CONNECT.request) XUA_AS(as-clnt-msc-0)[0x55f11c7df980]{AS_ACTIVE}: Received Event AS-TRANSFER.req //Tx CC SCCP-SCOC(929)[0x55f11c909c90]{IDLE}: State change to CONN_PEND_OUT (no timeout) ... X31 timeout triggers state change: map_sccp(...-SCCP-929)[0x55f11c909820]{wait_cc}: Timeout of X31 SCCP-SCOC(929)[0x55f11c909c90]{CONN_PEND_OUT}: Received Event N-DISCONNECT.req SCCP-SCOC(929)[0x55f11c909c90]{CONN_PEND_OUT}: State change to WAIT_CONN_CONF (no timeout) ... CC arrives, but conn_remote_pc is not properly assigned and tx of RLSD fails: SCCP-SCOC(929)[0x55f11c909c90]{WAIT_CONN_CONF}: Received Event RCOC-CONNECT_CONFIRM.ind MTP-TRANSFER.req from SCCP without DPC?!? called=RI=0 // PROBLEM HERE!!!! SCCP-SCOC(929)[0x55f11c909c90]{WAIT_CONN_CONF}: State change to DISCONN_PEND (no timeout) ... SCCP-SCOC(929)[0x55f11c909c90]{DISCONN_PEND}: Received Event T(rel)_expired Related: SYS#6616 Change-Id: I9f9f78c92dd95f38af7b03037e60a1c993d7e5b0 --- M src/sccp_scoc.c 1 file changed, 52 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved daniel: Looks good to me, but someone else must approve laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/sccp_scoc.c b/src/sccp_scoc.c index e273d17..0e1eb34 100644 --- a/src/sccp_scoc.c +++ b/src/sccp_scoc.c @@ -1160,6 +1160,13 @@ conn_stop_connect_timer(conn); /* associate rem ref to conn */ conn->remote_ref = xua_msg_get_u32(xua, SUA_IEI_SRC_REF); + /* 3.1.4.2 The node sending the CC message (identified + * by the parameter OPC contained in the + * MTP-TRANSFER.indication primitive which conveyed the + * CC message [plus the MTP-SAP instance]) is associated + * with the connection section. */ + conn->remote_pc = xua->mtp.opc; + /* released to SCRC */ xua_gen_relre_and_send(conn, conn->release_cause, NULL); /* start rel timer */ -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34921?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I9f9f78c92dd95f38af7b03037e60a1c993d7e5b0 Gerrit-Change-Number: 34921 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

6 months

1
0
0 0

[M] Change in libosmo-sccp[master]: sccp_scoc: Fix remote PC not assigned preventing RSLD to be sent in s...

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34921?usp=email ) Change subject: sccp_scoc: Fix remote PC not assigned preventing RSLD to be sent in st WAIT_CONN_CONF ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34921?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I9f9f78c92dd95f38af7b03037e60a1c993d7e5b0 Gerrit-Change-Number: 34921 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Oct 2023 15:51:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

6 months

1
0
0 0

[M] Change in libosmocore[master]: gsmtap_util: Use Osmo IO instead of Osmo write queues

by daniel

Attention is currently required from: arehbein, laforge, pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34743?usp=email ) Change subject: gsmtap_util: Use Osmo IO instead of Osmo write queues ...................................................................... Patch Set 8: (1 comment) File src/core/gsmtap_util.c: https://gerrit.osmocom.org/c/libosmocore/+/34743/comment/ea79b08c_33cae098 PS5, Line 478: osmo_iofd_setup(gti, gti->sink_fd, "gsmtap_inst.out", OSMO_IO_FD_MODE_READ_WRITE, &gsmtap_sink_ops, NULL); > @dwillmann@sysmocom. […] This would have also happened if the old code used write_queues, maybe that's the reason they didn't? In any case, I would suggest we temporarily disable the log target (by setting loglevel to LOGL_FATAL + 1) while we're in _gsmtap_raw_output(). That has the benefit that this log message would appear in other log targets such as stderr. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34743?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iadbbef74e3add7001d84dd6b68f51eac293e44d0 Gerrit-Change-Number: 34743 Gerrit-PatchSet: 8 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Oct 2023 15:49:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: comment

6 months

1
0
0 0

[S] Change in osmo-ci[master]: OBS: add workaround for limesuite 23.10 release

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/34926?usp=email ) Change subject: OBS: add workaround for limesuite 23.10 release ...................................................................... OBS: add workaround for limesuite 23.10 release The previous workaround for building on debian 12 is not needed anymore, as the related patch has been merged. Replace it with a new workaround needed for building the limesuite 23.10 release. Change-Id: I569642ebb13ac3eb3e241642e299be0a0a2ab15d --- M scripts/obs/lib/srcpkg.py 1 file changed, 19 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/scripts/obs/lib/srcpkg.py b/scripts/obs/lib/srcpkg.py index 9476d82..05a705f 100644 --- a/scripts/obs/lib/srcpkg.py +++ b/scripts/obs/lib/srcpkg.py @@ -124,10 +124,12 @@ def prepare_project_limesuite(): - """ Fix Debian 12 compat, until this is merged and in the next release: - https://github.com/myriadrf/LimeSuite/pull/381 """ - lib.run_cmd(["sed", "s/libwxgtk3.0-gtk3-dev,$/libwxgtk3.0-gtk3-dev | libwxgtk3.2-dev,/g", - "-i", "debian/control"], cwd=lib.git.get_repo_path("limesuite")) + """ Fix bug in 23.10: https://github.com/myriadrf/LimeSuite/pull/386 """ + lib.run_cmd(["mv", "-v", + "liblimesuite22.09-1.install", + "liblimesuite23.10-1.install"], + cwd=f"{lib.git.get_repo_path('limesuite')}/debian", + check=False) def run_generate_build_dep(project): -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34926?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I569642ebb13ac3eb3e241642e299be0a0a2ab15d Gerrit-Change-Number: 34926 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

6 months

1
0
0 0

[M] Change in libosmo-sccp[master]: sccp_scoc: Fix remote PC not assigned preventing RSLD to be sent in s...

by daniel

Attention is currently required from: neels, pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34921?usp=email ) Change subject: sccp_scoc: Fix remote PC not assigned preventing RSLD to be sent in st WAIT_CONN_CONF ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34921?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I9f9f78c92dd95f38af7b03037e60a1c993d7e5b0 Gerrit-Change-Number: 34921 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Oct 2023 15:45:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

6 months

1
0
0 0

[S] Change in osmo-ci[master]: OBS: add workaround for limesuite 23.10 release

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/34926?usp=email ) Change subject: OBS: add workaround for limesuite 23.10 release ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34926?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I569642ebb13ac3eb3e241642e299be0a0a2ab15d Gerrit-Change-Number: 34926 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Oct 2023 15:42:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

6 months

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: Bump version: 0.2.0

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34928?usp=email ) Change subject: Bump version: 0.2.0 ...................................................................... Bump version: 0.2.0 Change-Id: I3a175b0c7585268d748b007ab89110987b7e04cf --- M debian/changelog 1 file changed, 45 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified daniel: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/debian/changelog b/debian/changelog index 488f3d7..dfc8fb6 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,39 @@ +osmo-diameter2gsup (0.2.0) unstable; urgency=medium + + [ Alexander Couzens ] + * contrib/generate_build_dep.sh: remove erlang bytecode from checkouts + * docs: add a simple example to use configuration file + + [ Oliver Smith ] + * debian: set compat level to 10 + * systemd: depend on networking-online.target + + [ Alexander Couzens ] + * Use GSUP APN as Service-Selection field + + [ Pau Espin Pedrol ] + * rebar3.lock: Update epcap dep to v1.1.1 to fix compilation error + * README.md: Document how to run escript with config file + + [ Oliver Smith ] + * README.md: update + + [ Pau Espin Pedrol ] + * cosmetic: Fix typo in comment + * gsup: Log connect failures + * gsup: Attempt reconnecting if connect fails + * Add GMM error cause present in osmo-hlr's gsm48_gmm_cause_vty_names + * Translate GSUP Auth Info Answer error Cause in Diamater AIA + + [ Alexander Couzens ] + * server_cb: use a define for the VENDOR_3GPP code + * gsup: convert all unknown causes into diameter UNABLE_TO_COMPLY + + [ Oliver Smith ] + * debian/rules: extract build_dep.tar.gz first + + -- Oliver Smith <osmith(a)sysmocom.de> Tue, 31 Oct 2023 12:59:24 +0100 + osmo-diameter2gsup (0.1.2) unstable; urgency=medium [ Matt Johnson ] -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34928?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I3a175b0c7585268d748b007ab89110987b7e04cf Gerrit-Change-Number: 34928 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

6 months

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: Bump version: 0.2.0

by daniel

Attention is currently required from: lynxis lazus, osmith. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34928?usp=email ) Change subject: Bump version: 0.2.0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34928?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I3a175b0c7585268d748b007ab89110987b7e04cf Gerrit-Change-Number: 34928 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 31 Oct 2023 14:22:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

6 months

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: GGSN_Tests: Don't expect Used-Service-Unit AVP in Gy CCR INITIAL

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34929?usp=email ) Change subject: GGSN_Tests: Don't expect Used-Service-Unit AVP in Gy CCR INITIAL ...................................................................... GGSN_Tests: Don't expect Used-Service-Unit AVP in Gy CCR INITIAL open5gs 125740727e558c7604897eda711d4d40f2906239 changed behavior and is no longer sending the Used-Service-Unit AVP during INITIAL_REQUEST, which makes sense since those values should be only initialized and spec seems to more or less expect it that way, though receiving it at INITIAL time should be accepted too AFAICT. Related: https://github.com/open5gs/open5gs/pull/2721 Change-Id: Ia16a86ff10089974e0b5d49e594467fcd437ce7e --- M ggsn_tests/GGSN_Tests.ttcn M pgw/PGW_Tests.ttcn 2 files changed, 16 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/29/34929/1 diff --git a/ggsn_tests/GGSN_Tests.ttcn b/ggsn_tests/GGSN_Tests.ttcn index 5b1f7a1..d6a0403 100644 --- a/ggsn_tests/GGSN_Tests.ttcn +++ b/ggsn_tests/GGSN_Tests.ttcn @@ -534,7 +534,6 @@ tr_AVP_MultipleServicesIndicator, tr_AVP_Multiple_Services_Credit_Control(content := superset( tr_AVP_Requested_Service_Unit, - tr_AVP_Used_Service_Unit, tr_AVP_PCC_3GPP_QoS_Information, tr_AVP_GI_3GPP_RatType(rat_type) )), diff --git a/pgw/PGW_Tests.ttcn b/pgw/PGW_Tests.ttcn index 182147d..bafabdf 100644 --- a/pgw/PGW_Tests.ttcn +++ b/pgw/PGW_Tests.ttcn @@ -363,7 +363,6 @@ tr_AVP_MultipleServicesIndicator, tr_AVP_Multiple_Services_Credit_Control(content := superset( tr_AVP_Requested_Service_Unit, - tr_AVP_Used_Service_Unit, tr_AVP_PCC_3GPP_QoS_Information, tr_AVP_GI_3GPP_RatType(rat_type) )), -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34929?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia16a86ff10089974e0b5d49e594467fcd437ce7e Gerrit-Change-Number: 34929 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

6 months

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: Bump version: 0.2.0

by pespin

Attention is currently required from: daniel, lynxis lazus, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34928?usp=email ) Change subject: Bump version: 0.2.0 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34928?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I3a175b0c7585268d748b007ab89110987b7e04cf Gerrit-Change-Number: 34928 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 31 Oct 2023 13:39:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

6 months

1
0
0 0

[S] Change in osmo-hnbgw[master]: Depend on libosmo-sccp package

by pespin

Attention is currently required from: laforge, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/34927?usp=email ) Change subject: Depend on libosmo-sccp package ...................................................................... Patch Set 2: Code-Review-1 (1 comment) Patchset: PS2: > I think the proper solution would be to migrate (copy?) the values to libosmo-sigtran. […] I see other osmocom projects depending on it liek osmo-msc and osmo-smlc iirc, but ok, I will mark this one as WIP. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/34927?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Idf88da2d1aa126acd1c784ff096ab79349364f85 Gerrit-Change-Number: 34927 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 31 Oct 2023 13:39:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

6 months

1
0
0 0

[S] Change in osmo-hnbgw[master]: Increase default X31 val from 5 to 15 seconds

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/34922?usp=email ) Change subject: Increase default X31 val from 5 to 15 seconds ...................................................................... Increase default X31 val from 5 to 15 seconds It was spotted that in some deploys with satellite links and heavy load, the roundtrip times for CR and CC can go slightly over 12 seconds, so better increase the default value to 15 seconds to be on a safer place and avoid operation problems with default configuration. Related: SYS#6602, SYS#6616 Change-Id: I24225cfc0addf326c239ec658a27b93b83a3e751 --- M src/osmo-hnbgw/tdefs.c 1 file changed, 16 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-hnbgw/tdefs.c b/src/osmo-hnbgw/tdefs.c index 601f704..cae9405 100644 --- a/src/osmo-hnbgw/tdefs.c +++ b/src/osmo-hnbgw/tdefs.c @@ -34,7 +34,7 @@ struct osmo_tdef hnbgw_T_defs[] = { {.T = 3113, .default_val = 15, .desc = "Time to keep Paging record, for CN pools with more than one link" }, {.T = 4, .default_val = 5, .desc = "Timeout to receive RANAP RESET ACKNOWLEDGE from an MSC/SGSN" }, - {.T = -31, .default_val = 5, .desc = "Timeout for discarding a partially released context map (RUA <-> SCCP)" }, + {.T = -31, .default_val = 15, .desc = "Timeout for discarding a partially released context map (RUA <-> SCCP)" }, {.T = -1002, .default_val = 10, .desc = "Timeout for the HNB to respond to PS RAB Assignment Request" }, { } }; -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/34922?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I24225cfc0addf326c239ec658a27b93b83a3e751 Gerrit-Change-Number: 34922 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

6 months

1
0
0 0

[S] Change in ...osmo_dia2gsup[master]: Bump version: 0.2.0

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34928?usp=email ) Change subject: Bump version: 0.2.0 ...................................................................... Bump version: 0.2.0 Change-Id: I3a175b0c7585268d748b007ab89110987b7e04cf --- M debian/changelog 1 file changed, 45 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/28/34928/1 diff --git a/debian/changelog b/debian/changelog index 488f3d7..dfc8fb6 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,39 @@ +osmo-diameter2gsup (0.2.0) unstable; urgency=medium + + [ Alexander Couzens ] + * contrib/generate_build_dep.sh: remove erlang bytecode from checkouts + * docs: add a simple example to use configuration file + + [ Oliver Smith ] + * debian: set compat level to 10 + * systemd: depend on networking-online.target + + [ Alexander Couzens ] + * Use GSUP APN as Service-Selection field + + [ Pau Espin Pedrol ] + * rebar3.lock: Update epcap dep to v1.1.1 to fix compilation error + * README.md: Document how to run escript with config file + + [ Oliver Smith ] + * README.md: update + + [ Pau Espin Pedrol ] + * cosmetic: Fix typo in comment + * gsup: Log connect failures + * gsup: Attempt reconnecting if connect fails + * Add GMM error cause present in osmo-hlr's gsm48_gmm_cause_vty_names + * Translate GSUP Auth Info Answer error Cause in Diamater AIA + + [ Alexander Couzens ] + * server_cb: use a define for the VENDOR_3GPP code + * gsup: convert all unknown causes into diameter UNABLE_TO_COMPLY + + [ Oliver Smith ] + * debian/rules: extract build_dep.tar.gz first + + -- Oliver Smith <osmith(a)sysmocom.de> Tue, 31 Oct 2023 12:59:24 +0100 + osmo-diameter2gsup (0.1.2) unstable; urgency=medium [ Matt Johnson ] -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/34928?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I3a175b0c7585268d748b007ab89110987b7e04cf Gerrit-Change-Number: 34928 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

6 months

1
0
0 0

[S] Change in osmo-hnbgw[master]: Depend on libosmo-sccp package

by laforge

Attention is currently required from: neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/34927?usp=email ) Change subject: Depend on libosmo-sccp package ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: I think the proper solution would be to migrate (copy?) the values to libosmo-sigtran. libosmo-sccp is super legacy and should be abandoned completely as there are no active users for probably close to 10 years by now. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/34927?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Idf88da2d1aa126acd1c784ff096ab79349364f85 Gerrit-Change-Number: 34927 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Oct 2023 11:56:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

6 months

1
0
0 0

[S] Change in osmo-hnbgw[master]: Use proper SCCP release cause enum value instead of hardcoded value

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/34925?usp=email ) Change subject: Use proper SCCP release cause enum value instead of hardcoded value ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/34925?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: If44e7c4a3166822d7732b7af4c136b8f97898dc0 Gerrit-Change-Number: 34925 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Oct 2023 11:55:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

6 months

1
0
0 0

[S] Change in osmo-hnbgw[master]: Increase default X31 val from 5 to 15 seconds

by laforge

Attention is currently required from: daniel, neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/34922?usp=email ) Change subject: Increase default X31 val from 5 to 15 seconds ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/34922?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I24225cfc0addf326c239ec658a27b93b83a3e751 Gerrit-Change-Number: 34922 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Oct 2023 11:55:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

6 months

1
0
0 0

[S] Change in osmo-hnbgw[master]: Increase default X31 val from 5 to 15 seconds

by pespin

Attention is currently required from: daniel, laforge, neels. Hello Jenkins Builder, daniel, laforge, neels, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/34922?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: Increase default X31 val from 5 to 15 seconds ...................................................................... Increase default X31 val from 5 to 15 seconds It was spotted that in some deploys with satellite links and heavy load, the roundtrip times for CR and CC can go slightly over 12 seconds, so better increase the default value to 15 seconds to be on a safer place and avoid operation problems with default configuration. Related: SYS#6602, SYS#6616 Change-Id: I24225cfc0addf326c239ec658a27b93b83a3e751 --- M src/osmo-hnbgw/tdefs.c 1 file changed, 16 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/22/34922/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/34922?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I24225cfc0addf326c239ec658a27b93b83a3e751 Gerrit-Change-Number: 34922 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newpatchset

6 months

1
0
0 0

[S] Change in osmo-hnbgw[master]: Use proper SCCP release cause enum value instead of hardcoded value

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/34925?usp=email ) Change subject: Use proper SCCP release cause enum value instead of hardcoded value ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/34925?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: If44e7c4a3166822d7732b7af4c136b8f97898dc0 Gerrit-Change-Number: 34925 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Oct 2023 11:24:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

6 months

1
0
0 0

[S] Change in osmo-hnbgw[master]: Depend on libosmo-sccp package

by osmith

Attention is currently required from: laforge, neels, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/34927?usp=email ) Change subject: Depend on libosmo-sccp package ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/34927?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Idf88da2d1aa126acd1c784ff096ab79349364f85 Gerrit-Change-Number: 34927 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Oct 2023 11:23:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

6 months

1
0
0 0

[S] Change in osmo-hnbgw[master]: Depend on libosmo-sccp package

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/34927?usp=email ) Change subject: Depend on libosmo-sccp package ...................................................................... Depend on libosmo-sccp package This allows using definitions available in osmocom/sccp/ namespace. Change-Id: Idf88da2d1aa126acd1c784ff096ab79349364f85 --- M configure.ac M contrib/osmo-hnbgw.spec.in M debian/control 3 files changed, 14 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/27/34927/1 diff --git a/configure.ac b/configure.ac index bb8d29e..0cdb417 100644 --- a/configure.ac +++ b/configure.ac @@ -54,6 +54,7 @@ PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.9.0) PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.9.0) PKG_CHECK_MODULES(LIBOSMONETIF, libosmo-netif >= 1.4.0) +PKG_CHECK_MODULES(LIBOSMOSCCP, libosmo-sccp >= 1.8.0) PKG_CHECK_MODULES(LIBOSMOSIGTRAN, libosmo-sigtran >= 1.8.0) PKG_CHECK_MODULES(LIBOSMORUA, libosmo-rua >= 1.5.0) PKG_CHECK_MODULES(LIBOSMORANAP, libosmo-ranap >= 1.5.0) diff --git a/contrib/osmo-hnbgw.spec.in b/contrib/osmo-hnbgw.spec.in index 02247a3..18a3ec6 100644 --- a/contrib/osmo-hnbgw.spec.in +++ b/contrib/osmo-hnbgw.spec.in @@ -34,6 +34,7 @@ BuildRequires: pkgconfig(libcrypto) >= 0.9.5 BuildRequires: pkgconfig(libosmo-mgcp-client) >= 1.12.0 BuildRequires: pkgconfig(libosmo-netif) >= 1.4.0 +BuildRequires: pkgconfig(libosmo-sccp) >= 1.8.0 BuildRequires: pkgconfig(libosmo-sigtran) >= 1.8.0 BuildRequires: pkgconfig(libosmoabis) >= 1.5.0 BuildRequires: pkgconfig(libosmotrau) >= 1.5.0 diff --git a/debian/control b/debian/control index 77737b5..03d0a64 100644 --- a/debian/control +++ b/debian/control @@ -14,6 +14,7 @@ libasn1c-dev (>= 0.9.30), libsctp-dev, libosmocore-dev (>= 1.9.0), + libosmo-sccp-dev (>= 1.8.0), libosmo-sigtran-dev (>= 1.8.0), libosmo-abis-dev (>= 1.5.0), libosmo-netif-dev (>= 1.4.0), -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/34927?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Idf88da2d1aa126acd1c784ff096ab79349364f85 Gerrit-Change-Number: 34927 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

6 months

1
0
0 0

[S] Change in osmo-ci[master]: OBS: add workaround for limesuite 23.10 release

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/34926?usp=email ) Change subject: OBS: add workaround for limesuite 23.10 release ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34926?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I569642ebb13ac3eb3e241642e299be0a0a2ab15d Gerrit-Change-Number: 34926 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Oct 2023 11:11:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

6 months

1
0
0 0

[S] Change in osmo-ci[master]: OBS: add workaround for limesuite 23.10 release

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/34926?usp=email ) Change subject: OBS: add workaround for limesuite 23.10 release ...................................................................... OBS: add workaround for limesuite 23.10 release The previous workaround for building on debian 12 is not needed anymore, as the related patch has been merged. Replace it with a new workaround needed for building the limesuite 23.10 release. Change-Id: I569642ebb13ac3eb3e241642e299be0a0a2ab15d --- M scripts/obs/lib/srcpkg.py 1 file changed, 19 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/26/34926/1 diff --git a/scripts/obs/lib/srcpkg.py b/scripts/obs/lib/srcpkg.py index 9476d82..05a705f 100644 --- a/scripts/obs/lib/srcpkg.py +++ b/scripts/obs/lib/srcpkg.py @@ -124,10 +124,12 @@ def prepare_project_limesuite(): - """ Fix Debian 12 compat, until this is merged and in the next release: - https://github.com/myriadrf/LimeSuite/pull/381 """ - lib.run_cmd(["sed", "s/libwxgtk3.0-gtk3-dev,$/libwxgtk3.0-gtk3-dev | libwxgtk3.2-dev,/g", - "-i", "debian/control"], cwd=lib.git.get_repo_path("limesuite")) + """ Fix bug in 23.10: https://github.com/myriadrf/LimeSuite/pull/386 """ + lib.run_cmd(["mv", "-v", + "liblimesuite22.09-1.install", + "liblimesuite23.10-1.install"], + cwd=f"{lib.git.get_repo_path('limesuite')}/debian", + check=False) def run_generate_build_dep(project): -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34926?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I569642ebb13ac3eb3e241642e299be0a0a2ab15d Gerrit-Change-Number: 34926 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

6 months

1
0
0 0

[S] Change in pysim[master]: transport: print device path/number on initialization failure

by dexter

dexter has abandoned this change. ( https://gerrit.osmocom.org/c/pysim/+/34693?usp=email ) Change subject: transport: print device path/number on initialization failure ...................................................................... Abandoned We have now solved this differently -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34693?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3f5387508ccc2aa349adc7aec3d04d8fc977690b Gerrit-Change-Number: 34693 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: abandon

6 months

1
0
0 0

[S] Change in libosmocore[master]: Debian: ignore .deb build byproducts

by laforge

laforge has abandoned this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29680?usp=email ) Change subject: Debian: ignore .deb build byproducts ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29680?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Idbd92096c9058eccd12e33453713815c7baf0792 Gerrit-Change-Number: 29680 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: abandon

6 months

1
0
0 0

[M] Change in osmocom-bb[master]: mobile: add SI10 receive stub

by laforge

Attention is currently required from: msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31665?usp=email ) Change subject: mobile: add SI10 receive stub ...................................................................... Patch Set 4: (1 comment) This change is ready for review. Patchset: PS4: I guess this change can be abendoned now, as we have proper SI10 support in master? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31665?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia2672636251be1894c50b34d67ea1e6295f97d97 Gerrit-Change-Number: 31665 Gerrit-PatchSet: 4 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Oct 2023 10:00:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

6 months

1
0
0 0

[M] Change in osmo-bsc[master]: SI10: generate rest-octets

by laforge

Attention is currently required from: msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31047?usp=email ) Change subject: SI10: generate rest-octets ...................................................................... Patch Set 20: (1 comment) This change is ready for review. Patchset: PS20: I guess this change can be abendoned now, as we have proper SI10 support in master? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31047?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6b39f193d5940a629505bab0c0f1c4d192943fd8 Gerrit-Change-Number: 31047 Gerrit-PatchSet: 20 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Oct 2023 09:59:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

6 months

1
0
0 0

[S] Change in osmo-bsc[master]: SI10: add to SACCH filling

by laforge

Attention is currently required from: msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32631?usp=email ) Change subject: SI10: add to SACCH filling ...................................................................... Patch Set 2: (1 comment) This change is ready for review. Patchset: PS2: I guess this change can be abendoned now, as we have proper SI10 support in master? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32631?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5f5bd8887682ff09cf11cc7a3dae5048f50e3fd0 Gerrit-Change-Number: 32631 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: jolly <andreas(a)eversberg.eu> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Oct 2023 09:59:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

6 months

1
0
0 0

[M] Change in libosmocore[master]: gsmtap_util: Use Osmo IO instead of Osmo write queues

by arehbein

Attention is currently required from: daniel, laforge, pespin. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34743?usp=email ) Change subject: gsmtap_util: Use Osmo IO instead of Osmo write queues ...................................................................... Patch Set 8: (1 comment) File src/core/gsmtap_util.c: https://gerrit.osmocom.org/c/libosmocore/+/34743/comment/8a7aef64_440b964c PS5, Line 478: osmo_iofd_setup(gti, gti->sink_fd, "gsmtap_inst.out", OSMO_IO_FD_MODE_READ_WRITE, &gsmtap_sink_ops, NULL); > @dwillmann@sysmocom.de just tried changing the VTY command... […] @dwillmann@sysmocom.de there's a bug in Osmo IO, basically if gsmtap logging is used, then if the queue overflows, we get an infinite call loop ``` #3729 0x00007ffff7e0e0f4 in _gsmtap_raw_output (target=0x555555617c60, subsys=31, level=7, file=0x7ffff7e45249 "osmo_io.c", line=377, cont=0, format=0x7ffff7e453d8 "iofd(%s)enqueueing message failed (%d). Rejecting msgb\n", ap=0x7fffff873e20) at logging_gsmtap.c:117 #3730 0x00007ffff7e0c335 in osmo_vlogp (subsys=31, level=7, file=0x7ffff7e45249 "osmo_io.c", line=377, cont=0, format=0x7ffff7e453d8 "iofd(%s)enqueueing message failed (%d). Rejecting msgb\n", ap=0x7fffff873e98) at logging.c:728 #3731 0x00007ffff7e0c52b in logp2 (subsys=-29, level=7, file=0x7ffff7e45249 "osmo_io.c", line=377, cont=0, format=0x7ffff7e453d8 "iofd(%s)enqueueing message failed (%d). Rejecting msgb\n") at logging.c:766 #3732 0x00007ffff7e1643e in osmo_iofd_write_msgb (iofd=0x555555635910, msg=0x555558bf1ec0) at osmo_io.c:377 ``` (see backtrace numbers :)) because of the LOGPIO call in case of overflow. Not sure if this was also a bug when Osmo write queues were used (if LOGPIO was called to log a full-queue error, then yes...) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34743?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iadbbef74e3add7001d84dd6b68f51eac293e44d0 Gerrit-Change-Number: 34743 Gerrit-PatchSet: 8 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Oct 2023 09:56:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: comment

6 months

1
0
0 0

[S] Change in libosmo-sccp[master]: cosmetic: add spec reference

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29158?usp=email ) Change subject: cosmetic: add spec reference ...................................................................... cosmetic: add spec reference Related: OS#5579 Change-Id: I4d6bf9d0e681db779770b2fb815f7f9c5e608b15 --- M src/sua.c 1 file changed, 16 insertions(+), 4 deletions(-) Approvals: neels: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/sua.c b/src/sua.c index de69ab3..9e281e0 100644 --- a/src/sua.c +++ b/src/sua.c @@ -180,13 +180,15 @@ SUA_IEI_ROUTE_CTX, SUA_IEI_PROTO_CLASS, SUA_IEI_SRC_REF, SUA_IEI_DEST_REF, 0 }; + +/* ITU-T Rec Q.713 */ static const struct value_string sua_co_msgt_names[] = { { SUA_CO_CODT, "CODT" }, { SUA_CO_CODA, "CODA" }, - { SUA_CO_CORE, "CORE" }, - { SUA_CO_COAK, "COAK" }, - { SUA_CO_COREF, "COREF" }, - { SUA_CO_RELRE, "RELRE" }, + { SUA_CO_CORE, "CORE" }, /* §4.2 Connection request (CR) */ + { SUA_CO_COAK, "COAK" }, /* §4.3 Connection confirm (CC) */ + { SUA_CO_COREF, "COREF" }, /* §4.4 Connection refused (CREF) */ + { SUA_CO_RELRE, "RELRE" }, /* §4.5 Released (RLSD) */ { SUA_CO_RELCO, "RELCO" }, { SUA_CO_RESRE, "RESRE" }, { SUA_CO_RESCO, "RESCO" }, -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29158?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I4d6bf9d0e681db779770b2fb815f7f9c5e608b15 Gerrit-Change-Number: 29158 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

6 months

1
0
0 0

[S] Change in libosmo-sccp[master]: cosmetic: add spec reference

by laforge

Attention is currently required from: msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29158?usp=email ) Change subject: cosmetic: add spec reference ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/29158?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I4d6bf9d0e681db779770b2fb815f7f9c5e608b15 Gerrit-Change-Number: 29158 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Oct 2023 09:37:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

6 months

1
0
0 0

[S] Change in libosmo-sccp[master]: sccp_demo_user: Allow initiating conns from vty in server mode

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34924?usp=email ) Change subject: sccp_demo_user: Allow initiating conns from vty in server mode ...................................................................... sccp_demo_user: Allow initiating conns from vty in server mode This allows starting SCCP conns from within sccp_demo_user, which in turn allows testing more scenarios in osmo-ttcn3-hacks.git SCCP_RAW_Tests testsuite. Related: SYS#6616 Change-Id: I7d5b3534c496dca8a3f3e66025af554bbe860c04 --- M examples/sccp_demo_user.c 1 file changed, 15 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/examples/sccp_demo_user.c b/examples/sccp_demo_user.c index a88dd69..d67bd27 100644 --- a/examples/sccp_demo_user.c +++ b/examples/sccp_demo_user.c @@ -307,6 +307,7 @@ exit(1); } sccp_test_server_init(g_sccp); + sccp_test_user_vty_install(g_sccp, OSMO_SCCP_SSN_BSSAP); } g_calling_addr.pc = local_pc; g_called_addr.pc = remote_pc; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34924?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I7d5b3534c496dca8a3f3e66025af554bbe860c04 Gerrit-Change-Number: 34924 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

6 months

1
0
0 0

[S] Change in libosmo-sccp[master]: sccp_demo_user: Allow initiating conns from vty in server mode

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34924?usp=email ) Change subject: sccp_demo_user: Allow initiating conns from vty in server mode ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34924?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I7d5b3534c496dca8a3f3e66025af554bbe860c04 Gerrit-Change-Number: 34924 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Oct 2023 09:32:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

6 months

1
0
0 0

[M] Change in libosmo-sccp[master]: sccp_scoc: Fix remote PC not assigned preventing RSLD to be sent in s...

by laforge

Attention is currently required from: daniel, neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34921?usp=email ) Change subject: sccp_scoc: Fix remote PC not assigned preventing RSLD to be sent in st WAIT_CONN_CONF ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34921?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I9f9f78c92dd95f38af7b03037e60a1c993d7e5b0 Gerrit-Change-Number: 34921 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Oct 2023 09:32:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

6 months

1
0
0 0

[M] Change in libosmocore[master]: gsmtap_util: Use Osmo IO instead of Osmo write queues

by arehbein

Attention is currently required from: daniel, laforge, pespin. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34743?usp=email ) Change subject: gsmtap_util: Use Osmo IO instead of Osmo write queues ...................................................................... Patch Set 8: (1 comment) File src/core/gsmtap_util.c: https://gerrit.osmocom.org/c/libosmocore/+/34743/comment/2c898517_6a7f6f4e PS5, Line 478: osmo_iofd_setup(gti, gti->sink_fd, "gsmtap_inst.out", OSMO_IO_FD_MODE_READ_WRITE, &gsmtap_sink_ops, NULL); > @dwillmann@sysmocom.de just tried changing the VTY command... […] (currently investigating...) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34743?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iadbbef74e3add7001d84dd6b68f51eac293e44d0 Gerrit-Change-Number: 34743 Gerrit-PatchSet: 8 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Oct 2023 09:17:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: comment

6 months

1
0
0 0

[M] Change in libosmocore[master]: gsmtap_util: Use Osmo IO instead of Osmo write queues

by arehbein

Attention is currently required from: daniel, laforge, pespin. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34743?usp=email ) Change subject: gsmtap_util: Use Osmo IO instead of Osmo write queues ...................................................................... Patch Set 8: (1 comment) File src/core/gsmtap_util.c: https://gerrit.osmocom.org/c/libosmocore/+/34743/comment/bba3c6b5_64b01e61 PS5, Line 478: osmo_iofd_setup(gti, gti->sink_fd, "gsmtap_inst.out", OSMO_IO_FD_MODE_READ_WRITE, &gsmtap_sink_ops, NULL); > > In that case I guess we want to limit somehow the read buffer queue in the kernel to the minimum ( […] @dwillmann@sysmocom.de just tried changing the VTY command... makes the TTCN3 mgw test fail (-ENOSPC being returned, I suppose because the queue length of 64 isn't enough for MGCP_Test.TC_crcx_wildcarded_exhaust) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34743?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iadbbef74e3add7001d84dd6b68f51eac293e44d0 Gerrit-Change-Number: 34743 Gerrit-PatchSet: 8 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Oct 2023 08:56:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: comment

6 months

1
0
0 0

[M] Change in osmo-msc[master]: manuals: add section about the SGs interface.

by fixeria

Attention is currently required from: dexter, laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/34870?usp=email ) Change subject: manuals: add section about the SGs interface. ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/34870?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ic7c17511ee19cb7f6d5069b27beb661ecb4b0be8 Gerrit-Change-Number: 34870 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Oct 2023 05:23:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

6 months

1
0
0 0

[S] Change in osmo-hnbgw[master]: Use proper SCCP release cause enum value instead of hardcoded value

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/34925?usp=email ) Change subject: Use proper SCCP release cause enum value instead of hardcoded value ...................................................................... Use proper SCCP release cause enum value instead of hardcoded value Change-Id: If44e7c4a3166822d7732b7af4c136b8f97898dc0 --- M src/osmo-hnbgw/context_map_sccp.c 1 file changed, 13 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/25/34925/1 diff --git a/src/osmo-hnbgw/context_map_sccp.c b/src/osmo-hnbgw/context_map_sccp.c index 9b4837d..7d0176f 100644 --- a/src/osmo-hnbgw/context_map_sccp.c +++ b/src/osmo-hnbgw/context_map_sccp.c @@ -26,6 +26,7 @@ #include <osmocom/core/fsm.h> #include <osmocom/sigtran/sccp_helpers.h> +#include <osmocom/sccp/sccp_types.h> #include <osmocom/ranap/ranap_common_ran.h> @@ -183,7 +184,9 @@ return -1; } - return osmo_sccp_tx_disconn(map->cnlink->hnbgw_sccp_user->sccp_user, map->scu_conn_id, NULL, 0); + return osmo_sccp_tx_disconn(map->cnlink->hnbgw_sccp_user->sccp_user, + map->scu_conn_id, NULL, + SCCP_RELEASE_CAUSE_END_USER_ORIGINATED); } static int destruct_ranap_ran_rx_co_ies(ranap_message *ranap_message_p) -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/34925?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: If44e7c4a3166822d7732b7af4c136b8f97898dc0 Gerrit-Change-Number: 34925 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

6 months

1
0
0 0

[S] Change in libosmo-sccp[master]: sccp_demo_user: Allow initiating conns from vty in server mode

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/34924?usp=email ) Change subject: sccp_demo_user: Allow initiating conns from vty in server mode ...................................................................... sccp_demo_user: Allow initiating conns from vty in server mode This allows starting SCCP conns from within sccp_demo_user, which in turn allows testing more scenarios in osmo-ttcn3-hacks.git SCCP_RAW_Tests testsuite. Related: SYS#6616 Change-Id: I7d5b3534c496dca8a3f3e66025af554bbe860c04 --- M examples/sccp_demo_user.c 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/24/34924/1 diff --git a/examples/sccp_demo_user.c b/examples/sccp_demo_user.c index a88dd69..d67bd27 100644 --- a/examples/sccp_demo_user.c +++ b/examples/sccp_demo_user.c @@ -307,6 +307,7 @@ exit(1); } sccp_test_server_init(g_sccp); + sccp_test_user_vty_install(g_sccp, OSMO_SCCP_SSN_BSSAP); } g_calling_addr.pc = local_pc; g_called_addr.pc = remote_pc; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/34924?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I7d5b3534c496dca8a3f3e66025af554bbe860c04 Gerrit-Change-Number: 34924 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

6 months

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: sccp: Introduce test TC_cr_timeout_cc_too_late

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34923?usp=email ) Change subject: sccp: Introduce test TC_cr_timeout_cc_too_late ...................................................................... sccp: Introduce test TC_cr_timeout_cc_too_late Related: SYS#6602 Change-Id: If4b53565f1fa19894ca24fa71e02ae7b1941411e --- M library/SCCP_Templates.ttcn M sccp/SCCP_Tests_RAW.ttcn 2 files changed, 89 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/23/34923/1 diff --git a/library/SCCP_Templates.ttcn b/library/SCCP_Templates.ttcn index a87ef5c..8c89bda 100644 --- a/library/SCCP_Templates.ttcn +++ b/library/SCCP_Templates.ttcn @@ -113,6 +113,43 @@ return ret; } +template (present) PDU_SCCP tr_SCCP_CR(template (present) OCT3 source_lref := ?, + template (present) SCCP_PAR_Address called := ?, + template (present) SCCP_PAR_Address calling := ?) := { + connrequest := { + messageType := cr, + sourceLocRef := source_lref, + protClass := c_class2, + pointer1 := ?, + pointer2 := ?, + calledPAddress := tr_Addr(called), + optionalPart := { + credit := omit, + callingPAddress := ?, //FIXME: tr_Addr(calling), + data := omit, + hopCounter := *, + importance := * + }, + eop := * + } +} + +function ts_SCCP_CC(OCT3 source_lref, OCT3 dest_lref) +return template (value) PDU_SCCP { + var template (value) PDU_SCCP ret := { + connconfirm := { + messageType := cc, + destLocRef := dest_lref, + sourceLocRef := source_lref, + protClass := c_class2, + pointer1 := 0, /* overwritten */ + optionalPart := omit, + eop := { paramName:= con_SCCP_eop } + } + } + return ret; +} + template (present) PDU_SCCP tr_SCCP_CC(template (present) OCT3 source_lref, template (present) OCT3 dest_lref) := { connconfirm := { diff --git a/sccp/SCCP_Tests_RAW.ttcn b/sccp/SCCP_Tests_RAW.ttcn index 1c81d98..935df13 100644 --- a/sccp/SCCP_Tests_RAW.ttcn +++ b/sccp/SCCP_Tests_RAW.ttcn @@ -69,6 +69,18 @@ "sccp-timer iar " & int2str(g_demo_sccp_timer_iar)}); } +function f_vty_cmd_connect_req(integer conn_id) runs on SCCP_Test_RAW_CT { + f_vty_transceive(SCCP_DEMO_USER_VTY, "sccp-user"); + f_vty_transceive(SCCP_DEMO_USER_VTY, "connect-req " & int2str(conn_id)); + f_vty_transceive(SCCP_DEMO_USER_VTY, "end"); +} + +function f_vty_cmd_disconnect_req(integer conn_id) runs on SCCP_Test_RAW_CT { + f_vty_transceive(SCCP_DEMO_USER_VTY, "sccp-user"); + f_vty_transceive(SCCP_DEMO_USER_VTY, "disconnect-req " & int2str(conn_id)); + f_vty_transceive(SCCP_DEMO_USER_VTY, "end"); +} + private function f_init_raw(SCCP_Configuration cfg) runs on SCCP_Test_RAW_CT { g_param := { sio := { @@ -483,6 +495,35 @@ } +/* Test user initiating a conn (eg RUA), which triggers SCCP CR. While waiting + * for CC, user decides it timed out (eg. RUA side timeout) which makes it move to + * WAIT_CONN_CONF state. In that state, wait for CC and then submit an RLSD and + * wait for ack. */ +testcase TC_cr_timeout_cc_too_late() runs on SCCP_Test_RAW_CT { + var SCCP_MTP3_TRANSFERind mtp3_rx; + var integer conn_id := 1234; + var OCT3 remote_lref; + + f_init_raw(mp_sccp_cfg[0]); + f_sleep(1.0); + + f_vty_cmd_connect_req(conn_id); + mtp3_rx := f_exp_sccp(tr_SCCP_CR(?, ?, ?)); + + /* Emulate disconnection from the user: */ + f_vty_cmd_disconnect_req(conn_id); + remote_lref := mtp3_rx.data.connrequest.sourceLocRef; + + /* Now send CC, user should send RSLD to us: */ + f_send_sccp(ts_SCCP_CC(g_own_lref, remote_lref)); + log("Waiting for RLSD"); + f_exp_sccp(tr_SCCP_RLSD(remote_lref, g_own_lref, hex2int('2A'H))); /* Cause: Unknown */ + f_send_sccp(ts_SCCP_RLC(g_own_lref, remote_lref)); + + setverdict(pass); +} + + control { execute( TC_cr_cc() ); execute( TC_udt_without_cr_cc() ); @@ -496,6 +537,7 @@ execute( TC_scmg_sst_ssn_invalid() ); execute( TC_callingparty_ssn_only() ); + execute( TC_cr_timeout_cc_too_late() ); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34923?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If4b53565f1fa19894ca24fa71e02ae7b1941411e Gerrit-Change-Number: 34923 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

6 months

1
0
0 0

2024

2023

2022

gerrit-log October 2023