Attention is currently required from: laforge.
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/pysim/+/34897?usp=email )
Change subject: runtime: fix tracking of selected_adf
......................................................................
Patch Set 3:
(2 comments)
Patchset:
PS3:
this fix works. […]
I have had a closer look to
select and select_file in runtime.py now. I really had problems to understand what really
happens with select and select_file. I have cleaned up the code now:
https://gerrit.osmocom.org/c/pysim/+/34932
PS3:
I now see that self.selected_adf refers to
RuntimeState. […]
The change I did in RuntimeState is wrong I think. What we do
there is probing for the applications on a low level. This is in the startup phase where
the file system is created. We do not have to maintain the lchan state in this phase. We
also can not use select or select_file either. I think it is ok to access the card from
here directly. Also accessing self.selected_adf should not work. It should be
self.lchan[0].selected_adf.
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/34897?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I4cc0c58ff887422b4f3954d35c8380ddc00baa1d
Gerrit-Change-Number: 34897
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 31 Oct 2023 16:36:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment