October 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-hnbgw[master]: Depend on libosmo-sccp package
by osmith 31 Oct '23

31 Oct '23

Attention is currently required from: laforge, neels, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/34927?usp=email ) Change subject: Depend on libosmo-sccp package ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/34927?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Idf88da2d1aa126acd1c784ff096ab79349364f85 Gerrit-Change-Number: 34927 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Oct 2023 11:23:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-hnbgw[master]: Depend on libosmo-sccp package
by pespin 31 Oct '23

31 Oct '23

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/34927?usp=email ) Change subject: Depend on libosmo-sccp package ...................................................................... Depend on libosmo-sccp package This allows using definitions available in osmocom/sccp/ namespace. Change-Id: Idf88da2d1aa126acd1c784ff096ab79349364f85 --- M configure.ac M contrib/osmo-hnbgw.spec.in M debian/control 3 files changed, 14 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/27/34927/1 diff --git a/configure.ac b/configure.ac index bb8d29e..0cdb417 100644 --- a/configure.ac +++ b/configure.ac @@ -54,6 +54,7 @@ PKG_CHECK_MODULES(LIBOSMOCTRL, libosmoctrl >= 1.9.0) PKG_CHECK_MODULES(LIBOSMOGSM, libosmogsm >= 1.9.0) PKG_CHECK_MODULES(LIBOSMONETIF, libosmo-netif >= 1.4.0) +PKG_CHECK_MODULES(LIBOSMOSCCP, libosmo-sccp >= 1.8.0) PKG_CHECK_MODULES(LIBOSMOSIGTRAN, libosmo-sigtran >= 1.8.0) PKG_CHECK_MODULES(LIBOSMORUA, libosmo-rua >= 1.5.0) PKG_CHECK_MODULES(LIBOSMORANAP, libosmo-ranap >= 1.5.0) diff --git a/contrib/osmo-hnbgw.spec.in b/contrib/osmo-hnbgw.spec.in index 02247a3..18a3ec6 100644 --- a/contrib/osmo-hnbgw.spec.in +++ b/contrib/osmo-hnbgw.spec.in @@ -34,6 +34,7 @@ BuildRequires: pkgconfig(libcrypto) >= 0.9.5 BuildRequires: pkgconfig(libosmo-mgcp-client) >= 1.12.0 BuildRequires: pkgconfig(libosmo-netif) >= 1.4.0 +BuildRequires: pkgconfig(libosmo-sccp) >= 1.8.0 BuildRequires: pkgconfig(libosmo-sigtran) >= 1.8.0 BuildRequires: pkgconfig(libosmoabis) >= 1.5.0 BuildRequires: pkgconfig(libosmotrau) >= 1.5.0 diff --git a/debian/control b/debian/control index 77737b5..03d0a64 100644 --- a/debian/control +++ b/debian/control @@ -14,6 +14,7 @@ libasn1c-dev (>= 0.9.30), libsctp-dev, libosmocore-dev (>= 1.9.0), + libosmo-sccp-dev (>= 1.8.0), libosmo-sigtran-dev (>= 1.8.0), libosmo-abis-dev (>= 1.5.0), libosmo-netif-dev (>= 1.4.0), -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/34927?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Idf88da2d1aa126acd1c784ff096ab79349364f85 Gerrit-Change-Number: 34927 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in osmo-ci[master]: OBS: add workaround for limesuite 23.10 release
by pespin 31 Oct '23

31 Oct '23

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/34926?usp=email ) Change subject: OBS: add workaround for limesuite 23.10 release ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34926?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I569642ebb13ac3eb3e241642e299be0a0a2ab15d Gerrit-Change-Number: 34926 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Oct 2023 11:11:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in osmo-ci[master]: OBS: add workaround for limesuite 23.10 release
by osmith 31 Oct '23

31 Oct '23

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/34926?usp=email ) Change subject: OBS: add workaround for limesuite 23.10 release ...................................................................... OBS: add workaround for limesuite 23.10 release The previous workaround for building on debian 12 is not needed anymore, as the related patch has been merged. Replace it with a new workaround needed for building the limesuite 23.10 release. Change-Id: I569642ebb13ac3eb3e241642e299be0a0a2ab15d --- M scripts/obs/lib/srcpkg.py 1 file changed, 19 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/26/34926/1 diff --git a/scripts/obs/lib/srcpkg.py b/scripts/obs/lib/srcpkg.py index 9476d82..05a705f 100644 --- a/scripts/obs/lib/srcpkg.py +++ b/scripts/obs/lib/srcpkg.py @@ -124,10 +124,12 @@ def prepare_project_limesuite(): - """ Fix Debian 12 compat, until this is merged and in the next release: - https://github.com/myriadrf/LimeSuite/pull/381 """ - lib.run_cmd(["sed", "s/libwxgtk3.0-gtk3-dev,$/libwxgtk3.0-gtk3-dev | libwxgtk3.2-dev,/g", - "-i", "debian/control"], cwd=lib.git.get_repo_path("limesuite")) + """ Fix bug in 23.10: https://github.com/myriadrf/LimeSuite/pull/386 """ + lib.run_cmd(["mv", "-v", + "liblimesuite22.09-1.install", + "liblimesuite23.10-1.install"], + cwd=f"{lib.git.get_repo_path('limesuite')}/debian", + check=False) def run_generate_build_dep(project): -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34926?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I569642ebb13ac3eb3e241642e299be0a0a2ab15d Gerrit-Change-Number: 34926 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 0

[S] Change in pysim[master]: transport: print device path/number on initialization failure
by dexter 31 Oct '23

31 Oct '23

dexter has abandoned this change. ( https://gerrit.osmocom.org/c/pysim/+/34693?usp=email ) Change subject: transport: print device path/number on initialization failure ...................................................................... Abandoned We have now solved this differently -- To view, visit https://gerrit.osmocom.org/c/pysim/+/34693?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3f5387508ccc2aa349adc7aec3d04d8fc977690b Gerrit-Change-Number: 34693 Gerrit-PatchSet: 6 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: abandon

1 0

[S] Change in libosmocore[master]: Debian: ignore .deb build byproducts
by laforge 31 Oct '23

31 Oct '23

laforge has abandoned this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29680?usp=email ) Change subject: Debian: ignore .deb build byproducts ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29680?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Idbd92096c9058eccd12e33453713815c7baf0792 Gerrit-Change-Number: 29680 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: abandon

1 0

[M] Change in osmocom-bb[master]: mobile: add SI10 receive stub
by laforge 31 Oct '23

31 Oct '23

Attention is currently required from: msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/31665?usp=email ) Change subject: mobile: add SI10 receive stub ...................................................................... Patch Set 4: (1 comment) This change is ready for review. Patchset: PS4: I guess this change can be abendoned now, as we have proper SI10 support in master? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/31665?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ia2672636251be1894c50b34d67ea1e6295f97d97 Gerrit-Change-Number: 31665 Gerrit-PatchSet: 4 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Oct 2023 10:00:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in osmo-bsc[master]: SI10: generate rest-octets
by laforge 31 Oct '23

31 Oct '23

Attention is currently required from: msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31047?usp=email ) Change subject: SI10: generate rest-octets ...................................................................... Patch Set 20: (1 comment) This change is ready for review. Patchset: PS20: I guess this change can be abendoned now, as we have proper SI10 support in master? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31047?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6b39f193d5940a629505bab0c0f1c4d192943fd8 Gerrit-Change-Number: 31047 Gerrit-PatchSet: 20 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Oct 2023 09:59:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in osmo-bsc[master]: SI10: add to SACCH filling
by laforge 31 Oct '23

31 Oct '23

Attention is currently required from: msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32631?usp=email ) Change subject: SI10: add to SACCH filling ...................................................................... Patch Set 2: (1 comment) This change is ready for review. Patchset: PS2: I guess this change can be abendoned now, as we have proper SI10 support in master? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32631?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5f5bd8887682ff09cf11cc7a3dae5048f50e3fd0 Gerrit-Change-Number: 32631 Gerrit-PatchSet: 2 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: jolly <andreas(a)eversberg.eu> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Oct 2023 09:59:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in libosmocore[master]: gsmtap_util: Use Osmo IO instead of Osmo write queues
by arehbein 31 Oct '23

31 Oct '23

Attention is currently required from: daniel, laforge, pespin. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34743?usp=email ) Change subject: gsmtap_util: Use Osmo IO instead of Osmo write queues ...................................................................... Patch Set 8: (1 comment) File src/core/gsmtap_util.c: https://gerrit.osmocom.org/c/libosmocore/+/34743/comment/8a7aef64_440b964c PS5, Line 478: osmo_iofd_setup(gti, gti->sink_fd, "gsmtap_inst.out", OSMO_IO_FD_MODE_READ_WRITE, &gsmtap_sink_ops, NULL); > @dwillmann@sysmocom.de just tried changing the VTY command... […] @dwillmann@sysmocom.de there's a bug in Osmo IO, basically if gsmtap logging is used, then if the queue overflows, we get an infinite call loop ``` #3729 0x00007ffff7e0e0f4 in _gsmtap_raw_output (target=0x555555617c60, subsys=31, level=7, file=0x7ffff7e45249 "osmo_io.c", line=377, cont=0, format=0x7ffff7e453d8 "iofd(%s)enqueueing message failed (%d). Rejecting msgb\n", ap=0x7fffff873e20) at logging_gsmtap.c:117 #3730 0x00007ffff7e0c335 in osmo_vlogp (subsys=31, level=7, file=0x7ffff7e45249 "osmo_io.c", line=377, cont=0, format=0x7ffff7e453d8 "iofd(%s)enqueueing message failed (%d). Rejecting msgb\n", ap=0x7fffff873e98) at logging.c:728 #3731 0x00007ffff7e0c52b in logp2 (subsys=-29, level=7, file=0x7ffff7e45249 "osmo_io.c", line=377, cont=0, format=0x7ffff7e453d8 "iofd(%s)enqueueing message failed (%d). Rejecting msgb\n") at logging.c:766 #3732 0x00007ffff7e1643e in osmo_iofd_write_msgb (iofd=0x555555635910, msg=0x555558bf1ec0) at osmo_io.c:377 ``` (see backtrace numbers :)) because of the LOGPIO call in case of overflow. Not sure if this was also a bug when Osmo write queues were used (if LOGPIO was called to log a full-queue error, then yes...) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34743?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iadbbef74e3add7001d84dd6b68f51eac293e44d0 Gerrit-Change-Number: 34743 Gerrit-PatchSet: 8 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Oct 2023 09:56:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: comment

1 0