Attention is currently required from: daniel, laforge, pespin.
arehbein has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/34743?usp=email )
Change subject: gsmtap_util: Use Osmo IO instead of Osmo write queues
......................................................................
Patch Set 8:
(1 comment)
File src/core/gsmtap_util.c:
https://gerrit.osmocom.org/c/libosmocore/+/34743/comment/8a7aef64_440b964c
PS5, Line 478: osmo_iofd_setup(gti, gti->sink_fd, "gsmtap_inst.out",
OSMO_IO_FD_MODE_READ_WRITE, &gsmtap_sink_ops, NULL);
@dwillmann@sysmocom.de just tried changing the VTY
command... […]
@dwillmann@sysmocom.de there's a bug in Osmo IO, basically if
gsmtap logging is used, then if the queue overflows, we get an infinite call loop
```
#3729 0x00007ffff7e0e0f4 in _gsmtap_raw_output (target=0x555555617c60, subsys=31, level=7,
file=0x7ffff7e45249 "osmo_io.c", line=377, cont=0,
format=0x7ffff7e453d8 "iofd(%s)enqueueing message failed (%d). Rejecting
msgb\n", ap=0x7fffff873e20)
at logging_gsmtap.c:117
#3730 0x00007ffff7e0c335 in osmo_vlogp (subsys=31, level=7, file=0x7ffff7e45249
"osmo_io.c", line=377, cont=0,
format=0x7ffff7e453d8 "iofd(%s)enqueueing message failed (%d). Rejecting
msgb\n", ap=0x7fffff873e98)
at logging.c:728
#3731 0x00007ffff7e0c52b in logp2 (subsys=-29, level=7, file=0x7ffff7e45249
"osmo_io.c", line=377, cont=0,
format=0x7ffff7e453d8 "iofd(%s)enqueueing message failed (%d). Rejecting
msgb\n") at logging.c:766
#3732 0x00007ffff7e1643e in osmo_iofd_write_msgb (iofd=0x555555635910, msg=0x555558bf1ec0)
at osmo_io.c:377
```
(see backtrace numbers :)) because of the LOGPIO call in case of overflow. Not sure if
this was also a bug when Osmo write queues were used (if LOGPIO was called to log a
full-queue error, then yes...)
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/34743?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Iadbbef74e3add7001d84dd6b68f51eac293e44d0
Gerrit-Change-Number: 34743
Gerrit-PatchSet: 8
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 31 Oct 2023 09:56:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>
Gerrit-MessageType: comment