July 2023 - gerrit-log - lists.osmocom.org

[S] Change in osmo-bts[master]: rsl: rsl_handle_chan_mod_ie(): set lchan->csd_mode

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34032 ) Change subject: rsl: rsl_handle_chan_mod_ie(): set lchan->csd_mode ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34032 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I6b1b44cffae1484098709efe496efafacbd354a8 Gerrit-Change-Number: 34032 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 31 Jul 2023 21:43:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

9 months

1
0
0 0

[S] Change in osmo-bts[master]: rsl: rsl_handle_chan_mod_ie(): do not use legacy defines

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34033 ) Change subject: rsl: rsl_handle_chan_mod_ie(): do not use legacy defines ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34033 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I4e8f9ff5189af80bce13cfd1b27585aabda03f7a Gerrit-Change-Number: 34033 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 31 Jul 2023 21:42:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

9 months

1
0
0 0

[S] Change in osmo-bts[master]: rsl: rsl_handle_chan_mod_ie(): set lchan->csd_mode

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/34032 ) Change subject: rsl: rsl_handle_chan_mod_ie(): set lchan->csd_mode ...................................................................... rsl: rsl_handle_chan_mod_ie(): set lchan->csd_mode Change-Id: I6b1b44cffae1484098709efe496efafacbd354a8 Related: ca418643 "csd_v110_rtp_encode(): properly set E1/E2/E3 bits" Related: OS#1572 --- M src/common/rsl.c 1 file changed, 29 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/32/34032/1 diff --git a/src/common/rsl.c b/src/common/rsl.c index d47ba99..9c0bce0 100644 --- a/src/common/rsl.c +++ b/src/common/rsl.c @@ -242,29 +242,47 @@ case RSL_CMODE(RSL_CMOD_SPD_DATA, RSL_CMOD_CSD_T_32000): /* 32.0 kbit/s services, 32.0 kbit/s radio interface rate */ lchan->tch_mode = GSM48_CMODE_DATA_32k0; + lchan->csd_mode = LCHAN_CSD_M_T_32000; break; case RSL_CMODE(RSL_CMOD_SPD_DATA, RSL_CMOD_CSD_T_29000): /* 29.0 kbit/s services, 29.0 kbit/s radio interface rate */ lchan->tch_mode = GSM48_CMODE_DATA_29k0; + lchan->csd_mode = LCHAN_CSD_M_T_29000; break; case RSL_CMODE(RSL_CMOD_SPD_DATA, RSL_CMOD_CSD_T_14400): /* 14.4 kbit/s services, 14.5 kbit/s radio interface rate */ lchan->tch_mode = GSM48_CMODE_DATA_14k5; + lchan->csd_mode = LCHAN_CSD_M_T_14400; break; case RSL_CMODE(RSL_CMOD_SPD_DATA, RSL_CMOD_CSD_T_9600): /* 9.6 kbit/s services, 12.0 kbit/s radio interface rate */ lchan->tch_mode = GSM48_CMODE_DATA_12k0; + lchan->csd_mode = LCHAN_CSD_M_T_9600; break; case RSL_CMODE(RSL_CMOD_SPD_DATA, RSL_CMOD_CSD_T_4800): /* 4.8 kbit/s services, 6.0 kbit/s radio interface rate */ lchan->tch_mode = GSM48_CMODE_DATA_6k0; + lchan->csd_mode = LCHAN_CSD_M_T_4800; break; case RSL_CMODE(RSL_CMOD_SPD_DATA, RSL_CMOD_CSD_T_2400): + /* 2.4 kbit/s *and less* services, 3.6 kbit/s radio interface rate */ + lchan->tch_mode = GSM48_CMODE_DATA_3k6; + lchan->csd_mode = LCHAN_CSD_M_T_2400; + break; case RSL_CMODE(RSL_CMOD_SPD_DATA, RSL_CMOD_CSD_T_1200): + /* 2.4 kbit/s *and less* services, 3.6 kbit/s radio interface rate */ + lchan->tch_mode = GSM48_CMODE_DATA_3k6; + lchan->csd_mode = LCHAN_CSD_M_T_1200; + break; case RSL_CMODE(RSL_CMOD_SPD_DATA, RSL_CMOD_CSD_T_600): + /* 2.4 kbit/s *and less* services, 3.6 kbit/s radio interface rate */ + lchan->tch_mode = GSM48_CMODE_DATA_3k6; + lchan->csd_mode = LCHAN_CSD_M_T_600; + break; case RSL_CMODE(RSL_CMOD_SPD_DATA, RSL_CMOD_CSD_T_1200_75): /* 2.4 kbit/s *and less* services, 3.6 kbit/s radio interface rate */ lchan->tch_mode = GSM48_CMODE_DATA_3k6; + lchan->csd_mode = LCHAN_CSD_M_T_1200_75; break; default: -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34032 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I6b1b44cffae1484098709efe496efafacbd354a8 Gerrit-Change-Number: 34032 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

9 months

1
0
0 0

[S] Change in osmo-bts[master]: rsl: rsl_handle_chan_mod_ie(): do not use legacy defines

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/34033 ) Change subject: rsl: rsl_handle_chan_mod_ie(): do not use legacy defines ...................................................................... rsl: rsl_handle_chan_mod_ie(): do not use legacy defines Change-Id: I4e8f9ff5189af80bce13cfd1b27585aabda03f7a Related: OS#1572 --- M src/common/rsl.c 1 file changed, 17 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/33/34033/1 diff --git a/src/common/rsl.c b/src/common/rsl.c index 9c0bce0..b37dd43 100644 --- a/src/common/rsl.c +++ b/src/common/rsl.c @@ -239,37 +239,37 @@ break; /* If octet 4 indicates transparent data */ - case RSL_CMODE(RSL_CMOD_SPD_DATA, RSL_CMOD_CSD_T_32000): + case RSL_CMODE(RSL_CMOD_SPD_DATA, RSL_CMOD_CSD_T_32k0): /* 32.0 kbit/s services, 32.0 kbit/s radio interface rate */ lchan->tch_mode = GSM48_CMODE_DATA_32k0; lchan->csd_mode = LCHAN_CSD_M_T_32000; break; - case RSL_CMODE(RSL_CMOD_SPD_DATA, RSL_CMOD_CSD_T_29000): + case RSL_CMODE(RSL_CMOD_SPD_DATA, RSL_CMOD_CSD_T_29k0): /* 29.0 kbit/s services, 29.0 kbit/s radio interface rate */ lchan->tch_mode = GSM48_CMODE_DATA_29k0; lchan->csd_mode = LCHAN_CSD_M_T_29000; break; - case RSL_CMODE(RSL_CMOD_SPD_DATA, RSL_CMOD_CSD_T_14400): + case RSL_CMODE(RSL_CMOD_SPD_DATA, RSL_CMOD_CSD_T_14k4): /* 14.4 kbit/s services, 14.5 kbit/s radio interface rate */ lchan->tch_mode = GSM48_CMODE_DATA_14k5; lchan->csd_mode = LCHAN_CSD_M_T_14400; break; - case RSL_CMODE(RSL_CMOD_SPD_DATA, RSL_CMOD_CSD_T_9600): + case RSL_CMODE(RSL_CMOD_SPD_DATA, RSL_CMOD_CSD_T_9k6): /* 9.6 kbit/s services, 12.0 kbit/s radio interface rate */ lchan->tch_mode = GSM48_CMODE_DATA_12k0; lchan->csd_mode = LCHAN_CSD_M_T_9600; break; - case RSL_CMODE(RSL_CMOD_SPD_DATA, RSL_CMOD_CSD_T_4800): + case RSL_CMODE(RSL_CMOD_SPD_DATA, RSL_CMOD_CSD_T_4k8): /* 4.8 kbit/s services, 6.0 kbit/s radio interface rate */ lchan->tch_mode = GSM48_CMODE_DATA_6k0; lchan->csd_mode = LCHAN_CSD_M_T_4800; break; - case RSL_CMODE(RSL_CMOD_SPD_DATA, RSL_CMOD_CSD_T_2400): + case RSL_CMODE(RSL_CMOD_SPD_DATA, RSL_CMOD_CSD_T_2k4): /* 2.4 kbit/s *and less* services, 3.6 kbit/s radio interface rate */ lchan->tch_mode = GSM48_CMODE_DATA_3k6; lchan->csd_mode = LCHAN_CSD_M_T_2400; break; - case RSL_CMODE(RSL_CMOD_SPD_DATA, RSL_CMOD_CSD_T_1200): + case RSL_CMODE(RSL_CMOD_SPD_DATA, RSL_CMOD_CSD_T_1k2): /* 2.4 kbit/s *and less* services, 3.6 kbit/s radio interface rate */ lchan->tch_mode = GSM48_CMODE_DATA_3k6; lchan->csd_mode = LCHAN_CSD_M_T_1200; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34033 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I4e8f9ff5189af80bce13cfd1b27585aabda03f7a Gerrit-Change-Number: 34033 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

9 months

1
0
0 0

[S] Change in osmocom-bb[master]: layer23: modem: Fix newline character typo in log line

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34028 ) Change subject: layer23: modem: Fix newline character typo in log line ...................................................................... layer23: modem: Fix newline character typo in log line Change-Id: I3ff9b71ff469e339aadff643b582efb06d5efb6c --- M src/host/layer23/src/modem/gmm.c 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/host/layer23/src/modem/gmm.c b/src/host/layer23/src/modem/gmm.c index 5ea2b43..17cc228 100644 --- a/src/host/layer23/src/modem/gmm.c +++ b/src/host/layer23/src/modem/gmm.c @@ -161,7 +161,7 @@ } } else { if (old_tlli != OSMO_GPRS_GMM_TLLI_UNASSIGNED) - LOGP(DGMM, LOGL_ERROR, "%s(): Unexpected Rx %s with unknown TLLI=0x%08xn", + LOGP(DGMM, LOGL_ERROR, "%s(): Unexpected Rx %s with unknown TLLI=0x%08x\n", __func__, pdu_name, old_tlli); } -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34028 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I3ff9b71ff469e339aadff643b582efb06d5efb6c Gerrit-Change-Number: 34028 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

9 months

1
0
0 0

[S] Change in osmocom-bb[master]: layer23: modem: gmm: Log allocated TLLI on Attach Success

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34030 ) Change subject: layer23: modem: gmm: Log allocated TLLI on Attach Success ...................................................................... layer23: modem: gmm: Log allocated TLLI on Attach Success Change-Id: I29242873ebec173c430e6d413e6c533ec1e2b97a --- M src/host/layer23/src/modem/gmm.c 1 file changed, 12 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/host/layer23/src/modem/gmm.c b/src/host/layer23/src/modem/gmm.c index 17cc228..b8df38b 100644 --- a/src/host/layer23/src/modem/gmm.c +++ b/src/host/layer23/src/modem/gmm.c @@ -60,8 +60,9 @@ switch (OSMO_PRIM_HDR(&gmm_prim->oph)) { case OSMO_PRIM(OSMO_GPRS_GMM_GMMREG_ATTACH, PRIM_OP_CONFIRM): if (gmm_prim->gmmreg.attach_cnf.accepted) { - LOGP(DGMM, LOGL_NOTICE, "%s(): Rx %s: Attach success P-TMSI=0x%08x\n", - __func__, pdu_name, gmm_prim->gmmreg.attach_cnf.acc.allocated_ptmsi); + LOGP(DGMM, LOGL_NOTICE, "%s(): Rx %s: Attach success P-TMSI=0x%08x TLLI=0x%08x\n", + __func__, pdu_name, gmm_prim->gmmreg.attach_cnf.acc.allocated_ptmsi, + gmm_prim->gmmreg.attach_cnf.acc.allocated_tlli); ms->subscr.gprs.ptmsi = gmm_prim->gmmreg.attach_cnf.acc.allocated_ptmsi; ms->gmmlayer.tlli = gmm_prim->gmmreg.attach_cnf.acc.allocated_tlli; app_data.modem_state = MODEM_ST_ATTACHED; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34030 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I29242873ebec173c430e6d413e6c533ec1e2b97a Gerrit-Change-Number: 34030 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

9 months

1
0
0 0

[S] Change in libosmo-gprs[master]: rlcmac: rx pkt_uk_ack_nack: Use correct field containing UL TFI

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34026 ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: rlcmac: rx pkt_uk_ack_nack: Use correct field containing UL TFI ...................................................................... rlcmac: rx pkt_uk_ack_nack: Use correct field containing UL TFI Change-Id: If0bbd9989413a550243a6496bce16b6eb04508db --- M src/rlcmac/rlcmac.c 1 file changed, 12 insertions(+), 2 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/rlcmac/rlcmac.c b/src/rlcmac/rlcmac.c index a6d0e71..212b801 100644 --- a/src/rlcmac/rlcmac.c +++ b/src/rlcmac/rlcmac.c @@ -701,13 +701,14 @@ { struct gprs_rlcmac_ul_tbf *ul_tbf; int rc; + const Packet_Uplink_Ack_Nack_t *pkt_ul_ack = &dl_block->u.Packet_Uplink_Ack_Nack; - ul_tbf = gprs_rlcmac_find_ul_tbf_by_tfi(dl_block->TFI); + ul_tbf = gprs_rlcmac_find_ul_tbf_by_tfi(pkt_ul_ack->UPLINK_TFI); if (!ul_tbf) { LOGRLCMAC(LOGL_INFO, "TS=%u FN=%u Rx Pkt UL ACK/NACK: UL_TBF TFI=%u not found\n", rlcmac_prim->l1ctl.pdch_data_ind.ts_nr, rlcmac_prim->l1ctl.pdch_data_ind.fn, - dl_block->TFI); + pkt_ul_ack->UPLINK_TFI); return -ENOENT; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34026 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: If0bbd9989413a550243a6496bce16b6eb04508db Gerrit-Change-Number: 34026 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

9 months

1
0
0 0

[S] Change in libosmo-gprs[master]: llc,sndcp: Add missing hex prefix to log line printing TLLI

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34027 ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: llc,sndcp: Add missing hex prefix to log line printing TLLI ...................................................................... llc,sndcp: Add missing hex prefix to log line printing TLLI Change-Id: I8d31ed7cf89555a1ec3cbd91a77cc00cc42b546f --- M src/llc/llc_llgmm.c M src/sndcp/sndcp_prim.c M tests/llc/llc_prim_test.err M tests/sndcp/sndcp_prim_test.err 4 files changed, 27 insertions(+), 18 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/llc/llc_llgmm.c b/src/llc/llc_llgmm.c index 438de51..27150cc 100644 --- a/src/llc/llc_llgmm.c +++ b/src/llc/llc_llgmm.c @@ -166,7 +166,7 @@ goto ret_free; } - LOGLLME(llme, LOGL_NOTICE, "LLGM Assign pre (%08x => %08x)\n", old_tlli, new_tlli); + LOGLLME(llme, LOGL_NOTICE, "LLGM Assign pre (0x%08x => 0x%08x)\n", old_tlli, new_tlli); if (old_tlli == TLLI_UNASSIGNED && new_tlli != TLLI_UNASSIGNED) { /* TLLI Assignment 8.3.1 */ @@ -221,7 +221,7 @@ free = true; } - LOGLLME(llme, LOGL_NOTICE, "LLGM Assign post (%08x => %08x)\n", old_tlli, new_tlli); + LOGLLME(llme, LOGL_NOTICE, "LLGM Assign post (0x%08x => 0x%08x)\n", old_tlli, new_tlli); if (free) gprs_llc_llme_free(llme); diff --git a/src/sndcp/sndcp_prim.c b/src/sndcp/sndcp_prim.c index 45d6a0f..c07508a 100644 --- a/src/sndcp/sndcp_prim.c +++ b/src/sndcp/sndcp_prim.c @@ -335,7 +335,7 @@ sndcp_prim->sn.data_req.nsapi); if (!sne) { LOGSNDCP(LOGL_ERROR, "Message for non-existing SNDCP Entity " - "(TLLI=%08x, SAPI=%u, NSAPI=%u)\n", + "(TLLI=0x%08x, SAPI=%u, NSAPI=%u)\n", sndcp_prim->sn.tlli, sndcp_prim->sn.sapi, sndcp_prim->sn.data_req.nsapi); rc = -EIO; @@ -360,7 +360,7 @@ sndcp_prim->sn.unitdata_req.nsapi); if (!sne) { LOGSNDCP(LOGL_ERROR, "Message for non-existing SNDCP Entity " - "(TLLI=%08x, SAPI=%u, NSAPI=%u)\n", + "(TLLI=0x%08x, SAPI=%u, NSAPI=%u)\n", sndcp_prim->sn.tlli, sndcp_prim->sn.sapi, sndcp_prim->sn.unitdata_req.nsapi); rc = -EIO; @@ -383,7 +383,7 @@ sndcp_prim->sn.xid_req.nsapi); if (!sne) { LOGSNDCP(LOGL_ERROR, "Message for non-existing SNDCP Entity " - "(TLLI=%08x, SAPI=%u, NSAPI=%u)\n", + "(TLLI=0x%08x, SAPI=%u, NSAPI=%u)\n", sndcp_prim->sn.tlli, sndcp_prim->sn.sapi, sndcp_prim->sn.xid_req.nsapi); rc = -EIO; @@ -405,7 +405,7 @@ sndcp_prim->sn.xid_rsp.nsapi); if (!sne) { LOGSNDCP(LOGL_ERROR, "Message for non-existing SNDCP Entity " - "(TLLI=%08x, SAPI=%u, NSAPI=%u)\n", + "(TLLI=0x%08x, SAPI=%u, NSAPI=%u)\n", sndcp_prim->sn.tlli, sndcp_prim->sn.sapi, sndcp_prim->sn.xid_rsp.nsapi); rc = -EIO; @@ -476,7 +476,7 @@ sne = gprs_sndcp_sne_by_dlci_nsapi(llc_prim->ll.tlli, llc_prim->ll.sapi, sch->nsapi); if (!sne) { LOGSNDCP(LOGL_ERROR, "Message for non-existing SNDCP Entity " - "(TLLI=%08x, SAPI=%u, NSAPI=%u)\n", + "(TLLI=0x%08x, SAPI=%u, NSAPI=%u)\n", llc_prim->ll.tlli, llc_prim->ll.sapi, sch->nsapi); return -EIO; } @@ -493,7 +493,7 @@ sne = gprs_sndcp_sne_by_dlci(llc_prim->ll.tlli, llc_prim->ll.sapi); if (!sne) { LOGSNDCP(LOGL_ERROR, "Message for non-existing SNDCP Entity " - "(TLLI=%08x, SAPI=%u)\n", + "(TLLI=0x%08x, SAPI=%u)\n", llc_prim->ll.tlli, llc_prim->ll.sapi); return -EIO; } @@ -510,7 +510,7 @@ snme = gprs_sndcp_snme_find_by_tlli(llc_prim->ll.tlli); if (!snme) { LOGSNDCP(LOGL_ERROR, "SNDCP-LL-XID.ind: Message for non-existing SNDCP Entity " - "(TLLI=%08x, SAPI=%u)\n", + "(TLLI=0x%08x, SAPI=%u)\n", llc_prim->ll.tlli, llc_prim->ll.sapi); return -EIO; } @@ -529,7 +529,7 @@ snme = gprs_sndcp_snme_find_by_tlli(llc_prim->ll.tlli); if (!snme) { LOGSNDCP(LOGL_ERROR, "SNDCP-LL-XID.cnf: Message for non-existing SNDCP Entity " - "(TLLI=%08x, SAPI=%u)\n", + "(TLLI=0x%08x, SAPI=%u)\n", llc_prim->ll.tlli, llc_prim->ll.sapi); return -EIO; } @@ -546,7 +546,7 @@ snme = gprs_sndcp_snme_find_by_tlli(llc_prim->ll.tlli); if (!snme) { - LOGSNDCP(LOGL_ERROR, "SNDCP-LL-ASSIGN.ind: Message for non-existing SNDCP Entity (TLLI=%08x)\n", + LOGSNDCP(LOGL_ERROR, "SNDCP-LL-ASSIGN.ind: Message for non-existing SNDCP Entity (TLLI=0x%08x)\n", llc_prim->ll.tlli); return -EIO; } @@ -639,7 +639,7 @@ struct gprs_sndcp_entity *sne; struct osmo_gprs_sm_qos_profile_decoded decoded; - LOGSNDCP(LOGL_INFO, "SNSM-ACTIVATE.ind (TLLI=%08x, SAPI=%u, NSAPI=%u)\n", + LOGSNDCP(LOGL_INFO, "SNSM-ACTIVATE.ind (TLLI=0x%08x, SAPI=%u, NSAPI=%u)\n", tlli, sapi, nsapi); snme = gprs_sndcp_snme_find_by_tlli(tlli); @@ -709,14 +709,14 @@ snme = gprs_sndcp_snme_find_by_tlli(tlli); if (!snme) { LOGSNDCP(LOGL_ERROR, "SNSM-DEACTIVATE.ind: Message for non-existing SNDCP Management Entity " - "(TLLI=%08x, NSAPI=%u)\n", tlli, nsapi); + "(TLLI=0x%08x, NSAPI=%u)\n", tlli, nsapi); return -EIO; } sne = gprs_sndcp_snme_get_sne(snme, nsapi); if (!sne) { LOGSNDCP(LOGL_ERROR, "SNSM-DEACTIVATE.ind: Message for non-existing SNDCP Entity " - "(TLLI=%08x, NSAPI=%u)\n", tlli, nsapi); + "(TLLI=0x%08x, NSAPI=%u)\n", tlli, nsapi); return -EIO; } diff --git a/tests/llc/llc_prim_test.err b/tests/llc/llc_prim_test.err index 022dfac..e13bd7b 100644 --- a/tests/llc/llc_prim_test.err +++ b/tests/llc/llc_prim_test.err @@ -26,8 +26,8 @@ DLGLOBAL DEBUG LLE(ffffffff/e1c5d364,GMM){UNASSIGNED} Rx SAPI=1 (GMM), UI func=UI C/R=0 PM=0 E=0 IP=0 N(U)=0 FCS=f218e2 DLGLOBAL INFO Rx from upper layers: LL-UNITDATA.request DLGLOBAL INFO Rx from upper layers: LLGMM-ASSIGN.request -DLGLOBAL NOTICE LLME(ffffffff/e1c5d364){UNASSIGNED} LLGM Assign pre (e1c5d364 => e1c5d364) -DLGLOBAL NOTICE LLME(e1c5d364/e1c5d364){ASSIGNED} LLGM Assign post (e1c5d364 => e1c5d364) +DLGLOBAL NOTICE LLME(ffffffff/e1c5d364){UNASSIGNED} LLGM Assign pre (0xe1c5d364 => 0xe1c5d364) +DLGLOBAL NOTICE LLME(e1c5d364/e1c5d364){ASSIGNED} LLGM Assign post (0xe1c5d364 => 0xe1c5d364) DLGLOBAL INFO Rx from upper layers: LLGMM-RESET.request DLGLOBAL INFO LLME(e1c5d364/e1c5d364){ASSIGNED} LLGMM-RESET.request DLGLOBAL INFO Rx from upper layers: LL-ESTABLISH.request diff --git a/tests/sndcp/sndcp_prim_test.err b/tests/sndcp/sndcp_prim_test.err index d61a18a..d858a49 100644 --- a/tests/sndcp/sndcp_prim_test.err +++ b/tests/sndcp/sndcp_prim_test.err @@ -1,5 +1,5 @@ DLGLOBAL INFO Rx from SNDCP SM sublayer: SNSM-ACTIVATE.indication -DLGLOBAL INFO SNSM-ACTIVATE.ind (TLLI=e1c5d364, SAPI=3, NSAPI=5) +DLGLOBAL INFO SNSM-ACTIVATE.ind (TLLI=0xe1c5d364, SAPI=3, NSAPI=5) DLGLOBAL INFO Rx from lower layers: LL-XID.indication DLGLOBAL DEBUG SNE(e1c5d364,SNDCP3,5) LL-XID.ind: Found SNE SAPI=3 DLGLOBAL DEBUG SNME(e1c5d364) LL-XID.cnf requested comp_fields: @@ -112,7 +112,7 @@ DLGLOBAL DEBUG SNME(e1c5d364) No SNDCP Entities left activate, freeing SNME DLGLOBAL DEBUG SNME(e1c5d364) free() DLGLOBAL INFO Rx from SNDCP SM sublayer: SNSM-ACTIVATE.indication -DLGLOBAL INFO SNSM-ACTIVATE.ind (TLLI=e1c5d364, SAPI=3, NSAPI=5) +DLGLOBAL INFO SNSM-ACTIVATE.ind (TLLI=0xe1c5d364, SAPI=3, NSAPI=5) DLGLOBAL INFO Rx from lower layers: LL-XID.confirm DLGLOBAL DEBUG SNE(e1c5d364,SNDCP3,5) LL-XID.cnf: Found SNE SAPI=3 DLGLOBAL INFO Rx from upper layers: SN-XID.request -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34027 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I8d31ed7cf89555a1ec3cbd91a77cc00cc42b546f Gerrit-Change-Number: 34027 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

9 months

1
0
0 0

[S] Change in libosmo-gprs[master]: llc: Silently discard UI Dummy commands

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34025 ) Change subject: llc: Silently discard UI Dummy commands ...................................................................... llc: Silently discard UI Dummy commands Change-Id: I807e140b96de7140d8f6922417f3eaf0eadeed84 --- M src/llc/llc.c 1 file changed, 23 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/llc/llc.c b/src/llc/llc.c index be1ebec..dc1a7b6 100644 --- a/src/llc/llc.c +++ b/src/llc/llc.c @@ -53,6 +53,11 @@ { 0, NULL } }; +/* 3GPP TS 44.064 6.4.2.2 */ +static const uint8_t gprs_llc_ui_dummy_command[] = { + 0x43, 0xc0, 0x01, 0x2b, 0x2b, 0x2b +}; + /* Section 8.9.9 LLC layer parameter default values */ static const struct gprs_llc_params llc_default_params[NUM_SAPIS] = { [1] = { @@ -844,6 +849,15 @@ if (~pdu_dec->flags & OSMO_GPRS_LLC_PDU_F_PROT_MODE) crc_length = OSMO_MIN(crc_length, UI_HDR_LEN + N202); if (pdu_dec->fcs != gprs_llc_fcs(ll_pdu, crc_length)) { + if (ll_pdu_len >= sizeof(gprs_llc_ui_dummy_command) || + memcmp(ll_pdu, gprs_llc_ui_dummy_command, sizeof(gprs_llc_ui_dummy_command)) == 0) { + /* 6.4.2.2: "If the LLC entity at the MS receives a UI Dummy command, it shall discard + * it without any further actions" [...] + * "The format specified for the UI Dummy command ensures that a receiving LLC entity + * will always discard it, since the FCS field check always fails" "*/ + LOGLLE(lle, LOGL_DEBUG, "Dropping UI Dummy command len=%zu\n", ll_pdu_len); + return 0; + } LOGLLE(lle, LOGL_NOTICE, "Dropping frame with invalid FCS 0x%06x vs exp 0x%06x: %s\n", pdu_dec->fcs, gprs_llc_fcs(ll_pdu, crc_length), osmo_hexdump(ll_pdu, ll_pdu_len)); -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34025 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I807e140b96de7140d8f6922417f3eaf0eadeed84 Gerrit-Change-Number: 34025 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

9 months

1
0
0 0

[S] Change in libosmo-gprs[master]: llc: Silently discard UI Dummy commands

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34025 ) Change subject: llc: Silently discard UI Dummy commands ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34025 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I807e140b96de7140d8f6922417f3eaf0eadeed84 Gerrit-Change-Number: 34025 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 31 Jul 2023 17:25:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

9 months

1
0
0 0

[S] Change in osmo-pcu[master]: pcu_l1_if.cpp: Fix gsmtap not sent in PCU_IF_SAPI_PCH_DT

by fixeria

Attention is currently required from: pespin, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/34019 ) Change subject: pcu_l1_if.cpp: Fix gsmtap not sent in PCU_IF_SAPI_PCH_DT ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/34019 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2cfa0486a3483140ce219b4645e0544e7923870a Gerrit-Change-Number: 34019 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 31 Jul 2023 16:28:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

9 months

1
0
0 0

[S] Change in osmocom-bb[master]: layer23: modem: gmm: Adapt log string about no TLLI found

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34031 ) Change subject: layer23: modem: gmm: Adapt log string about no TLLI found ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34031 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I31c04288789393391084000fbdbcdcedb11d0b68 Gerrit-Change-Number: 34031 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 31 Jul 2023 16:26:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

9 months

1
0
0 0

[S] Change in libosmo-gprs[master]: llc: Silently discard UI Dummy commands

by pespin

Attention is currently required from: osmith. Hello osmith, Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34025 to look at the new patch set (#2). Change subject: llc: Silently discard UI Dummy commands ...................................................................... llc: Silently discard UI Dummy commands Change-Id: I807e140b96de7140d8f6922417f3eaf0eadeed84 --- M src/llc/llc.c 1 file changed, 23 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/25/34025/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34025 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I807e140b96de7140d8f6922417f3eaf0eadeed84 Gerrit-Change-Number: 34025 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

9 months

1
0
0 0

[S] Change in libosmo-gprs[master]: llc,sndcp: Add missing hex prefix to log line printing TLLI

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34027 to look at the new patch set (#3). Change subject: llc,sndcp: Add missing hex prefix to log line printing TLLI ...................................................................... llc,sndcp: Add missing hex prefix to log line printing TLLI Change-Id: I8d31ed7cf89555a1ec3cbd91a77cc00cc42b546f --- M src/llc/llc_llgmm.c M src/sndcp/sndcp_prim.c M tests/llc/llc_prim_test.err M tests/sndcp/sndcp_prim_test.err 4 files changed, 27 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/27/34027/3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34027 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I8d31ed7cf89555a1ec3cbd91a77cc00cc42b546f Gerrit-Change-Number: 34027 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

9 months

1
0
0 0

[S] Change in libosmo-gprs[master]: rlcmac: rx pkt_uk_ack_nack: Use correct field containing UL TFI

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34026 to look at the new patch set (#2). Change subject: rlcmac: rx pkt_uk_ack_nack: Use correct field containing UL TFI ...................................................................... rlcmac: rx pkt_uk_ack_nack: Use correct field containing UL TFI Change-Id: If0bbd9989413a550243a6496bce16b6eb04508db --- M src/rlcmac/rlcmac.c 1 file changed, 12 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/26/34026/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34026 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: If0bbd9989413a550243a6496bce16b6eb04508db Gerrit-Change-Number: 34026 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

9 months

1
0
0 0

[S] Change in libosmo-gprs[master]: rlcmac: keep looking up GRE based on old TLLI

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34023 ) Change subject: rlcmac: keep looking up GRE based on old TLLI ...................................................................... rlcmac: keep looking up GRE based on old TLLI This is needed after RAU Update since the PCU may still be using the old TLLI to reference the MS for a while until it finds out about the TLLI update. Change-Id: I2653db3dac58342df02a1b4d0c76e69e0e8d583f --- M include/osmocom/gprs/rlcmac/gre.h M src/rlcmac/gre.c M src/rlcmac/rlcmac.c M src/rlcmac/rlcmac_prim.c 4 files changed, 19 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/include/osmocom/gprs/rlcmac/gre.h b/include/osmocom/gprs/rlcmac/gre.h index a7317cd..be36e23 100644 --- a/include/osmocom/gprs/rlcmac/gre.h +++ b/include/osmocom/gprs/rlcmac/gre.h @@ -21,6 +21,7 @@ struct gprs_rlcmac_entity { struct llist_head entry; /* item in (struct gprs_rlcmac_ctx)->gre_list */ uint32_t tlli; + uint32_t old_tlli; /* Used to match paging requests coming from CS domain: */ uint32_t ptmsi; diff --git a/src/rlcmac/gre.c b/src/rlcmac/gre.c index 0eb6a8c..9102124 100644 --- a/src/rlcmac/gre.c +++ b/src/rlcmac/gre.c @@ -66,6 +66,7 @@ goto err_free_gre; gre->tlli = tlli; + gre->old_tlli = GPRS_RLCMAC_TLLI_UNASSIGNED; gre->ptmsi = GSM_RESERVED_TMSI; llist_add_tail(&gre->entry, &g_rlcmac_ctx->gre_list); diff --git a/src/rlcmac/rlcmac.c b/src/rlcmac/rlcmac.c index f35c04d..a6d0e71 100644 --- a/src/rlcmac/rlcmac.c +++ b/src/rlcmac/rlcmac.c @@ -137,7 +137,7 @@ { struct gprs_rlcmac_entity *gre; llist_for_each_entry(gre, &g_rlcmac_ctx->gre_list, entry) { - if (gre->tlli == tlli) + if (gre->tlli == tlli || gre->old_tlli == tlli) return gre; } return NULL; diff --git a/src/rlcmac/rlcmac_prim.c b/src/rlcmac/rlcmac_prim.c index f13ac3d..1ce7c9e 100644 --- a/src/rlcmac/rlcmac_prim.c +++ b/src/rlcmac/rlcmac_prim.c @@ -469,6 +469,8 @@ rc = -ENOENT; goto free_ret; } + gre->old_tlli = old_tlli; + gre->tlli = GPRS_RLCMAC_TLLI_UNASSIGNED; gprs_rlcmac_entity_free(gre); gre = NULL; goto free_ret; @@ -481,7 +483,9 @@ goto free_ret; } LOGGRE(gre, LOGL_INFO, "Update TLLI 0x%08x -> 0x%08x\n", old_tlli, new_tlli); + gre->old_tlli = old_tlli; gre->tlli = new_tlli; + } /* cache/update knowledge about this GMME's PTMSI and IMSI. It will be -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34023 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I2653db3dac58342df02a1b4d0c76e69e0e8d583f Gerrit-Change-Number: 34023 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

9 months

1
0
0 0

[S] Change in libosmo-gprs[master]: gmm: Several fixes for radio_prio

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34020 ) Change subject: gmm: Several fixes for radio_prio ...................................................................... gmm: Several fixes for radio_prio The "Radio Priority" received in GMM Attach Accept are for SMS and TOM8 SAPs only. For GMM/SM unitdata transferred to LLC, use highest radio_prio=1. Change-Id: Ie583c433547fb5ecbb6b6077c39a157961f73cfc --- M include/osmocom/gprs/gmm/gmm_private.h M src/gmm/gmm.c M src/gmm/gmm_prim.c 3 files changed, 27 insertions(+), 12 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/include/osmocom/gprs/gmm/gmm_private.h b/include/osmocom/gprs/gmm/gmm_private.h index 2abd583..db2cc8e 100644 --- a/include/osmocom/gprs/gmm/gmm_private.h +++ b/include/osmocom/gprs/gmm/gmm_private.h @@ -64,7 +64,8 @@ char imei[GSM23003_IMEI_NUM_DIGITS + 1]; char imeisv[GSM23003_IMEISV_NUM_DIGITS+1]; - uint8_t radio_prio; /* TS 24.008 10.5.7.2 */ + uint8_t radio_prio_sms; /* TS 24.008 10.5.7.2 */ + uint8_t radio_prio_tom8; /* TS 24.008 10.5.7.2 */ struct gprs_ra_id ra; /* TS 24.008 10.5.5.15 (decoded) */ bool pdp_ctx_status_present; uint8_t pdp_ctx_status[2]; /* TS 24.008 10.5.7.1 */ diff --git a/src/gmm/gmm.c b/src/gmm/gmm.c index e3afc18..7be6c13 100644 --- a/src/gmm/gmm.c +++ b/src/gmm/gmm.c @@ -581,9 +581,9 @@ } llc_prim->ll.l3_pdu = msg->l3h; llc_prim->ll.l3_pdu_len = msgb_l3len(msg); + llc_prim->ll.unitdata_req.radio_prio = 1; /* highest */ /* TODO: llc_prim->ll.qos_params.*; - llc_prim->ll.radio_prio; llc_prim->ll.apply_gea; llc_prim->ll.apply_gia; */ @@ -615,9 +615,9 @@ } llc_prim->ll.l3_pdu = msg->l3h; llc_prim->ll.l3_pdu_len = msgb_l3len(msg); + llc_prim->ll.unitdata_req.radio_prio = 1; /* highest */ /* TODO: llc_prim->ll.qos_params.*; - llc_prim->ll.radio_prio; llc_prim->ll.apply_gea; llc_prim->ll.apply_gia; */ @@ -652,9 +652,9 @@ } llc_prim->ll.l3_pdu = msg->l3h; llc_prim->ll.l3_pdu_len = msgb_l3len(msg); + llc_prim->ll.unitdata_req.radio_prio = 1; /* highest */ /* TODO: llc_prim->ll.qos_params.*; - llc_prim->ll.radio_prio; llc_prim->ll.apply_gea; llc_prim->ll.apply_gia; */ @@ -684,9 +684,9 @@ } llc_prim->ll.l3_pdu = msg->l3h; llc_prim->ll.l3_pdu_len = msgb_l3len(msg); + llc_prim->ll.unitdata_req.radio_prio = 1; /* highest */ /* TODO: llc_prim->ll.qos_params.*; - llc_prim->ll.radio_prio; llc_prim->ll.apply_gea; llc_prim->ll.apply_gia; */ @@ -718,9 +718,9 @@ } llc_prim->ll.l3_pdu = msg->l3h; llc_prim->ll.l3_pdu_len = msgb_l3len(msg); + llc_prim->ll.unitdata_req.radio_prio = 1; /* highest */ /* TODO: llc_prim->ll.qos_params.*; - llc_prim->ll.radio_prio; llc_prim->ll.apply_gea; llc_prim->ll.apply_gia; */ @@ -750,9 +750,9 @@ } llc_prim->ll.l3_pdu = msg->l3h; llc_prim->ll.l3_pdu_len = msgb_l3len(msg); + llc_prim->ll.unitdata_req.radio_prio = 1; /* highest */ /* TODO: llc_prim->ll.qos_params.*; - llc_prim->ll.radio_prio; llc_prim->ll.apply_gea; llc_prim->ll.apply_gia; */ @@ -784,9 +784,9 @@ } llc_prim->ll.l3_pdu = msg->l3h; llc_prim->ll.l3_pdu_len = msgb_l3len(msg); + llc_prim->ll.unitdata_req.radio_prio = 1; /* highest */ /* TODO: llc_prim->ll.qos_params.*; - llc_prim->ll.radio_prio; llc_prim->ll.apply_gea; llc_prim->ll.apply_gia; */ @@ -825,9 +825,9 @@ } llc_prim->ll.l3_pdu = msg->l3h; llc_prim->ll.l3_pdu_len = msgb_l3len(msg); + llc_prim->ll.unitdata_req.radio_prio = 1; /* highest */ /* TODO: llc_prim->ll.qos_params.*; - llc_prim->ll.radio_prio; llc_prim->ll.apply_gea; llc_prim->ll.apply_gia; */ @@ -857,9 +857,9 @@ } llc_prim->ll.l3_pdu = msg->l3h; llc_prim->ll.l3_pdu_len = msgb_l3len(msg); + llc_prim->ll.unitdata_req.radio_prio = 1; /* highest */ /* TODO: llc_prim->ll.qos_params.*; - llc_prim->ll.radio_prio; llc_prim->ll.apply_gea; llc_prim->ll.apply_gia; */ @@ -886,7 +886,8 @@ aa = (struct gsm48_attach_ack *)&gh->data[0]; periodic_rau_sec = gprs_gmm_gprs_tmr_to_secs(aa->ra_upd_timer); - gmme->radio_prio = aa->radio_prio; + gmme->radio_prio_sms = aa->radio_prio >> 4; + gmme->radio_prio_tom8 = aa->radio_prio & 0x0f; gmme->t3312_assigned_sec = periodic_rau_sec >= 0 ? periodic_rau_sec : 0; if (gmme->t3312_assigned_sec == 0) gprs_gmm_gmme_t3312_stop(gmme); diff --git a/src/gmm/gmm_prim.c b/src/gmm/gmm_prim.c index 3beaea8..693a811 100644 --- a/src/gmm/gmm_prim.c +++ b/src/gmm/gmm_prim.c @@ -541,7 +541,7 @@ gmme->tlli, OSMO_GPRS_LLC_SAPI_GMM, gmm_prim->gmmsm.unitdata_req.smpdu, gmm_prim->gmmsm.unitdata_req.smpdu_len); - llc_prim->ll.unitdata_req.radio_prio = gmme->radio_prio; + llc_prim->ll.unitdata_req.radio_prio = 1; /* highest */ /* TODO: llc_prim->ll.qos_params.*; llc_prim->ll.apply_gea; -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34020 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ie583c433547fb5ecbb6b6077c39a157961f73cfc Gerrit-Change-Number: 34020 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

9 months

1
0
0 0

[S] Change in libosmo-gprs[master]: rlcmac: Fix OSMO_GPRS_RLCMAC_GMMRR_LLC_TRANSMITTED declared in wrong ...

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34021 ) Change subject: rlcmac: Fix OSMO_GPRS_RLCMAC_GMMRR_LLC_TRANSMITTED declared in wrong offset ...................................................................... rlcmac: Fix OSMO_GPRS_RLCMAC_GMMRR_LLC_TRANSMITTED declared in wrong offset This enum should match osmo_gprs_gmm_gmmrr_prim_type, and I placed that osmocom-specific enum at the wrong place in the rlcmac counterpart. Change-Id: I3f198c756866417f8f975373f84fd3ec4da608fa --- M include/osmocom/gprs/rlcmac/rlcmac_prim.h 1 file changed, 13 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/include/osmocom/gprs/rlcmac/rlcmac_prim.h b/include/osmocom/gprs/rlcmac/rlcmac_prim.h index 70d1075..acb0d75 100644 --- a/include/osmocom/gprs/rlcmac/rlcmac_prim.h +++ b/include/osmocom/gprs/rlcmac/rlcmac_prim.h @@ -71,8 +71,8 @@ */ enum osmo_gprs_rlcmac_gmmrr_prim_type { OSMO_GPRS_RLCMAC_GMMRR_ASSIGN, /* Req: newTLLI */ - OSMO_GPRS_RLCMAC_GMMRR_LLC_TRANSMITTED, /* Ind: TLLI */ OSMO_GPRS_RLCMAC_GMMRR_PAGE, /* Ind: TLLI */ + OSMO_GPRS_RLCMAC_GMMRR_LLC_TRANSMITTED, /* Ind: TLLI */ }; extern const struct value_string osmo_gprs_rlcmac_gmmrr_prim_type_names[]; -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34021 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I3f198c756866417f8f975373f84fd3ec4da608fa Gerrit-Change-Number: 34021 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

9 months

1
0
0 0

[S] Change in libosmo-gprs[master]: llc: Log rx PDUs with invalid FCS

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34024 ) Change subject: llc: Log rx PDUs with invalid FCS ...................................................................... llc: Log rx PDUs with invalid FCS Change-Id: Ie52ced7e074a3d4451447551e1ac166397ee8a48 --- M src/llc/llc.c 1 file changed, 12 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/src/llc/llc.c b/src/llc/llc.c index cff6c16..be1ebec 100644 --- a/src/llc/llc.c +++ b/src/llc/llc.c @@ -844,8 +844,9 @@ if (~pdu_dec->flags & OSMO_GPRS_LLC_PDU_F_PROT_MODE) crc_length = OSMO_MIN(crc_length, UI_HDR_LEN + N202); if (pdu_dec->fcs != gprs_llc_fcs(ll_pdu, crc_length)) { - LOGLLE(lle, LOGL_NOTICE, "Dropping frame with invalid FCS 0x%06x vs exp 0x%06x\n", - pdu_dec->fcs, gprs_llc_fcs(ll_pdu, crc_length)); + LOGLLE(lle, LOGL_NOTICE, "Dropping frame with invalid FCS 0x%06x vs exp 0x%06x: %s\n", + pdu_dec->fcs, gprs_llc_fcs(ll_pdu, crc_length), + osmo_hexdump(ll_pdu, ll_pdu_len)); return -EIO; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34024 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ie52ced7e074a3d4451447551e1ac166397ee8a48 Gerrit-Change-Number: 34024 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

9 months

1
0
0 0

[L] Change in libosmo-netif[master]: stream: Add server-side (segmentation) support for IPA

by daniel

Attention is currently required from: arehbein, pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33197 ) Change subject: stream: Add server-side (segmentation) support for IPA ...................................................................... Patch Set 13: (1 comment) File tests/stream/stream_test.c: https://gerrit.osmocom.org/c/libosmo-netif/+/33197/comment/80b6d596_0fdb4528 PS10, Line 621: rc = clock_gettime(CLOCK_MONOTONIC, &start); > The advantage is not mixing the code testing the API with the test-code itself. […] I agree that the error handling needed for clock_gettime() is not really nice. The default handler for SIGALARM is to terminate the program so that should work without any handler installed. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33197 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I6c91ff385cb5f36ab6b6c96d0e44997995d0d24c Gerrit-Change-Number: 33197 Gerrit-PatchSet: 13 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 31 Jul 2023 16:22:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: comment

9 months

1
0
0 0

[S] Change in osmocom-bb[master]: layer23: modem: gmm: Adapt log string about no TLLI found

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34031 ) Change subject: layer23: modem: gmm: Adapt log string about no TLLI found ...................................................................... layer23: modem: gmm: Adapt log string about no TLLI found During initial GMM Attach, the GMM layer generates an internal local TLLI and uses it to do the GMM Attach. Only at the time it receives the GMM Attach Accept with the assigned TLLI from the network then explicitly informs other layers about the TLLI update. Hence, the GMMREG user doesn't really know about the TLLI in use until the GMM Attach success happens (gmmreg-attach.cnf). During that time, the TLLI at the app is basically unassigned (0xffffffff). Hence, during that same time a TLLI update hook in GMMRR-Assign.req will not work since the app is unaware of the remporary local TLLI, so no match can be done. In that specific scenario, that's fine, since anyway it is waiting to receive the GMMREG-Attach.cnf, which will indicate the assigned TLLI to it. In summary, not being able to match the TLLI in GMMRR-Assign.req is not bad per se, so soften the log error there. Change-Id: I31c04288789393391084000fbdbcdcedb11d0b68 --- M src/host/layer23/src/modem/gmm.c 1 file changed, 26 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/31/34031/1 diff --git a/src/host/layer23/src/modem/gmm.c b/src/host/layer23/src/modem/gmm.c index b8df38b..c0e6936 100644 --- a/src/host/layer23/src/modem/gmm.c +++ b/src/host/layer23/src/modem/gmm.c @@ -162,7 +162,7 @@ } } else { if (old_tlli != OSMO_GPRS_GMM_TLLI_UNASSIGNED) - LOGP(DGMM, LOGL_ERROR, "%s(): Unexpected Rx %s with unknown TLLI=0x%08x\n", + LOGP(DGMM, LOGL_NOTICE, "%s(): Rx %s with unknown TLLI=0x%08x, probably the MS is still attaching\n", __func__, pdu_name, old_tlli); } -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34031 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I31c04288789393391084000fbdbcdcedb11d0b68 Gerrit-Change-Number: 34031 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

9 months

1
0
0 0

[S] Change in libosmo-gprs[master]: llc,sndcp: Add missing hex prefix to log line printing TLLI

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34027 ) Change subject: llc,sndcp: Add missing hex prefix to log line printing TLLI ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34027 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I8d31ed7cf89555a1ec3cbd91a77cc00cc42b546f Gerrit-Change-Number: 34027 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 31 Jul 2023 16:19:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

9 months

1
0
0 0

[S] Change in libosmo-gprs[master]: rlcmac: rx pkt_uk_ack_nack: Use correct field containing UL TFI

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34026 ) Change subject: rlcmac: rx pkt_uk_ack_nack: Use correct field containing UL TFI ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34026 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: If0bbd9989413a550243a6496bce16b6eb04508db Gerrit-Change-Number: 34026 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 31 Jul 2023 16:17:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

9 months

1
0
0 0

[S] Change in libosmo-gprs[master]: llc: Silently dicard UI Dummy commands

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34025 ) Change subject: llc: Silently dicard UI Dummy commands ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34025 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I807e140b96de7140d8f6922417f3eaf0eadeed84 Gerrit-Change-Number: 34025 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 31 Jul 2023 16:16:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

9 months

1
0
0 0

[S] Change in libosmo-gprs[master]: llc: Silently dicard UI Dummy commands

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34025 ) Change subject: llc: Silently dicard UI Dummy commands ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34025 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I807e140b96de7140d8f6922417f3eaf0eadeed84 Gerrit-Change-Number: 34025 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 31 Jul 2023 16:16:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

9 months

1
0
0 0

[S] Change in libosmo-gprs[master]: llc: Log rx PDUs with invalid FCS

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34024 ) Change subject: llc: Log rx PDUs with invalid FCS ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34024 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ie52ced7e074a3d4451447551e1ac166397ee8a48 Gerrit-Change-Number: 34024 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 31 Jul 2023 16:15:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

9 months

1
0
0 0

[S] Change in libosmo-gprs[master]: rlcmac: keep looking up GRE based on old TLLI

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34023 ) Change subject: rlcmac: keep looking up GRE based on old TLLI ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34023 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I2653db3dac58342df02a1b4d0c76e69e0e8d583f Gerrit-Change-Number: 34023 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 31 Jul 2023 16:14:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

9 months

1
0
0 0

[S] Change in libosmo-gprs[master]: rlcmac: Fix OSMO_GPRS_RLCMAC_GMMRR_LLC_TRANSMITTED declared in wrong ...

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34021 ) Change subject: rlcmac: Fix OSMO_GPRS_RLCMAC_GMMRR_LLC_TRANSMITTED declared in wrong offset ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34021 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I3f198c756866417f8f975373f84fd3ec4da608fa Gerrit-Change-Number: 34021 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 31 Jul 2023 16:13:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

9 months

1
0
0 0

[S] Change in libosmo-gprs[master]: gmm: Several fixes for radio_prio

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34020 ) Change subject: gmm: Several fixes for radio_prio ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34020 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ie583c433547fb5ecbb6b6077c39a157961f73cfc Gerrit-Change-Number: 34020 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 31 Jul 2023 16:12:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

9 months

1
0
0 0

[S] Change in osmo-bsc[master]: ASCI: Fix compiler warnings in vgcs_fsm.c, found by gcc 13.1.1.20230714

by fixeria

Attention is currently required from: jolly. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34029 ) Change subject: ASCI: Fix compiler warnings in vgcs_fsm.c, found by gcc 13.1.1.20230714 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34029 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iee4cc0fbf03e7ca4b53424f7f52ed9d599f96e49 Gerrit-Change-Number: 34029 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 31 Jul 2023 16:10:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

9 months

1
0
0 0

[S] Change in osmocom-bb[master]: layer23: modem: gmm: Log allocated TLLI on Attach Success

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34030 ) Change subject: layer23: modem: gmm: Log allocated TLLI on Attach Success ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34030 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I29242873ebec173c430e6d413e6c533ec1e2b97a Gerrit-Change-Number: 34030 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 31 Jul 2023 16:06:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

9 months

1
0
0 0

[S] Change in osmocom-bb[master]: layer23: modem: Fix newline character typo in log line

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34028 ) Change subject: layer23: modem: Fix newline character typo in log line ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34028 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I3ff9b71ff469e339aadff643b582efb06d5efb6c Gerrit-Change-Number: 34028 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 31 Jul 2023 16:05:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

9 months

1
0
0 0

[S] Change in osmocom-bb[master]: layer23: modem: gmm: Log allocated TLLI on Attach Success

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34030 ) Change subject: layer23: modem: gmm: Log allocated TLLI on Attach Success ...................................................................... layer23: modem: gmm: Log allocated TLLI on Attach Success Change-Id: I29242873ebec173c430e6d413e6c533ec1e2b97a --- M src/host/layer23/src/modem/gmm.c 1 file changed, 12 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/30/34030/1 diff --git a/src/host/layer23/src/modem/gmm.c b/src/host/layer23/src/modem/gmm.c index 17cc228..b8df38b 100644 --- a/src/host/layer23/src/modem/gmm.c +++ b/src/host/layer23/src/modem/gmm.c @@ -60,8 +60,9 @@ switch (OSMO_PRIM_HDR(&gmm_prim->oph)) { case OSMO_PRIM(OSMO_GPRS_GMM_GMMREG_ATTACH, PRIM_OP_CONFIRM): if (gmm_prim->gmmreg.attach_cnf.accepted) { - LOGP(DGMM, LOGL_NOTICE, "%s(): Rx %s: Attach success P-TMSI=0x%08x\n", - __func__, pdu_name, gmm_prim->gmmreg.attach_cnf.acc.allocated_ptmsi); + LOGP(DGMM, LOGL_NOTICE, "%s(): Rx %s: Attach success P-TMSI=0x%08x TLLI=0x%08x\n", + __func__, pdu_name, gmm_prim->gmmreg.attach_cnf.acc.allocated_ptmsi, + gmm_prim->gmmreg.attach_cnf.acc.allocated_tlli); ms->subscr.gprs.ptmsi = gmm_prim->gmmreg.attach_cnf.acc.allocated_ptmsi; ms->gmmlayer.tlli = gmm_prim->gmmreg.attach_cnf.acc.allocated_tlli; app_data.modem_state = MODEM_ST_ATTACHED; -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34030 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I29242873ebec173c430e6d413e6c533ec1e2b97a Gerrit-Change-Number: 34030 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

9 months

1
0
0 0

[S] Change in osmo-bsc[master]: ASCI: Fix compiler warnings in vgcs_fsm.c, found by gcc 13.1.1.20230714

by jolly

jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34029 ) Change subject: ASCI: Fix compiler warnings in vgcs_fsm.c, found by gcc 13.1.1.20230714 ...................................................................... ASCI: Fix compiler warnings in vgcs_fsm.c, found by gcc 13.1.1.20230714 Change-Id: Iee4cc0fbf03e7ca4b53424f7f52ed9d599f96e49 --- M src/osmo-bsc/vgcs_fsm.c 1 file changed, 13 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/29/34029/1 diff --git a/src/osmo-bsc/vgcs_fsm.c b/src/osmo-bsc/vgcs_fsm.c index 6b78933..8969d4f 100644 --- a/src/osmo-bsc/vgcs_fsm.c +++ b/src/osmo-bsc/vgcs_fsm.c @@ -539,8 +539,10 @@ /* Create VGCS FSM. */ conn->vgcs_call.fi = osmo_fsm_inst_alloc(&vgcs_call_fsm, conn->network, conn, LOGL_DEBUG, NULL); - if (!conn->vgcs_call.fi) + if (!conn->vgcs_call.fi) { + cause = GSM0808_CAUSE_INCORRECT_VALUE; goto reject; + } /* Init list of cells that are used by the call. */ INIT_LLIST_HEAD(&conn->vgcs_call.chan_list); @@ -1080,7 +1082,7 @@ }; uint8_t cause; struct gsm_bts *bts; - struct gsm_lchan *lchan; + struct gsm_lchan *lchan = NULL; int rc; int i; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34029 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iee4cc0fbf03e7ca4b53424f7f52ed9d599f96e49 Gerrit-Change-Number: 34029 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-MessageType: newchange

9 months

1
0
0 0

[S] Change in osmocom-bb[master]: layer23: modem: Fix newline character typo in log line

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34028 ) Change subject: layer23: modem: Fix newline character typo in log line ...................................................................... layer23: modem: Fix newline character typo in log line Change-Id: I3ff9b71ff469e339aadff643b582efb06d5efb6c --- M src/host/layer23/src/modem/gmm.c 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/28/34028/1 diff --git a/src/host/layer23/src/modem/gmm.c b/src/host/layer23/src/modem/gmm.c index 5ea2b43..17cc228 100644 --- a/src/host/layer23/src/modem/gmm.c +++ b/src/host/layer23/src/modem/gmm.c @@ -161,7 +161,7 @@ } } else { if (old_tlli != OSMO_GPRS_GMM_TLLI_UNASSIGNED) - LOGP(DGMM, LOGL_ERROR, "%s(): Unexpected Rx %s with unknown TLLI=0x%08xn", + LOGP(DGMM, LOGL_ERROR, "%s(): Unexpected Rx %s with unknown TLLI=0x%08x\n", __func__, pdu_name, old_tlli); } -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34028 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I3ff9b71ff469e339aadff643b582efb06d5efb6c Gerrit-Change-Number: 34028 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

9 months

1
0
0 0

[S] Change in libosmo-gprs[master]: llc,sndcp: Add missing hex prefix to log line printing TLLI

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34027 to look at the new patch set (#2). Change subject: llc,sndcp: Add missing hex prefix to log line printing TLLI ...................................................................... llc,sndcp: Add missing hex prefix to log line printing TLLI Change-Id: I8d31ed7cf89555a1ec3cbd91a77cc00cc42b546f --- M src/llc/llc_llgmm.c M src/sndcp/sndcp_prim.c M tests/llc/llc_prim_test.err M tests/sndcp/sndcp_prim_test.err 4 files changed, 27 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/27/34027/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34027 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I8d31ed7cf89555a1ec3cbd91a77cc00cc42b546f Gerrit-Change-Number: 34027 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

9 months

1
0
0 0

[S] Change in libosmo-gprs[master]: llc: Add missing hex prefix to log line printing TLLI

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34027 ) Change subject: llc: Add missing hex prefix to log line printing TLLI ...................................................................... llc: Add missing hex prefix to log line printing TLLI Change-Id: I8d31ed7cf89555a1ec3cbd91a77cc00cc42b546f --- M src/llc/llc_llgmm.c 1 file changed, 11 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/27/34027/1 diff --git a/src/llc/llc_llgmm.c b/src/llc/llc_llgmm.c index 438de51..27150cc 100644 --- a/src/llc/llc_llgmm.c +++ b/src/llc/llc_llgmm.c @@ -166,7 +166,7 @@ goto ret_free; } - LOGLLME(llme, LOGL_NOTICE, "LLGM Assign pre (%08x => %08x)\n", old_tlli, new_tlli); + LOGLLME(llme, LOGL_NOTICE, "LLGM Assign pre (0x%08x => 0x%08x)\n", old_tlli, new_tlli); if (old_tlli == TLLI_UNASSIGNED && new_tlli != TLLI_UNASSIGNED) { /* TLLI Assignment 8.3.1 */ @@ -221,7 +221,7 @@ free = true; } - LOGLLME(llme, LOGL_NOTICE, "LLGM Assign post (%08x => %08x)\n", old_tlli, new_tlli); + LOGLLME(llme, LOGL_NOTICE, "LLGM Assign post (0x%08x => 0x%08x)\n", old_tlli, new_tlli); if (free) gprs_llc_llme_free(llme); -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34027 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I8d31ed7cf89555a1ec3cbd91a77cc00cc42b546f Gerrit-Change-Number: 34027 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

9 months

1
0
0 0

[S] Change in libosmo-gprs[master]: rlcmac: rx pkt_uk_ack_nack: Use correct field containing UL TFI

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34026 ) Change subject: rlcmac: rx pkt_uk_ack_nack: Use correct field containing UL TFI ...................................................................... rlcmac: rx pkt_uk_ack_nack: Use correct field containing UL TFI Change-Id: If0bbd9989413a550243a6496bce16b6eb04508db --- M src/rlcmac/rlcmac.c 1 file changed, 12 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/26/34026/1 diff --git a/src/rlcmac/rlcmac.c b/src/rlcmac/rlcmac.c index a6d0e71..212b801 100644 --- a/src/rlcmac/rlcmac.c +++ b/src/rlcmac/rlcmac.c @@ -701,13 +701,14 @@ { struct gprs_rlcmac_ul_tbf *ul_tbf; int rc; + const Packet_Uplink_Ack_Nack_t *pkt_ul_ack = &dl_block->u.Packet_Uplink_Ack_Nack; - ul_tbf = gprs_rlcmac_find_ul_tbf_by_tfi(dl_block->TFI); + ul_tbf = gprs_rlcmac_find_ul_tbf_by_tfi(pkt_ul_ack->UPLINK_TFI); if (!ul_tbf) { LOGRLCMAC(LOGL_INFO, "TS=%u FN=%u Rx Pkt UL ACK/NACK: UL_TBF TFI=%u not found\n", rlcmac_prim->l1ctl.pdch_data_ind.ts_nr, rlcmac_prim->l1ctl.pdch_data_ind.fn, - dl_block->TFI); + pkt_ul_ack->UPLINK_TFI); return -ENOENT; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34026 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: If0bbd9989413a550243a6496bce16b6eb04508db Gerrit-Change-Number: 34026 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

9 months

1
0
0 0

[S] Change in libosmo-gprs[master]: llc: Silently dicard UI Dummy commands

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34025 ) Change subject: llc: Silently dicard UI Dummy commands ...................................................................... llc: Silently dicard UI Dummy commands Change-Id: I807e140b96de7140d8f6922417f3eaf0eadeed84 --- M src/llc/llc.c 1 file changed, 23 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/25/34025/1 diff --git a/src/llc/llc.c b/src/llc/llc.c index be1ebec..dc1a7b6 100644 --- a/src/llc/llc.c +++ b/src/llc/llc.c @@ -53,6 +53,11 @@ { 0, NULL } }; +/* 3GPP TS 44.064 6.4.2.2 */ +static const uint8_t gprs_llc_ui_dummy_command[] = { + 0x43, 0xc0, 0x01, 0x2b, 0x2b, 0x2b +}; + /* Section 8.9.9 LLC layer parameter default values */ static const struct gprs_llc_params llc_default_params[NUM_SAPIS] = { [1] = { @@ -844,6 +849,15 @@ if (~pdu_dec->flags & OSMO_GPRS_LLC_PDU_F_PROT_MODE) crc_length = OSMO_MIN(crc_length, UI_HDR_LEN + N202); if (pdu_dec->fcs != gprs_llc_fcs(ll_pdu, crc_length)) { + if (ll_pdu_len >= sizeof(gprs_llc_ui_dummy_command) || + memcmp(ll_pdu, gprs_llc_ui_dummy_command, sizeof(gprs_llc_ui_dummy_command)) == 0) { + /* 6.4.2.2: "If the LLC entity at the MS receives a UI Dummy command, it shall discard + * it without any further actions" [...] + * "The format specified for the UI Dummy command ensures that a receiving LLC entity + * will always discard it, since the FCS field check always fails" "*/ + LOGLLE(lle, LOGL_DEBUG, "Dropping UI Dummy command len=%zu\n", ll_pdu_len); + return 0; + } LOGLLE(lle, LOGL_NOTICE, "Dropping frame with invalid FCS 0x%06x vs exp 0x%06x: %s\n", pdu_dec->fcs, gprs_llc_fcs(ll_pdu, crc_length), osmo_hexdump(ll_pdu, ll_pdu_len)); -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34025 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I807e140b96de7140d8f6922417f3eaf0eadeed84 Gerrit-Change-Number: 34025 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

9 months

1
0
0 0

[S] Change in libosmo-gprs[master]: rlcmac: keep looking up GRE based on old TLLI

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34023 ) Change subject: rlcmac: keep looking up GRE based on old TLLI ...................................................................... Patch Set 1: (1 comment) File src/rlcmac/rlcmac.c: https://gerrit.osmocom.org/c/libosmo-gprs/+/34023/comment/b3e25319_77c3bc99 PS1, Line 140: if (gre->tlli == tlli || gre->old_tlli == tlli) > It's probably the case but I'm wondering if calling code makes sure that tlli != GPRS_RLCMAC_TLLI_UN […] it doesn't mark snse to lookup tlli based on GPRS_RLCMAC_TLLI_UNASSIGNED, so in any case that's a separate bug in any caller which would need to be fixed. I'm not really worried by this right now tbh. -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34023 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I2653db3dac58342df02a1b4d0c76e69e0e8d583f Gerrit-Change-Number: 34023 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 31 Jul 2023 14:36:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

9 months

1
0
0 0

[M] Change in osmo-bsc[master]: osmo-bsc: Have PCU socket connection use osmo_wqueue

by pespin

Attention is currently required from: arehbein, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33891 ) Change subject: osmo-bsc: Have PCU socket connection use osmo_wqueue ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33891 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ifd9741045a87338e17eec3492590a5de9c308cb5 Gerrit-Change-Number: 33891 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 31 Jul 2023 14:34:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

9 months

1
0
0 0

[S] Change in libosmo-gprs[master]: llc: Log rx PDUs with invalid FCS

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34024 ) Change subject: llc: Log rx PDUs with invalid FCS ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34024 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ie52ced7e074a3d4451447551e1ac166397ee8a48 Gerrit-Change-Number: 34024 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 31 Jul 2023 14:32:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

9 months

1
0
0 0

[M] Change in osmo-bsc[master]: osmo-bsc: Have PCU socket connection use osmo_wqueue

by arehbein

Attention is currently required from: laforge, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/33891 to look at the new patch set (#2). Change subject: osmo-bsc: Have PCU socket connection use osmo_wqueue ...................................................................... osmo-bsc: Have PCU socket connection use osmo_wqueue Close PCU socket on write queue overflow. Related: OS#5774 Change-Id: Ifd9741045a87338e17eec3492590a5de9c308cb5 --- M include/osmocom/bsc/pcu_if.h M src/osmo-bsc/pcu_sock.c 2 files changed, 52 insertions(+), 65 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/91/33891/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33891 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ifd9741045a87338e17eec3492590a5de9c308cb5 Gerrit-Change-Number: 33891 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

9 months

1
0
0 0

[S] Change in libosmo-gprs[master]: rlcmac: keep looking up GRE based on old TLLI

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34023 ) Change subject: rlcmac: keep looking up GRE based on old TLLI ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/rlcmac/rlcmac.c: https://gerrit.osmocom.org/c/libosmo-gprs/+/34023/comment/aedb198c_4abf455f PS1, Line 140: if (gre->tlli == tlli || gre->old_tlli == tlli) It's probably the case but I'm wondering if calling code makes sure that tlli != GPRS_RLCMAC_TLLI_UNASSIGNED -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34023 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I2653db3dac58342df02a1b4d0c76e69e0e8d583f Gerrit-Change-Number: 34023 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 31 Jul 2023 14:32:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

9 months

1
0
0 0

[S] Change in libosmo-gprs[master]: rlcmac: Fix OSMO_GPRS_RLCMAC_GMMRR_LLC_TRANSMITTED declared in wrong ...

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34021 ) Change subject: rlcmac: Fix OSMO_GPRS_RLCMAC_GMMRR_LLC_TRANSMITTED declared in wrong offset ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34021 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I3f198c756866417f8f975373f84fd3ec4da608fa Gerrit-Change-Number: 34021 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 31 Jul 2023 14:27:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

9 months

1
0
0 0

[S] Change in libosmo-gprs[master]: gmm: Several fixes for radio_prio

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34020 ) Change subject: gmm: Several fixes for radio_prio ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34020 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ie583c433547fb5ecbb6b6077c39a157961f73cfc Gerrit-Change-Number: 34020 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 31 Jul 2023 14:27:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

9 months

1
0
0 0

[S] Change in libosmo-gprs[master]: llc: Log rx PDUs with invalid FCS

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34024 ) Change subject: llc: Log rx PDUs with invalid FCS ...................................................................... llc: Log rx PDUs with invalid FCS Change-Id: Ie52ced7e074a3d4451447551e1ac166397ee8a48 --- M src/llc/llc.c 1 file changed, 12 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/24/34024/1 diff --git a/src/llc/llc.c b/src/llc/llc.c index cff6c16..be1ebec 100644 --- a/src/llc/llc.c +++ b/src/llc/llc.c @@ -844,8 +844,9 @@ if (~pdu_dec->flags & OSMO_GPRS_LLC_PDU_F_PROT_MODE) crc_length = OSMO_MIN(crc_length, UI_HDR_LEN + N202); if (pdu_dec->fcs != gprs_llc_fcs(ll_pdu, crc_length)) { - LOGLLE(lle, LOGL_NOTICE, "Dropping frame with invalid FCS 0x%06x vs exp 0x%06x\n", - pdu_dec->fcs, gprs_llc_fcs(ll_pdu, crc_length)); + LOGLLE(lle, LOGL_NOTICE, "Dropping frame with invalid FCS 0x%06x vs exp 0x%06x: %s\n", + pdu_dec->fcs, gprs_llc_fcs(ll_pdu, crc_length), + osmo_hexdump(ll_pdu, ll_pdu_len)); return -EIO; } -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34024 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ie52ced7e074a3d4451447551e1ac166397ee8a48 Gerrit-Change-Number: 34024 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

9 months

1
0
0 0

[S] Change in libosmo-gprs[master]: rlcmac: keep looking up GRE based on old TLLI

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/34023 ) Change subject: rlcmac: keep looking up GRE based on old TLLI ...................................................................... rlcmac: keep looking up GRE based on old TLLI This is needed after RAU Update since the PCU may still be using the old TLLI to reference the MS for a while until it finds out about the TLLI update. Change-Id: I2653db3dac58342df02a1b4d0c76e69e0e8d583f --- M include/osmocom/gprs/rlcmac/gre.h M src/rlcmac/gre.c M src/rlcmac/rlcmac.c M src/rlcmac/rlcmac_prim.c 4 files changed, 19 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/23/34023/1 diff --git a/include/osmocom/gprs/rlcmac/gre.h b/include/osmocom/gprs/rlcmac/gre.h index a7317cd..be36e23 100644 --- a/include/osmocom/gprs/rlcmac/gre.h +++ b/include/osmocom/gprs/rlcmac/gre.h @@ -21,6 +21,7 @@ struct gprs_rlcmac_entity { struct llist_head entry; /* item in (struct gprs_rlcmac_ctx)->gre_list */ uint32_t tlli; + uint32_t old_tlli; /* Used to match paging requests coming from CS domain: */ uint32_t ptmsi; diff --git a/src/rlcmac/gre.c b/src/rlcmac/gre.c index 0eb6a8c..9102124 100644 --- a/src/rlcmac/gre.c +++ b/src/rlcmac/gre.c @@ -66,6 +66,7 @@ goto err_free_gre; gre->tlli = tlli; + gre->old_tlli = GPRS_RLCMAC_TLLI_UNASSIGNED; gre->ptmsi = GSM_RESERVED_TMSI; llist_add_tail(&gre->entry, &g_rlcmac_ctx->gre_list); diff --git a/src/rlcmac/rlcmac.c b/src/rlcmac/rlcmac.c index f35c04d..a6d0e71 100644 --- a/src/rlcmac/rlcmac.c +++ b/src/rlcmac/rlcmac.c @@ -137,7 +137,7 @@ { struct gprs_rlcmac_entity *gre; llist_for_each_entry(gre, &g_rlcmac_ctx->gre_list, entry) { - if (gre->tlli == tlli) + if (gre->tlli == tlli || gre->old_tlli == tlli) return gre; } return NULL; diff --git a/src/rlcmac/rlcmac_prim.c b/src/rlcmac/rlcmac_prim.c index f13ac3d..1ce7c9e 100644 --- a/src/rlcmac/rlcmac_prim.c +++ b/src/rlcmac/rlcmac_prim.c @@ -469,6 +469,8 @@ rc = -ENOENT; goto free_ret; } + gre->old_tlli = old_tlli; + gre->tlli = GPRS_RLCMAC_TLLI_UNASSIGNED; gprs_rlcmac_entity_free(gre); gre = NULL; goto free_ret; @@ -481,7 +483,9 @@ goto free_ret; } LOGGRE(gre, LOGL_INFO, "Update TLLI 0x%08x -> 0x%08x\n", old_tlli, new_tlli); + gre->old_tlli = old_tlli; gre->tlli = new_tlli; + } /* cache/update knowledge about this GMME's PTMSI and IMSI. It will be -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/34023 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I2653db3dac58342df02a1b4d0c76e69e0e8d583f Gerrit-Change-Number: 34023 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

9 months

1
0
0 0

[M] Change in osmo-bsc[master]: osmo-bsc (WIP): Have PCU socket connection use osmo_wqueue

by arehbein

Attention is currently required from: laforge, pespin. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/33891 ) Change subject: osmo-bsc (WIP): Have PCU socket connection use osmo_wqueue ...................................................................... Patch Set 1: (1 comment) This change is ready for review. Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/33891/comment/2b2c5606_ef2f2ab9 PS1, Line 7: WIP > see my comment in the other patch about using WIP in the commit log vs gerrit. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/33891 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ifd9741045a87338e17eec3492590a5de9c308cb5 Gerrit-Change-Number: 33891 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 31 Jul 2023 14:16:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

9 months

1
0
0 0

[S] Change in osmo-ci[master]: jobs/osmo-gsm-tester: disable

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/34022 ) Change subject: jobs/osmo-gsm-tester: disable ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I think we should at least keep _run-virtual working for now. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/34022 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I5f7468a402d82e3b6ee03b4f792ae7e3aae3942b Gerrit-Change-Number: 34022 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 31 Jul 2023 13:45:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

9 months

1
0
0 0

2024

2023

2022

gerrit-log July 2023