Attention is currently required from: laforge, pespin.
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30302 )
Change subject: rate_ctr: convert to timerfd
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS4:
> I doubt that any part of Osmocom stack is capable of working on a system so overloaded that timer sl […]
Done
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30302
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I2525fd691caa380a862d305cfcb4fa3cc50b70d0
Gerrit-Change-Number: 30302
Gerrit-PatchSet: 6
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 30 Nov 2022 19:59:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: laforge, pespin, msuraev.
Hello Jenkins Builder, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmocore/+/30302
to look at the new patch set (#6).
Change subject: rate_ctr: convert to timerfd
......................................................................
rate_ctr: convert to timerfd
Use timerfd to schedule 1-second periodic timer once
instead rescheduling every second in timer callback.
Related: OS#5671
Change-Id: I2525fd691caa380a862d305cfcb4fa3cc50b70d0
---
M src/rate_ctr.c
1 file changed, 48 insertions(+), 12 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/02/30302/6
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30302
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I2525fd691caa380a862d305cfcb4fa3cc50b70d0
Gerrit-Change-Number: 30302
Gerrit-PatchSet: 6
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: laforge, pespin, msuraev.
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30302 )
Change subject: rate_ctr: convert to timerfd
......................................................................
Patch Set 4:
(2 comments)
This change is ready for review.
Patchset:
PS4:
I doubt that any part of Osmocom stack is capable of working on a system so overloaded that timer slack exceed 1 second but ok.
File src/rate_ctr.c:
https://gerrit.osmocom.org/c/libosmocore/+/30302/comment/6f1b44bd_5de0855e
PS3, Line 359: timer_ticks++;
> I agree with pau. […]
Done
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30302
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I2525fd691caa380a862d305cfcb4fa3cc50b70d0
Gerrit-Change-Number: 30302
Gerrit-PatchSet: 4
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 30 Nov 2022 19:57:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de>
Gerrit-MessageType: comment