January 2023 - gerrit-log - lists.osmocom.org

Change in osmo-msc[master]: LCLS: Fix Global Call Reference generation

by fixeria

Attention is currently required from: keith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/31131 ) Change subject: LCLS: Fix Global Call Reference generation ...................................................................... Patch Set 1: (2 comments) File src/libmsc/transaction.c: https://gerrit.osmocom.org/c/osmo-msc/+/31131/comment/5d49ac94_b0fba89b PS1, Line 165: 0x%x 0x04x to ensure consistent formatting https://gerrit.osmocom.org/c/osmo-msc/+/31131/comment/fba7f7fd_f4fed6af PS1, Line 165: %sfor missing space between '%s' and 'for' -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31131 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9c33a89c819e8925d89ca833d7705ed5ced6b566 Gerrit-Change-Number: 31131 Gerrit-PatchSet: 1 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Comment-Date: Tue, 31 Jan 2023 21:04:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

Change in pysim[master]: filesystem: add unit tests for encoder/decoder methods

by fixeria

Attention is currently required from: laforge, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/24012 ) Change subject: filesystem: add unit tests for encoder/decoder methods ...................................................................... Patch Set 12: Code-Review+1 (3 comments) Patchset: PS12: Looks good now! File tests/test_files.py: https://gerrit.osmocom.org/c/pysim/+/24012/comment/0038742d_bb179b05 PS12, Line 56: debug("Testing decode of %s" % name) Not really critical (for tests), just a tip: documentation of the Python's logging framework recommends using lazy format-string composition instead of manual composition in-place. This can be achieved by passing format string arguments as arguments of the logging functions: logging.debug("Testing decode of %s", name) The idea is that the format string is evaluated only if it's actually going to be printed. https://gerrit.osmocom.org/c/pysim/+/24012/comment/e42616b2_906e0d07 PS12, Line 160: for c in classes: Can be done a bit simpler: return filter(lambda c: c not in trans_rec_classes, classes) Also, you can make it a class variable, so there would be no need to call get_classes() every time. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/24012 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I02d884547f4982e0b8ed7ef21b8cda75237942e2 Gerrit-Change-Number: 24012 Gerrit-PatchSet: 12 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Falkenber9 <robert.falkenberg(a)tu-dortmund.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Jan 2023 20:44:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

Change in pysim[master]: filesystem: add unit tests for encoder/decoder methods

by laforge

Attention is currently required from: fixeria, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/24012 ) Change subject: filesystem: add unit tests for encoder/decoder methods ...................................................................... Patch Set 12: (2 comments) Patchset: PS8: > I'm going to try to resurrect this after not receiving any updates for a very long time Done File pySim/filesystem.py: https://gerrit.osmocom.org/c/pysim/+/24012/comment/9f6646ad_11a7f2d5 PS1, Line 383: file. To run this, simply define a _encode_decode_testvector[] testvector > Mix of tabs and spaces, please do s/\t/ /g. Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/24012 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I02d884547f4982e0b8ed7ef21b8cda75237942e2 Gerrit-Change-Number: 24012 Gerrit-PatchSet: 12 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Falkenber9 <robert.falkenberg(a)tu-dortmund.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Jan 2023 20:29:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

Change in pysim[master]: ts_51_011: Fix decoding/encoding of EF_LOCIGPRS

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/31125 ) Change subject: ts_51_011: Fix decoding/encoding of EF_LOCIGPRS ...................................................................... ts_51_011: Fix decoding/encoding of EF_LOCIGPRS The P-TMSI signature is a 3-byte value, not a 1-byte value. Change-Id: I06e8d3efe0b3cf3970159c913acfd2f72280302d --- M pySim/ts_51_011.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/pySim/ts_51_011.py b/pySim/ts_51_011.py index 4d819dd..80182af 100644 --- a/pySim/ts_51_011.py +++ b/pySim/ts_51_011.py @@ -824,7 +824,8 @@ class EF_LOCIGPRS(TransparentEF): def __init__(self, fid='6f53', sfid=None, name='EF.LOCIGPRS', desc='GPRS Location Information', size=(14, 14)): super().__init__(fid, sfid=sfid, name=name, desc=desc, size=size) - self._construct = Struct('ptmsi'/HexAdapter(Bytes(4)), 'ptmsi_sig'/Int8ub, 'rai'/HexAdapter(Bytes(6)), + self._construct = Struct('ptmsi'/HexAdapter(Bytes(4)), 'ptmsi_sig'/HexAdapter(Bytes(3)), + 'rai'/HexAdapter(Bytes(6)), 'rau_status'/Enum(Byte, updated=0, not_updated=1, plmn_not_allowed=2, routing_area_not_allowed=3)) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31125 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I06e8d3efe0b3cf3970159c913acfd2f72280302d Gerrit-Change-Number: 31125 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 2 months

1
0
0 0

Change in pysim[master]: ts_31_102: Fix several bugs in EF_ECC encoder

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/31123 ) Change subject: ts_31_102: Fix several bugs in EF_ECC encoder ...................................................................... ts_31_102: Fix several bugs in EF_ECC encoder The encoder function apparently was never tested, it didn't match at all the output of the decoder, not even in terms of the string keys of the dict. Change-Id: Id67bc39d52c4dfb39dc7756d8041cbd552ccbbc4 --- M pySim/ts_31_102.py 1 file changed, 6 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/pySim/ts_31_102.py b/pySim/ts_31_102.py index 4d1c3dc..4125f4a 100644 --- a/pySim/ts_31_102.py +++ b/pySim/ts_31_102.py @@ -622,9 +622,12 @@ if in_json is None: return b'\xff\xff\xff\xff' code = EF_ECC.cc_construct.build(in_json['call_code']) - svc_category = EF_ECC.category_construct.build(in_json['category']) - alpha_id = EF_ECC.alpha_construct.build(in_json['alpha_id']) - # FIXME: alpha_id needs padding up to 'record_length - 4' + svc_category = EF_ECC.category_construct.build(in_json['service_category']) + if 'alpha_id' in in_json: + alpha_id = EF_ECC.alpha_construct.build(in_json['alpha_id']) + # FIXME: alpha_id needs padding up to 'record_length - 4' + else: + alpha_id = b'' return code + alpha_id + svc_category -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31123 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id67bc39d52c4dfb39dc7756d8041cbd552ccbbc4 Gerrit-Change-Number: 31123 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 2 months

1
0
0 0

Change in pysim[master]: ts_51_011: EF_SMSP: Use integer division in ValidityPeriodAdapter

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/31121 ) Change subject: ts_51_011: EF_SMSP: Use integer division in ValidityPeriodAdapter ...................................................................... ts_51_011: EF_SMSP: Use integer division in ValidityPeriodAdapter ValidityPeriodAdapter() must return integer values when encoding a value, as only integer values can be expressed in the binary format. Change-Id: I0b431a591ac1761d875b5697a71b6d59241db87d --- M pySim/ts_51_011.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/pySim/ts_51_011.py b/pySim/ts_51_011.py index cd17ec8..4d819dd 100644 --- a/pySim/ts_51_011.py +++ b/pySim/ts_51_011.py @@ -435,11 +435,11 @@ if obj <= 12*60: return obj/5 - 1 elif obj <= 24*60: - return 143 + ((obj - (12 * 60)) / 30) + return 143 + ((obj - (12 * 60)) // 30) elif obj <= 30 * 24 * 60: return 166 + (obj / (24 * 60)) elif obj <= 63 * 7 * 24 * 60: - return 192 + (obj / (7 * 24 * 60)) + return 192 + (obj // (7 * 24 * 60)) else: raise ValueError -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31121 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0b431a591ac1761d875b5697a71b6d59241db87d Gerrit-Change-Number: 31121 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 2 months

1
0
0 0

Change in pysim[master]: Assume first record number if caller specifies none

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/31124 ) Change subject: Assume first record number if caller specifies none ...................................................................... Assume first record number if caller specifies none This fixes a regression introduced in Change-Id I02d6942016dd0631b21d1fd301711c13cb27962b which added support for different encoding/decoding of records by their record number. Change-Id: I0c5fd21a96d2344bfd9551f31030eba0769636bf --- M pySim/filesystem.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/pySim/filesystem.py b/pySim/filesystem.py index 6dd1db7..ce1882b 100644 --- a/pySim/filesystem.py +++ b/pySim/filesystem.py @@ -945,7 +945,7 @@ self._construct = None self._tlv = None - def decode_record_hex(self, raw_hex_data: str, record_nr: int) -> dict: + def decode_record_hex(self, raw_hex_data: str, record_nr: int = 1) -> dict: """Decode raw (hex string) data into abstract representation. A derived class would typically provide a _decode_record_bin() or _decode_record_hex() -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31124 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0c5fd21a96d2344bfd9551f31030eba0769636bf Gerrit-Change-Number: 31124 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 2 months

1
0
0 0

Change in pysim[master]: ts_51_011: Fix decoding/encoding of EF_LOCIGPRS

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/31125 ) Change subject: ts_51_011: Fix decoding/encoding of EF_LOCIGPRS ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31125 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I06e8d3efe0b3cf3970159c913acfd2f72280302d Gerrit-Change-Number: 31125 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 31 Jan 2023 20:15:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

Change in pysim[master]: Assume first record number if caller specifies none

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/31124 ) Change subject: Assume first record number if caller specifies none ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31124 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0c5fd21a96d2344bfd9551f31030eba0769636bf Gerrit-Change-Number: 31124 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 31 Jan 2023 20:14:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

Change in pysim[master]: ts_31_102: Fix several bugs in EF_ECC encoder

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/31123 ) Change subject: ts_31_102: Fix several bugs in EF_ECC encoder ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31123 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id67bc39d52c4dfb39dc7756d8041cbd552ccbbc4 Gerrit-Change-Number: 31123 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 31 Jan 2023 20:14:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

Change in pysim[master]: ts_51_011: EF_SMSP: Use integer division in ValidityPeriodAdapter

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/31121 ) Change subject: ts_51_011: EF_SMSP: Use integer division in ValidityPeriodAdapter ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31121 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0b431a591ac1761d875b5697a71b6d59241db87d Gerrit-Change-Number: 31121 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 31 Jan 2023 20:13:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

Change in osmo-pcu[master]: pcu_l1_if: ignore frame numbers that exceed the valid range

by fixeria

Attention is currently required from: dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31023 ) Change subject: pcu_l1_if: ignore frame numbers that exceed the valid range ...................................................................... Patch Set 4: (2 comments) File src/pcu_l1_if.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/31023/comment/9a410f03_8a06b554 PS1, Line 628: ", > missing \n Done https://gerrit.osmocom.org/c/osmo-pcu/+/31023/comment/d16ae29e_339b9deb PS1, Line 628: %d > %u Done -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31023 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ib0cf1738be07733c95fc6c459a8a7c4cb2eeef26 Gerrit-Change-Number: 31023 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Jan 2023 20:11:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

Change in osmo-bsc[master]: timeslot_fsm: Warn in case Ercisson RBS uses static PDCH

by fixeria

Attention is currently required from: dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31112 ) Change subject: timeslot_fsm: Warn in case Ercisson RBS uses static PDCH ...................................................................... Patch Set 4: (1 comment) File src/osmo-bsc/bts_trx.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31112/comment/6dcfbddf_ae587c8b PS4, Line 339: does A space is missing, the user will see 'doesnot' in logging. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31112 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icc7c2956fc934691e3bfacb283d896a8767baf27 Gerrit-Change-Number: 31112 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Jan 2023 20:10:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

Change in osmo-msc[master]: LCLS: Fix Global Call Reference generation

by laforge

Attention is currently required from: fixeria, keith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/31131 ) Change subject: LCLS: Fix Global Call Reference generation ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31131 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9c33a89c819e8925d89ca833d7705ed5ced6b566 Gerrit-Change-Number: 31131 Gerrit-PatchSet: 1 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Comment-Date: Tue, 31 Jan 2023 20:02:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

Change in pysim[master]: filesystem: add unit tests for encoder/decoder methods

by laforge

Attention is currently required from: fixeria, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/24012 ) Change subject: filesystem: add unit tests for encoder/decoder methods ...................................................................... Patch Set 12: (8 comments) File pySim/ts_31_102.py: https://gerrit.osmocom.org/c/pysim/+/24012/comment/8306d6c9_6f6f420b PS4, Line 294: _encode_decode_testvector = ['{"prot_scheme_id_list": [{"priority": 0, "identifier": 2, "key_index": 1}, {"priority": 1, "identifier": 1, "key_index": 2}, {"priority": 2, "identifier": 0, "key_index": 0}], "hnet_pubkey_list": [{"hnet_pubkey_identifier": 27, "hnet_pubkey": "0272da71976234ce833a6907425867b82e074d44ef907dfb4b3e21c1c2256ebcd1"}, {"hnet_pubkey_identifier": 30, "hnet_pubkey": "5a8d38864820197c3394b92613b20b91633cbd897119273bf8e4a6f4eec0a650"}]}'] > > I agree that this line is not easy to read but you can copy+paste it into pySim-shell and it will […] I went for python notation and not json/string, after all. File pySim/ts_31_103.py: https://gerrit.osmocom.org/c/pysim/+/24012/comment/622848fe_430bacb9 PS4, Line 121: '{"addr": "hello,world", "addr_type": "00"}'] > mixing tabs and spaces, let's avoid this Done File pySim/ts_51_011.py: https://gerrit.osmocom.org/c/pysim/+/24012/comment/512a1cad_6cc2c6f1 PS4, Line 380: '{"msisdn": [1, 3, "123456"]}'] > mixing tabs and spaces, let's avoid this Done https://gerrit.osmocom.org/c/pysim/+/24012/comment/e94016e8_40f2a18c PS4, Line 471: '{"imsi": "123456789012345"}'] > same here and below Done File tests/test_files.py: https://gerrit.osmocom.org/c/pysim/+/24012/comment/7b14c796_b793f241 PS4, Line 57: for testvec_json in ef.__class__._encode_decode_testvector: > The problem without subTest is that it simply stops a the first assert and doesn't continue to check […] Done https://gerrit.osmocom.org/c/pysim/+/24012/comment/581c3dc7_ef50436c PS4, Line 71: testcase.assertEqual(testvec_json, decoded_json) > In my opinion matching the strings is the best way possible. […] Done https://gerrit.osmocom.org/c/pysim/+/24012/comment/bf84e410_a9d10118 PS4, Line 94: for obj in gc.get_objects(): > we already have utils.py:all_subclasses() for getting that recursive list. Done https://gerrit.osmocom.org/c/pysim/+/24012/comment/d0d6d5f7_2a3b908d PS4, Line 96: if not file_in_list(test_candidates, obj.name): > Ack Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/24012 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I02d884547f4982e0b8ed7ef21b8cda75237942e2 Gerrit-Change-Number: 24012 Gerrit-PatchSet: 12 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Falkenber9 <robert.falkenberg(a)tu-dortmund.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Jan 2023 19:59:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

Change in osmo-msc[master]: LCLS: Fix Global Call Reference generation

by keith

keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/31131 ) Change subject: LCLS: Fix Global Call Reference generation ...................................................................... LCLS: Fix Global Call Reference generation According to 3gpp spec the Call Reference part of GCR is 5 octets, 3 octets Call ID followed by 2 octets BSS ID. We are using our internal call reference (4 octets) and the location area code, or optionally Cell ID as BSS ID (2 octets). Obviously it does not fit. Let's use only 3 octets from the call reference, dropping the MSB. Includes code by Vadim Yanitskiy <vyanitskiy(a)sysmocom.de> Change-Id: I9c33a89c819e8925d89ca833d7705ed5ced6b566 --- M src/libmsc/transaction.c 1 file changed, 10 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/31/31131/1 diff --git a/src/libmsc/transaction.c b/src/libmsc/transaction.c index 25c0e3c..34adce3 100644 --- a/src/libmsc/transaction.c +++ b/src/libmsc/transaction.c @@ -153,11 +153,17 @@ /* net id from Q.1902.3 3-5 bytes, this function gives 3 bytes exactly */ osmo_plmn_to_bcd(lcls->gcr.net, &trans->net->plmn); - osmo_store32be(trans->callref, lcls->gcr.cr); - osmo_store16be(use_lac ? trans->msc_a->via_cell.lai.lac : trans->msc_a->via_cell.cell_identity, lcls->gcr.cr + 3); - LOGP(DCC, LOGL_INFO, "LCLS: allocated %s-based CR-ID %s\n", use_lac ? "LAC" : "CI", - osmo_hexdump(lcls->gcr.cr, 5)); + /* TS 29.205 Table B.2.1.9.2 Call Reference ID + * 3 octets Call ID + 2 octets BSS ID + */ + lcls->gcr.cr[2] = (trans->callref >> 0) & 0xff; + lcls->gcr.cr[1] = (trans->callref >> 8) & 0xff; + lcls->gcr.cr[0] = (trans->callref >> 16) & 0xff; + osmo_store16be(use_lac ? trans->msc_a->via_cell.lai.lac : trans->msc_a->via_cell.cell_identity, &lcls->gcr.cr[3]); + + LOGP(DCC, LOGL_INFO, "LCLS: allocated %s-based CR-ID %sfor callref 0x%x\n", use_lac ? "LAC" : "CI", + osmo_hexdump(lcls->gcr.cr, 5), trans->callref); lcls->config = GSM0808_LCLS_CFG_BOTH_WAY; lcls->control = GSM0808_LCLS_CSC_CONNECT; -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31131 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9c33a89c819e8925d89ca833d7705ed5ced6b566 Gerrit-Change-Number: 31131 Gerrit-PatchSet: 1 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-MessageType: newchange

1 year, 2 months

1
0
0 0

Change in libosmo-gprs[master]: WIP: rlcmac: Rearrange csn1 related definitions

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31130 ) Change subject: WIP: rlcmac: Rearrange csn1 related definitions ...................................................................... WIP: rlcmac: Rearrange csn1 related definitions This patch contains several changes trying to isolate and enclose all the CSN1 data structure big amount of churn, to avoid annoying readers not interested in that part of the code (most of the time). * osmo_gprs_rlcmac_encode/decode* APIs are kept private (gprs_rlmac_*) * Related tests now link againt .a instead of .la to access the private symbols. * All CSN1 content is split into 2 parts: ** csn1_defs: Contain the data types and definitions used by the CSN1 encoder/decoder ** csn1_encdec: Contain the functions and related code calling the CSN1 encoder/decoder Hence, gprs_rlcmac.h is split into csn1_defs.h and csn1_encdec.h, and most of the content of ts_*.c is moved to csn1_defs_ts_*.c and csn1_encdec_ts_*.c. Only CSN1-agnostic content (like enums and value_strings) are kept in ts_*.c files, and defined in types.h. TODO: lots of CSN_DESCR need to have its "static" removed and CSN_DESCR_EXTERN() added to csn1_defs.h or csn1_encdec.h. Change-Id: I7f48c1f40581c7689b280c0881d88c4900d56a10 --- M debian/copyright M include/osmocom/gprs/rlcmac/Makefile.am R include/osmocom/gprs/rlcmac/csn1_defs.h A include/osmocom/gprs/rlcmac/csn1_encdec.h M include/osmocom/gprs/rlcmac/rlcmac_enc.h M include/osmocom/gprs/rlcmac/types.h M src/rlcmac/Makefile.am R src/rlcmac/csn1_defs_ts_24_008.c R src/rlcmac/csn1_defs_ts_44_018.c A src/rlcmac/csn1_defs_ts_44_060.c A src/rlcmac/csn1_encdec_ts_24_008.c A src/rlcmac/csn1_encdec_ts_44_018.c A src/rlcmac/csn1_encdec_ts_44_060.c M src/rlcmac/rlcmac_enc.c M src/rlcmac/tbf_ul.c M src/rlcmac/tbf_ul_ass_fsm.c M src/rlcmac/ts_44_060.c M tests/rlcmac/Makefile.am M tests/rlcmac/ts_44_018_test.c M tests/rlcmac/ts_44_018_test.ok M tests/rlcmac/ts_44_060_test.c M tests/rlcmac/ts_44_060_test.ok 22 files changed, 5,572 insertions(+), 5,412 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/30/31130/1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31130 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I7f48c1f40581c7689b280c0881d88c4900d56a10 Gerrit-Change-Number: 31130 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 2 months

1
0
0 0

Change in libosmo-gprs[master]: rlcmac: Initial implementation of UL TBF assignment and scheduler

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31099 ) Change subject: rlcmac: Initial implementation of UL TBF assignment and scheduler ...................................................................... Patch Set 5: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31099 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I420c57a9d0b63f9c2805a7c2ae8ce85532a48eef Gerrit-Change-Number: 31099 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Tue, 31 Jan 2023 17:39:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

Change in osmo-bsc[master]: pcu_sock: fix endianess when populating gsm_pcu_if_info_ind

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31129 ) Change subject: pcu_sock: fix endianess when populating gsm_pcu_if_info_ind ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31129 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib62dcceb80fd500e477dd5e1a0e43de47e16eeb0 Gerrit-Change-Number: 31129 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Jan 2023 17:39:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

Change in osmo-bsc[master]: abis_rsl: constify parameters of rsl_X_imm_assign_cmd

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31128 ) Change subject: abis_rsl: constify parameters of rsl_X_imm_assign_cmd ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31128 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1bd2e0c844bf273d2c4381eec9e9bb9562254873 Gerrit-Change-Number: 31128 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Jan 2023 17:38:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

Change in osmo-bsc[master]: pcu_sock: fix endianess when populating gsm_pcu_if_info_ind

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31129 ) Change subject: pcu_sock: fix endianess when populating gsm_pcu_if_info_ind ...................................................................... pcu_sock: fix endianess when populating gsm_pcu_if_info_ind The intended endienaess for the remote_port member is host byte order, while the endianess in the nsvc struct is in network byte order. (see also pcu_sock.c in osmo-bts.git) Change-Id: Ib62dcceb80fd500e477dd5e1a0e43de47e16eeb0 Related: OS#5198 --- M src/osmo-bsc/pcu_sock.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/29/31129/1 diff --git a/src/osmo-bsc/pcu_sock.c b/src/osmo-bsc/pcu_sock.c index e9bd7ad..f665f91 100644 --- a/src/osmo-bsc/pcu_sock.c +++ b/src/osmo-bsc/pcu_sock.c @@ -263,14 +263,14 @@ case AF_INET: info_ind->address_type[i] = PCU_IF_ADDR_TYPE_IPV4; info_ind->remote_ip[i].v4 = nsvc->remote.u.sin.sin_addr; - info_ind->remote_port[i] = nsvc->remote.u.sin.sin_port; + info_ind->remote_port[i] = ntohs(nsvc->remote.u.sin.sin_port); break; case AF_INET6: info_ind->address_type[i] = PCU_IF_ADDR_TYPE_IPV6; memcpy(&info_ind->remote_ip[i].v6, &nsvc->remote.u.sin6.sin6_addr, sizeof(struct in6_addr)); - info_ind->remote_port[i] = nsvc->remote.u.sin6.sin6_port; + info_ind->remote_port[i] = ntohs(nsvc->remote.u.sin6.sin6_port); break; default: info_ind->address_type[i] = PCU_IF_ADDR_TYPE_UNSPEC; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31129 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib62dcceb80fd500e477dd5e1a0e43de47e16eeb0 Gerrit-Change-Number: 31129 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 2 months

1
0
0 0

Change in osmo-bsc[master]: abis_rsl: constify parameters of rsl_X_imm_assign_cmd

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31128 ) Change subject: abis_rsl: constify parameters of rsl_X_imm_assign_cmd ...................................................................... abis_rsl: constify parameters of rsl_X_imm_assign_cmd Related: OS#5198 Change-Id: I1bd2e0c844bf273d2c4381eec9e9bb9562254873 --- M include/osmocom/bsc/abis_rsl.h M src/osmo-bsc/abis_rsl.c 2 files changed, 7 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/28/31128/1 diff --git a/include/osmocom/bsc/abis_rsl.h b/include/osmocom/bsc/abis_rsl.h index 0a9cfdc..ea029e6 100644 --- a/include/osmocom/bsc/abis_rsl.h +++ b/include/osmocom/bsc/abis_rsl.h @@ -55,7 +55,7 @@ int rsl_paging_cmd(struct gsm_bts *bts, uint8_t paging_group, const struct osmo_mobile_identity *mi, uint8_t chan_needed, bool is_gprs); -int rsl_imm_assign_cmd(struct gsm_bts *bts, uint8_t len, uint8_t *val); +int rsl_imm_assign_cmd(const struct gsm_bts *bts, uint8_t len, const uint8_t *val); int rsl_tx_imm_assignment(struct gsm_lchan *lchan); int rsl_tx_imm_ass_rej(struct gsm_bts *bts, struct gsm48_req_ref *rqd_ref); int gsm48_send_rr_ass_cmd(struct gsm_lchan *dest_lchan, struct gsm_lchan *lchan, uint8_t power_command); @@ -65,7 +65,8 @@ int rsl_relase_request(struct gsm_lchan *lchan, uint8_t link_id); /* Ericcson vendor specific RSL extensions */ -int rsl_ericsson_imm_assign_cmd(struct gsm_bts *bts, uint32_t tlli, uint8_t len, uint8_t *val, uint8_t pag_grp); +int rsl_ericsson_imm_assign_cmd(const struct gsm_bts *bts, uint32_t tlli, uint8_t len, + const uint8_t *val, uint8_t pag_grp); /* Siemens vendor-specific RSL extensions */ int rsl_siemens_mrpci(struct gsm_lchan *lchan, struct rsl_mrpci *mrpci); diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index ea9fd2e..9eedfd5 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -928,7 +928,7 @@ } /* Chapter 8.5.6 */ -struct msgb *rsl_imm_assign_cmd_common(struct gsm_bts *bts, uint8_t len, uint8_t *val) +struct msgb *rsl_imm_assign_cmd_common(const struct gsm_bts *bts, uint8_t len, const uint8_t *val) { struct msgb *msg = rsl_msgb_alloc(); struct abis_rsl_dchan_hdr *dh; @@ -955,7 +955,7 @@ } /* Chapter 8.5.6 */ -int rsl_imm_assign_cmd(struct gsm_bts *bts, uint8_t len, uint8_t *val) +int rsl_imm_assign_cmd(const struct gsm_bts *bts, uint8_t len, const uint8_t *val) { struct msgb *msg = rsl_imm_assign_cmd_common(bts, len, val); if (!msg) @@ -964,7 +964,8 @@ } /* Chapter 8.5.6 Immediate Assignment Command (with Ericcson vendor specific RSL extension) */ -int rsl_ericsson_imm_assign_cmd(struct gsm_bts *bts, uint32_t tlli, uint8_t len, uint8_t *val, uint8_t pag_grp) +int rsl_ericsson_imm_assign_cmd(const struct gsm_bts *bts, uint32_t tlli, uint8_t len, + const uint8_t *val, uint8_t pag_grp) { struct msgb *msg = rsl_imm_assign_cmd_common(bts, len, val); if (!msg) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31128 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1bd2e0c844bf273d2c4381eec9e9bb9562254873 Gerrit-Change-Number: 31128 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 2 months

1
0
0 0

Change in osmo-bts[master]: pcu_sock: use ARRAY_SIZE rather then magic number

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31127 ) Change subject: pcu_sock: use ARRAY_SIZE rather then magic number ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31127 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0e016e6fff420851dfabebef5d8d43c735b968b2 Gerrit-Change-Number: 31127 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Jan 2023 17:27:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

Change in osmo-bts[master]: pcu_sock: use ARRAY_SIZE rather then magic number

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/31127 ) Change subject: pcu_sock: use ARRAY_SIZE rather then magic number ...................................................................... pcu_sock: use ARRAY_SIZE rather then magic number Lets use ARRAY_SIZE instead of magic number (8) to determine the number of timeslots to iterate. Change-Id: I0e016e6fff420851dfabebef5d8d43c735b968b2 --- M src/common/pcu_sock.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/27/31127/1 diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c index b7ec048..8f8b3af 100644 --- a/src/common/pcu_sock.c +++ b/src/common/pcu_sock.c @@ -203,7 +203,7 @@ return; } - for (tn = 0; tn < 8; tn++) { + for (tn = 0; tn < ARRAY_SIZE(trx->ts); tn++) { const struct gsm_bts_trx_ts *ts = &trx->ts[tn]; if (ts->mo.nm_state.operational != NM_OPSTATE_ENABLED) -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31127 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0e016e6fff420851dfabebef5d8d43c735b968b2 Gerrit-Change-Number: 31127 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 2 months

1
0
0 0

Change in osmo-pcu[master]: pcuif_proto: add indication to communicate E1 parameters

by dexter

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31102 ) Change subject: pcuif_proto: add indication to communicate E1 parameters ...................................................................... pcuif_proto: add indication to communicate E1 parameters osmo-pcu will also support GPRS via E1 timeslots in a BSC co-located setup. To avoid duplicate configuration the BSC has to communicate the E1 parameters (which TS, SS etc.) to the PCU. Lets add a new primitive to do that. Change-Id: Ia7928489130c1205b06bb9b10de0fb1461843301 Related: OS#5198 --- M include/osmocom/pcu/pcuif_proto.h 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/include/osmocom/pcu/pcuif_proto.h b/include/osmocom/pcu/pcuif_proto.h index fef0f88..720723e 100644 --- a/include/osmocom/pcu/pcuif_proto.h +++ b/include/osmocom/pcu/pcuif_proto.h @@ -19,6 +19,7 @@ #define PCU_IF_MSG_DATA_CNF_DT 0x11 /* confirm (with direct tlli) */ #define PCU_IF_MSG_RACH_IND 0x22 /* receive RACH */ #define PCU_IF_MSG_INFO_IND 0x32 /* retrieve BTS info */ +#define PCU_IF_MSG_E1_CCU_IND 0x33 /* retrieve E1 CCU comm. parameters */ #define PCU_IF_MSG_ACT_REQ 0x40 /* activate/deactivate PDCH */ #define PCU_IF_MSG_TIME_IND 0x52 /* GSM time indication */ #define PCU_IF_MSG_INTERF_IND 0x53 /* interference report */ @@ -257,6 +258,17 @@ } cgi_ps; } __attribute__ ((packed)); +/* E1 CCU connection parameters */ +struct gsm_pcu_if_e1_ccu_ind { + /* GSM/GPRS air interface */ + uint8_t trx_nr; + uint8_t ts_nr; + /* E1 line interface */ + uint8_t e1_nr; + uint8_t e1_ts; + uint8_t e1_ts_ss; +} __attribute__ ((packed)); + struct gsm_pcu_if { /* context based information */ uint8_t msg_type; /* message type */ @@ -273,6 +285,7 @@ struct gsm_pcu_if_rach_ind rach_ind; struct gsm_pcu_if_txt_ind txt_ind; struct gsm_pcu_if_info_ind info_ind; + struct gsm_pcu_if_e1_ccu_ind e1_ccu_ind; struct gsm_pcu_if_act_req act_req; struct gsm_pcu_if_time_ind time_ind; struct gsm_pcu_if_pag_req pag_req; 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31102 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ia7928489130c1205b06bb9b10de0fb1461843301 Gerrit-Change-Number: 31102 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 2 months

1
0
0 0

Change in pysim[master]: filesystem: add unit tests for encoder/decoder methods

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/24012 ) Change subject: filesystem: add unit tests for encoder/decoder methods ...................................................................... Patch Set 12: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/24012 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I02d884547f4982e0b8ed7ef21b8cda75237942e2 Gerrit-Change-Number: 24012 Gerrit-PatchSet: 12 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Falkenber9 <robert.falkenberg(a)tu-dortmund.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Jan 2023 16:26:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

Change in pysim[master]: ts_51_011: Fix decoding/encoding of EF_LOCIGPRS

by laforge

Attention is currently required from: laforge. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/31125 to look at the new patch set (#2). Change subject: ts_51_011: Fix decoding/encoding of EF_LOCIGPRS ...................................................................... ts_51_011: Fix decoding/encoding of EF_LOCIGPRS The P-TMSI signature is a 3-byte value, not a 1-byte value. Change-Id: I06e8d3efe0b3cf3970159c913acfd2f72280302d --- M pySim/ts_51_011.py 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/25/31125/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31125 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I06e8d3efe0b3cf3970159c913acfd2f72280302d Gerrit-Change-Number: 31125 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 year, 2 months

1
0
0 0

Change in pysim[master]: Assume first record number if caller specifies none

by laforge

Attention is currently required from: laforge. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/31124 to look at the new patch set (#2). Change subject: Assume first record number if caller specifies none ...................................................................... Assume first record number if caller specifies none This fixes a regression introduced in Change-Id I02d6942016dd0631b21d1fd301711c13cb27962b which added support for different encoding/decoding of records by their record number. Change-Id: I0c5fd21a96d2344bfd9551f31030eba0769636bf --- M pySim/filesystem.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/24/31124/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31124 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0c5fd21a96d2344bfd9551f31030eba0769636bf Gerrit-Change-Number: 31124 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 year, 2 months

1
0
0 0

Change in pysim[master]: ts_31_102: Fix several bugs in EF_ECC encoder

by laforge

Attention is currently required from: laforge. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/31123 to look at the new patch set (#2). Change subject: ts_31_102: Fix several bugs in EF_ECC encoder ...................................................................... ts_31_102: Fix several bugs in EF_ECC encoder The encoder function apparently was never tested, it didn't match at all the output of the decoder, not even in terms of the string keys of the dict. Change-Id: Id67bc39d52c4dfb39dc7756d8041cbd552ccbbc4 --- M pySim/ts_31_102.py 1 file changed, 6 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/23/31123/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31123 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id67bc39d52c4dfb39dc7756d8041cbd552ccbbc4 Gerrit-Change-Number: 31123 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

1 year, 2 months

1
0
0 0

Change in osmo-bsc[master]: pcuif_proto: add indication to communicate E1 parameters

by dexter

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31117 ) Change subject: pcuif_proto: add indication to communicate E1 parameters ...................................................................... pcuif_proto: add indication to communicate E1 parameters osmo-pcu will also support GPRS via E1 timeslots in a BSC co-located setup. To avoid duplicate configuration the BSC has to communicate the E1 parameters (which TS, SS etc.) to the PCU. Lets add a new primitive to do that. Change-Id: I3a0f6ae6b98694458230d7c0ac2c89b332cfbc92 Related: OS#5198 --- M include/osmocom/bsc/pcuif_proto.h 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/include/osmocom/bsc/pcuif_proto.h b/include/osmocom/bsc/pcuif_proto.h index fef0f88..720723e 100644 --- a/include/osmocom/bsc/pcuif_proto.h +++ b/include/osmocom/bsc/pcuif_proto.h @@ -19,6 +19,7 @@ #define PCU_IF_MSG_DATA_CNF_DT 0x11 /* confirm (with direct tlli) */ #define PCU_IF_MSG_RACH_IND 0x22 /* receive RACH */ #define PCU_IF_MSG_INFO_IND 0x32 /* retrieve BTS info */ +#define PCU_IF_MSG_E1_CCU_IND 0x33 /* retrieve E1 CCU comm. parameters */ #define PCU_IF_MSG_ACT_REQ 0x40 /* activate/deactivate PDCH */ #define PCU_IF_MSG_TIME_IND 0x52 /* GSM time indication */ #define PCU_IF_MSG_INTERF_IND 0x53 /* interference report */ @@ -257,6 +258,17 @@ } cgi_ps; } __attribute__ ((packed)); +/* E1 CCU connection parameters */ +struct gsm_pcu_if_e1_ccu_ind { + /* GSM/GPRS air interface */ + uint8_t trx_nr; + uint8_t ts_nr; + /* E1 line interface */ + uint8_t e1_nr; + uint8_t e1_ts; + uint8_t e1_ts_ss; +} __attribute__ ((packed)); + struct gsm_pcu_if { /* context based information */ uint8_t msg_type; /* message type */ @@ -273,6 +285,7 @@ struct gsm_pcu_if_rach_ind rach_ind; struct gsm_pcu_if_txt_ind txt_ind; struct gsm_pcu_if_info_ind info_ind; + struct gsm_pcu_if_e1_ccu_ind e1_ccu_ind; struct gsm_pcu_if_act_req act_req; struct gsm_pcu_if_time_ind time_ind; struct gsm_pcu_if_pag_req pag_req; 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31117 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3a0f6ae6b98694458230d7c0ac2c89b332cfbc92 Gerrit-Change-Number: 31117 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 2 months

1
0
0 0

Change in osmo-bsc[master]: abis_rsl: add ericsson specific paging group IE to rsl_ericsson_imm_a...

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31126 ) Change subject: abis_rsl: add ericsson specific paging group IE to rsl_ericsson_imm_assign_cmd ...................................................................... Patch Set 1: (1 comment) File src/osmo-bsc/pcu_sock.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31126/comment/7d0de3fb_d7e7175e PS1, Line 489: LOGP(DPCU, LOGL_DEBUG, "PCU Sends immediate assignment via PCH (tlli=0x%08x, pag_grp=0x%02x)\n", you want to say AGCH insead of PCH here right? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31126 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4452f4973d1ec69c96aad527b057226e8a6edf99 Gerrit-Change-Number: 31126 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Jan 2023 16:21:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

Change in osmo-bsc[master]: abis_rsl: add ericsson specific paging group IE to rsl_ericsson_imm_a...

by dexter

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31126 ) Change subject: abis_rsl: add ericsson specific paging group IE to rsl_ericsson_imm_assign_cmd ...................................................................... abis_rsl: add ericsson specific paging group IE to rsl_ericsson_imm_assign_cmd The immediate assign command used with ericsson BTSs supports a proprietary paging group IE, which is required for GPRS support. Change-Id: I4452f4973d1ec69c96aad527b057226e8a6edf99 Related: OS#5198 --- M include/osmocom/bsc/abis_rsl.h M src/osmo-bsc/abis_rsl.c M src/osmo-bsc/pcu_sock.c 3 files changed, 35 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/26/31126/1 diff --git a/include/osmocom/bsc/abis_rsl.h b/include/osmocom/bsc/abis_rsl.h index dcae348..0a9cfdc 100644 --- a/include/osmocom/bsc/abis_rsl.h +++ b/include/osmocom/bsc/abis_rsl.h @@ -65,7 +65,7 @@ int rsl_relase_request(struct gsm_lchan *lchan, uint8_t link_id); /* Ericcson vendor specific RSL extensions */ -int rsl_ericsson_imm_assign_cmd(struct gsm_bts *bts, uint32_t tlli, uint8_t len, uint8_t *val); +int rsl_ericsson_imm_assign_cmd(struct gsm_bts *bts, uint32_t tlli, uint8_t len, uint8_t *val, uint8_t pag_grp); /* Siemens vendor-specific RSL extensions */ int rsl_siemens_mrpci(struct gsm_lchan *lchan, struct rsl_mrpci *mrpci); diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index 6a7a900..ea9fd2e 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -964,12 +964,16 @@ } /* Chapter 8.5.6 Immediate Assignment Command (with Ericcson vendor specific RSL extension) */ -int rsl_ericsson_imm_assign_cmd(struct gsm_bts *bts, uint32_t tlli, uint8_t len, uint8_t *val) +int rsl_ericsson_imm_assign_cmd(struct gsm_bts *bts, uint32_t tlli, uint8_t len, uint8_t *val, uint8_t pag_grp) { struct msgb *msg = rsl_imm_assign_cmd_common(bts, len, val); if (!msg) return 1; + /* Append ericsson proprietary paging group IE */ + msgb_put_u8(msg, RSL_IE_ERIC_PAGING_GROUP); + msgb_put_u8(msg, pag_grp); + /* ericsson can handle a reference at the end of the message which is used in * the confirm message. The confirm message is only sent if the trailer is present */ msgb_put_u8(msg, RSL_IE_ERIC_MOBILE_ID); diff --git a/src/osmo-bsc/pcu_sock.c b/src/osmo-bsc/pcu_sock.c index def2df0..e9bd7ad 100644 --- a/src/osmo-bsc/pcu_sock.c +++ b/src/osmo-bsc/pcu_sock.c @@ -405,6 +405,27 @@ return rc; } +/* Helper function for pcu_rx_data_req() to extract paging group info */ +static uint8_t extract_paging_group(struct gsm_bts *bts, uint8_t *data) +{ + char imsi_digit_buf[4]; + uint8_t pag_grp; + + /* the first three bytes are the last three digits of + * the IMSI, which we need to compute the paging group */ + imsi_digit_buf[0] = data[0]; + imsi_digit_buf[1] = data[1]; + imsi_digit_buf[2] = data[2]; + imsi_digit_buf[3] = '\0'; + + pag_grp = gsm0502_calc_paging_group(&bts->si_common.chan_desc, + str_to_imsi(imsi_digit_buf)); + + LOGP(DPCU, LOGL_DEBUG, "Calculating paging group: imsi_digit_buf=%s ==> pag_grp=0x%02x\n", imsi_digit_buf, pag_grp); + + return pag_grp; +} + static int pcu_rx_data_req(struct gsm_bts *bts, uint8_t msg_type, struct gsm_pcu_if_data *data_req) { @@ -455,17 +476,21 @@ break; } memcpy(&tlli, data_req->data, 4); + pag_grp = extract_paging_group(bts, data_req->data + 4); - msg = msgb_alloc(data_req->len - 4, "pcu_agch"); + msg = msgb_alloc(data_req->len - 7, "pcu_agch"); if (!msg) { rc = -ENOMEM; break; } - msg->l3h = msgb_put(msg, data_req->len - 4); - memcpy(msg->l3h, data_req->data + 4, data_req->len - 4); + msg->l3h = msgb_put(msg, data_req->len - 7); + memcpy(msg->l3h, data_req->data + 7, data_req->len - 7); + + LOGP(DPCU, LOGL_DEBUG, "PCU Sends immediate assignment via PCH (tlli=0x%08x, pag_grp=0x%02x)\n", + tlli, pag_grp); if (bts->type == GSM_BTS_TYPE_RBS2000) - rc = rsl_ericsson_imm_assign_cmd(bts, tlli, msg->len, msg->data); + rc = rsl_ericsson_imm_assign_cmd(bts, tlli, msg->len, msg->data, pag_grp); else rc = rsl_imm_assign_cmd(bts, msg->len, msg->data); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31126 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4452f4973d1ec69c96aad527b057226e8a6edf99 Gerrit-Change-Number: 31126 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 2 months

1
0
0 0

Change in osmo-bsc[master]: pcu_sock: inform when no PDCH is available at all

by dexter

dexter has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31111 ) Change subject: pcu_sock: inform when no PDCH is available at all ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31111 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie3e5409cd798f6027404c0ff95297af850e516c4 Gerrit-Change-Number: 31111 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-MessageType: abandon

1 year, 2 months

1
0
0 0

Change in pysim[master]: ts_51_011: EF_SMSP: Use integer division in ValidityPeriodAdapter

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/31121 ) Change subject: ts_51_011: EF_SMSP: Use integer division in ValidityPeriodAdapter ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31121 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0b431a591ac1761d875b5697a71b6d59241db87d Gerrit-Change-Number: 31121 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 31 Jan 2023 16:12:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

Change in pysim[master]: ts_51_011: Fix decoding/encoding of EF_LOCIGPRS

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/31125 ) Change subject: ts_51_011: Fix decoding/encoding of EF_LOCIGPRS ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31125 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I06e8d3efe0b3cf3970159c913acfd2f72280302d Gerrit-Change-Number: 31125 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 31 Jan 2023 16:09:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

Change in pysim[master]: Assume first record number if caller specifies none

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/31124 ) Change subject: Assume first record number if caller specifies none ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31124 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0c5fd21a96d2344bfd9551f31030eba0769636bf Gerrit-Change-Number: 31124 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 31 Jan 2023 16:09:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

Change in pysim[master]: ts_31_102: Fix several bugs in EF_ECC encoder

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/31123 ) Change subject: ts_31_102: Fix several bugs in EF_ECC encoder ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31123 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id67bc39d52c4dfb39dc7756d8041cbd552ccbbc4 Gerrit-Change-Number: 31123 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 31 Jan 2023 16:08:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

Change in osmo-bsc[master]: pcuif_proto: add indication to communicate E1 parameters

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31117 ) Change subject: pcuif_proto: add indication to communicate E1 parameters ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31117 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3a0f6ae6b98694458230d7c0ac2c89b332cfbc92 Gerrit-Change-Number: 31117 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Jan 2023 16:07:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

Change in osmo-pcu[master]: pcuif_proto: add indication to communicate E1 parameters

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31102 ) Change subject: pcuif_proto: add indication to communicate E1 parameters ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31102 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ia7928489130c1205b06bb9b10de0fb1461843301 Gerrit-Change-Number: 31102 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Jan 2023 16:07:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

Change in osmo-pcu[master]: pcu_l1_if: ignore frame numbers that exceed the valid range

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31023 ) Change subject: pcu_l1_if: ignore frame numbers that exceed the valid range ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31023 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ib0cf1738be07733c95fc6c459a8a7c4cb2eeef26 Gerrit-Change-Number: 31023 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Jan 2023 16:06:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

Change in osmo-bsc[master]: timeslot_fsm: Warn in case Ercisson RBS uses static PDCH

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31112 ) Change subject: timeslot_fsm: Warn in case Ercisson RBS uses static PDCH ...................................................................... timeslot_fsm: Warn in case Ercisson RBS uses static PDCH The Ericsson RBS is a BTS that natively works with dynamic timeslots. This colides with the current understanding of static PDCH channels because the BTSs we support so far get thier static PDCH information on startup and then handle everything related internally. The BSC does not actively manage the channel in those cases. In the case of Ericsson we have to activate the PDCH via RSL like any other channel and the timeslot FSM has to manage it. Lets not add work arouds for this, lets just print and error message and use the BTS in the dynamic scheme as intended by the manufacturer. Change-Id: Icc7c2956fc934691e3bfacb283d896a8767baf27 Related: OS#5198 --- M src/osmo-bsc/bts_trx.c 1 file changed, 17 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/osmo-bsc/bts_trx.c b/src/osmo-bsc/bts_trx.c index 1348e74..49702d0 100644 --- a/src/osmo-bsc/bts_trx.c +++ b/src/osmo-bsc/bts_trx.c @@ -326,6 +326,23 @@ } break; + case GSM_PCHAN_PDCH: + if (is_ericsson_bts(trx->bts)) { + /* NOTE: A static PDCH is usually handled by the BTS/PCU internally, the BSC + * will not actively manage this channel. It will just keep the timeslot + * unused so that it is free for the BTS/PCU to use it as PDCH. Not all BTSs + * work well in this scheme. Ericsson RBS BTSs support dynamic channels natively + * and require a channel activation on RSL level before the PDCH can be used. + * One could work around this by activating the PDCH once on startup and + * leave it on indefinetly but we decided not to do so. Users of Ericsson RBS + * BTSs must configure a dynamic PDCH channel. */ + LOGP(DNM, LOGL_ERROR, "%s is not allowed, because Ericsson RBS does" + "not support static PDCH (use TCH/F_TCH/H_SDCCH8_PDCH)\n", + gsm_pchan_name(ts->pchan_from_config)); + result = false; + } + break; + default: /* CCCH on TS0 is mandatory for C0 */ if (trx->bts->c0 == trx && i == 0) { -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31112 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icc7c2956fc934691e3bfacb283d896a8767baf27 Gerrit-Change-Number: 31112 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 2 months

1
0
0 0

Change in osmo-bsc[master]: timeslot_fsm: Warn in case Ercisson RBS uses static PDCH

by laforge

Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31112 ) Change subject: timeslot_fsm: Warn in case Ercisson RBS uses static PDCH ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31112 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icc7c2956fc934691e3bfacb283d896a8767baf27 Gerrit-Change-Number: 31112 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Jan 2023 16:05:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

Change in osmo-bsc[master]: pcu_sock: inform when no PDCH is available at all

by laforge

Attention is currently required from: pespin, fixeria, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31111 ) Change subject: pcu_sock: inform when no PDCH is available at all ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > You will still trigger that for a multi-trx BTS which has TRX used only for CS, which is totally fin […] agreed. In multi-trx it is indeed confusing if you see such messages. it is pretty normal to have some TRX reserved entirely for circuit switched channels without any PDCH. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31111 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie3e5409cd798f6027404c0ff95297af850e516c4 Gerrit-Change-Number: 31111 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Jan 2023 16:04:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

Change in osmo-bsc[master]: pcu_sock: rework check logic for ts

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30876 ) Change subject: pcu_sock: rework check logic for ts ...................................................................... pcu_sock: rework check logic for ts Before filling in the TS in the info indication, it is checked that the MO opstate is enabled. Also it is checked that the TS serves a PDCH. Lets restructure this check and move the PDCH check into a helper function as we need to check for PDCH from other location as well later. Change-Id: Icaab52ab73c38889dfadb523b89bb54cafacc99a Related: OS#5198 --- M src/osmo-bsc/pcu_sock.c 1 file changed, 17 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/src/osmo-bsc/pcu_sock.c b/src/osmo-bsc/pcu_sock.c index b778cbd..def2df0 100644 --- a/src/osmo-bsc/pcu_sock.c +++ b/src/osmo-bsc/pcu_sock.c @@ -92,6 +92,20 @@ return msg; } +/* Check if the timeslot can be utilized as PDCH now + * (PDCH is currently active on BTS) */ +static bool ts_now_usable_as_pdch(const struct gsm_bts_trx_ts *ts) +{ + switch (ts->pchan_is) { + case GSM_PCHAN_PDCH: + /* NOTE: We currently only support Ericsson RBS as a BSC + * co-located BTS. This BTS only supports dynamic channels. */ + return true; + default: + return false; + } +} + /* Fill the frequency hopping parameter */ static void info_ind_fill_fhp(struct gsm_pcu_if_info_trx_ts *ts_info, const struct gsm_bts_trx_ts *ts) @@ -124,8 +138,9 @@ for (tn = 0; tn < ARRAY_SIZE(trx->ts); tn++) { ts = &trx->ts[tn]; - if (ts->mo.nm_state.operational != NM_OPSTATE_ENABLED || - ts->pchan_is != GSM_PCHAN_PDCH) + if (ts->mo.nm_state.operational != NM_OPSTATE_ENABLED) + continue; + if (!ts_now_usable_as_pdch(ts)) continue; trx_info->pdch_mask |= (1 << tn); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30876 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icaab52ab73c38889dfadb523b89bb54cafacc99a Gerrit-Change-Number: 30876 Gerrit-PatchSet: 8 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 2 months

1
0
0 0

Change in osmo-bsc[master]: pcu_sock: rework check logic for ts

by laforge

Attention is currently required from: pespin, fixeria, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30876 ) Change subject: pcu_sock: rework check logic for ts ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30876 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icaab52ab73c38889dfadb523b89bb54cafacc99a Gerrit-Change-Number: 30876 Gerrit-PatchSet: 8 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Jan 2023 16:02:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

Change in pysim[master]: gsm_r: EF_IC: Network String Table Index is 16bit, not 8bit

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/31122 ) Change subject: gsm_r: EF_IC: Network String Table Index is 16bit, not 8bit ...................................................................... gsm_r: EF_IC: Network String Table Index is 16bit, not 8bit As per EIRENE GSM-R SIM-Card FFFIS, EF_IC conatains records of 1+2+2+2 bytes, the network string table index is 16bit and not 8bit as we implemented so far. Change-Id: I9e3d4a48b3cb6fb0ecf887b04c308e903a99f547 --- M pySim/gsm_r.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved; Verified diff --git a/pySim/gsm_r.py b/pySim/gsm_r.py index edb5193..78c9ad9 100644 --- a/pySim/gsm_r.py +++ b/pySim/gsm_r.py @@ -211,7 +211,7 @@ self._construct = Struct('next_table_type'/NextTableType, 'id_of_next_table'/HexAdapter(Bytes(2)), 'ic_decision_value'/BcdAdapter(Bytes(2)), - 'network_string_table_index'/Int8ub) + 'network_string_table_index'/Int16ub) class EF_NW(LinFixedEF): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31122 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9e3d4a48b3cb6fb0ecf887b04c308e903a99f547 Gerrit-Change-Number: 31122 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 year, 2 months

1
0
0 0

Change in pysim[master]: gsm_r: EF_IC: Network String Table Index is 16bit, not 8bit

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/31122 ) Change subject: gsm_r: EF_IC: Network String Table Index is 16bit, not 8bit ...................................................................... Patch Set 3: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31122 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9e3d4a48b3cb6fb0ecf887b04c308e903a99f547 Gerrit-Change-Number: 31122 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 31 Jan 2023 16:00:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

Change in pysim[master]: gsm_r: EF_IC: Network String Table Index is 16bit, not 8bit

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/31122 ) Change subject: gsm_r: EF_IC: Network String Table Index is 16bit, not 8bit ...................................................................... Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31122 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9e3d4a48b3cb6fb0ecf887b04c308e903a99f547 Gerrit-Change-Number: 31122 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 31 Jan 2023 16:00:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

Change in pysim[master]: gsm_r: EF_IC: Network String Table Index is 16bit, not 8bit

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/31122 ) Change subject: gsm_r: EF_IC: Network String Table Index is 16bit, not 8bit ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31122 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9e3d4a48b3cb6fb0ecf887b04c308e903a99f547 Gerrit-Change-Number: 31122 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 31 Jan 2023 16:00:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 2 months

1
0
0 0

Change in pysim[master]: gsm_r: EF_IC: Network String Table Index is 16bit, not 8bit

by laforge

laforge has removed a vote from this change. ( https://gerrit.osmocom.org/c/pysim/+/31122 ) Change subject: gsm_r: EF_IC: Network String Table Index is 16bit, not 8bit ...................................................................... Removed Code-Review+2 by laforge <laforge(a)osmocom.org> -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31122 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9e3d4a48b3cb6fb0ecf887b04c308e903a99f547 Gerrit-Change-Number: 31122 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: deleteVote

1 year, 2 months

1
0
0 0

2024

2023

2022

gerrit-log January 2023