lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

January 2023

  • 1 participants
  • 2205 discussions
Change in osmo-bsc[master]: abis_rsl: constify parameters of rsl_X_imm_assign_cmd
by pespin 31 Jan '23

31 Jan '23
Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31128 ) Change subject: abis_rsl: constify parameters of rsl_X_imm_assign_cmd ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31128 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1bd2e0c844bf273d2c4381eec9e9bb9562254873 Gerrit-Change-Number: 31128 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Jan 2023 17:38:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
Change in osmo-bsc[master]: pcu_sock: fix endianess when populating gsm_pcu_if_info_ind
by dexter 31 Jan '23

31 Jan '23
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31129 ) Change subject: pcu_sock: fix endianess when populating gsm_pcu_if_info_ind ...................................................................... pcu_sock: fix endianess when populating gsm_pcu_if_info_ind The intended endienaess for the remote_port member is host byte order, while the endianess in the nsvc struct is in network byte order. (see also pcu_sock.c in osmo-bts.git) Change-Id: Ib62dcceb80fd500e477dd5e1a0e43de47e16eeb0 Related: OS#5198 --- M src/osmo-bsc/pcu_sock.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/29/31129/1 diff --git a/src/osmo-bsc/pcu_sock.c b/src/osmo-bsc/pcu_sock.c index e9bd7ad..f665f91 100644 --- a/src/osmo-bsc/pcu_sock.c +++ b/src/osmo-bsc/pcu_sock.c @@ -263,14 +263,14 @@ case AF_INET: info_ind->address_type[i] = PCU_IF_ADDR_TYPE_IPV4; info_ind->remote_ip[i].v4 = nsvc->remote.u.sin.sin_addr; - info_ind->remote_port[i] = nsvc->remote.u.sin.sin_port; + info_ind->remote_port[i] = ntohs(nsvc->remote.u.sin.sin_port); break; case AF_INET6: info_ind->address_type[i] = PCU_IF_ADDR_TYPE_IPV6; memcpy(&info_ind->remote_ip[i].v6, &nsvc->remote.u.sin6.sin6_addr, sizeof(struct in6_addr)); - info_ind->remote_port[i] = nsvc->remote.u.sin6.sin6_port; + info_ind->remote_port[i] = ntohs(nsvc->remote.u.sin6.sin6_port); break; default: info_ind->address_type[i] = PCU_IF_ADDR_TYPE_UNSPEC; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31129 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib62dcceb80fd500e477dd5e1a0e43de47e16eeb0 Gerrit-Change-Number: 31129 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange
1 0
0 0
Change in osmo-bsc[master]: abis_rsl: constify parameters of rsl_X_imm_assign_cmd
by dexter 31 Jan '23

31 Jan '23
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31128 ) Change subject: abis_rsl: constify parameters of rsl_X_imm_assign_cmd ...................................................................... abis_rsl: constify parameters of rsl_X_imm_assign_cmd Related: OS#5198 Change-Id: I1bd2e0c844bf273d2c4381eec9e9bb9562254873 --- M include/osmocom/bsc/abis_rsl.h M src/osmo-bsc/abis_rsl.c 2 files changed, 7 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/28/31128/1 diff --git a/include/osmocom/bsc/abis_rsl.h b/include/osmocom/bsc/abis_rsl.h index 0a9cfdc..ea029e6 100644 --- a/include/osmocom/bsc/abis_rsl.h +++ b/include/osmocom/bsc/abis_rsl.h @@ -55,7 +55,7 @@ int rsl_paging_cmd(struct gsm_bts *bts, uint8_t paging_group, const struct osmo_mobile_identity *mi, uint8_t chan_needed, bool is_gprs); -int rsl_imm_assign_cmd(struct gsm_bts *bts, uint8_t len, uint8_t *val); +int rsl_imm_assign_cmd(const struct gsm_bts *bts, uint8_t len, const uint8_t *val); int rsl_tx_imm_assignment(struct gsm_lchan *lchan); int rsl_tx_imm_ass_rej(struct gsm_bts *bts, struct gsm48_req_ref *rqd_ref); int gsm48_send_rr_ass_cmd(struct gsm_lchan *dest_lchan, struct gsm_lchan *lchan, uint8_t power_command); @@ -65,7 +65,8 @@ int rsl_relase_request(struct gsm_lchan *lchan, uint8_t link_id); /* Ericcson vendor specific RSL extensions */ -int rsl_ericsson_imm_assign_cmd(struct gsm_bts *bts, uint32_t tlli, uint8_t len, uint8_t *val, uint8_t pag_grp); +int rsl_ericsson_imm_assign_cmd(const struct gsm_bts *bts, uint32_t tlli, uint8_t len, + const uint8_t *val, uint8_t pag_grp); /* Siemens vendor-specific RSL extensions */ int rsl_siemens_mrpci(struct gsm_lchan *lchan, struct rsl_mrpci *mrpci); diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index ea9fd2e..9eedfd5 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -928,7 +928,7 @@ } /* Chapter 8.5.6 */ -struct msgb *rsl_imm_assign_cmd_common(struct gsm_bts *bts, uint8_t len, uint8_t *val) +struct msgb *rsl_imm_assign_cmd_common(const struct gsm_bts *bts, uint8_t len, const uint8_t *val) { struct msgb *msg = rsl_msgb_alloc(); struct abis_rsl_dchan_hdr *dh; @@ -955,7 +955,7 @@ } /* Chapter 8.5.6 */ -int rsl_imm_assign_cmd(struct gsm_bts *bts, uint8_t len, uint8_t *val) +int rsl_imm_assign_cmd(const struct gsm_bts *bts, uint8_t len, const uint8_t *val) { struct msgb *msg = rsl_imm_assign_cmd_common(bts, len, val); if (!msg) @@ -964,7 +964,8 @@ } /* Chapter 8.5.6 Immediate Assignment Command (with Ericcson vendor specific RSL extension) */ -int rsl_ericsson_imm_assign_cmd(struct gsm_bts *bts, uint32_t tlli, uint8_t len, uint8_t *val, uint8_t pag_grp) +int rsl_ericsson_imm_assign_cmd(const struct gsm_bts *bts, uint32_t tlli, uint8_t len, + const uint8_t *val, uint8_t pag_grp) { struct msgb *msg = rsl_imm_assign_cmd_common(bts, len, val); if (!msg) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31128 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1bd2e0c844bf273d2c4381eec9e9bb9562254873 Gerrit-Change-Number: 31128 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange
1 0
0 0
Change in osmo-bts[master]: pcu_sock: use ARRAY_SIZE rather then magic number
by pespin 31 Jan '23

31 Jan '23
Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31127 ) Change subject: pcu_sock: use ARRAY_SIZE rather then magic number ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31127 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0e016e6fff420851dfabebef5d8d43c735b968b2 Gerrit-Change-Number: 31127 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Jan 2023 17:27:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
Change in osmo-bts[master]: pcu_sock: use ARRAY_SIZE rather then magic number
by dexter 31 Jan '23

31 Jan '23
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/31127 ) Change subject: pcu_sock: use ARRAY_SIZE rather then magic number ...................................................................... pcu_sock: use ARRAY_SIZE rather then magic number Lets use ARRAY_SIZE instead of magic number (8) to determine the number of timeslots to iterate. Change-Id: I0e016e6fff420851dfabebef5d8d43c735b968b2 --- M src/common/pcu_sock.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/27/31127/1 diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c index b7ec048..8f8b3af 100644 --- a/src/common/pcu_sock.c +++ b/src/common/pcu_sock.c @@ -203,7 +203,7 @@ return; } - for (tn = 0; tn < 8; tn++) { + for (tn = 0; tn < ARRAY_SIZE(trx->ts); tn++) { const struct gsm_bts_trx_ts *ts = &trx->ts[tn]; if (ts->mo.nm_state.operational != NM_OPSTATE_ENABLED) -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/31127 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0e016e6fff420851dfabebef5d8d43c735b968b2 Gerrit-Change-Number: 31127 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: newchange
1 0
0 0
Change in osmo-pcu[master]: pcuif_proto: add indication to communicate E1 parameters
by dexter 31 Jan '23

31 Jan '23
dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31102 ) Change subject: pcuif_proto: add indication to communicate E1 parameters ...................................................................... pcuif_proto: add indication to communicate E1 parameters osmo-pcu will also support GPRS via E1 timeslots in a BSC co-located setup. To avoid duplicate configuration the BSC has to communicate the E1 parameters (which TS, SS etc.) to the PCU. Lets add a new primitive to do that. Change-Id: Ia7928489130c1205b06bb9b10de0fb1461843301 Related: OS#5198 --- M include/osmocom/pcu/pcuif_proto.h 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/include/osmocom/pcu/pcuif_proto.h b/include/osmocom/pcu/pcuif_proto.h index fef0f88..720723e 100644 --- a/include/osmocom/pcu/pcuif_proto.h +++ b/include/osmocom/pcu/pcuif_proto.h @@ -19,6 +19,7 @@ #define PCU_IF_MSG_DATA_CNF_DT 0x11 /* confirm (with direct tlli) */ #define PCU_IF_MSG_RACH_IND 0x22 /* receive RACH */ #define PCU_IF_MSG_INFO_IND 0x32 /* retrieve BTS info */ +#define PCU_IF_MSG_E1_CCU_IND 0x33 /* retrieve E1 CCU comm. parameters */ #define PCU_IF_MSG_ACT_REQ 0x40 /* activate/deactivate PDCH */ #define PCU_IF_MSG_TIME_IND 0x52 /* GSM time indication */ #define PCU_IF_MSG_INTERF_IND 0x53 /* interference report */ @@ -257,6 +258,17 @@ } cgi_ps; } __attribute__ ((packed)); +/* E1 CCU connection parameters */ +struct gsm_pcu_if_e1_ccu_ind { + /* GSM/GPRS air interface */ + uint8_t trx_nr; + uint8_t ts_nr; + /* E1 line interface */ + uint8_t e1_nr; + uint8_t e1_ts; + uint8_t e1_ts_ss; +} __attribute__ ((packed)); + struct gsm_pcu_if { /* context based information */ uint8_t msg_type; /* message type */ @@ -273,6 +285,7 @@ struct gsm_pcu_if_rach_ind rach_ind; struct gsm_pcu_if_txt_ind txt_ind; struct gsm_pcu_if_info_ind info_ind; + struct gsm_pcu_if_e1_ccu_ind e1_ccu_ind; struct gsm_pcu_if_act_req act_req; struct gsm_pcu_if_time_ind time_ind; struct gsm_pcu_if_pag_req pag_req; 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31102 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ia7928489130c1205b06bb9b10de0fb1461843301 Gerrit-Change-Number: 31102 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged
1 0
0 0
Change in pysim[master]: filesystem: add unit tests for encoder/decoder methods
by laforge 31 Jan '23

31 Jan '23
Attention is currently required from: dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/24012 ) Change subject: filesystem: add unit tests for encoder/decoder methods ...................................................................... Patch Set 12: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/24012 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I02d884547f4982e0b8ed7ef21b8cda75237942e2 Gerrit-Change-Number: 24012 Gerrit-PatchSet: 12 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Falkenber9 <robert.falkenberg(a)tu-dortmund.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Jan 2023 16:26:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
1 0
0 0
Change in pysim[master]: ts_51_011: Fix decoding/encoding of EF_LOCIGPRS
by laforge 31 Jan '23

31 Jan '23
Attention is currently required from: laforge. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/31125 to look at the new patch set (#2). Change subject: ts_51_011: Fix decoding/encoding of EF_LOCIGPRS ...................................................................... ts_51_011: Fix decoding/encoding of EF_LOCIGPRS The P-TMSI signature is a 3-byte value, not a 1-byte value. Change-Id: I06e8d3efe0b3cf3970159c913acfd2f72280302d --- M pySim/ts_51_011.py 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/25/31125/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31125 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I06e8d3efe0b3cf3970159c913acfd2f72280302d Gerrit-Change-Number: 31125 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset
1 0
0 0
Change in pysim[master]: Assume first record number if caller specifies none
by laforge 31 Jan '23

31 Jan '23
Attention is currently required from: laforge. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/31124 to look at the new patch set (#2). Change subject: Assume first record number if caller specifies none ...................................................................... Assume first record number if caller specifies none This fixes a regression introduced in Change-Id I02d6942016dd0631b21d1fd301711c13cb27962b which added support for different encoding/decoding of records by their record number. Change-Id: I0c5fd21a96d2344bfd9551f31030eba0769636bf --- M pySim/filesystem.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/24/31124/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31124 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0c5fd21a96d2344bfd9551f31030eba0769636bf Gerrit-Change-Number: 31124 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset
1 0
0 0
Change in pysim[master]: ts_31_102: Fix several bugs in EF_ECC encoder
by laforge 31 Jan '23

31 Jan '23
Attention is currently required from: laforge. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/31123 to look at the new patch set (#2). Change subject: ts_31_102: Fix several bugs in EF_ECC encoder ...................................................................... ts_31_102: Fix several bugs in EF_ECC encoder The encoder function apparently was never tested, it didn't match at all the output of the decoder, not even in terms of the string keys of the dict. Change-Id: Id67bc39d52c4dfb39dc7756d8041cbd552ccbbc4 --- M pySim/ts_31_102.py 1 file changed, 6 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/23/31123/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31123 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id67bc39d52c4dfb39dc7756d8041cbd552ccbbc4 Gerrit-Change-Number: 31123 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset
1 0
0 0
  • ← Newer
  • 1
  • 2
  • 3
  • 4
  • 5
  • 6
  • ...
  • 221
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.