January 2023 - gerrit-log - lists.osmocom.org

Change in pysim[master]: gsm_r: EF_IC: Network String Table Index is 16bit, not 8bit

by laforge

laforge has removed a vote from this change. ( https://gerrit.osmocom.org/c/pysim/+/31122 ) Change subject: gsm_r: EF_IC: Network String Table Index is 16bit, not 8bit ...................................................................... Removed Code-Review+2 by laforge <laforge(a)osmocom.org> -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31122 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9e3d4a48b3cb6fb0ecf887b04c308e903a99f547 Gerrit-Change-Number: 31122 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: deleteVote

2 years, 6 months

1
0
0 0

Change in pysim[master]: gsm_r: EF_IC: Network String Table Index is 16bit, not 8bit

by laforge

laforge has removed a vote from this change. ( https://gerrit.osmocom.org/c/pysim/+/31122 ) Change subject: gsm_r: EF_IC: Network String Table Index is 16bit, not 8bit ...................................................................... Removed Verified+1 by laforge <laforge(a)osmocom.org> -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31122 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9e3d4a48b3cb6fb0ecf887b04c308e903a99f547 Gerrit-Change-Number: 31122 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: deleteVote

2 years, 6 months

1
0
0 0

Change in pysim[master]: gsm_r: EF_IC: Network String Table Index is 16bit, not 8bit

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/31122 ) Change subject: gsm_r: EF_IC: Network String Table Index is 16bit, not 8bit ...................................................................... Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31122 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9e3d4a48b3cb6fb0ecf887b04c308e903a99f547 Gerrit-Change-Number: 31122 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 31 Jan 2023 15:59:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in pysim[master]: gsm_r: EF_IC: Network String Table Index is 16bit, not 8bit

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/31122 ) Change subject: gsm_r: EF_IC: Network String Table Index is 16bit, not 8bit ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31122 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9e3d4a48b3cb6fb0ecf887b04c308e903a99f547 Gerrit-Change-Number: 31122 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 31 Jan 2023 15:59:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in pysim[master]: ts_51_011: Fix decoding/encoding of EF_LOCIGPRS

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/31125 ) Change subject: ts_51_011: Fix decoding/encoding of EF_LOCIGPRS ...................................................................... ts_51_011: Fix decoding/encoding of EF_LOCIGPRS The P-TMSI signature is a 3-byte value, not a 1-byte value. Change-Id: I06e8d3efe0b3cf3970159c913acfd2f72280302d --- M pySim/ts_51_011.py 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/25/31125/1 diff --git a/pySim/ts_51_011.py b/pySim/ts_51_011.py index 4d819dd..80182af 100644 --- a/pySim/ts_51_011.py +++ b/pySim/ts_51_011.py @@ -824,7 +824,8 @@ class EF_LOCIGPRS(TransparentEF): def __init__(self, fid='6f53', sfid=None, name='EF.LOCIGPRS', desc='GPRS Location Information', size=(14, 14)): super().__init__(fid, sfid=sfid, name=name, desc=desc, size=size) - self._construct = Struct('ptmsi'/HexAdapter(Bytes(4)), 'ptmsi_sig'/Int8ub, 'rai'/HexAdapter(Bytes(6)), + self._construct = Struct('ptmsi'/HexAdapter(Bytes(4)), 'ptmsi_sig'/HexAdapter(Bytes(3)), + 'rai'/HexAdapter(Bytes(6)), 'rau_status'/Enum(Byte, updated=0, not_updated=1, plmn_not_allowed=2, routing_area_not_allowed=3)) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31125 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I06e8d3efe0b3cf3970159c913acfd2f72280302d Gerrit-Change-Number: 31125 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

2 years, 6 months

1
0
0 0

Change in pysim[master]: Assume first record number if caller specifies none

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/31124 ) Change subject: Assume first record number if caller specifies none ...................................................................... Assume first record number if caller specifies none This fixes a regression introduced in Change-Id I02d6942016dd0631b21d1fd301711c13cb27962b which added support for different encoding/decoding of records by their record number. Change-Id: I0c5fd21a96d2344bfd9551f31030eba0769636bf --- M pySim/filesystem.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/24/31124/1 diff --git a/pySim/filesystem.py b/pySim/filesystem.py index 6dd1db7..ce1882b 100644 --- a/pySim/filesystem.py +++ b/pySim/filesystem.py @@ -945,7 +945,7 @@ self._construct = None self._tlv = None - def decode_record_hex(self, raw_hex_data: str, record_nr: int) -> dict: + def decode_record_hex(self, raw_hex_data: str, record_nr: int = 1) -> dict: """Decode raw (hex string) data into abstract representation. A derived class would typically provide a _decode_record_bin() or _decode_record_hex() -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31124 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0c5fd21a96d2344bfd9551f31030eba0769636bf Gerrit-Change-Number: 31124 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

2 years, 6 months

1
0
0 0

Change in pysim[master]: gsm_r: EF_IC: Network String Table Idnx is 16bit, not 8bit

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/31122 ) Change subject: gsm_r: EF_IC: Network String Table Idnx is 16bit, not 8bit ...................................................................... gsm_r: EF_IC: Network String Table Idnx is 16bit, not 8bit As per EIRENE GSM-R SIM-Card FFFIS, EF_IC conatains records of 1+2+2+2 bytes, the network string table index is 16bit and not 8bit as we implemented so far. Change-Id: I9e3d4a48b3cb6fb0ecf887b04c308e903a99f547 --- M pySim/gsm_r.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/22/31122/1 diff --git a/pySim/gsm_r.py b/pySim/gsm_r.py index edb5193..78c9ad9 100644 --- a/pySim/gsm_r.py +++ b/pySim/gsm_r.py @@ -211,7 +211,7 @@ self._construct = Struct('next_table_type'/NextTableType, 'id_of_next_table'/HexAdapter(Bytes(2)), 'ic_decision_value'/BcdAdapter(Bytes(2)), - 'network_string_table_index'/Int8ub) + 'network_string_table_index'/Int16ub) class EF_NW(LinFixedEF): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31122 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9e3d4a48b3cb6fb0ecf887b04c308e903a99f547 Gerrit-Change-Number: 31122 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

2 years, 6 months

1
0
0 0

Change in pysim[master]: ts_51_011: EF_SMSP: Use integer division in ValidityPeriodAdapter

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/31121 ) Change subject: ts_51_011: EF_SMSP: Use integer division in ValidityPeriodAdapter ...................................................................... ts_51_011: EF_SMSP: Use integer division in ValidityPeriodAdapter ValidityPeriodAdapter() must return integer values when encoding a value, as only integer values can be expressed in the binary format. Change-Id: I0b431a591ac1761d875b5697a71b6d59241db87d --- M pySim/ts_51_011.py 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/21/31121/1 diff --git a/pySim/ts_51_011.py b/pySim/ts_51_011.py index cd17ec8..4d819dd 100644 --- a/pySim/ts_51_011.py +++ b/pySim/ts_51_011.py @@ -435,11 +435,11 @@ if obj <= 12*60: return obj/5 - 1 elif obj <= 24*60: - return 143 + ((obj - (12 * 60)) / 30) + return 143 + ((obj - (12 * 60)) // 30) elif obj <= 30 * 24 * 60: return 166 + (obj / (24 * 60)) elif obj <= 63 * 7 * 24 * 60: - return 192 + (obj / (7 * 24 * 60)) + return 192 + (obj // (7 * 24 * 60)) else: raise ValueError -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31121 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0b431a591ac1761d875b5697a71b6d59241db87d Gerrit-Change-Number: 31121 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

2 years, 6 months

1
0
0 0

Change in pysim[master]: ts_31_102: Fix several bugs in EF_ECC encoder

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/31123 ) Change subject: ts_31_102: Fix several bugs in EF_ECC encoder ...................................................................... ts_31_102: Fix several bugs in EF_ECC encoder The encoder function apparently was never tested, it didn't match at all the output of the decoder, not even in terms of the string keys of the dict. Change-Id: Id67bc39d52c4dfb39dc7756d8041cbd552ccbbc4 --- M pySim/ts_31_102.py 1 file changed, 6 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/23/31123/1 diff --git a/pySim/ts_31_102.py b/pySim/ts_31_102.py index 4d1c3dc..4125f4a 100644 --- a/pySim/ts_31_102.py +++ b/pySim/ts_31_102.py @@ -622,9 +622,12 @@ if in_json is None: return b'\xff\xff\xff\xff' code = EF_ECC.cc_construct.build(in_json['call_code']) - svc_category = EF_ECC.category_construct.build(in_json['category']) - alpha_id = EF_ECC.alpha_construct.build(in_json['alpha_id']) - # FIXME: alpha_id needs padding up to 'record_length - 4' + svc_category = EF_ECC.category_construct.build(in_json['service_category']) + if 'alpha_id' in in_json: + alpha_id = EF_ECC.alpha_construct.build(in_json['alpha_id']) + # FIXME: alpha_id needs padding up to 'record_length - 4' + else: + alpha_id = b'' return code + alpha_id + svc_category -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31123 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id67bc39d52c4dfb39dc7756d8041cbd552ccbbc4 Gerrit-Change-Number: 31123 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

2 years, 6 months

1
0
0 0

Change in osmo-bsc[master]: Work around coverity false positives in macros

by laforge

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/31118 to look at the new patch set (#2). Change subject: Work around coverity false positives in macros ...................................................................... Work around coverity false positives in macros We have some macros that may at times have signed arguments, and at other times unsigned. Checking for <= 0 is not a bug in this case. Let's typecast any unsigned arguments to signed int to work around. Change-Id: I10e60b20c6f8092cf1ce09ebe501e739fd4a9479 Closes: CID#272993, CID#272992 (and many others) --- M include/osmocom/bsc/gsm_data.h 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/18/31118/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31118 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I10e60b20c6f8092cf1ce09ebe501e739fd4a9479 Gerrit-Change-Number: 31118 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

2 years, 6 months

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2023