Change in pysim[master]: gsm_r: EF_Predefined: Decode first record different from others
Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/31056 ) Change subject: gsm_r: EF_Predefined: Decode first record different from others ...................................................................... Patch Set 3: Code-Review+2 (3 comments) File pySim/gsm_r.py: https://gerrit.osmocom.org/c/pysim/+/31056/comment/52668ac2_0c00d1a9 PS2, Line 252: EF_Predefined
I thought that only works for instance variables, but not for class variables? I can test, but I thi […] Done
https://gerrit.osmocom.org/c/pysim/+/31056/comment/383e7597_f714042f PS2, Line 257: r = None
In that case: What would ensure that the scope of 'r' is not just within the "if" statement but in t […] Done
https://gerrit.osmocom.org/c/pysim/+/31056/comment/11630541_4792e29b PS2, Line 261: EF_Predefined
self Done
-- To view, visit https://gerrit.osmocom.org/c/pysim/+/31056 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ib526f6c3c2ac9a945b8242e2e54536628376efc0 Gerrit-Change-Number: 31056 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Fri, 27 Jan 2023 19:50:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge@osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Gerrit-MessageType: comment
participants (1)
-
laforge