January 2023 - gerrit-log - lists.osmocom.org

Change in pysim[master]: ts_31_102: Fix several bugs in EF_ECC encoder

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/31123 ) Change subject: ts_31_102: Fix several bugs in EF_ECC encoder ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31123 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id67bc39d52c4dfb39dc7756d8041cbd552ccbbc4 Gerrit-Change-Number: 31123 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 31 Jan 2023 20:14:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in pysim[master]: ts_51_011: EF_SMSP: Use integer division in ValidityPeriodAdapter

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/31121 ) Change subject: ts_51_011: EF_SMSP: Use integer division in ValidityPeriodAdapter ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/31121 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0b431a591ac1761d875b5697a71b6d59241db87d Gerrit-Change-Number: 31121 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 31 Jan 2023 20:13:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-pcu[master]: pcu_l1_if: ignore frame numbers that exceed the valid range

by fixeria

Attention is currently required from: dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31023 ) Change subject: pcu_l1_if: ignore frame numbers that exceed the valid range ...................................................................... Patch Set 4: (2 comments) File src/pcu_l1_if.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/31023/comment/9a410f03_8a06b554 PS1, Line 628: ", > missing \n Done https://gerrit.osmocom.org/c/osmo-pcu/+/31023/comment/d16ae29e_339b9deb PS1, Line 628: %d > %u Done -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31023 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ib0cf1738be07733c95fc6c459a8a7c4cb2eeef26 Gerrit-Change-Number: 31023 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Jan 2023 20:11:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-bsc[master]: timeslot_fsm: Warn in case Ercisson RBS uses static PDCH

by fixeria

Attention is currently required from: dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31112 ) Change subject: timeslot_fsm: Warn in case Ercisson RBS uses static PDCH ...................................................................... Patch Set 4: (1 comment) File src/osmo-bsc/bts_trx.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31112/comment/6dcfbddf_ae587c8b PS4, Line 339: does A space is missing, the user will see 'doesnot' in logging. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31112 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icc7c2956fc934691e3bfacb283d896a8767baf27 Gerrit-Change-Number: 31112 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Jan 2023 20:10:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-msc[master]: LCLS: Fix Global Call Reference generation

by laforge

Attention is currently required from: fixeria, keith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/31131 ) Change subject: LCLS: Fix Global Call Reference generation ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31131 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9c33a89c819e8925d89ca833d7705ed5ced6b566 Gerrit-Change-Number: 31131 Gerrit-PatchSet: 1 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Comment-Date: Tue, 31 Jan 2023 20:02:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in pysim[master]: filesystem: add unit tests for encoder/decoder methods

by laforge

Attention is currently required from: fixeria, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/24012 ) Change subject: filesystem: add unit tests for encoder/decoder methods ...................................................................... Patch Set 12: (8 comments) File pySim/ts_31_102.py: https://gerrit.osmocom.org/c/pysim/+/24012/comment/8306d6c9_6f6f420b PS4, Line 294: _encode_decode_testvector = ['{"prot_scheme_id_list": [{"priority": 0, "identifier": 2, "key_index": 1}, {"priority": 1, "identifier": 1, "key_index": 2}, {"priority": 2, "identifier": 0, "key_index": 0}], "hnet_pubkey_list": [{"hnet_pubkey_identifier": 27, "hnet_pubkey": "0272da71976234ce833a6907425867b82e074d44ef907dfb4b3e21c1c2256ebcd1"}, {"hnet_pubkey_identifier": 30, "hnet_pubkey": "5a8d38864820197c3394b92613b20b91633cbd897119273bf8e4a6f4eec0a650"}]}'] > > I agree that this line is not easy to read but you can copy+paste it into pySim-shell and it will […] I went for python notation and not json/string, after all. File pySim/ts_31_103.py: https://gerrit.osmocom.org/c/pysim/+/24012/comment/622848fe_430bacb9 PS4, Line 121: '{"addr": "hello,world", "addr_type": "00"}'] > mixing tabs and spaces, let's avoid this Done File pySim/ts_51_011.py: https://gerrit.osmocom.org/c/pysim/+/24012/comment/512a1cad_6cc2c6f1 PS4, Line 380: '{"msisdn": [1, 3, "123456"]}'] > mixing tabs and spaces, let's avoid this Done https://gerrit.osmocom.org/c/pysim/+/24012/comment/e94016e8_40f2a18c PS4, Line 471: '{"imsi": "123456789012345"}'] > same here and below Done File tests/test_files.py: https://gerrit.osmocom.org/c/pysim/+/24012/comment/7b14c796_b793f241 PS4, Line 57: for testvec_json in ef.__class__._encode_decode_testvector: > The problem without subTest is that it simply stops a the first assert and doesn't continue to check […] Done https://gerrit.osmocom.org/c/pysim/+/24012/comment/581c3dc7_ef50436c PS4, Line 71: testcase.assertEqual(testvec_json, decoded_json) > In my opinion matching the strings is the best way possible. […] Done https://gerrit.osmocom.org/c/pysim/+/24012/comment/bf84e410_a9d10118 PS4, Line 94: for obj in gc.get_objects(): > we already have utils.py:all_subclasses() for getting that recursive list. Done https://gerrit.osmocom.org/c/pysim/+/24012/comment/d0d6d5f7_2a3b908d PS4, Line 96: if not file_in_list(test_candidates, obj.name): > Ack Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/24012 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I02d884547f4982e0b8ed7ef21b8cda75237942e2 Gerrit-Change-Number: 24012 Gerrit-PatchSet: 12 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Falkenber9 <robert.falkenberg(a)tu-dortmund.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Jan 2023 19:59:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-msc[master]: LCLS: Fix Global Call Reference generation

by keith

keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/31131 ) Change subject: LCLS: Fix Global Call Reference generation ...................................................................... LCLS: Fix Global Call Reference generation According to 3gpp spec the Call Reference part of GCR is 5 octets, 3 octets Call ID followed by 2 octets BSS ID. We are using our internal call reference (4 octets) and the location area code, or optionally Cell ID as BSS ID (2 octets). Obviously it does not fit. Let's use only 3 octets from the call reference, dropping the MSB. Includes code by Vadim Yanitskiy <vyanitskiy(a)sysmocom.de> Change-Id: I9c33a89c819e8925d89ca833d7705ed5ced6b566 --- M src/libmsc/transaction.c 1 file changed, 10 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/31/31131/1 diff --git a/src/libmsc/transaction.c b/src/libmsc/transaction.c index 25c0e3c..34adce3 100644 --- a/src/libmsc/transaction.c +++ b/src/libmsc/transaction.c @@ -153,11 +153,17 @@ /* net id from Q.1902.3 3-5 bytes, this function gives 3 bytes exactly */ osmo_plmn_to_bcd(lcls->gcr.net, &trans->net->plmn); - osmo_store32be(trans->callref, lcls->gcr.cr); - osmo_store16be(use_lac ? trans->msc_a->via_cell.lai.lac : trans->msc_a->via_cell.cell_identity, lcls->gcr.cr + 3); - LOGP(DCC, LOGL_INFO, "LCLS: allocated %s-based CR-ID %s\n", use_lac ? "LAC" : "CI", - osmo_hexdump(lcls->gcr.cr, 5)); + /* TS 29.205 Table B.2.1.9.2 Call Reference ID + * 3 octets Call ID + 2 octets BSS ID + */ + lcls->gcr.cr[2] = (trans->callref >> 0) & 0xff; + lcls->gcr.cr[1] = (trans->callref >> 8) & 0xff; + lcls->gcr.cr[0] = (trans->callref >> 16) & 0xff; + osmo_store16be(use_lac ? trans->msc_a->via_cell.lai.lac : trans->msc_a->via_cell.cell_identity, &lcls->gcr.cr[3]); + + LOGP(DCC, LOGL_INFO, "LCLS: allocated %s-based CR-ID %sfor callref 0x%x\n", use_lac ? "LAC" : "CI", + osmo_hexdump(lcls->gcr.cr, 5), trans->callref); lcls->config = GSM0808_LCLS_CFG_BOTH_WAY; lcls->control = GSM0808_LCLS_CSC_CONNECT; -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/31131 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9c33a89c819e8925d89ca833d7705ed5ced6b566 Gerrit-Change-Number: 31131 Gerrit-PatchSet: 1 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

Change in libosmo-gprs[master]: WIP: rlcmac: Rearrange csn1 related definitions

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31130 ) Change subject: WIP: rlcmac: Rearrange csn1 related definitions ...................................................................... WIP: rlcmac: Rearrange csn1 related definitions This patch contains several changes trying to isolate and enclose all the CSN1 data structure big amount of churn, to avoid annoying readers not interested in that part of the code (most of the time). * osmo_gprs_rlcmac_encode/decode* APIs are kept private (gprs_rlmac_*) * Related tests now link againt .a instead of .la to access the private symbols. * All CSN1 content is split into 2 parts: ** csn1_defs: Contain the data types and definitions used by the CSN1 encoder/decoder ** csn1_encdec: Contain the functions and related code calling the CSN1 encoder/decoder Hence, gprs_rlcmac.h is split into csn1_defs.h and csn1_encdec.h, and most of the content of ts_*.c is moved to csn1_defs_ts_*.c and csn1_encdec_ts_*.c. Only CSN1-agnostic content (like enums and value_strings) are kept in ts_*.c files, and defined in types.h. TODO: lots of CSN_DESCR need to have its "static" removed and CSN_DESCR_EXTERN() added to csn1_defs.h or csn1_encdec.h. Change-Id: I7f48c1f40581c7689b280c0881d88c4900d56a10 --- M debian/copyright M include/osmocom/gprs/rlcmac/Makefile.am R include/osmocom/gprs/rlcmac/csn1_defs.h A include/osmocom/gprs/rlcmac/csn1_encdec.h M include/osmocom/gprs/rlcmac/rlcmac_enc.h M include/osmocom/gprs/rlcmac/types.h M src/rlcmac/Makefile.am R src/rlcmac/csn1_defs_ts_24_008.c R src/rlcmac/csn1_defs_ts_44_018.c A src/rlcmac/csn1_defs_ts_44_060.c A src/rlcmac/csn1_encdec_ts_24_008.c A src/rlcmac/csn1_encdec_ts_44_018.c A src/rlcmac/csn1_encdec_ts_44_060.c M src/rlcmac/rlcmac_enc.c M src/rlcmac/tbf_ul.c M src/rlcmac/tbf_ul_ass_fsm.c M src/rlcmac/ts_44_060.c M tests/rlcmac/Makefile.am M tests/rlcmac/ts_44_018_test.c M tests/rlcmac/ts_44_018_test.ok M tests/rlcmac/ts_44_060_test.c M tests/rlcmac/ts_44_060_test.ok 22 files changed, 5,572 insertions(+), 5,412 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/30/31130/1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31130 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I7f48c1f40581c7689b280c0881d88c4900d56a10 Gerrit-Change-Number: 31130 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 4 months

1
0
0 0

Change in libosmo-gprs[master]: rlcmac: Initial implementation of UL TBF assignment and scheduler

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31099 ) Change subject: rlcmac: Initial implementation of UL TBF assignment and scheduler ...................................................................... Patch Set 5: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31099 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I420c57a9d0b63f9c2805a7c2ae8ce85532a48eef Gerrit-Change-Number: 31099 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Tue, 31 Jan 2023 17:39:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

Change in osmo-bsc[master]: pcu_sock: fix endianess when populating gsm_pcu_if_info_ind

by pespin

Attention is currently required from: dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31129 ) Change subject: pcu_sock: fix endianess when populating gsm_pcu_if_info_ind ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31129 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib62dcceb80fd500e477dd5e1a0e43de47e16eeb0 Gerrit-Change-Number: 31129 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 31 Jan 2023 17:39:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2023