June 2025 - gerrit-log - lists.osmocom.org

[M] Change in libosmo-sigtran[master]: Make sure MTP-PAUSE.ind is sent to SCCP when AS goes down
by pespin 30 Jun '25

30 Jun '25

Attention is currently required from: daniel, laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40488?usp=email ) Change subject: Make sure MTP-PAUSE.ind is sent to SCCP when AS goes down ...................................................................... Patch Set 6: (1 comment) Patchset: PS6: > @laforge@gnumonks.org this improves the current situation regarding receiving N-PCSTATE. […] @laforge@gnumonks.org with https://gerrit.osmocom.org/c/libosmo-sigtran/+/40561 and https://gerrit.osmocom.org/c/osmo-bsc/+/40562 I plan to make sure the interesting DPCs for the app end up registered in sccp bookaddr and hence can be taken into account by sending a DAUD when ASP becomes active, hence making sure we receive a DAVA/DUNA for them. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40488?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I0f28b049045fbea93fe91c99251e7aaa40c014e5 Gerrit-Change-Number: 40488 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 30 Jun 2025 16:48:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-bsc[master]: WIP: bsc: Make sure MSC PC is added to sccp-addressbook
by pespin 30 Jun '25

30 Jun '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/40562?usp=email ) Change subject: WIP: bsc: Make sure MSC PC is added to sccp-addressbook ...................................................................... WIP: bsc: Make sure MSC PC is added to sccp-addressbook This way they can used by libosmo-sigtran to figure out interesting remote PCs it should track availability for. Related: OS#5917 Related: SYS#7501 Depends: libosmo-sigtran.git Change-Id I9d2452d9cc8e443050927a047b7ebacd2b2f37e1 Change-Id: I57dca92eb5f482e9017d9b19cd7f8feebd9e2721 --- M TODO-RELEASE M src/osmo-bsc/bsc_vty.c M src/osmo-bsc/osmo_bsc_sigtran.c 3 files changed, 70 insertions(+), 42 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/62/40562/1 diff --git a/TODO-RELEASE b/TODO-RELEASE index c6495da..0eae0e8 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -8,3 +8,4 @@ # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line libosmo-mgcp-client bump_dep Depend on I0d58e6d84418f50670c8ab7cf8490af3bc2f5c26 +libosmo-sigtran >2.1.0 osmo_sccp_addr_{create,update}() diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c index 98a7792..52ad6b3 100644 --- a/src/osmo-bsc/bsc_vty.c +++ b/src/osmo-bsc/bsc_vty.c @@ -2946,7 +2946,8 @@ /* Make sure only standard SSN numbers are used. If no ssn number is * configured, silently apply the default SSN */ -static void enforce_standard_ssn(struct vty *vty, struct osmo_sccp_addr *addr) +static void enforce_standard_ssn(struct vty *vty, struct osmo_ss7_instance *ss7, + const char *addr_name, struct osmo_sccp_addr *addr) { if (addr->presence & OSMO_SCCP_ADDR_T_SSN) { if (addr->ssn != OSMO_SCCP_SSN_BSSAP) @@ -2957,6 +2958,7 @@ addr->presence |= OSMO_SCCP_ADDR_T_SSN; addr->ssn = OSMO_SCCP_SSN_BSSAP; + osmo_sccp_addr_update(ss7, addr_name, addr); } DEFUN(cfg_msc_cs7_bsc_addr, @@ -2988,8 +2990,8 @@ msc->a.cs7_instance = ss7_id; msc->a.cs7_instance_valid = true; - enforce_standard_ssn(vty, &msc->a.bsc_addr); msc->a.bsc_addr_name = talloc_strdup(msc, bsc_addr_name); + enforce_standard_ssn(vty, ss7, bsc_addr_name, &msc->a.bsc_addr); return CMD_SUCCESS; } @@ -3022,8 +3024,8 @@ msc->a.cs7_instance = ss7_id; msc->a.cs7_instance_valid = true; - enforce_standard_ssn(vty, &msc->a.msc_addr); msc->a.msc_addr_name = talloc_strdup(msc, msc_addr_name); + enforce_standard_ssn(vty, ss7, msc_addr_name, &msc->a.msc_addr); return CMD_SUCCESS; } diff --git a/src/osmo-bsc/osmo_bsc_sigtran.c b/src/osmo-bsc/osmo_bsc_sigtran.c index f51aa0a..8abeeb6 100644 --- a/src/osmo-bsc/osmo_bsc_sigtran.c +++ b/src/osmo-bsc/osmo_bsc_sigtran.c @@ -552,6 +552,9 @@ /* Default point-code to be used as remote address (MSC) */ #define MSC_DEFAULT_PC "0.23.1" +/* Default point-code to be used as remote address (MSC) */ +#define MSC_DEFAULT_ADDR_NAME "addr-dyn-msc-default" + static int asp_rx_unknown(struct osmo_ss7_asp *asp, int ppid_mux, struct msgb *msg); /* Initialize osmo sigtran backhaul */ @@ -560,55 +563,79 @@ struct bsc_msc_data *msc; uint32_t default_pc; struct llist_head *ll_it; - int create_instance_0_for_msc_nr = -1; + int rc; osmo_ss7_register_rx_unknown_cb(&asp_rx_unknown); OSMO_ASSERT(mscs); msc_list = mscs; - /* Guard against multiple MSCs with identical config */ + /* Apply default address on each MSC and validate which ss7 instance it runs on. */ llist_for_each_entry(msc, msc_list, entry) { - struct bsc_msc_data *msc2; + struct osmo_ss7_instance *s7i; /* An MSC with invalid cs7 instance defaults to cs7 instance 0 */ - uint32_t msc_inst = (msc->a.cs7_instance_valid ? msc->a.cs7_instance : 0); + if (!msc->a.cs7_instance_valid) { + s7i = osmo_ss7_instance_find(0); + if (!s7i) { + LOGP(DMSC, LOGL_NOTICE, "To auto-configure msc %d, creating cs7 instance 0 implicitly\n", + msc->nr); + s7i = osmo_ss7_instance_find_or_create(tall_bsc_ctx, 0); + OSMO_ASSERT(s7i); + } + msc->a.cs7_instance = osmo_ss7_instance_get_id(s7i); + msc->a.cs7_instance_valid = true; + } else { + s7i = osmo_ss7_instance_find(msc->a.cs7_instance); + } - if (!msc->a.cs7_instance_valid) - create_instance_0_for_msc_nr = msc->nr; - - /* If unset, use default SCCP address for the MSC */ - if (!msc->a.msc_addr.presence) - osmo_sccp_make_addr_pc_ssn(&msc->a.msc_addr, - osmo_ss7_pointcode_parse(NULL, MSC_DEFAULT_PC), - OSMO_SCCP_SSN_BSSAP); - - /* (more optimally, we'd only iterate the remaining other mscs after this msc, but this happens only - * during startup, so nevermind that complexity and rather check each pair twice. That also ensures to - * compare all MSCs that have no explicit msc_addr set, see osmo_sccp_make_addr_pc_ssn() above.) */ - llist_for_each_entry(msc2, msc_list, entry) { - uint32_t msc2_inst; - - if (msc2 == msc) - continue; - - msc2_inst = (msc2->a.cs7_instance_valid ? msc2->a.cs7_instance : 0); - if (msc_inst != msc2_inst) - continue; - - if (osmo_sccp_addr_cmp(&msc->a.msc_addr, &msc2->a.msc_addr, OSMO_SCCP_ADDR_T_PC) == 0) { - LOGP(DMSC, LOGL_ERROR, "'msc %d' and 'msc %d' cannot use the same remote PC" - " %s on the same cs7 instance %u\n", - msc->nr, msc2->nr, osmo_sccp_addr_dump(&msc->a.msc_addr), msc_inst); - return -EINVAL; + /* User didn't configure an 'msc-addr' in VTY for this msc, add + * default SCCP address for the MSC to the address book */ + if (!msc->a.msc_addr_name) { + msc->a.msc_addr_name = talloc_strdup(msc, MSC_DEFAULT_ADDR_NAME); + LOGP(DMSC, LOGL_NOTICE, "To auto-configure msc %d, adding address '%s' to cs7 instance 0 address-book implicitly\n", + msc->nr, msc->a.msc_addr_name); + } + if (!msc->a.msc_addr.presence) { + struct osmo_ss7_instance *ss7; + ss7 = osmo_sccp_addr_by_name(&msc->a.msc_addr, msc->a.msc_addr_name); + if (!ss7) { + osmo_sccp_make_addr_pc_ssn(&msc->a.msc_addr, + osmo_ss7_pointcode_parse(s7i, MSC_DEFAULT_PC), + OSMO_SCCP_SSN_BSSAP); + rc = osmo_sccp_addr_create(s7i, msc->a.msc_addr_name, &msc->a.msc_addr); + if (rc < 0) + return -EINVAL; + } else { + OSMO_ASSERT(s7i == ss7); + osmo_sccp_make_addr_pc_ssn(&msc->a.msc_addr, + osmo_ss7_pointcode_parse(s7i, MSC_DEFAULT_PC), + OSMO_SCCP_SSN_BSSAP); + rc = osmo_sccp_addr_update(s7i, msc->a.msc_addr_name, &msc->a.msc_addr); + if (rc < 0) + return -EINVAL; } } } - if (create_instance_0_for_msc_nr >= 0 && !osmo_ss7_instance_find(0)) { - LOGP(DMSC, LOGL_NOTICE, "To auto-configure msc %d, creating cs7 instance 0 implicitly\n", - create_instance_0_for_msc_nr); - OSMO_ASSERT(osmo_ss7_instance_find_or_create(tall_bsc_ctx, 0)); + /* Guard against multiple MSCs with identical config */ + /* (more optimally, we'd only iterate the remaining other mscs after this msc, but this happens only + * during startup, so nevermind that complexity and rather check each pair twice. That also ensures to + * compare all MSCs that have no explicit msc_addr set, see osmo_sccp_make_addr_pc_ssn() above.) */ + llist_for_each_entry(msc, msc_list, entry) { + struct bsc_msc_data *msc2; + llist_for_each_entry(msc2, msc_list, entry) { + if (msc2 == msc) + continue; + if (msc->a.cs7_instance != msc2->a.cs7_instance) + continue; + if (osmo_sccp_addr_cmp(&msc->a.msc_addr, &msc2->a.msc_addr, OSMO_SCCP_ADDR_T_PC) == 0) { + LOGP(DMSC, LOGL_ERROR, "'msc %d' and 'msc %d' cannot use the same remote PC" + " %s on the same cs7 instance %u\n", + msc->nr, msc2->nr, osmo_sccp_addr_dump(&msc->a.msc_addr), msc->a.cs7_instance); + return -EINVAL; + } + } } /* Set up exactly one SCCP user and one ASP+AS per cs7 instance. @@ -627,8 +654,7 @@ llist_for_each_entry(msc, msc_list, entry) { /* An MSC with invalid cs7 instance id defaults to cs7 instance 0 */ - if ((inst_id != msc->a.cs7_instance) - && !(inst_id == 0 && !msc->a.cs7_instance_valid)) + if (inst_id != msc->a.cs7_instance) continue; /* This msc runs on this cs7 inst. Check the asp_proto. */ @@ -676,8 +702,7 @@ char msc_name[32]; /* Skip MSCs that don't run on this cs7 instance */ - if ((inst_id != msc->a.cs7_instance) - && !(inst_id == 0 && !msc->a.cs7_instance_valid)) + if (inst_id != msc->a.cs7_instance) continue; snprintf(msc_name, sizeof(msc_name), "msc-%d", msc->nr); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/40562?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I57dca92eb5f482e9017d9b19cd7f8feebd9e2721 Gerrit-Change-Number: 40562 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: sccp_sap.h: Add APIs to insert and update addresses in address book
by pespin 30 Jun '25

30 Jun '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40561?usp=email ) Change subject: sccp_sap.h: Add APIs to insert and update addresses in address book ...................................................................... sccp_sap.h: Add APIs to insert and update addresses in address book This will be used by applications to dynamically add addresses in the address book, which later on libosmo-sigtran can make use of to eg. send DAUD for intereting DPCs. Change-Id: I9d2452d9cc8e443050927a047b7ebacd2b2f37e1 --- M include/osmocom/sigtran/sccp_sap.h M src/ss7_instance.c M src/ss7_vty.c M tests/vty/osmo_stp_test.vty M tests/vty/ss7_asp_test.vty 5 files changed, 93 insertions(+), 27 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/61/40561/1 diff --git a/include/osmocom/sigtran/sccp_sap.h b/include/osmocom/sigtran/sccp_sap.h index 98a48be..65eff74 100644 --- a/include/osmocom/sigtran/sccp_sap.h +++ b/include/osmocom/sigtran/sccp_sap.h @@ -330,12 +330,12 @@ int osmo_sccp_user_sap_down(struct osmo_sccp_user *scu, struct osmo_prim_hdr *oph); int osmo_sccp_user_sap_down_nofree(struct osmo_sccp_user *scu, struct osmo_prim_hdr *oph); +int osmo_sccp_addr_create(struct osmo_ss7_instance *inst, const char *name, const struct osmo_sccp_addr *dest_addr); +int osmo_sccp_addr_update(struct osmo_ss7_instance *inst, const char *name, const struct osmo_sccp_addr *dest_addr); struct osmo_ss7_instance *osmo_sccp_addr_by_name(struct osmo_sccp_addr *dest_addr, const char *name); int osmo_sccp_addr_by_name_local(struct osmo_sccp_addr *dest_addr, const char *name, const struct osmo_ss7_instance *inst); - const char *osmo_sccp_name_by_addr(const struct osmo_sccp_addr *addr); - void osmo_sccp_local_addr_by_instance(struct osmo_sccp_addr *dest_addr, const struct osmo_sccp_instance *inst, uint32_t ssn); diff --git a/src/ss7_instance.c b/src/ss7_instance.c index ef0fbd8..b583b98 100644 --- a/src/ss7_instance.c +++ b/src/ss7_instance.c @@ -619,6 +619,74 @@ * (see also .cfg in struct osmo_ss7_instance) */ LLIST_HEAD(sccp_address_book_global); +static struct osmo_sccp_addr_entry *addr_entry_alloc(struct osmo_ss7_instance *inst, const char *name, + const struct osmo_sccp_addr *addr) +{ + struct osmo_sccp_addr_entry *entry; + + entry = talloc_zero(inst, struct osmo_sccp_addr_entry); + OSMO_STRLCPY_ARRAY(entry->name, name); + entry->inst = inst; + memcpy(&entry->addr, addr, sizeof(entry->addr)); + llist_add_tail(&entry->list, &inst->cfg.sccp_address_book); + llist_add_tail(&entry->list_global, &sccp_address_book_global); + return entry; +} + +/*! \brief Add an SCCP address entry to the addressbook. + * \param[int] inst cs7 instance where this address belongs + * \param[in] name of the address to create + * \param[in] dest_addr address value to add to the addressbook. + * \returns 0 on success, negative error code on error. + * + * Validates that the name is unique among all cs7 instances of the process, and + * that no such entry already exists. */ +int osmo_sccp_addr_create(struct osmo_ss7_instance *inst, const char *name, + const struct osmo_sccp_addr *dest_addr) +{ + struct osmo_sccp_addr_entry *entry; + if (strlen(name) >= sizeof(entry->name)) { + LOGSS7(inst, LOGL_ERROR, "%s: SCCP address name too long: '%s'\n", + __func__, name); + return -ENOSPC; + } + + /* Ensure that we do not use address names that + * are already used in other ss7 instances. */ + entry = addr_entry_by_name_global(name); + if (entry) { + LOGSS7(inst, LOGL_ERROR, "%s: SCCP address name already used in cs7 instance %u: '%s'\n", + __func__, entry->inst->cfg.id, entry->name); + return -EALREADY; + } + + entry = addr_entry_alloc(inst, name, dest_addr); + OSMO_ASSERT(entry); + return 0; +} + +/*! \brief Update the value of an SCCP address entry already present in the addressbook. + * \param[int] inst cs7 instance where this address belongs + * \param[in] name of the address to update + * \param[in] dest_addr address value to store in the addressbook. + * \returns 0 on success, negative error code on error. + */ +int osmo_sccp_addr_update(struct osmo_ss7_instance *inst, const char *name, const struct osmo_sccp_addr *dest_addr) +{ + struct osmo_sccp_addr_entry *entry; + + /* Ensure that we do not use address names that + * are already used in other ss7 instances. */ + entry = addr_entry_by_name_local(name, inst); + if (!entry) { + LOGSS7(inst, LOGL_ERROR, "%s: SCCP address '%s' not found in cs7 instance %u\n", + __func__, name, inst->cfg.id); + return -ENOKEY; + } + memcpy(&entry->addr, dest_addr, sizeof(entry->addr)); + return 0; +} + /* Pick an SCCP address entry from the addressbook list by its name */ struct osmo_sccp_addr_entry *addr_entry_by_name_local(const char *name, diff --git a/src/ss7_vty.c b/src/ss7_vty.c index 9e9ceaa..a3f1a34 100644 --- a/src/ss7_vty.c +++ b/src/ss7_vty.c @@ -952,36 +952,34 @@ struct osmo_ss7_instance *inst = (struct osmo_ss7_instance *)vty->index; struct osmo_sccp_addr_entry *entry; const char *name = argv[0]; + int rc; - if (strlen(name) >= sizeof(entry->name)) { - vty_out(vty, "Error: SCCP address name too long: '%s'%s", - name, VTY_NEWLINE); - return CMD_ERR_INCOMPLETE; - } - - /* Ensure that we do not use address names that - * are already used in other ss7 instances. */ - entry = addr_entry_by_name_global(name); - if (entry != NULL) { - vty_out(vty, - "Error: SCCP address name already used in cs7 instance %u: '%s'%s", - entry->inst->cfg.id, entry->name, VTY_NEWLINE); - return CMD_ERR_INCOMPLETE; + entry = addr_entry_by_name_local(name, inst); + if (!entry) { + /* Create a new addressbook entry if we can not find an + * already existing entry */ + struct osmo_sccp_addr sccp_addr = { + .ri = OSMO_SCCP_RI_SSN_PC, + }; + rc = osmo_sccp_addr_create(inst, name, &sccp_addr); + if (rc < 0) { + if (rc == -ENOSPC) + vty_out(vty, "Error: SCCP address name too long: '%s'%s", + name, VTY_NEWLINE); + if (rc == -EALREADY) + vty_out(vty, "Error: SCCP address name already used in cs7 instance other than %u: '%s'%s", + inst->cfg.id, name, VTY_NEWLINE); + return CMD_ERR_INCOMPLETE; + } } entry = addr_entry_by_name_local(name, inst); - - /* Create a new addressbook entry if we can not find an - * already existing entry */ if (!entry) { - entry = talloc_zero(inst, struct osmo_sccp_addr_entry); - osmo_strlcpy(entry->name, name, sizeof(entry->name)); - llist_add_tail(&entry->list, &inst->cfg.sccp_address_book); - llist_add_tail(&entry->list_global, &sccp_address_book_global); - entry->addr.ri = OSMO_SCCP_RI_SSN_PC; + vty_out(vty, "%% Error: Unable to find SCCP address '%s' just created in instance %u%s", + name, inst->cfg.id, VTY_NEWLINE); + return CMD_WARNING; } - entry->inst = (struct osmo_ss7_instance *)vty->index; vty->node = L_CS7_SCCPADDR_NODE; vty->index = entry; diff --git a/tests/vty/osmo_stp_test.vty b/tests/vty/osmo_stp_test.vty index 2c5b5d8..4502c74 100644 --- a/tests/vty/osmo_stp_test.vty +++ b/tests/vty/osmo_stp_test.vty @@ -259,7 +259,7 @@ OsmoSTP(config-cs7)# exit OsmoSTP(config)# cs7 instance 1 OsmoSTP(config-cs7)# sccp-address foo -Error: SCCP address name already used in cs7 instance 0: 'foo' +Error: SCCP address name already used in cs7 instance other than 1: 'foo' % Command incomplete. OsmoSTP(config-cs7)# sccp-address bar OsmoSTP(config-cs7-sccpaddr)# point-code 1.2.3 diff --git a/tests/vty/ss7_asp_test.vty b/tests/vty/ss7_asp_test.vty index b565557..2bf753d 100644 --- a/tests/vty/ss7_asp_test.vty +++ b/tests/vty/ss7_asp_test.vty @@ -238,7 +238,7 @@ ss7_asp_vty_test(config-cs7)# exit ss7_asp_vty_test(config)# cs7 instance 1 ss7_asp_vty_test(config-cs7)# sccp-address foo -Error: SCCP address name already used in cs7 instance 0: 'foo' +Error: SCCP address name already used in cs7 instance other than 1: 'foo' % Command incomplete. ss7_asp_vty_test(config-cs7)# sccp-address bar ss7_asp_vty_test(config-cs7-sccpaddr)# point-code 1.2.3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40561?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I9d2452d9cc8e443050927a047b7ebacd2b2f37e1 Gerrit-Change-Number: 40561 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: route: Introduce LOGPRT macro to improve logging
by osmith 30 Jun '25

30 Jun '25

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40554?usp=email ) Change subject: route: Introduce LOGPRT macro to improve logging ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40554?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I00823f4b61d082d2de848c81e8592a4a1b2697e5 Gerrit-Change-Number: 40554 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 30 Jun 2025 13:05:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: route: Print priority in osmo_ss7_route_name()
by osmith 30 Jun '25

30 Jun '25

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40553?usp=email ) Change subject: route: Print priority in osmo_ss7_route_name() ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40553?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ib9a6ae95562a40eb6c03bbc81ddabf2694e4efa6 Gerrit-Change-Number: 40553 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 30 Jun 2025 13:04:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-sigtran[master]: Fix combined linkset lookup when inserting route
by osmith 30 Jun '25

30 Jun '25

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40551?usp=email ) Change subject: Fix combined linkset lookup when inserting route ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40551?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I44d7545a3c6a3ea4839e983104112f8afa6b981a Gerrit-Change-Number: 40551 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 30 Jun 2025 13:04:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: ss7_vty: Improve VTY output of vty_dump_rtable()
by osmith 30 Jun '25

30 Jun '25

Attention is currently required from: laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40550?usp=email ) Change subject: ss7_vty: Improve VTY output of vty_dump_rtable() ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40550?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I87511084278976889ab031fcfd10c09cc60c7595 Gerrit-Change-Number: 40550 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 30 Jun 2025 13:03:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: ss7_vty: Improve VTY output of vty_dump_rtable()
by osmith 30 Jun '25

30 Jun '25

Attention is currently required from: laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40550?usp=email ) Change subject: ss7_vty: Improve VTY output of vty_dump_rtable() ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40550?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I87511084278976889ab031fcfd10c09cc60c7595 Gerrit-Change-Number: 40550 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 30 Jun 2025 13:03:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: xua_asp_fsm: Drop code branch never called in xUA ASP
by osmith 30 Jun '25

30 Jun '25

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40549?usp=email ) Change subject: xua_asp_fsm: Drop code branch never called in xUA ASP ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40549?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ic0b8b4fbe31ab2e5206a4f4c7907868f20d2ef10 Gerrit-Change-Number: 40549 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 30 Jun 2025 12:58:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in libosmo-sigtran[master]: Differentiate between dynamic and static routes
by osmith 30 Jun '25

30 Jun '25

Attention is currently required from: laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40543?usp=email ) Change subject: Differentiate between dynamic and static routes ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/40543?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ic6c6b46084a1e4063ebf1f5d13e0e03386bb4c45 Gerrit-Change-Number: 40543 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 30 Jun 2025 12:58:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0