lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

October 2026

  • 1 participants
  • 1426 discussions
[S] Change in pysim[master]: personalization: SmspTpScAddr edits record 1 of EF.SMSP only
by hampushellsberg 31 Oct '26

31 Oct '26
Attention is currently required from: dexter, laforge, neels, osmith. hampushellsberg has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/43983?usp=email ) Change subject: personalization: SmspTpScAddr edits record 1 of EF.SMSP only ...................................................................... Patch Set 3: (1 comment) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/43983/comment/3c95e99a_a6048da8?usp=em… : PS3, Line 651: if rec_len > I don't think "if rec_len" is the right predicate here. IMHO, it will always be true. […] You're right, it's always true here: the EF.SMSP templates are linear fixed with a record length, and slicing past the end just gives b''. I only meant to guard against rec_len being None, which can't happen for this file. I'd drop the condition and add a test with a one-record and a two-record EF.SMSP that checks the second record is kept. Would that work for you? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43983?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I47b1abc97d7b8caad0c74d7af2e5da38e9a895b1 Gerrit-Change-Number: 43983 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sat, 31 Oct 2026 13:11:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
1 0
0 0
[S] Change in pysim[master]: esim.saip: keep keyAccess and keyCounterValue of security domain keys
by hampushellsberg 31 Oct '26

31 Oct '26
Attention is currently required from: laforge. hampushellsberg has posted comments on this change by hampushellsberg. ( https://gerrit.osmocom.org/c/pysim/+/44011?usp=email ) Change subject: esim.saip: keep keyAccess and keyCounterValue of security domain keys ...................................................................... Patch Set 1: (1 comment) File pySim/esim/saip/__init__.py: https://gerrit.osmocom.org/c/pysim/+/44011/comment/bf11fe54_b00f4a76?usp=em… : PS1, Line 1156: > can't we deduct the SCP02/03/80 usage from the KVN? And then determine the length based on that? If […] As far as I can see there is only one length per SCP: 5 bytes for SCP80, 3 for SCP03 and 2 for SCP02, the same as the defaults in SAIP 8.6.3. So yes, the length could come from the KVN ranges in that table. Two corner cases I'd like to align on before I upload the next patch set: - A counter on a KVN outside those ranges (the table says it's incomplete): should that raise, or would you allow an optional explicit length there? - A decoded counter whose length doesn't match its KVN: keep the decoded length, so decode and re-encode stay byte-identical, or re-encode with the length the KVN implies? What would you prefer? -- To view, visit https://gerrit.osmocom.org/c/pysim/+/44011?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7df8ef6f2c81cd8544a04dbf7ff5d096685103e3 Gerrit-Change-Number: 44011 Gerrit-PatchSet: 1 Gerrit-Owner: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sat, 31 Oct 2026 13:08:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: hampushellsberg <hampushellsberg(a)gmail.com> Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
1 0
0 0
[XS] Change in osmo-dev[master]: sanitize: add open5gs
by laforge 31 Oct '26

31 Oct '26
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/44018?usp=email ) Change subject: sanitize: add open5gs ...................................................................... sanitize: add open5gs Allow building open5gs with asan options, e.g. via: ./testenv.py run --asan Change-Id: I0a9d797b63b2ad519bb94829b85a1f4b9cc38765 --- M sanitize.opts 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/sanitize.opts b/sanitize.opts index d26a3ce..0deb210 100644 --- a/sanitize.opts +++ b/sanitize.opts @@ -30,3 +30,4 @@ osmocom-bb_trxcon --enable-sanitize osmocom-bb_virtphy --enable-sanitize upf-benchmark --enable-sanitize +open5gs -Db_sanitize=address,undefined -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/44018?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I0a9d797b63b2ad519bb94829b85a1f4b9cc38765 Gerrit-Change-Number: 44018 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
1 0
0 0
[XS] Change in simtrace2[master]: host_communication: send a ZLP after any message of whole packets
by laforge 31 Oct '26

31 Oct '26
laforge has submitted this change. ( https://gerrit.osmocom.org/c/simtrace2/+/43973?usp=email ) Change subject: host_communication: send a ZLP after any message of whole packets ...................................................................... host_communication: send a ZLP after any message of whole packets usb_write_cb() ends a message with a zero-length packet only when transferred == ep_size, that is for a message of exactly one packet. The SAM3S USB HAL reports the whole message in transferred, so a message of 128, 192 or 256 bytes leaves the board as full packets with no short packet behind it, and a host that reads into a larger buffer sees it only when the board sends its next message. In card emulation that is the RX-DATA message of a modem command with Lc 72, B2 or F2: osmo-remsim-client-st2 submits 4096-byte bulk IN transfers, so such a command stays on the host until the modem gives up and resets the card, about 120 s later. Send the ZLP whenever a non-empty message is a whole number of packets and the transfer covered all of it. The callback after the ZLP sees transferred == 0 and frees the buffer as before. The folder osmocom-simtrace2-cardem-zlp of hampushellsberg-dev/PySIM-upstream-patches on GitHub has the analysis, a journal repro and the before/after validation. Change-Id: Ie3cf86cb79d523d12b2993a3019b83e9b1c9c4e0 --- M firmware/libcommon/source/host_communication.c 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified tnt: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/firmware/libcommon/source/host_communication.c b/firmware/libcommon/source/host_communication.c index b2faf1b..d61d977 100644 --- a/firmware/libcommon/source/host_communication.c +++ b/firmware/libcommon/source/host_communication.c @@ -34,7 +34,12 @@ TRACE_DEBUG("%s (EP=0x%02x)\r\n", __func__, bep->ep); - if (((msgb_length(msg) % ep_size) == 0) && (transferred == ep_size)) { + /* A transfer that fills its last packet ends only at a short packet, so a + * message of any whole number of packets needs a ZLP, not just one of a + * single packet: the host reads into a larger buffer and would otherwise + * see this message only once the next one arrives. */ + if (msgb_length(msg) && ((msgb_length(msg) % ep_size) == 0) && + (transferred == msgb_length(msg))) { /* terminate with ZLP; pass in 'msg' again as 'arg' so we get * called the second time and proceed with usb_buf_free below */ USBD_Write(bep->ep, 0, 0, (TransferCallback) &usb_write_cb, msg); -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43973?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Ie3cf86cb79d523d12b2993a3019b83e9b1c9c4e0 Gerrit-Change-Number: 43973 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-CC: hampushellsberg <hampushellsberg(a)gmail.com>
1 0
0 0
[XS] Change in simtrace2[master]: host_communication: send a ZLP after any message of whole packets
by laforge 31 Oct '26

31 Oct '26
Attention is currently required from: Hoernchen. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/simtrace2/+/43973?usp=email ) Change subject: host_communication: send a ZLP after any message of whole packets ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43973?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Ie3cf86cb79d523d12b2993a3019b83e9b1c9c4e0 Gerrit-Change-Number: 43973 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-CC: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Sat, 31 Oct 2026 11:43:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[S] Change in pysim[master]: personalization: SmspTpScAddr edits record 1 of EF.SMSP only
by laforge 31 Oct '26

31 Oct '26
Attention is currently required from: dexter, neels, osmith. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/43983?usp=email ) Change subject: personalization: SmspTpScAddr edits record 1 of EF.SMSP only ...................................................................... Patch Set 3: (1 comment) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/43983/comment/32af98cd_55a2fcb5?usp=em… : PS3, Line 651: if rec_len I don't think "if rec_len" is the right predicate here. IMHO, it will always be true. I guess you wanted to check "if len(f_smsp.body) > rec_len" ? Even in that case, I'm not entirely sure if it's needed. I would expect that f_smsp.body[len(f_smsp.body):] would always be an empty byte-string and hence can be safely appended? Best to try it in form of a test case. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43983?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I47b1abc97d7b8caad0c74d7af2e5da38e9a895b1 Gerrit-Change-Number: 43983 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sat, 31 Oct 2026 08:51:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
1 0
0 0
[XS] Change in pysim[master]: setup: make smpp.twisted3 an extra, only pySim-smpp2sim.py needs it
by laforge 31 Oct '26

31 Oct '26
laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/43981?usp=email ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: setup: make smpp.twisted3 an extra, only pySim-smpp2sim.py needs it ...................................................................... setup: make smpp.twisted3 an extra, only pySim-smpp2sim.py needs it smpp.twisted3 is imported by pySim-smpp2sim.py alone; no module under pySim/ uses it. Every release of smpp.twisted3 pins Twisted~=23.10.0, a Twisted with three open advisories (CVE-2026-42304, CVE-2024-41810, CVE-2024-41671), so every installation of the library carries a Twisted it never loads and cannot upgrade. Move the requirement to a `smpp2sim` extra; the script keeps working with `pip install "pysim[smpp2sim]"` and fails with a plain ImportError without it, the same way the `smdpp` extra behaves for klein. The folder osmocom-pysim-smpp-twisted-optional of hampushellsberg-dev/PySIM-upstream-patches on GitHub has the analysis and the validation output. Co-Authored-By: Oliver Smith <osmith(a)sysmocom.de> Change-Id: I7001effd073fa341c08a6e4508e22b568aa7cd70 --- M contrib/jenkins.sh M requirements.txt M setup.py 3 files changed, 6 insertions(+), 3 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index fa2575b..2763f57 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -42,7 +42,7 @@ "card-test") # tests requiring physical cards setup_venv - pip install -r requirements.txt + pip install . # Run pySim-prog integration tests cd tests/pySim-prog_test/ @@ -53,6 +53,8 @@ python3 -m unittest discover -v -s ./tests/pySim-shell_test/ # Run pySim-smpp2sim test + pip install .[smpp2sim] + pip install smpplib tests/pySim-smpp2sim_test/pySim-smpp2sim_test.sh ;; "distcheck") diff --git a/requirements.txt b/requirements.txt index aafccc2..947ccff 100644 --- a/requirements.txt +++ b/requirements.txt @@ -14,5 +14,4 @@ git+https://github.com/osmocom/asn1tools packaging git+https://github.com/hologram-io/smpp.pdu -smpp.twisted3 @ git+https://github.com/jookies/smpp.twisted smpplib diff --git a/setup.py b/setup.py index ff093fb..20feba4 100644 --- a/setup.py +++ b/setup.py @@ -33,7 +33,6 @@ "packaging", "smpp.pdu @ git+https://github.com/hologram-io/smpp.pdu", "asn1tools", - "smpp.twisted3 @ git+https://github.com/jookies/smpp.twisted", ], scripts=[ 'pySim-prog.py', @@ -57,6 +56,9 @@ "requests", "smpplib", ], + "smpp2sim": [ + "smpp.twisted3 @ git+https://github.com/jookies/smpp.twisted", + ], "CardKeyProviderPgsql": [ "psycopg2-binary", ] -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43981?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I7001effd073fa341c08a6e4508e22b568aa7cd70 Gerrit-Change-Number: 43981 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)gnumonks.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: hampushellsberg <hampushellsberg(a)gmail.com>
1 0
0 0
[XS] Change in simtrace2[master]: host_communication: send a ZLP after any message of whole packets
by tnt 31 Oct '26

31 Oct '26
Attention is currently required from: Hoernchen, laforge. tnt has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/simtrace2/+/43973?usp=email ) Change subject: host_communication: send a ZLP after any message of whole packets ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: The logic makes sense to me as well. -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43973?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: Ie3cf86cb79d523d12b2993a3019b83e9b1c9c4e0 Gerrit-Change-Number: 43973 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-CC: hampushellsberg <hampushellsberg(a)gmail.com> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sat, 31 Oct 2026 08:31:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
1 0
0 0
[S] Change in osmo-ttcn3-hacks[master]: bts: drop mp_l1_supports_gprs, run all GPRS tests
by fixeria 30 Oct '26

30 Oct '26
fixeria has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43862?usp=email ) Change subject: bts: drop mp_l1_supports_gprs, run all GPRS tests ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43862?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibe8db314c2eb676d536779d5875456d17ecb60e8 Gerrit-Change-Number: 43862 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de>
1 0
0 0
[XS] Change in osmo-dev[master]: all.deps: osmocom-bb/layer23 depends on libosmo-gprs
by fixeria 30 Oct '26

30 Oct '26
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/43947?usp=email ) Change subject: all.deps: osmocom-bb/layer23 depends on libosmo-gprs ...................................................................... all.deps: osmocom-bb/layer23 depends on libosmo-gprs Change-Id: I7a6f733fb0e4f21483740b9665c074598675ea0b --- M all.deps 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/all.deps b/all.deps index d88f0eb..278d709 100644 --- a/all.deps +++ b/all.deps @@ -54,7 +54,7 @@ simtrace2 # configure.ac not in topdir of repository -osmocom-bb_layer23 libosmocore +osmocom-bb_layer23 libosmocore libosmo-gprs osmocom-bb_virtphy libosmocore osmocom-bb_trxcon libosmocore osmo-trx simtrace2_host libosmocore -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/43947?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I7a6f733fb0e4f21483740b9665c074598675ea0b Gerrit-Change-Number: 43947 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
1 0
0 0
  • ← Newer
  • 1
  • 2
  • 3
  • 4
  • ...
  • 143
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.