October 2026 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-sgsn[master]: gprs_sndcp_xid: use reasonable static buffer size
by lynxis lazus 26 Oct '26

26 Oct '26

Attention is currently required from: dexter. lynxis lazus has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43957?usp=email ) Change subject: gprs_sndcp_xid: use reasonable static buffer size ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43957?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: If348e15a98fd6d28a1de08df57983bb710001d73 Gerrit-Change-Number: 43957 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Oct 2026 11:50:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-gprs[master]: sndcp_xid: fix length check in gprs_sndcp_compile_xid
by dexter 26 Oct '26

26 Oct '26

dexter has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/43962?usp=email ) Change subject: sndcp_xid: fix length check in gprs_sndcp_compile_xid ...................................................................... sndcp_xid: fix length check in gprs_sndcp_compile_xid The function gprs_sndcp_compile_xid gets an output buffer (dst) and a length (dst_maxlen), but unfortunately, the length is not checked before data is written to the output buffer (tlv_put). The problem was reported by osmocom.org user tsato (see related ticket) This patch has been ported from: osmo-sgsn.git I977946a036f96d4dee2656bef048e2618198db40 Related: OS#7095 Change-Id: I38844155027673d90079c84df5cfd85053f48656 --- M src/sndcp/sndcp_xid.c M tests/sndcp/sndcp_xid_test.c M tests/sndcp/sndcp_xid_test.ok 3 files changed, 41 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified dexter: Looks good to me, approved diff --git a/src/sndcp/sndcp_xid.c b/src/sndcp/sndcp_xid.c index 4442f18..28e8928 100644 --- a/src/sndcp/sndcp_xid.c +++ b/src/sndcp/sndcp_xid.c @@ -587,8 +587,10 @@ OSMO_ASSERT(rc >= 0); if (rc > 0) { + byte_counter += TLV_GROSS_LEN(rc); + if (byte_counter > dst_maxlen) + return -ENOMEM; dst = tlv_put(dst, SNDCP_XID_DATA_COMPRESSION, rc, comp_bytes); - byte_counter += rc + 2; } /* Add header compression fields */ @@ -598,9 +600,11 @@ OSMO_ASSERT(rc >= 0); if (rc > 0) { + byte_counter += TLV_GROSS_LEN(rc); + if (byte_counter > dst_maxlen) + return -ENOMEM; dst = tlv_put(dst, SNDCP_XID_PROTOCOL_COMPRESSION, rc, comp_bytes); - byte_counter += rc + 2; } /* Return generated length */ diff --git a/tests/sndcp/sndcp_xid_test.c b/tests/sndcp/sndcp_xid_test.c index 63a479a..a9f576a 100644 --- a/tests/sndcp/sndcp_xid_test.c +++ b/tests/sndcp/sndcp_xid_test.c @@ -246,6 +246,38 @@ talloc_free(comp_fields_dec); } +/* Encode fields SNDCP-XID fields into a destination buffer that is to small */ +static void test_xid_encode_overflow(const void *ctx) +{ + printf("Testing SNDCP XID-Encoder with too small output buffer (overflow)\n"); + + LLIST_HEAD(comp_fields); + struct gprs_sndcp_pcomp_rfc1144_params rfc1144_params; + struct gprs_sndcp_comp_field rfc1144_comp_field; + + uint8_t xid[16]; + unsigned int xid_len = sizeof(xid); + int rc; + + /* Setup dummy rfc1144 compression fields. This field is artificially enlarged and the encoding result will + not fit into the xid buffer above. (we will leave all rfc1144_comp_field.comp values at zero) */ + memset(&rfc1144_comp_field, 0, sizeof(struct gprs_sndcp_comp_field)); + rfc1144_params.nsapi[0] = 5; + rfc1144_params.nsapi_len = 1; + rfc1144_params.s01 = 7; + rfc1144_comp_field.p = 1; + rfc1144_comp_field.entity = 0; + rfc1144_comp_field.algo.pcomp = RFC_1144; + rfc1144_comp_field.comp_len = 15; + rfc1144_comp_field.rfc1144_params = &rfc1144_params; + llist_add(&rfc1144_comp_field.list, &comp_fields); + + rc = gprs_sndcp_compile_xid(xid, xid_len, &comp_fields, + DEFAULT_SNDCP_VERSION); + printf("rc: %d\n", rc); + OSMO_ASSERT(rc < 0); +} + static struct log_info_cat gprs_categories[] = { [DSNDCP] = { .name = "DSNDCP", @@ -276,6 +308,7 @@ test_xid_decode_realworld(xid_ctx); test_xid_encode_decode(xid_ctx); + test_xid_encode_overflow(xid_ctx); printf("Done\n"); diff --git a/tests/sndcp/sndcp_xid_test.ok b/tests/sndcp/sndcp_xid_test.ok index f357282..f23b119 100644 --- a/tests/sndcp/sndcp_xid_test.ok +++ b/tests/sndcp/sndcp_xid_test.ok @@ -8,4 +8,6 @@ Test input data: Encoded: 000100011a83010dab00208003012c012c02580258830007a000200308001402408000041200200781010c3456700040010005a80f000f82022789ffe0000f00a80000000101010002010200030103000401040005010500060007010700080108 (97 bytes) Decoded: +Testing SNDCP XID-Encoder with too small output buffer (overflow) +rc: -12 Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/43962?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I38844155027673d90079c84df5cfd85053f48656 Gerrit-Change-Number: 43962 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-gprs[master]: sndcp_xid: fix length check in gprs_sndcp_compile_xid
by dexter 26 Oct '26

26 Oct '26

Attention is currently required from: fixeria, pespin. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/43962?usp=email ) Change subject: sndcp_xid: fix length check in gprs_sndcp_compile_xid ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/43962?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I38844155027673d90079c84df5cfd85053f48656 Gerrit-Change-Number: 43962 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Oct 2026 11:45:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-sgsn[master]: gprs_sndcp_xid: fix length check in gprs_sndcp_compile_xid
by dexter 26 Oct '26

26 Oct '26

dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43953?usp=email ) Change subject: gprs_sndcp_xid: fix length check in gprs_sndcp_compile_xid ...................................................................... gprs_sndcp_xid: fix length check in gprs_sndcp_compile_xid The function gprs_sndcp_compile_xid gets an output buffer (dst) and a length (dst_maxlen), but unfortunately, the length is not checked before data is written to the output buffer (tlv_put). The problem was reported by osmocom.org user tsato (see related ticket) Related: OS#7095 Change-Id: I977946a036f96d4dee2656bef048e2618198db40 --- M src/sgsn/gprs_sndcp_xid.c M tests/sndcp_xid/sndcp_xid_test.c M tests/sndcp_xid/sndcp_xid_test.ok 3 files changed, 41 insertions(+), 2 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/sgsn/gprs_sndcp_xid.c b/src/sgsn/gprs_sndcp_xid.c index 344fda4..0b981b5 100644 --- a/src/sgsn/gprs_sndcp_xid.c +++ b/src/sgsn/gprs_sndcp_xid.c @@ -593,8 +593,10 @@ OSMO_ASSERT(rc >= 0); if (rc > 0) { + byte_counter += TLV_GROSS_LEN(rc); + if (byte_counter > dst_maxlen) + return -ENOMEM; dst = tlv_put(dst, SNDCP_XID_DATA_COMPRESSION, rc, comp_bytes); - byte_counter += rc + 2; } /* Add header compression fields */ @@ -604,9 +606,11 @@ OSMO_ASSERT(rc >= 0); if (rc > 0) { + byte_counter += TLV_GROSS_LEN(rc); + if (byte_counter > dst_maxlen) + return -ENOMEM; dst = tlv_put(dst, SNDCP_XID_PROTOCOL_COMPRESSION, rc, comp_bytes); - byte_counter += rc + 2; } /* Return generated length */ diff --git a/tests/sndcp_xid/sndcp_xid_test.c b/tests/sndcp_xid/sndcp_xid_test.c index 92f04ba..5cb7817 100644 --- a/tests/sndcp_xid/sndcp_xid_test.c +++ b/tests/sndcp_xid/sndcp_xid_test.c @@ -244,6 +244,38 @@ talloc_free(comp_fields_dec); } +/* Encode fields SNDCP-XID fields into a destination buffer that is to small */ +static void test_xid_encode_overflow(const void *ctx) +{ + printf("Testing SNDCP XID-Encoder with too small output buffer (overflow)\n"); + + LLIST_HEAD(comp_fields); + struct gprs_sndcp_pcomp_rfc1144_params rfc1144_params; + struct gprs_sndcp_comp_field rfc1144_comp_field; + + uint8_t xid[16]; + unsigned int xid_len = sizeof(xid); + int rc; + + /* Setup dummy rfc1144 compression fields. This field is artificially enlarged and the encoding result will + not fit into the xid buffer above. (we will leave all rfc1144_comp_field.comp values at zero) */ + memset(&rfc1144_comp_field, 0, sizeof(struct gprs_sndcp_comp_field)); + rfc1144_params.nsapi[0] = 5; + rfc1144_params.nsapi_len = 1; + rfc1144_params.s01 = 7; + rfc1144_comp_field.p = 1; + rfc1144_comp_field.entity = 0; + rfc1144_comp_field.algo.pcomp = RFC_1144; + rfc1144_comp_field.comp_len = 15; + rfc1144_comp_field.rfc1144_params = &rfc1144_params; + llist_add(&rfc1144_comp_field.list, &comp_fields); + + rc = gprs_sndcp_compile_xid(xid, xid_len, &comp_fields, + DEFAULT_SNDCP_VERSION); + printf("rc: %d\n", rc); + OSMO_ASSERT(rc < 0); +} + static struct log_info_cat gprs_categories[] = { [DSNDCP] = { .name = "DSNDCP", @@ -269,6 +301,7 @@ test_xid_decode_realworld(xid_ctx); test_xid_encode_decode(xid_ctx); + test_xid_encode_overflow(xid_ctx); printf("Done\n"); diff --git a/tests/sndcp_xid/sndcp_xid_test.ok b/tests/sndcp_xid/sndcp_xid_test.ok index f357282..f23b119 100644 --- a/tests/sndcp_xid/sndcp_xid_test.ok +++ b/tests/sndcp_xid/sndcp_xid_test.ok @@ -8,4 +8,6 @@ Test input data: Encoded: 000100011a83010dab00208003012c012c02580258830007a000200308001402408000041200200781010c3456700040010005a80f000f82022789ffe0000f00a80000000101010002010200030103000401040005010500060007010700080108 (97 bytes) Decoded: +Testing SNDCP XID-Encoder with too small output buffer (overflow) +rc: -12 Done -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43953?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I977946a036f96d4dee2656bef048e2618198db40 Gerrit-Change-Number: 43953 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-gprs[master]: sndcp_xid: fix length check in gprs_sndcp_compile_xid
by dexter 26 Oct '26

26 Oct '26

Attention is currently required from: fixeria, pespin. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-gprs/+/43962?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Code-Review+2 by pespin The change is no longer submittable: Code-Review is unsatisfied now. Change subject: sndcp_xid: fix length check in gprs_sndcp_compile_xid ...................................................................... sndcp_xid: fix length check in gprs_sndcp_compile_xid The function gprs_sndcp_compile_xid gets an output buffer (dst) and a length (dst_maxlen), but unfortunately, the length is not checked before data is written to the output buffer (tlv_put). The problem was reported by osmocom.org user tsato (see related ticket) This patch has been ported from: osmo-sgsn.git I977946a036f96d4dee2656bef048e2618198db40 Related: OS#7095 Change-Id: I38844155027673d90079c84df5cfd85053f48656 --- M src/sndcp/sndcp_xid.c M tests/sndcp/sndcp_xid_test.c M tests/sndcp/sndcp_xid_test.ok 3 files changed, 41 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-gprs refs/changes/62/43962/3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/43962?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I38844155027673d90079c84df5cfd85053f48656 Gerrit-Change-Number: 43962 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-gprs[master]: sndcp_xid: fix length check in gprs_sndcp_compile_xid
by dexter 26 Oct '26

26 Oct '26

Attention is currently required from: fixeria, pespin. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/43962?usp=email ) The change is no longer submittable: Code-Review is unsatisfied now. Change subject: sndcp_xid: fix length check in gprs_sndcp_compile_xid ...................................................................... Patch Set 3: (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmo-gprs/+/43962/comment/47106b3b_ed003c51… : PS2, Line 16: This patch has been orted from: > ported from Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/43962?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I38844155027673d90079c84df5cfd85053f48656 Gerrit-Change-Number: 43962 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Oct 2026 11:44:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: pySim-trace: ignore all other exception and retry parsing it
by dexter 26 Oct '26

26 Oct '26

Attention is currently required from: lynxis lazus. dexter has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/pysim/+/43196?usp=email ) Change subject: pySim-trace: ignore all other exception and retry parsing it ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43196?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I53a5e7e7087073f242eab1d86ef8a9ec929193bd Gerrit-Change-Number: 43196 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 26 Oct 2026 10:59:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: pySim/apdu: protect SW access from None
by dexter 26 Oct '26

26 Oct '26

Attention is currently required from: lynxis lazus. dexter has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/pysim/+/43197?usp=email ) Change subject: pySim/apdu: protect SW access from None ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: As this fixes a real bug, let's merge this better sooner than later. Maybe you can re-order the patchset and merge this one early. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43197?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iff7fe02f700e0eb42766a3264a856fc7947cdcd2 Gerrit-Change-Number: 43197 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 26 Oct 2026 10:58:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-ttcn3-hacks[master]: bts: f_TC_pcu_tx_ul_block_req(): target the block after the next one
by fixeria 26 Oct '26

26 Oct '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43964?usp=email ) Change subject: bts: f_TC_pcu_tx_ul_block_req(): target the block after the next one ...................................................................... bts: f_TC_pcu_tx_ul_block_req(): target the block after the next one trxcon sends the L1CTL DL BLOCK.ind after the last burst of a block has been received, while the Uplink bursts are scheduled in advance (see '--trx-advance', default 2). Thus it's already too late to target the block following the received one: trxcon drops such UL BLOCK.req as stale, and TC_pcu_data_ind_lqual_cb fails with "Timeout waiting for PCUIF_DATA.ind". Fix this by targeting the block after the next one. While at it, use the existing f_next_pdtch_block() instead of open-coding the TDMA Fn calculation. Change-Id: Ie77761c472ba14ad17414c347e1aed140a3295e8 --- M bts/BTS_Tests.ttcn 1 file changed, 7 insertions(+), 9 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index 719d8e3..719a9fa 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -5335,21 +5335,19 @@ T.start(1.0); alt { [] as_l1ctl_dl_block_ind(block_ind, tn := tn, usf := usf) { - var integer fn := block_ind.hdr.fn; + var GsmFrameNumber fn := block_ind.hdr.fn; /* Ignore PTCCH/D blocks, their Fn is too far away */ if (fn mod 104 == 12) { repeat; } - /* Every fn % 13 == 12 we have either a PTCCH or an IDLE slot, thus - * every fn % 13 == 8 we add 5 frames, or 4 frames othrwise. The - * resulting value is first fn of the next block. */ - if (fn mod 13 == 8) { - fn := (fn + 5) mod (2048 * 51 * 26); - } else { - fn := (fn + 4) mod (2048 * 51 * 26); - } + /* Skip the next block, target the one after it. + * The DL BLOCK.ind is sent by trxcon after the last burst of a block + * has been received, while the Uplink bursts are scheduled in advance, + * so it's already too late to target the block following the received + * one. Hence the UL BLOCK.req targets the block after the next one. */ + fn := f_next_pdtch_block(f_next_pdtch_block(fn)); L1CTL.send(ts_L1CTL_GPRS_UL_BLOCK_REQ(fn, block_ind.hdr.tn, data)); return {fn, block_ind.hdr.tn}; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43964?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie77761c472ba14ad17414c347e1aed140a3295e8 Gerrit-Change-Number: 43964 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-dev[master]: ttcn3/tmux: check-in ttcn3-s1gw-test.sh
by fixeria 26 Oct '26

26 Oct '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/43945?usp=email ) Change subject: ttcn3/tmux: check-in ttcn3-s1gw-test.sh ...................................................................... ttcn3/tmux: check-in ttcn3-s1gw-test.sh Change-Id: Ie4cfd665f166feb06e35f341f348bc196bcfa215 --- A ttcn3/tmux/ttcn3-s1gw-test.sh 1 file changed, 17 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/ttcn3/tmux/ttcn3-s1gw-test.sh b/ttcn3/tmux/ttcn3-s1gw-test.sh new file mode 100755 index 0000000..c03cae1 --- /dev/null +++ b/ttcn3/tmux/ttcn3-s1gw-test.sh @@ -0,0 +1,17 @@ +#!/bin/sh + +SESSION="ttcn3-s1gw-test" + +OSMO_DIR="/home/$USER/osmocom" +S1GW_DIR="$OSMO_DIR/osmo-s1gw" +SUITE_DIR="$OSMO_DIR/osmo-ttcn3-hacks" + +tmux new-session -s $SESSION -n $SESSION -d + +tmux split-window -t $SESSION:0 -v +tmux send-keys -t $SESSION:0.0 "cd $S1GW_DIR" C-m +tmux send-keys -t $SESSION:0.0 "make shell CONFIG=$SUITE_DIR/s1gw/osmo-s1gw.config" C-m +tmux send-keys -t $SESSION:0.1 "cd $SUITE_DIR/s1gw" C-m +tmux send-keys -t $SESSION:0.1 "../start-testsuite.sh s1gw/S1GW_Tests S1GW_Tests.cfg" + +tmux attach -t $SESSION:0 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/43945?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Ie4cfd665f166feb06e35f341f348bc196bcfa215 Gerrit-Change-Number: 43945 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log October 2026