Attention is currently required from: laforge.
Jenkins Builder has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/43151?usp=email )
Change subject: linuxlist: drop no-op prefetch() calls
......................................................................
Patch Set 2:
(4 comments)
File include/osmocom/core/linuxlist.h:
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/libosmocore/+/43151/comment/93c6ef1b_fe37bd50?… :
PS2, Line 362: pos = pos->next, ({ smp_read_barrier_depends(); 0;}))
space required after that ';' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/libosmocore/+/43151/comment/a67033f1_81d36eb8?… :
PS2, Line 384: __llist_member(pos, member) != (head); \
please, no space before tabs
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/libosmocore/+/43151/comment/a49babc9_4933fc80?… :
PS2, Line 386: ({ smp_read_barrier_depends(); 0;}))
space required after that ';' (ctx:VxV)
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/libosmocore/+/43151/comment/4039e91a_c4d12568?… :
PS2, Line 395: (pos) = (pos)->next, ({ smp_read_barrier_depends(); 0;}))
space required after that ';' (ctx:VxV)
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/43151?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Id84973330df44b4efdd1bd85e4b7c3cb88642f92
Gerrit-Change-Number: 43151
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Fri, 31 Jul 2026 18:56:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: laforge.
Hello laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmocore/+/43151?usp=email
to look at the new patch set (#2).
Change subject: linuxlist: drop no-op prefetch() calls
......................................................................
linuxlist: drop no-op prefetch() calls
prefetch() has always been a no-op stub in this header so calling
it buys nothing at runtime. Drop all call sites and remove the
now-dead stub itself.
The macro was copied over from the Linux kernel, where prefetch()
is a real, arch-specific cache prefetch hint; here it never was
anything but an empty inline function.
Change-Id: Id84973330df44b4efdd1bd85e4b7c3cb88642f92
Related: OS#7036, OS#6858
---
M include/osmocom/core/linuxlist.h
1 file changed, 17 insertions(+), 30 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/51/43151/2
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/43151?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Id84973330df44b4efdd1bd85e4b7c3cb88642f92
Gerrit-Change-Number: 43151
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Attention is currently required from: pespin.
fixeria has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/libosmocore/+/43150?usp=email )
Change subject: linuxlist: fix false-positive UBSan misaligned-access reports
......................................................................
linuxlist: fix false-positive UBSan misaligned-access reports
llist_for_each_entry() and its variants terminate by comparing
&pos->member against head. Once a full traversal reaches the end of a
non-empty list (or the list is empty to begin with), pos becomes a pure
container_of()-computed sentinel address that was never a real object
of typeof(*pos), only ever the plain 'struct llist_head *' passed in as
head. Forming 'pos->member' on that address requires pos to satisfy
the alignment of typeof(*pos), which the sentinel does not necessarily
provide (e.g. embedded struct osmo_timer_list/gprs_nsvc on 32-bit ARM
with a 64-bit time_t need 8-byte alignment, while head itself is only
pointer-aligned) - tripping -fsanitize=alignment even though no real
object is ever misaligned or dereferenced.
Add __llist_member(), computing the same address via 'char *'
pointer arithmetic and an explicit cast to 'struct llist_head *', which
carries no alignment requirement of its own. Use it for the loop
termination check, the "next" pointer computation, and the prefetch()
calls (dereferencing the returned struct llist_head * still only
requires pointer alignment, so prefetch() keeps working exactly
as before without reintroducing the false positive).
Change-Id: I0424e76e76d8aa9402bd1a5aefe789de16e72fae
Related: OS#7036, OS#6858
---
M include/osmocom/core/linuxlist.h
1 file changed, 33 insertions(+), 19 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/50/43150/2
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/43150?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I0424e76e76d8aa9402bd1a5aefe789de16e72fae
Gerrit-Change-Number: 43150
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/43150?usp=email )
Change subject: linuxlist: fix false-positive UBSan misaligned-access reports
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> +1 once you fix the space vs tab at the end.
I don't understand what the linter wants here, TBH.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/43150?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I0424e76e76d8aa9402bd1a5aefe789de16e72fae
Gerrit-Change-Number: 43150
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 31 Jul 2026 18:45:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/43150?usp=email )
Change subject: linuxlist: fix false-positive UBSan misaligned-access reports
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
+1 once you fix the space vs tab at the end.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/43150?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I0424e76e76d8aa9402bd1a5aefe789de16e72fae
Gerrit-Change-Number: 43150
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 31 Jul 2026 18:43:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Jenkins Builder has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/43150?usp=email )
Change subject: linuxlist: fix false-positive UBSan misaligned-access reports
......................................................................
Patch Set 1:
(2 comments)
File include/osmocom/core/linuxlist.h:
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/libosmocore/+/43150/comment/3b963472_872c0acc?… :
PS1, Line 364: __llist_member(pos, member) != (head); \
please, no space before tabs
Robot Comment from checkpatch (run ID ):
https://gerrit.osmocom.org/c/libosmocore/+/43150/comment/2b94d327_66175006?… :
PS1, Line 396: __llist_member(pos, member) != (head); \
please, no space before tabs
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/43150?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I0424e76e76d8aa9402bd1a5aefe789de16e72fae
Gerrit-Change-Number: 43150
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Fri, 31 Jul 2026 18:41:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No