Attention is currently required from: neels, pespin, dexter.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31145 )
Change subject: bts: add IMMEDIATE ASSIGNMENT via PCH transmission
......................................................................
Patch Set 18:
(1 comment)
File src/bts.cpp:
https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/684db5eb_79093fbe
PS17, Line 1134: pcu_l1if_tx_pch(bts, immediate_assignment, plen, ms_paging_group(tbf_ms(tbf)));
> > ... PCU will become incompatible with osmo-bts […]
Here is the BTS side patch: https://gerrit.osmocom.org/c/osmo-bts/+/31600 [WIP].
Let me know if you need me to help with the TTCN-3 stuff - there we will need backwards compatibility.
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31145
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I2a78651593323e8b9627c39918d949a33497b70f
Gerrit-Change-Number: 31145
Gerrit-PatchSet: 18
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 28 Feb 2023 21:24:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: neels, pespin, dexter.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31145 )
Change subject: bts: add IMMEDIATE ASSIGNMENT via PCH transmission
......................................................................
Patch Set 18: Code-Review-1
(1 comment)
File include/osmocom/pcu/pcuif_proto.h:
https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/39be9e40_3c907ecb
PS17, Line 280: uint8_t pgroup[3];
Wait a minute, I am confused by this field. It's named `pgroup`, so that means it's supposed to contain a paging group, right? But in reality it's just the last three digits of the IMSI converted to ASCII.
For some reason in osmo-pcu we convert these last three digits to ASCII, and then in osmo-bts (see `paging_add_imm_ass()`) we convert three ASCII bytes back to an integer add feed to `gsm0502_calc_paging_group()`.
> I think this would then make using the struct at the BSC side more complicated
I haven't looked at the BSC's implementation of the relevant part, but I don't see how using ASCII instead of plain integers simplifies things either.
> The thing is that this value ends up at extract_paging_group and this function does a str_to_imsi(imsi_digit_buf) with the value ...
So by sending a plain integer stored in `uint16_t` here we actually eliminate the need for `str_to_imsi()`.
> If we can feed gsm0502_calc_paging_group() the pgroup value from here directly then we can use an uint16_t.
I am pretty sure we can, why not.
To summarize:
* I see no reason for using ASCII to carry the last three digits of IMSI,
* so let's just send plain integer here, directly from `ms_paging_group()`.
* I agree with Pau that we should simply use `uint16_t`.
* Name the field `imsi`, it's not a paging group itself.
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31145
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I2a78651593323e8b9627c39918d949a33497b70f
Gerrit-Change-Number: 31145
Gerrit-PatchSet: 18
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 28 Feb 2023 20:59:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: neels, pespin, dexter.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31145 )
Change subject: bts: add IMMEDIATE ASSIGNMENT via PCH transmission
......................................................................
Patch Set 18:
(4 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/c681e679_fca4667c
PS18, Line 7: bts: add IMMEDIATE ASSIGNMENT via PCH transmission
The commit message contains nothing about bumping the PCUIF version.
Such changes should definitely be reflected in the commit log, IMO.
File include/osmocom/pcu/pcuif_proto.h:
https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/76c17bd0_245e4ec4
PS18, Line 43: PCU_IF_SAPI_PCH_DT
Didn't we agree that in the new PCUIF version there will be only one way to send DL blocks over PCH and the message will always contain TLLI now. I remember Pau complaining that having several ways to do the same thing is a mess. My understanding is that there should be only `PCU_IF_SAPI_PCH` in the new version and it shall always contain a TLLI.
Ah, now I see comments from Pau and your response about backwards compatibility.
https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/8fddec62_fdec130c
PS18, Line 273: is send
typo: is sent
File src/bts.cpp:
https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/4ec80c15_17cafdc2
PS17, Line 1134: pcu_l1if_tx_pch(bts, immediate_assignment, plen, ms_paging_group(tbf_ms(tbf)));
> ... PCU will become incompatible with osmo-bts
Yes, this is expected and desired when you bump the PCUIF version.
> As far as I remember we decided to add a deprecation warning and upgrade osmo-bts later.
It was discussed *before* we came to a conclusion that bumping the PCUIF version is needed after all. The point was to prevent the user from running an old version of osmo-pcu, which does not support and ignores the new E1 configuration messages.
> ... lets not get blocked by the BTS part and keep compatibility for now
Ok, now I see the reason why you're keeping the old messages and backwards compatibility (nothing in the commit message explains that). But what would it take to get this implemented in osmo-bts? I can quickly help you with that, so we just bump the PCUIF version and be done with it. I think 1h would be enough for me to implement this on the BTS side.
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31145
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I2a78651593323e8b9627c39918d949a33497b70f
Gerrit-Change-Number: 31145
Gerrit-PatchSet: 18
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 28 Feb 2023 19:10:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: osmith.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/31598 )
Change subject: docker kill: wait until containers are stopped
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File jenkins-common.sh:
https://gerrit.osmocom.org/c/docker-playground/+/31598/comment/ac85a66a_930…
PS2, Line 195: "$1"
Might be a good idea to allow specifying several containers at once.
Both kill and wait commands do support this. Can be achieved by using "$*" here.
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/31598
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I0242ece96541d8036ebbf8b0f498ebf231db26b5
Gerrit-Change-Number: 31598
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 28 Feb 2023 19:05:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31576 )
Change subject: rlcmac: dl_tbf: Improve logic requesting a new UL TBF
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31576
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I702872ba32a410bb5f09943af3cdadca482562db
Gerrit-Change-Number: 31576
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 28 Feb 2023 19:05:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment