February 2023 - gerrit-log - lists.osmocom.org

[S] Change in libosmocore[master]: osmo_wqueue_enqueue(): Avoid redundant if-check

by arehbein

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/31591 to look at the new patch set (#2). Change subject: osmo_wqueue_enqueue(): Avoid redundant if-check ...................................................................... osmo_wqueue_enqueue(): Avoid redundant if-check Remove call to osmo_wqueue_enqueue_quiet(), which checks the same condition as osmo_wqueue_enqueue. The result is basically one function less on the call stack and one if-check less; while having two more statements in osmo_wqueue_enqueue() itself compared to before. Change-Id: I3ecc1698e836ca40e178a5b84c2946ae0e6bbfc9 --- M src/core/write_queue.c 1 file changed, 17 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/91/31591/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31591 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3ecc1698e836ca40e178a5b84c2946ae0e6bbfc9 Gerrit-Change-Number: 31591 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

1 year, 1 month

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: pgw: Avoid access to unbound global variable

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31592 ) Change subject: pgw: Avoid access to unbound global variable ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31592 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9731b755ddc7bb3ebd56bdec550961cc36f2e2c6 Gerrit-Change-Number: 31592 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 12:01:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-bsc[master]: bssmap_handle_ass_req_tp_codec_list: tweak log msg

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31550 ) Change subject: bssmap_handle_ass_req_tp_codec_list: tweak log msg ...................................................................... Patch Set 2: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/31550/comment/2c7af3d7_e6e6555c PS1, Line 9: Remove "speech mode" from the log message, as it is relevant for CSD > as it is not relevant? "as it is relevant" with "it" meaning the log message. I've reworded it. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31550 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Idfab0b7f6e97a6b67d140f967ddfe9b29818586e Gerrit-Change-Number: 31550 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 11:50:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[M] Change in osmo-bsc[master]: rsl_tx_ipacc_crcx/mdcx: omit speech mode for CSD

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31549 ) Change subject: rsl_tx_ipacc_crcx/mdcx: omit speech mode for CSD ...................................................................... Patch Set 2: (1 comment) File src/osmo-bsc/abis_rsl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31549/comment/89597ff0_280cb653 PS1, Line 2747: if (lchan->abis_ip.rtp_payload == RTP_PT_CSDATA) > match {} with else below. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31549 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6641b713177276bcf798f08123e1dd2e88ffdce6 Gerrit-Change-Number: 31549 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 11:50:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[M] Change in osmo-bsc[master]: bssmap_handle_ass_req_ct_data: implement

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31547 ) Change subject: bssmap_handle_ass_req_ct_data: implement ...................................................................... Patch Set 2: (1 comment) File include/osmocom/bsc/codec_pref.h: https://gerrit.osmocom.org/c/osmo-bsc/+/31547/comment/11f056ba_ca4c80b7 PS1, Line 22: const bool full_rate); > I wonder why is enum rate_pref rate_pref not used here. Because it is not possible to use RATE_PREF_NONE here, so it's a boolean. Do you think it makes more sense to use enum rate_pref regardless of this? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31547 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I350bea15fd2158eb6edc9bc92f2dca48930736e9 Gerrit-Change-Number: 31547 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 11:50:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[M] Change in osmo-bsc[master]: codec_pref: split test_codec_support_bts_rate

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31544 ) Change subject: codec_pref: split test_codec_support_bts_rate ...................................................................... Patch Set 2: (1 comment) File src/osmo-bsc/codec_pref.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31544/comment/5547a57d_616f3fec PS1, Line 211: if (rc < 0 || !test_codec_support_bts_rate(bts, full_rate)) > this looks a bit weird/condensed, you could split it into 2 ifs like it was before. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31544 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iea8a23ef3c66ed556110038fe9f3bc7f6eef3e96 Gerrit-Change-Number: 31544 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 11:49:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[M] Change in osmo-bsc[master]: bssmap_handle_ass_req_ct_speech: refactor

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31543 ) Change subject: bssmap_handle_ass_req_ct_speech: refactor ...................................................................... Patch Set 2: (1 comment) File src/osmo-bsc/osmo_bsc_bssap.c: https://gerrit.osmocom.org/c/osmo-bsc/+/31543/comment/40814f45_6b555a14 PS1, Line 994: struct assignment_request req; > change looks non related? Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31543 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6bb16b26d89056dffa50bd8296fefe9315c587ca Gerrit-Change-Number: 31543 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 11:49:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[M] Change in osmo-bsc[master]: bssmap_handle_ass_req_ct_speech: refactor

by osmith

Attention is currently required from: osmith. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/31543 to look at the new patch set (#2). Change subject: bssmap_handle_ass_req_ct_speech: refactor ...................................................................... bssmap_handle_ass_req_ct_speech: refactor Move the translation from osmo_sockaddr_to_str_and_uint into bssmap_handle_ass_req_tp_rtp_addr, which will be used by bssmap_handle_ass_req_ct_data in a future patch too. Pass pointers to variables in req, instead of duplicating variables and filling it in later (like in bssmap_handle_ass_req_ct_sign). Related: OS#4393 Change-Id: I6bb16b26d89056dffa50bd8296fefe9315c587ca --- M src/osmo-bsc/osmo_bsc_bssap.c 1 file changed, 42 insertions(+), 34 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/43/31543/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31543 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6bb16b26d89056dffa50bd8296fefe9315c587ca Gerrit-Change-Number: 31543 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 1 month

1
0
0 0

[M] Change in osmo-bsc[master]: codec_pref: split test_codec_support_bts_rate

by osmith

Attention is currently required from: osmith. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/31544 to look at the new patch set (#2). Change subject: codec_pref: split test_codec_support_bts_rate ...................................................................... codec_pref: split test_codec_support_bts_rate Move the check for the rate into an extra function, so it can be used for CSD without checking a speech codec at the same time. Related: OS#4393 Change-Id: Iea8a23ef3c66ed556110038fe9f3bc7f6eef3e96 --- M src/osmo-bsc/codec_pref.c 1 file changed, 37 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/44/31544/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31544 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Iea8a23ef3c66ed556110038fe9f3bc7f6eef3e96 Gerrit-Change-Number: 31544 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 1 month

1
0
0 0

[M] Change in osmo-bsc[master]: rsl_tx_ipacc_crcx/mdcx: omit speech mode for CSD

by osmith

Attention is currently required from: osmith. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/31549 to look at the new patch set (#2). Change subject: rsl_tx_ipacc_crcx/mdcx: omit speech mode for CSD ...................................................................... rsl_tx_ipacc_crcx/mdcx: omit speech mode for CSD Omit the A-bis/IP specific RSL_IE_IPAC_SPEECH_MODE, as it doesn't make sense for circuit switched data. Related: OS#4393 Change-Id: I6641b713177276bcf798f08123e1dd2e88ffdce6 --- M src/osmo-bsc/abis_rsl.c M src/osmo-bsc/lchan_rtp_fsm.c 2 files changed, 58 insertions(+), 24 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/49/31549/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31549 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6641b713177276bcf798f08123e1dd2e88ffdce6 Gerrit-Change-Number: 31549 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 1 month

1
0
0 0

[S] Change in osmo-bsc[master]: bssmap_handle_ass_req_tp_codec_list: tweak log msg

by osmith

Attention is currently required from: osmith. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/31550 to look at the new patch set (#2). Change subject: bssmap_handle_ass_req_tp_codec_list: tweak log msg ...................................................................... bssmap_handle_ass_req_tp_codec_list: tweak log msg Remove "speech mode" from the log message, as the log message is relevant for CSD too. According to 3GPP TS 48.008 § 3.2.1.1 note 13 the IE shall be included for AoIP unless channel type is signalling. Related: OS#4393 Change-Id: Idfab0b7f6e97a6b67d140f967ddfe9b29818586e --- M src/osmo-bsc/osmo_bsc_bssap.c 1 file changed, 15 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/50/31550/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31550 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Idfab0b7f6e97a6b67d140f967ddfe9b29818586e Gerrit-Change-Number: 31550 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 1 month

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: pgw: Avoid access to unbound global variable

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31592 ) Change subject: pgw: Avoid access to unbound global variable ...................................................................... pgw: Avoid access to unbound global variable This happens if GTv2C failed prior: """ 11:30:17.577738 15 PGW_Tests.ttcn:645 setverdict(fail): none -> fail reason: "Unexpected GTPv2 while waiting for CreateSessionResp", new component reason: "Une xpected GTPv2 while waiting for CreateSessionResp" 11:30:17.578004 15 PGW_Tests.ttcn:756 Dynamic test case error: Initializing a TTCN_Buffer with an unbound octetstring value. """ Change-Id: I9731b755ddc7bb3ebd56bdec550961cc36f2e2c6 --- M pgw/PGW_Tests.ttcn 1 file changed, 20 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/92/31592/1 diff --git a/pgw/PGW_Tests.ttcn b/pgw/PGW_Tests.ttcn index b8c363b..8a25ebf 100644 --- a/pgw/PGW_Tests.ttcn +++ b/pgw/PGW_Tests.ttcn @@ -753,6 +753,10 @@ private function f_ping4(charstring host, integer interval := 1, integer count := 10) runs on PGW_Session_CT { var charstring ping :="ping -c " & int2str(count) & " -i " & int2str(interval); + + if (not isbound(g_ip4_addr)) { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "f_ping4(): g_ip4_addr is unset!"); + } ping := ping & " -I " & f_inet_ntoa(g_ip4_addr); ping := ping & " " & host; f_start_prog_wait(ping, tout := int2float(5 + interval*count)); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/31592 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9731b755ddc7bb3ebd56bdec550961cc36f2e2c6 Gerrit-Change-Number: 31592 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 1 month

1
0
0 0

[S] Change in libosmocore[master]: osmo_wqueue_enqueue(): Avoid redundant if-check

by arehbein

arehbein has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/31591 ) Change subject: osmo_wqueue_enqueue(): Avoid redundant if-check ...................................................................... osmo_wqueue_enqueue(): Avoid redundant if-check Remove call to osmo_wqueue_enqueue_quiet(), which checks the same condition as osmo_wqueue_enqueue. The result is basically one function less on the call stack and one if-check less; while having one more statement in osmo_wqueue_enqueue() itself compared to before. Change-Id: I3ecc1698e836ca40e178a5b84c2946ae0e6bbfc9 --- M src/core/write_queue.c 1 file changed, 17 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/91/31591/1 diff --git a/src/core/write_queue.c b/src/core/write_queue.c index 884cebd..b5cbe6d 100644 --- a/src/core/write_queue.c +++ b/src/core/write_queue.c @@ -128,7 +128,10 @@ return -ENOSPC; } - return osmo_wqueue_enqueue_quiet(queue, data); + msgb_enqueue_count(&queue->msg_queue, data, &queue->current_length); + queue->bfd.when |= OSMO_FD_WRITE; + + return 0; } /*! Clear a \ref osmo_wqueue -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31591 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3ecc1698e836ca40e178a5b84c2946ae0e6bbfc9 Gerrit-Change-Number: 31591 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 1 month

1
0
0 0

[S] Change in osmo-bsc[master]: Cosmetic: fix various typos

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31539 ) Change subject: Cosmetic: fix various typos ...................................................................... Cosmetic: fix various typos Change-Id: I9225e733e3afa8171f24253e21eaffc654f689af --- M src/osmo-bsc/assignment_fsm.c M src/osmo-bsc/codec_pref.c 2 files changed, 11 insertions(+), 2 deletions(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-bsc/assignment_fsm.c b/src/osmo-bsc/assignment_fsm.c index e2213d4..d382f10 100644 --- a/src/osmo-bsc/assignment_fsm.c +++ b/src/osmo-bsc/assignment_fsm.c @@ -389,7 +389,7 @@ return 0; } -/* Check if the incoming assignment requests requires a voice stream or not, +/* Check if the incoming assignment request requires a voice stream or not, * we will look at the preferred and the alternate channel mode and also make * sure that both are consistent. */ static int check_requires_voice_stream(struct gsm_subscriber_connection *conn) diff --git a/src/osmo-bsc/codec_pref.c b/src/osmo-bsc/codec_pref.c index 9b4b37f..3824e14 100644 --- a/src/osmo-bsc/codec_pref.c +++ b/src/osmo-bsc/codec_pref.c @@ -376,7 +376,7 @@ break; } - /* Exit without result, in case no match can be deteched */ + /* Exit without result, in case no match can be detected */ if (!match) { ch_mode_rate->chan_mode = GSM48_CMODE_SIGN; ch_mode_rate->chan_rate = CH_RATE_SDCCH; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31539 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I9225e733e3afa8171f24253e21eaffc654f689af Gerrit-Change-Number: 31539 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 1 month

1
0
0 0

[S] Change in osmo-bsc[master]: Cosmetic: codec_pref: tweak comments

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31540 ) Change subject: Cosmetic: codec_pref: tweak comments ...................................................................... Cosmetic: codec_pref: tweak comments Remove "Helper function for match_codec_pref()" at the beginning of the descriptions of these functions, looks like a leftover from before this was moved to its own c file. Remove a duplicated "received" in a comment. Change-Id: I30f0744db9aebf2f05077fef840097c332b9dafd --- M src/osmo-bsc/codec_pref.c 1 file changed, 23 insertions(+), 12 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bsc/codec_pref.c b/src/osmo-bsc/codec_pref.c index 3824e14..a64425a 100644 --- a/src/osmo-bsc/codec_pref.c +++ b/src/osmo-bsc/codec_pref.c @@ -61,8 +61,7 @@ return 0; } -/* Helper function for match_codec_pref(), looks up a matching chan mode for - * a given permitted speech value */ +/* Look up a matching chan mode for a given permitted speech value */ static enum gsm48_chan_mode gsm88_to_chan_mode(enum gsm0808_permitted_speech speech) { switch (speech) { @@ -88,8 +87,7 @@ } } -/* Helper function for match_codec_pref(), looks up a matching permitted speech - * value for a given msc audio codec pref */ +/* Look up a matching permitted speech value for a given msc audio codec pref */ static enum gsm0808_permitted_speech audio_support_to_gsm88(const struct gsm_audio_support *audio) { if (audio->hr) { @@ -125,10 +123,9 @@ } } -/* Helper function for match_codec_pref(), tests if a given audio support - * matches one of the permitted speech settings of the channel type element. - * The matched permitted speech value is then also compared against the - * speech codec list. (optional, only relevant for AoIP) */ +/* Test if a given audio support matches one of the permitted speech settings + * of the channel type element. The matched permitted speech value is then also + * compared against the speech codec list. (optional, only relevant for AoIP) */ static bool test_codec_pref(const struct gsm0808_speech_codec **sc_match, const struct gsm0808_speech_codec_list *scl, const struct gsm0808_channel_type *ct, @@ -177,8 +174,8 @@ return false; } -/* Helper function to check if the given permitted speech value is supported - * by the BTS. (vty option bts->codec-support). */ +/* Check if the given permitted speech value is supported by the BTS + * (vty option bts->codec-support). */ static bool test_codec_support_bts(const struct gsm_bts *bts, uint8_t perm_spch) { struct gsm_bts_trx *trx; @@ -308,8 +305,8 @@ return 0; } -/*! Match the codec preferences from local config with a received codec preferences IEs received from the - * MSC and the BTS' codec configuration. +/*! Match the codec preferences from local config with codec preference IEs + * received from the MSC and the BTS' codec configuration. * \param[out] ch_mode_rate resulting codec and rate information * \param[in] ct GSM 08.08 channel type received from MSC. * \param[in] scl GSM 08.08 speech codec list received from MSC (optional). -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31540 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I30f0744db9aebf2f05077fef840097c332b9dafd Gerrit-Change-Number: 31540 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 1 month

1
0
0 0

[S] Change in osmo-bsc[master]: Cosmetic: codec_pref: tweak comments

by osmith

Attention is currently required from: neels. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31540 ) Change subject: Cosmetic: codec_pref: tweak comments ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31540 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I30f0744db9aebf2f05077fef840097c332b9dafd Gerrit-Change-Number: 31540 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 11:06:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-pcap[master]: osmo_{client,server}_main: Remove is_config_node in vty_app_info

by daniel

daniel has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/31588 ) Change subject: osmo_{client,server}_main: Remove is_config_node in vty_app_info ...................................................................... osmo_{client,server}_main: Remove is_config_node in vty_app_info This member is deprcated/unused so simply remove it: > 'is_config_node' is deprecated: Implicit parent node tracking has > replaced the use of this callback. This callback is no longer called, > ever, and can be left NULL. Change-Id: I34295950557d9009b0d8d3378deb3b1263476f82 --- M src/osmo_client_main.c M src/osmo_common.c M src/osmo_server_main.c 3 files changed, 15 insertions(+), 12 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo_client_main.c b/src/osmo_client_main.c index 8ca2df3..818a2f1 100644 --- a/src/osmo_client_main.c +++ b/src/osmo_client_main.c @@ -79,7 +79,6 @@ .name = "OsmoPCAPClient", .version = PACKAGE_VERSION, .go_parent_cb = osmopcap_go_parent, - .is_config_node = osmopcap_is_config_node, }; static void print_usage() diff --git a/src/osmo_common.c b/src/osmo_common.c index 39f448a..7c641e6 100644 --- a/src/osmo_common.c +++ b/src/osmo_common.c @@ -88,13 +88,3 @@ return vty->node; } - -int osmopcap_is_config_node(struct vty *vty, int node) -{ - switch (node) { - case CONFIG_NODE: - return 0; - default: - return 1; - } -} diff --git a/src/osmo_server_main.c b/src/osmo_server_main.c index 8ad89ba..4633888 100644 --- a/src/osmo_server_main.c +++ b/src/osmo_server_main.c @@ -89,7 +89,6 @@ .name = "OsmoPCAPServer", .version = PACKAGE_VERSION, .go_parent_cb = osmopcap_go_parent, - .is_config_node = osmopcap_is_config_node, }; static void print_usage() -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/31588 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I34295950557d9009b0d8d3378deb3b1263476f82 Gerrit-Change-Number: 31588 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 1 month

1
0
0 0

[S] Change in osmo-pcap[master]: cosmetic: Remove trailing whitespace

by daniel

daniel has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/31589 ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: cosmetic: Remove trailing whitespace ...................................................................... cosmetic: Remove trailing whitespace Change-Id: I33c8747f1f9c1020232e91d5559f0a06a31857d8 --- M src/osmo_common.c 1 file changed, 11 insertions(+), 2 deletions(-) Approvals: daniel: Looks good to me, approved pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo_common.c b/src/osmo_common.c index 7c641e6..b90d339 100644 --- a/src/osmo_common.c +++ b/src/osmo_common.c @@ -62,7 +62,7 @@ .num_cat = ARRAY_SIZE(default_categories), }; -const char *osmopcap_copyright = +const char *osmopcap_copyright = "Copyright (C) 2011-2017 Holger Freyther and contributors\r\n" "License AGPLv3+: GNU AGPL version 3 or later <http://gnu.org/licenses/agpl-3.0.html>\r\n" "This is free software: you are free to change and redistribute it.\r\n" @@ -86,5 +86,5 @@ break; } - return vty->node; + return vty->node; } -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/31589 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I33c8747f1f9c1020232e91d5559f0a06a31857d8 Gerrit-Change-Number: 31589 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 1 month

1
0
0 0

[S] Change in libosmocore[master]: libosmocore.map: add tall_{ctr/msgb}_ctx

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31590 ) Change subject: libosmocore.map: add tall_{ctr/msgb}_ctx ...................................................................... libosmocore.map: add tall_{ctr/msgb}_ctx These should not be used, but add them for backwards compatibility with building older versions of osmo-bsc, osmo-iuh, osmo-pcap against current libosmocore. Fixes: 213fc420 ("Add libosmocore.map") Change-Id: I4cfccf3622844d0923818bb8d8ce206f70e44a0d --- M src/core/libosmocore.map 1 file changed, 16 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve daniel: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/core/libosmocore.map b/src/core/libosmocore.map index 16b7261..984046b 100644 --- a/src/core/libosmocore.map +++ b/src/core/libosmocore.map @@ -559,7 +559,9 @@ rb_replace_node; sercomm_drv_lock; sercomm_drv_unlock; +tall_ctr_ctx; /* deprecated */ tall_log_ctx; +tall_msgb_ctx; /* deprecated */ local: *; }; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31590 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4cfccf3622844d0923818bb8d8ce206f70e44a0d Gerrit-Change-Number: 31590 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 1 month

1
0
0 0

[S] Change in osmo-pcap[master]: osmo_{client,server}_main: Remove is_config_node in vty_app_info

by pespin

Attention is currently required from: daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/31588 ) Change subject: osmo_{client,server}_main: Remove is_config_node in vty_app_info ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/31588 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I34295950557d9009b0d8d3378deb3b1263476f82 Gerrit-Change-Number: 31588 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 10:43:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-pcap[master]: osmo_{client,server}_main: Remove is_config_node in vty_app_info

by daniel

Attention is currently required from: pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/31588 ) Change subject: osmo_{client,server}_main: Remove is_config_node in vty_app_info ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > Don't you need to remove the symbol too? I should, yeah.. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/31588 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I34295950557d9009b0d8d3378deb3b1263476f82 Gerrit-Change-Number: 31588 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 10:41:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-pcap[master]: osmo_{client,server}_main: Remove is_config_node in vty_app_info

by daniel

Attention is currently required from: pespin. Hello osmith, Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcap/+/31588 to look at the new patch set (#2). Change subject: osmo_{client,server}_main: Remove is_config_node in vty_app_info ...................................................................... osmo_{client,server}_main: Remove is_config_node in vty_app_info This member is deprcated/unused so simply remove it: > 'is_config_node' is deprecated: Implicit parent node tracking has > replaced the use of this callback. This callback is no longer called, > ever, and can be left NULL. Change-Id: I34295950557d9009b0d8d3378deb3b1263476f82 --- M src/osmo_client_main.c M src/osmo_common.c M src/osmo_server_main.c 3 files changed, 15 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/88/31588/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/31588 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I34295950557d9009b0d8d3378deb3b1263476f82 Gerrit-Change-Number: 31588 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 1 month

1
0
0 0

[S] Change in libosmocore[master]: libosmocore.map: add tall_{ctr/msgb}_ctx

by daniel

Attention is currently required from: osmith. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31590 ) Change subject: libosmocore.map: add tall_{ctr/msgb}_ctx ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31590 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4cfccf3622844d0923818bb8d8ce206f70e44a0d Gerrit-Change-Number: 31590 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 10:37:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in libosmocore[master]: libosmocore.map: add tall_{ctr/msgb}_ctx

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31590 ) Change subject: libosmocore.map: add tall_{ctr/msgb}_ctx ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31590 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4cfccf3622844d0923818bb8d8ce206f70e44a0d Gerrit-Change-Number: 31590 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 10:33:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in libosmocore[master]: libosmocore.map: add tall_{ctr/msgb}_ctx

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31590 ) Change subject: libosmocore.map: add tall_{ctr/msgb}_ctx ...................................................................... Patch Set 3: (1 comment) File src/core/libosmocore.map: https://gerrit.osmocom.org/c/libosmocore/+/31590/comment/f13c0d67_9e33e6b7 PS2, Line 562: tall_ctr_ctx; > Maybe add comments in here regarding only exported due to historical reasons and are actually deprec […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31590 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4cfccf3622844d0923818bb8d8ce206f70e44a0d Gerrit-Change-Number: 31590 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 10:33:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in libosmocore[master]: libosmocore.map: add tall_{ctr/msgb}_ctx

by osmith

Attention is currently required from: osmith. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/31590 to look at the new patch set (#4). Change subject: libosmocore.map: add tall_{ctr/msgb}_ctx ...................................................................... libosmocore.map: add tall_{ctr/msgb}_ctx These should not be used, but add them for backwards compatibility with building older versions of osmo-bsc, osmo-iuh, osmo-pcap against current libosmocore. Fixes: 213fc420 ("Add libosmocore.map") Change-Id: I4cfccf3622844d0923818bb8d8ce206f70e44a0d --- M src/core/libosmocore.map 1 file changed, 16 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/90/31590/4 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31590 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4cfccf3622844d0923818bb8d8ce206f70e44a0d Gerrit-Change-Number: 31590 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 1 month

1
0
0 0

[S] Change in libosmo-sccp[master]: Transition to use of 'telnet_init_default'

by arehbein

arehbein has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/31516 ) Change subject: Transition to use of 'telnet_init_default' ...................................................................... Transition to use of 'telnet_init_default' Related: OS#5809 Change-Id: Icc57c68337d55c6594c1c36e9bf41624d11dab0a --- M examples/sccp_demo_user.c M stp/stp_main.c M tests/vty/ss7_asp_vty_test.c 3 files changed, 13 insertions(+), 4 deletions(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/examples/sccp_demo_user.c b/examples/sccp_demo_user.c index df6c9af..a88dd69 100644 --- a/examples/sccp_demo_user.c +++ b/examples/sccp_demo_user.c @@ -285,8 +285,7 @@ } } - rc = telnet_init_dynif(NULL, NULL, config_file ? vty_get_bind_addr() : local_address, - 2324+client); + rc = telnet_init_default(NULL, NULL, 2324 + client); if (rc < 0) { perror("Error binding VTY port"); exit(1); diff --git a/stp/stp_main.c b/stp/stp_main.c index 569cf8e..01d1865 100644 --- a/stp/stp_main.c +++ b/stp/stp_main.c @@ -243,7 +243,7 @@ exit(1); } - rc = telnet_init_dynif(tall_stp_ctx, NULL, vty_get_bind_addr(), OSMO_VTY_PORT_STP); + rc = telnet_init_default(tall_stp_ctx, NULL, OSMO_VTY_PORT_STP); if (rc < 0) { perror("Error binding VTY port\n"); exit(1); diff --git a/tests/vty/ss7_asp_vty_test.c b/tests/vty/ss7_asp_vty_test.c index 80ce3ec..5423f6f 100644 --- a/tests/vty/ss7_asp_vty_test.c +++ b/tests/vty/ss7_asp_vty_test.c @@ -182,7 +182,7 @@ } } - rc = telnet_init_dynif(root_ctx, NULL, vty_get_bind_addr(), 42043); + rc = telnet_init_default(root_ctx, NULL, 42043); if (rc < 0) return 2; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/31516 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Icc57c68337d55c6594c1c36e9bf41624d11dab0a Gerrit-Change-Number: 31516 Gerrit-PatchSet: 3 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 1 month

1
0
0 0

[S] Change in osmo-sgsn[master]: Transition to use of 'telnet_init_default'

by arehbein

arehbein has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/31523 ) Change subject: Transition to use of 'telnet_init_default' ...................................................................... Transition to use of 'telnet_init_default' Related: OS#5809 Change-Id: Icc57c68337d55c6594c1c36e9bf41624d11dab0a --- M src/gtphub/gtphub_main.c M src/sgsn/sgsn_main.c 2 files changed, 12 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/gtphub/gtphub_main.c b/src/gtphub/gtphub_main.c index d25123e..9b0532b 100644 --- a/src/gtphub/gtphub_main.c +++ b/src/gtphub/gtphub_main.c @@ -354,8 +354,7 @@ } /* start telnet after reading config for vty_get_bind_addr() */ - rc = telnet_init_dynif(osmo_gtphub_ctx, 0, vty_get_bind_addr(), - OSMO_VTY_PORT_GTPHUB); + rc = telnet_init_default(osmo_gtphub_ctx, NULL, OSMO_VTY_PORT_GTPHUB); if (rc < 0) exit(1); diff --git a/src/sgsn/sgsn_main.c b/src/sgsn/sgsn_main.c index 04de6a2..d6afdef 100644 --- a/src/sgsn/sgsn_main.c +++ b/src/sgsn/sgsn_main.c @@ -442,8 +442,7 @@ } /* start telnet after reading config for vty_get_bind_addr() */ - rc = telnet_init_dynif(tall_sgsn_ctx, NULL, - vty_get_bind_addr(), OSMO_VTY_PORT_SGSN); + rc = telnet_init_default(tall_sgsn_ctx, NULL, OSMO_VTY_PORT_SGSN); if (rc < 0) exit(1); -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/31523 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Icc57c68337d55c6594c1c36e9bf41624d11dab0a Gerrit-Change-Number: 31523 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 1 month

1
0
0 0

[S] Change in libosmocore[master]: libosmocore.map: add tall_{ctr/msgb}_ctx

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31590 ) Change subject: libosmocore.map: add tall_{ctr/msgb}_ctx ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31590 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4cfccf3622844d0923818bb8d8ce206f70e44a0d Gerrit-Change-Number: 31590 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 10:31:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in libosmocore[master]: libosmocore.map: add tall_{ctr/msgb}_ctx

by pespin

Attention is currently required from: osmith, pespin. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31590 ) Change subject: libosmocore.map: add tall_{ctr/msgb}_ctx ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/core/libosmocore.map: https://gerrit.osmocom.org/c/libosmocore/+/31590/comment/54238fd9_880ea58e PS2, Line 562: tall_ctr_ctx; Maybe add comments in here regarding only exported due to historical reasons and are actually deprecated. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31590 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4cfccf3622844d0923818bb8d8ce206f70e44a0d Gerrit-Change-Number: 31590 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 10:30:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in libosmocore[master]: libosmocore.map: add tall_{ctr/msgb}_ctx

by osmith

osmith has uploaded a new patch set (#3). ( https://gerrit.osmocom.org/c/libosmocore/+/31590 ) Change subject: libosmocore.map: add tall_{ctr/msgb}_ctx ...................................................................... libosmocore.map: add tall_{ctr/msgb}_ctx These should not be used, but add them for backwards compatibility with building older versions of osmo-bsc, osmo-iuh, osmo-pcap against current libosmocore. Fixes: 213fc420 ("Add libosmocore.map") Change-Id: I4cfccf3622844d0923818bb8d8ce206f70e44a0d --- M src/core/libosmocore.map 1 file changed, 16 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/90/31590/3 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31590 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4cfccf3622844d0923818bb8d8ce206f70e44a0d Gerrit-Change-Number: 31590 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset

1 year, 1 month

1
0
0 0

[S] Change in osmo-pcap[master]: osmo_{client,server}_main: Remove is_config_node in vty_app_info

by pespin

Attention is currently required from: daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/31588 ) Change subject: osmo_{client,server}_main: Remove is_config_node in vty_app_info ...................................................................... Patch Set 1: -Code-Review (1 comment) Patchset: PS1: Don't you need to remove the symbol too? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/31588 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I34295950557d9009b0d8d3378deb3b1263476f82 Gerrit-Change-Number: 31588 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 10:29:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in libosmocore[master]: libosmocore.map: add tall_{ctr/msgb}_ctx

by osmith

osmith has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/libosmocore/+/31590 ) Change subject: libosmocore.map: add tall_{ctr/msgb}_ctx ...................................................................... libosmocore.map: add tall_{ctr/msgb}_ctx These should not be used, but add them for backwards compatibility with building older versions of osmo-bsc, osmo-iuh, osmo-pcap against current libosmocore. Change-Id: I4cfccf3622844d0923818bb8d8ce206f70e44a0d --- M src/core/libosmocore.map 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/90/31590/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31590 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4cfccf3622844d0923818bb8d8ce206f70e44a0d Gerrit-Change-Number: 31590 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset

1 year, 1 month

1
0
0 0

[S] Change in osmo-pcap[master]: osmo_{client,server}_main: Remove is_config_node in vty_app_info

by pespin

Attention is currently required from: daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/31588 ) Change subject: osmo_{client,server}_main: Remove is_config_node in vty_app_info ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/31588 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I34295950557d9009b0d8d3378deb3b1263476f82 Gerrit-Change-Number: 31588 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 10:29:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-pcap[master]: cosmetic: Remove trailing whitespace

by pespin

Attention is currently required from: daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/31589 ) Change subject: cosmetic: Remove trailing whitespace ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/31589 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I33c8747f1f9c1020232e91d5559f0a06a31857d8 Gerrit-Change-Number: 31589 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 10:28:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in libosmocore[master]: libosmocore.map: add tall_{ctr/msgbx}_ctx

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/31590 ) Change subject: libosmocore.map: add tall_{ctr/msgbx}_ctx ...................................................................... libosmocore.map: add tall_{ctr/msgbx}_ctx These should not be used, but add them for backwards compatibility with building older versions of osmo-bsc, osmo-iuh, osmo-pcap against current libosmocore. Change-Id: I4cfccf3622844d0923818bb8d8ce206f70e44a0d --- M src/core/libosmocore.map 1 file changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/90/31590/1 diff --git a/src/core/libosmocore.map b/src/core/libosmocore.map index 16b7261..b204651 100644 --- a/src/core/libosmocore.map +++ b/src/core/libosmocore.map @@ -559,7 +559,9 @@ rb_replace_node; sercomm_drv_lock; sercomm_drv_unlock; +tall_ctr_ctx; tall_log_ctx; +tall_msgb_ctx; local: *; }; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31590 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4cfccf3622844d0923818bb8d8ce206f70e44a0d Gerrit-Change-Number: 31590 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 1 month

1
0
0 0

[S] Change in osmo-pcap[master]: osmo_{client,server}_main: Remove is_config_node in vty_app_info

by osmith

Attention is currently required from: pespin, daniel. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/31588 ) Change subject: osmo_{client,server}_main: Remove is_config_node in vty_app_info ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/31588 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I34295950557d9009b0d8d3378deb3b1263476f82 Gerrit-Change-Number: 31588 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 10:24:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-pcap[master]: cosmetic: Remove trailing whitespace

by daniel

daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/31589 ) Change subject: cosmetic: Remove trailing whitespace ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: whitespace change -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/31589 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I33c8747f1f9c1020232e91d5559f0a06a31857d8 Gerrit-Change-Number: 31589 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 28 Feb 2023 10:23:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-pcap[master]: osmo_{client,server}_main: Remove tall_ctr_ctx and tall_msgb_ctx

by daniel

daniel has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/31586 ) Change subject: osmo_{client,server}_main: Remove tall_ctr_ctx and tall_msgb_ctx ...................................................................... osmo_{client,server}_main: Remove tall_ctr_ctx and tall_msgb_ctx tall_ctr_ctx is only used by the obsolete osmo_counters which are not used anymore. tall_msgb_ctx is now set through msgb_tallox_ctx_init(). Fixes undefined reference errors since libosmocore.map was introduced in I13169c00a59fb59513dfc598de5a71d094492422: ``` osmo-pcap/src/osmo_client_main.c:226: undefined reference to `tall_msgb_ctx' /usr/bin/ld: osmo-pcap/src/osmo_client_main.c:226: undefined reference to `tall_msgb_ctx' /usr/bin/ld: osmo-pcap/src/osmo_client_main.c:227: undefined reference to `tall_ctr_ctx' /usr/bin/ld: osmo-pcap/src/osmo_client_main.c:227: undefined reference to `tall_ctr_ctx' ``` Change-Id: Idcbb96fd070f5ad20d3091ce886dc6130968538f --- M src/osmo_client_main.c M src/osmo_server_main.c 2 files changed, 25 insertions(+), 8 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve daniel: Looks good to me, approved diff --git a/src/osmo_client_main.c b/src/osmo_client_main.c index 3033b15..8ca2df3 100644 --- a/src/osmo_client_main.c +++ b/src/osmo_client_main.c @@ -51,8 +51,6 @@ void *tall_cli_ctx; struct osmo_pcap_client *pcap_client; -extern void *tall_msgb_ctx; -extern void *tall_ctr_ctx; static const struct rate_ctr_desc pcap_client_ctr_desc[] = { @@ -223,8 +221,7 @@ static void talloc_init_ctx() { tall_cli_ctx = talloc_named_const(NULL, 0, "client"); - tall_msgb_ctx = talloc_named_const(tall_cli_ctx, 0, "msgb"); - tall_ctr_ctx = talloc_named_const(tall_cli_ctx, 0, "counter"); + msgb_talloc_ctx_init(tall_cli_ctx, 0); } int main(int argc, char **argv) diff --git a/src/osmo_server_main.c b/src/osmo_server_main.c index 484b51d..8ad89ba 100644 --- a/src/osmo_server_main.c +++ b/src/osmo_server_main.c @@ -52,8 +52,6 @@ void *tall_srv_ctx; struct osmo_pcap_server *pcap_server; -extern void *tall_msgb_ctx; -extern void *tall_ctr_ctx; static const struct rate_ctr_desc pcap_peer_ctr_desc[] = { @@ -235,8 +233,7 @@ static void talloc_init_ctx() { tall_srv_ctx = talloc_named_const(NULL, 0, "server"); - tall_msgb_ctx = talloc_named_const(tall_srv_ctx, 0, "msgb"); - tall_ctr_ctx = talloc_named_const(tall_srv_ctx, 0, "counter"); + msgb_talloc_ctx_init(tall_srv_ctx, 0); } int main(int argc, char **argv) -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/31586 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Idcbb96fd070f5ad20d3091ce886dc6130968538f Gerrit-Change-Number: 31586 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 1 month

1
0
0 0

[S] Change in osmo-pcap[master]: osmo_{client,server}_main: Remove tall_ctr_ctx and tall_msgb_ctx

by daniel

daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/31586 ) Change subject: osmo_{client,server}_main: Remove tall_ctr_ctx and tall_msgb_ctx ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/31586 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Idcbb96fd070f5ad20d3091ce886dc6130968538f Gerrit-Change-Number: 31586 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 10:22:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-pcap[master]: osmo_{client,server}_main: Remove is_config_node in vty_app_info

by daniel

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcap/+/31588 ) Change subject: osmo_{client,server}_main: Remove is_config_node in vty_app_info ...................................................................... osmo_{client,server}_main: Remove is_config_node in vty_app_info This member is deprcated/unused so simply remove it: > 'is_config_node' is deprecated: Implicit parent node tracking has > replaced the use of this callback. This callback is no longer called, > ever, and can be left NULL. Change-Id: I34295950557d9009b0d8d3378deb3b1263476f82 --- M src/osmo_client_main.c M src/osmo_server_main.c 2 files changed, 15 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/88/31588/1 diff --git a/src/osmo_client_main.c b/src/osmo_client_main.c index 8ca2df3..818a2f1 100644 --- a/src/osmo_client_main.c +++ b/src/osmo_client_main.c @@ -79,7 +79,6 @@ .name = "OsmoPCAPClient", .version = PACKAGE_VERSION, .go_parent_cb = osmopcap_go_parent, - .is_config_node = osmopcap_is_config_node, }; static void print_usage() diff --git a/src/osmo_server_main.c b/src/osmo_server_main.c index 8ad89ba..4633888 100644 --- a/src/osmo_server_main.c +++ b/src/osmo_server_main.c @@ -89,7 +89,6 @@ .name = "OsmoPCAPServer", .version = PACKAGE_VERSION, .go_parent_cb = osmopcap_go_parent, - .is_config_node = osmopcap_is_config_node, }; static void print_usage() -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/31588 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I34295950557d9009b0d8d3378deb3b1263476f82 Gerrit-Change-Number: 31588 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 1 month

1
0
0 0

[S] Change in osmo-pcap[master]: cosmetic: Remove trailing whitespace

by daniel

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcap/+/31589 ) Change subject: cosmetic: Remove trailing whitespace ...................................................................... cosmetic: Remove trailing whitespace Change-Id: I33c8747f1f9c1020232e91d5559f0a06a31857d8 --- M src/osmo_common.c 1 file changed, 11 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcap refs/changes/89/31589/1 diff --git a/src/osmo_common.c b/src/osmo_common.c index 39f448a..6a12728 100644 --- a/src/osmo_common.c +++ b/src/osmo_common.c @@ -62,7 +62,7 @@ .num_cat = ARRAY_SIZE(default_categories), }; -const char *osmopcap_copyright = +const char *osmopcap_copyright = "Copyright (C) 2011-2017 Holger Freyther and contributors\r\n" "License AGPLv3+: GNU AGPL version 3 or later <http://gnu.org/licenses/agpl-3.0.html>\r\n" "This is free software: you are free to change and redistribute it.\r\n" @@ -86,7 +86,7 @@ break; } - return vty->node; + return vty->node; } int osmopcap_is_config_node(struct vty *vty, int node) -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/31589 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I33c8747f1f9c1020232e91d5559f0a06a31857d8 Gerrit-Change-Number: 31589 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 1 month

1
0
0 0

[S] Change in osmo-iuh[master]: test-ranap: don't use libosmocore's tall_msgb_ctx

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/31587 ) Change subject: test-ranap: don't use libosmocore's tall_msgb_ctx ...................................................................... test-ranap: don't use libosmocore's tall_msgb_ctx Use msgb_ctx from test_common.c instead, which is the same pointer after test_common_init() ran. tall_msgb_ctx from libosmocore is no longer getting exported since I13169c00a59fb59513dfc598de5a71d094492422. Fix for: /usr/bin/ld: test-ranap.o: in function `main': /build/src/tests/test-ranap.c:201: undefined reference to `tall_msgb_ctx' /usr/bin/ld: /build/src/tests/test-ranap.c:201: undefined reference to `tall_msgb_ctx' Change-Id: I7d0b3068760c2cd7067e2a5d929f03c7e7d1decb --- M src/tests/test-ranap.c M src/tests/test_common.c 2 files changed, 21 insertions(+), 3 deletions(-) Approvals: daniel: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/tests/test-ranap.c b/src/tests/test-ranap.c index 633bb2b..e593bd9 100644 --- a/src/tests/test-ranap.c +++ b/src/tests/test-ranap.c @@ -32,7 +32,7 @@ #include "test_common.h" -extern void *tall_msgb_ctx; +extern void *msgb_ctx; static void test_aper_int(uint32_t inp) { @@ -198,7 +198,7 @@ printf("report\n"); talloc_report(talloc_asn1_ctx, stdout); - talloc_report(tall_msgb_ctx, stdout); + talloc_report(msgb_ctx, stdout); //talloc_report(NULL, stdout); test_common_cleanup(); diff --git a/src/tests/test_common.c b/src/tests/test_common.c index 187a269..36d9954 100644 --- a/src/tests/test_common.c +++ b/src/tests/test_common.c @@ -71,7 +71,7 @@ }; static void *tall_hnb_ctx; -static void *msgb_ctx; +void *msgb_ctx; int test_common_init(void) { -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/31587 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I7d0b3068760c2cd7067e2a5d929f03c7e7d1decb Gerrit-Change-Number: 31587 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 1 month

1
0
0 0

[S] Change in osmo-iuh[master]: test-ranap: don't use libosmocore's tall_msgb_ctx

by osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/31587 ) Change subject: test-ranap: don't use libosmocore's tall_msgb_ctx ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/31587 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I7d0b3068760c2cd7067e2a5d929f03c7e7d1decb Gerrit-Change-Number: 31587 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 10:19:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-iuh[master]: test-ranap: don't use libosmocore's tall_msgb_ctx

by daniel

Attention is currently required from: osmith. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/31587 ) Change subject: test-ranap: don't use libosmocore's tall_msgb_ctx ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/31587 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I7d0b3068760c2cd7067e2a5d929f03c7e7d1decb Gerrit-Change-Number: 31587 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 10:19:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-pcap[master]: osmo_{client,server}_main: Remove tall_ctr_ctx and tall_msgb_ctx

by pespin

Attention is currently required from: daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/31586 ) Change subject: osmo_{client,server}_main: Remove tall_ctr_ctx and tall_msgb_ctx ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/31586 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Idcbb96fd070f5ad20d3091ce886dc6130968538f Gerrit-Change-Number: 31586 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 10:18:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-iuh[master]: test-ranap: don't use libosmocore's tall_msgb_ctx

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/31587 ) Change subject: test-ranap: don't use libosmocore's tall_msgb_ctx ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/31587 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I7d0b3068760c2cd7067e2a5d929f03c7e7d1decb Gerrit-Change-Number: 31587 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 10:17:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[M] Change in osmo-pcu[master]: bts: add IMMEDIATE ASSIGNMENT via PCH transmission

by pespin

Attention is currently required from: neels, fixeria, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/31145 ) Change subject: bts: add IMMEDIATE ASSIGNMENT via PCH transmission ...................................................................... Patch Set 17: Code-Review-1 (6 comments) File include/osmocom/pcu/pcuif_proto.h: https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/de5fe3fe_854658d9 PS17, Line 48: #define PCU_IF_FLAG_DT (1 << 2)/* use TLLI for confirmation directly */ I think we agreed in the call this flag was not needed. https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/669099fc_aa3e5889 PS17, Line 280: uint8_t pgroup[3]; This can be a int16_t containing a number 0-999. https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/f86341bf_e27d3f4d PS17, Line 294: struct gsm_pcu_if_data_cnf_dt data_cnf_dt; isn't it a bit weird that we have a cnf_dt but no data_dt? File src/bts.h: https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/3c1259d6_37a48a0b PS17, Line 282: /* Use the TLLI directly to handle IMMEDIATE ASSIGNMENT confirmation, otherwise the TLLI is extracted This is most probably not needed anymore and can be dropped. File src/bts.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/5d34526d_f3a0f307 PS17, Line 1134: pcu_l1if_tx_pch(bts, immediate_assignment, plen, ms_paging_group(tbf_ms(tbf))); I thought we agreed on dropping the previous message? File src/pcu_l1_if.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/31145/comment/eaf4a5b4_12c55936 PS17, Line 769: this can be dropped. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/31145 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2a78651593323e8b9627c39918d949a33497b70f Gerrit-Change-Number: 31145 Gerrit-PatchSet: 17 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 10:16:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-pcap[master]: osmo_{client,server}_main: Remove tall_ctr_ctx and tall_msgb_ctx

by osmith

Attention is currently required from: daniel. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcap/+/31586 ) Change subject: osmo_{client,server}_main: Remove tall_ctr_ctx and tall_msgb_ctx ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/31586 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Idcbb96fd070f5ad20d3091ce886dc6130968538f Gerrit-Change-Number: 31586 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Feb 2023 10:14:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 1 month

1
0
0 0

[S] Change in osmo-iuh[master]: test-ranap: don't use libosmocore's tall_msgb_ctx

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-iuh/+/31587 ) Change subject: test-ranap: don't use libosmocore's tall_msgb_ctx ...................................................................... test-ranap: don't use libosmocore's tall_msgb_ctx Use msgb_ctx from test_common.c instead, which is the same pointer after test_common_init() ran. tall_msgb_ctx from libosmocore is no longer getting exported since I13169c00a59fb59513dfc598de5a71d094492422. Fix for: /usr/bin/ld: test-ranap.o: in function `main': /build/src/tests/test-ranap.c:201: undefined reference to `tall_msgb_ctx' /usr/bin/ld: /build/src/tests/test-ranap.c:201: undefined reference to `tall_msgb_ctx' Change-Id: I7d0b3068760c2cd7067e2a5d929f03c7e7d1decb --- M src/tests/test-ranap.c M src/tests/test_common.c 2 files changed, 21 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/87/31587/1 diff --git a/src/tests/test-ranap.c b/src/tests/test-ranap.c index 633bb2b..e593bd9 100644 --- a/src/tests/test-ranap.c +++ b/src/tests/test-ranap.c @@ -32,7 +32,7 @@ #include "test_common.h" -extern void *tall_msgb_ctx; +extern void *msgb_ctx; static void test_aper_int(uint32_t inp) { @@ -198,7 +198,7 @@ printf("report\n"); talloc_report(talloc_asn1_ctx, stdout); - talloc_report(tall_msgb_ctx, stdout); + talloc_report(msgb_ctx, stdout); //talloc_report(NULL, stdout); test_common_cleanup(); diff --git a/src/tests/test_common.c b/src/tests/test_common.c index 187a269..36d9954 100644 --- a/src/tests/test_common.c +++ b/src/tests/test_common.c @@ -71,7 +71,7 @@ }; static void *tall_hnb_ctx; -static void *msgb_ctx; +void *msgb_ctx; int test_common_init(void) { -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/31587 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I7d0b3068760c2cd7067e2a5d929f03c7e7d1decb Gerrit-Change-Number: 31587 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 1 month

1
0
0 0

2024

2023

2022

gerrit-log February 2023