Attention is currently required from: lynxis lazus.
daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38410?usp=email )
Change subject: vlr: add a logging layer
......................................................................
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38410?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I6d87b38d6d7d704c7c7b2c90ad12187e4b953b8b
Gerrit-Change-Number: 38410
Gerrit-PatchSet: 6
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Thu, 31 Oct 2024 17:33:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: lynxis lazus.
daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38413?usp=email )
Change subject: vlr: vlr_auth_fsm: make the fsm instance private
......................................................................
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38413?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Iec85f299cd99879475ab094998433d935e980394
Gerrit-Change-Number: 38413
Gerrit-PatchSet: 8
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Thu, 31 Oct 2024 17:21:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: lynxis lazus.
daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38490?usp=email )
Change subject: vlr: add PS support
......................................................................
Patch Set 2:
(1 comment)
File src/libvlr/vlr_lu_fsm.c:
https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/b6957705_9f420a55?usp… :
PS2, Line 613: [LU_COMPL_VLR_S_WAIT_SUB_PRES] = {
This state is not handled in the timeout function, but onenter resets N. Could you explain why it's needed?
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38490?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ie9ffeb140c9d354b3a0f4822e2619f623235add0
Gerrit-Change-Number: 38490
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Thu, 31 Oct 2024 17:19:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: lynxis lazus, pespin.
daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37869?usp=email )
Change subject: GMM: split parsing of a RA Update Request in a separate file
......................................................................
Patch Set 23: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37869?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I413da1b6b4b7c0c4781393acd8564661bc74ce2d
Gerrit-Change-Number: 37869
Gerrit-PatchSet: 23
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Thu, 31 Oct 2024 17:07:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: lynxis lazus.
daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38485?usp=email )
Change subject: vlr: add bool is_ps to vlr_alloc()
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/38485?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ib77aad8492a198131c966d4ac4cf8f5f727edcfa
Gerrit-Change-Number: 38485
Gerrit-PatchSet: 2
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Thu, 31 Oct 2024 16:57:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: lynxis lazus.
daniel has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38401?usp=email )
Change subject: SGSN: TC_attach_auth_id_timeout: set TMSI to provoke a ID Request
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38401?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5a860582aa57ebc073e4c33f3f2f8884e360edef
Gerrit-Change-Number: 38401
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Thu, 31 Oct 2024 16:46:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38598?usp=email )
Change subject: hnbgw: Introduce test TC_ps_iu_release_req_rua_disconnect
......................................................................
Patch Set 3:
(2 comments)
File hnbgw/HNBGW_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38598/comment/281e9ba5_b7ae… :
PS3, Line 1372: if (g_pars.pfcp_pars.pfcp_enabled) {
TODO: we may want to move this (already present in other test) to the f_init_handler() function, to avoid needing to run it explicitly every time?
Maybe look at what we do in S1GW_Tests testsuite.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38598/comment/99062c7f_d2df… :
PS3, Line 1407: f_init_pfcp(testcasename());
We probably want to move this inside f_init().
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38598?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id24a5aed5255af77fbbd30521be70700a9bff1c9
Gerrit-Change-Number: 38598
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Thu, 31 Oct 2024 16:41:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38598?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: hnbgw: Introduce test TC_ps_iu_release_req_rua_disconnect
......................................................................
hnbgw: Introduce test TC_ps_iu_release_req_rua_disconnect
Change-Id: Id24a5aed5255af77fbbd30521be70700a9bff1c9
---
M hnbgw/HNBGW_Tests.ttcn
M hnbgw/expected-results.xml
2 files changed, 50 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/98/38598/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38598?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id24a5aed5255af77fbbd30521be70700a9bff1c9
Gerrit-Change-Number: 38598
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38597?usp=email )
Change subject: hnbgw: Tear down SCCP conn from CN under normal conditions
......................................................................
hnbgw: Tear down SCCP conn from CN under normal conditions
Specs mention that under normal conditions the CN is the one expected to
tear down the SCCP underlaying connection upon recieving
Iu-ReleaseComplete.
Change-Id: I920cabcb63ca352db0ed06e4c35dade52bae5399
---
M hnbgw/ConnHdlr.ttcn
M library/SCCP_Templates.ttcn
2 files changed, 19 insertions(+), 15 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/97/38597/1
diff --git a/hnbgw/ConnHdlr.ttcn b/hnbgw/ConnHdlr.ttcn
index 1b053d0..13c8d4c 100644
--- a/hnbgw/ConnHdlr.ttcn
+++ b/hnbgw/ConnHdlr.ttcn
@@ -72,6 +72,7 @@
import from L3_Common all;
import from SCCPasp_Types all;
+import from SCCP_Templates all;
/***********************************************************************
* code running inside per-UE ConnHdlr
@@ -444,19 +445,6 @@
/* expect to receive it on the Iu side */
rx := f_bssap_expect(exp_rx);
-
- /* expect disconnect on the Iu side */
- T.start;
- alt {
- [] BSSAP.receive(tr_MSC_CONN_PRIM_DISC_IND) {
- setverdict(pass);
- }
- [] T.timeout {
- setverdict(fail, "Timeout waiting for Iu disconnect");
- return rx;
- }
-
- }
return rx;
}
@@ -545,13 +533,13 @@
/* HNB <- CN: Iu-ReleaseCmd, HNB -> CN: Iu-ReleaseCompl */
function f_cn_iu_release_procedure(boolean mgcp_teardown := false, boolean pfcp_teardown := false) runs on ConnHdlr {
var RANAP_PDU tx;
- timer T := 5.0;
+ timer T;
tx := valueof(ts_RANAP_IuReleaseCommand(g_pars.rab_rel_cause));
f_iu2iuh(tx);
if (mgcp_teardown) {
- T.start;
+ T.start(5.0);
alt {
[] as_mgcp_dlcx() {}
[] T.timeout {
@@ -570,6 +558,21 @@
tx := valueof(ts_RANAP_IuReleaseComplete());
f_iuh2iu_disconnect(tx, RUA_IEs.Cause:{radioNetwork:=normal});
+
+ /* Once CN receives Iu-ReleaseComplete, it tears down the SCCP conn under Iu: */
+ BSSAP.send(ts_MSC_CONN_PRIM_DISC_REQ(sccp_par_reason_end_user_originated));
+ /* There's no signalling from lower layers regarding when RLC is
+ * received, hence only make sure the IUT is not sending an RLSD on its own
+ * after a timeout, which would mean it didn't process our RLSD */
+ T.start(2.0);
+ alt {
+ [] BSSAP.receive(tr_MSC_CONN_PRIM_DISC_IND) {
+ Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Rx Unexpected RLSD to our RLSD");
+ }
+ [] T.timeout {
+ setverdict(pass);
+ }
+ }
}
/* Reply to a received CRCX with an OK (or the reply configured in cpars), using the given parameters.
diff --git a/library/SCCP_Templates.ttcn b/library/SCCP_Templates.ttcn
index 40a6156..f36dc5a 100644
--- a/library/SCCP_Templates.ttcn
+++ b/library/SCCP_Templates.ttcn
@@ -15,6 +15,7 @@
import from SCCPasp_Types all;
import from SCCP_Emulation all;
+const integer sccp_par_reason_end_user_originated := 0; /* End user originated */
const integer sccp_par_reason_end_user_failure := 2; /* End user failure */
/* construct a SCCP_PAR_Address with just SSN and no PC or GT */
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38597?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I920cabcb63ca352db0ed06e4c35dade52bae5399
Gerrit-Change-Number: 38597
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>