pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38598?usp=email ) Change subject: hnbgw: Introduce test TC_ps_iu_release_req_rua_disconnect ...................................................................... Patch Set 3: (2 comments) File hnbgw/HNBGW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38598/comment/281e9ba5_b7ae… : PS3, Line 1372: if (g_pars.pfcp_pars.pfcp_enabled) { TODO: we may want to move this (already present in other test) to the f_init_handler() function, to avoid needing to run it explicitly every time? Maybe look at what we do in S1GW_Tests testsuite. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38598/comment/99062c7f_d2df… : PS3, Line 1407: f_init_pfcp(testcasename()); We probably want to move this inside f_init(). -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38598?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id24a5aed5255af77fbbd30521be70700a9bff1c9 Gerrit-Change-Number: 38598 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Thu, 31 Oct 2024 16:41:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No