October 2024 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: hnbgw: Use g_pars.mgcp_pars directly during RAB CS setup

by pespin

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38588?usp=email ) Change subject: hnbgw: Use g_pars.mgcp_pars directly during RAB CS setup ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38588?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1f699e197e29f912ad06378f10563063aa291af3 Gerrit-Change-Number: 38588 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 31 Oct 2024 13:29:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 3 weeks

1
0
0 0

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Rename RAB helper functions to be CS specific

by pespin

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38587?usp=email ) Change subject: hnbgw: Rename RAB helper functions to be CS specific ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38587?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If8a97fe847083e95a480006d147ff59be695b713 Gerrit-Change-Number: 38587 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 31 Oct 2024 13:29:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 3 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: hnbgw: Set missing variable in t_pars()

by pespin

pespin has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38589?usp=email ) Change subject: hnbgw: Set missing variable in t_pars() ...................................................................... Abandoned Fixed too by https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38590 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38589?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2889d522e4d014ee67f6fc0fdcb36544452c9be8 Gerrit-Change-Number: 38589 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

4 months, 3 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: hnbgw: fixup for expect_compl_l3_success

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38590?usp=email ) Change subject: hnbgw: fixup for expect_compl_l3_success ...................................................................... hnbgw: fixup for expect_compl_l3_success During my rebase of Neels patch, I've missed setting expect_compl_l3_success in t_pars(), leading to: HNBGW_Tests.ttcn:571 Dynamic test case error: Text encoder: Encoding an unbound boolean value. For a lot of tests. Also add the parameter to f_TestHdlrParams() for consistency. Fixes: 25fc127c ("hnbgw: test for RUA Disconnect when there is no CN") Change-Id: Idbfcb77a80d74f7715ef1f84ba4cbfdb08483a5c --- M hnbgw/ConnHdlr.ttcn M hnbgw/HNBGW_Tests.ttcn 2 files changed, 3 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/hnbgw/ConnHdlr.ttcn b/hnbgw/ConnHdlr.ttcn index d89123e..6168716 100644 --- a/hnbgw/ConnHdlr.ttcn +++ b/hnbgw/ConnHdlr.ttcn @@ -196,6 +196,7 @@ hnb := omit, /* filled in later */ expect_separate_sccp_cr := expect_separate_sccp_cr, tx_sccp_cr_data_len := tx_sccp_cr_data_len, + expect_compl_l3_success := expect_compl_l3_success, pfcp_local_addr := pfcp_local_addr, nas_pdu := omit, sccp_addr_msc := omit, diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index 44f0e43..7ba4c6f 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -507,6 +507,7 @@ boolean ps_domain := false, boolean expect_separate_sccp_cr := false, integer tx_sccp_cr_data_len := 0, + boolean expect_compl_l3_success := true, integer cn_nr := 0, template (value) RANAP_IEs.Cause rab_rel_cause := ts_RanapCause_nas_normal) runs on test_CT return TestHdlrParams { @@ -515,6 +516,7 @@ ps_domain := ps_domain, expect_separate_sccp_cr := expect_separate_sccp_cr, tx_sccp_cr_data_len := tx_sccp_cr_data_len, + expect_compl_l3_success := expect_compl_l3_success, cn_idx := f_cn_idx(ps_domain, cn_nr), pfcp_local_addr := mp_pfcp_ip_local, rab_rel_cause := rab_rel_cause, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38590?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idbfcb77a80d74f7715ef1f84ba4cbfdb08483a5c Gerrit-Change-Number: 38590 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: hnbgw: fixup for expect_compl_l3_success

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38590?usp=email ) Change subject: hnbgw: fixup for expect_compl_l3_success ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38590?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idbfcb77a80d74f7715ef1f84ba4cbfdb08483a5c Gerrit-Change-Number: 38590 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 31 Oct 2024 13:25:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

4 months, 3 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: hnbgw: fixup for expect_compl_l3_success

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38590?usp=email ) Change subject: hnbgw: fixup for expect_compl_l3_success ...................................................................... hnbgw: fixup for expect_compl_l3_success During my rebase of Neels patch, I've missed setting expect_compl_l3_success in t_pars(), leading to: HNBGW_Tests.ttcn:571 Dynamic test case error: Text encoder: Encoding an unbound boolean value. For a lot of tests. Also add the parameter to f_TestHdlrParams() for consistency. Fixes: 25fc127c ("hnbgw: test for RUA Disconnect when there is no CN") Change-Id: Idbfcb77a80d74f7715ef1f84ba4cbfdb08483a5c --- M hnbgw/ConnHdlr.ttcn M hnbgw/HNBGW_Tests.ttcn 2 files changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/90/38590/1 diff --git a/hnbgw/ConnHdlr.ttcn b/hnbgw/ConnHdlr.ttcn index d89123e..6168716 100644 --- a/hnbgw/ConnHdlr.ttcn +++ b/hnbgw/ConnHdlr.ttcn @@ -196,6 +196,7 @@ hnb := omit, /* filled in later */ expect_separate_sccp_cr := expect_separate_sccp_cr, tx_sccp_cr_data_len := tx_sccp_cr_data_len, + expect_compl_l3_success := expect_compl_l3_success, pfcp_local_addr := pfcp_local_addr, nas_pdu := omit, sccp_addr_msc := omit, diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index 44f0e43..7ba4c6f 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -507,6 +507,7 @@ boolean ps_domain := false, boolean expect_separate_sccp_cr := false, integer tx_sccp_cr_data_len := 0, + boolean expect_compl_l3_success := true, integer cn_nr := 0, template (value) RANAP_IEs.Cause rab_rel_cause := ts_RanapCause_nas_normal) runs on test_CT return TestHdlrParams { @@ -515,6 +516,7 @@ ps_domain := ps_domain, expect_separate_sccp_cr := expect_separate_sccp_cr, tx_sccp_cr_data_len := tx_sccp_cr_data_len, + expect_compl_l3_success := expect_compl_l3_success, cn_idx := f_cn_idx(ps_domain, cn_nr), pfcp_local_addr := mp_pfcp_ip_local, rab_rel_cause := rab_rel_cause, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38590?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idbfcb77a80d74f7715ef1f84ba4cbfdb08483a5c Gerrit-Change-Number: 38590 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[XS] Change in libosmocore[master]: rate_ctr,CTRL[2/2]: log ctrg inst names invalid for CTRL

by osmith

osmith has abandoned this change. ( https://gerrit.osmocom.org/c/libosmocore/+/38020?usp=email ) Change subject: rate_ctr,CTRL[2/2]: log ctrg inst names invalid for CTRL ...................................................................... Abandoned (SYS#7165) seems like a good idea, but the patch is unfinished (CI not passing, by_id -> by_name, more?). it solves a problem that is currently not an issue anymore, as a patch was reverted instead. abandoning for now, maybe worth picking up later again. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38020?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic721219649e20960c7af5765ee4d3b641fef5081 Gerrit-Change-Number: 38020 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[M] Change in libosmocore[master]: rate_ctr,CTRL[1/2]: GET using rate_ctr_group_set_name()

by osmith

osmith has abandoned this change. ( https://gerrit.osmocom.org/c/libosmocore/+/37881?usp=email ) Change subject: rate_ctr,CTRL[1/2]: GET using rate_ctr_group_set_name() ...................................................................... Abandoned (SYS#7165) seems like a good idea, but the patch is unfinished (CI not passing, by_id -> by_name, more?). it solves a problem that is currently not an issue anymore, as a patch was reverted instead. abandoning for now, maybe worth picking up later again. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37881?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I841a12f76e6fcb2bd7aecb5f4b1707d9ec927137 Gerrit-Change-Number: 37881 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org>

4 months, 3 weeks

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: hnbgw: Set missing variable in t_pars()

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38589?usp=email ) Change subject: hnbgw: Set missing variable in t_pars() ...................................................................... hnbgw: Set missing variable in t_pars() Change-Id: I2889d522e4d014ee67f6fc0fdcb36544452c9be8 --- M hnbgw/ConnHdlr.ttcn 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/89/38589/1 diff --git a/hnbgw/ConnHdlr.ttcn b/hnbgw/ConnHdlr.ttcn index 17e2103..adbfcae 100644 --- a/hnbgw/ConnHdlr.ttcn +++ b/hnbgw/ConnHdlr.ttcn @@ -196,6 +196,7 @@ hnb := omit, /* filled in later */ expect_separate_sccp_cr := expect_separate_sccp_cr, tx_sccp_cr_data_len := tx_sccp_cr_data_len, + expect_compl_l3_success := expect_compl_l3_success, pfcp_local_addr := pfcp_local_addr, nas_pdu := omit, sccp_addr_msc := omit, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38589?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2889d522e4d014ee67f6fc0fdcb36544452c9be8 Gerrit-Change-Number: 38589 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: hnbgw: Introduce test TC_cs_iu_release_req_rua_disconnect

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38576?usp=email ) Change subject: hnbgw: Introduce test TC_cs_iu_release_req_rua_disconnect ...................................................................... hnbgw: Introduce test TC_cs_iu_release_req_rua_disconnect Related: SYS#6602 Change-Id: I6782920c4a86d3311eb54239ab13a18e393c1ec0 --- M hnbgw/HNBGW_Tests.ttcn M hnbgw/expected-results.xml M library/ranap/RANAP_Templates.ttcn 3 files changed, 56 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index 8a263d5..44f0e43 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -1325,6 +1325,58 @@ f_tc_ranap_creq_cref(8, true); } +/* Scenario: HNB tears down the RUA/Iu conn by first sending RUA_DATA[RANAP + * IuReleaseReq], followed shortly by a RUA Disconnect with no RANAP and + * Cause!=Normal. HNBGW should release the SCCP connection through RLSD since it's + * impossible to terminate the Iu connection in a normal condition. (SYS#6602) */ +private function f_tc_cs_iu_release_req_rua_disconnect(charstring id) runs on ConnHdlr { + var RANAP_PDU tx; + timer T := 5.0; + + f_create_mgcp_expect(ExpectCriteria:{omit,omit,omit}); + + tx := f_build_initial_ue(g_pars); + f_iuh2iu_connect(tx); + + f_create_rab(g_pars.mgcp_pars); + + RUA.send(ts_RANAP_IuReleaseRequest(ts_RanapCause_radio_rab_preempted)); + BSSAP.receive(tr_RANAP_IuReleaseRequest(ts_RanapCause_radio_rab_preempted)); + + RUA.send(RUA_Disc_Req:{{misc:=unspecified}, omit}); + + /* HNBGW tears down related MGW sessions: */ + T.start; + alt { + [] as_mgcp_dlcx() {} + [] T.timeout { + setverdict(fail, "Timeout waiting for DLCX"); + } + } + T.stop; + + /* We cannot guarantee we can send Iu-ReleaseCommand at RANAP_Emulation + * before it receives the RLSD from HNBGW, hence we don't send it. If we + * sent it, it would be ignored by HNBGW since the RUA conn is already + * disconnected: + * BSSAP.send(ts_RANAP_IuReleaseCommand(ts_RanapCause_radio_rab_preempted)); + */ + + BSSAP.receive(tr_MSC_CONN_PRIM_DISC_IND); + /* Let RAN_Emulation some time to answer RLSD with RLC: */ + f_sleep(1.0); +} +testcase TC_cs_iu_release_req_rua_disconnect() runs on test_CT { + var ConnHdlr vc_conn; + g_num_hnbs := 1; + f_init(); + + vc_conn := f_start_handler_with_pars(refers(f_tc_cs_iu_release_req_rua_disconnect), f_TestHdlrParams(9)); + vc_conn.done; + + f_shutdown_helper(); +} + type record FTeid { HostName addr, OCT4 teid @@ -2439,6 +2491,7 @@ execute(TC_ranap_ps_mo_disconnect()); execute(TC_ranap_cs_creq_cref()); execute(TC_ranap_ps_creq_cref()); + execute(TC_cs_iu_release_req_rua_disconnect()); if (mp_enable_pfcp_tests) { execute(TC_ps_rab_assignment_with_pfcp()); diff --git a/hnbgw/expected-results.xml b/hnbgw/expected-results.xml index 0b67ec6..7d8bbbf 100644 --- a/hnbgw/expected-results.xml +++ b/hnbgw/expected-results.xml @@ -1,5 +1,5 @@ <?xml version="1.0"?> -<testsuite name='Titan' tests='42' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> +<testsuite name='Titan' tests='50' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> <testcase classname='HNBGW_Tests' name='TC_hnb_register' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_hnb_register_duplicate' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_hnb_register_duplicate_reuse_sctp_assoc' time='MASKED'/> @@ -23,6 +23,7 @@ <testcase classname='HNBGW_Tests' name='TC_ranap_ps_mo_disconnect' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_ranap_cs_creq_cref' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_ranap_ps_creq_cref' time='MASKED'/> + <testcase classname='HNBGW_Tests' name='TC_cs_iu_release_req_rua_disconnect' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_ps_rab_assignment_without_pfcp' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_mscpool_L3Compl_on_1_cnlink' time='MASKED'/> <testcase classname='HNBGW_Tests' name='TC_mscpool_L3Complete_by_imsi_round_robin' time='MASKED'/> diff --git a/library/ranap/RANAP_Templates.ttcn b/library/ranap/RANAP_Templates.ttcn index 3f9c497..b09d23e 100644 --- a/library/ranap/RANAP_Templates.ttcn +++ b/library/ranap/RANAP_Templates.ttcn @@ -13,6 +13,7 @@ template (value) Cause ts_RanapCause_om_intervention := { misc := 113 }; template (value) Cause ts_RanapCause_nas_normal := { nAS := 83 }; +template (value) Cause ts_RanapCause_radio_rab_preempted := { radioNetwork := 1 }; template (value) Cause ts_RanapCause_radio_conn_release := { radioNetwork := 40 }; template (value) Cause ts_RanapCause_radio_conn_lost := { radioNetwork := 46 }; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38576?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6782920c4a86d3311eb54239ab13a18e393c1ec0 Gerrit-Change-Number: 38576 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

4 months, 3 weeks

1
0
0 0

2025

2024

2023

2022

gerrit-log October 2024