August 2025 - gerrit-log - lists.osmocom.org

[XL] Change in libosmo-netif[master]: bring twrtp into libosmo-netif
by falconia 31 Aug '25

31 Aug '25

Attention is currently required from: pespin. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39281?usp=email ) Change subject: bring twrtp into libosmo-netif ...................................................................... Patch Set 7: (3 comments) File include/osmocom/netif/twrtp.h: https://gerrit.osmocom.org/c/libosmo-netif/+/39281/comment/72729e24_3f110f2… : PS1, Line 26: struct osmo_twrtp_stats { > Similarly to the public struct discussion I opened in the previous twjit patch, it also applies here […] Please see how I handle it in Patchset 7. File src/twrtp.c: https://gerrit.osmocom.org/c/libosmo-netif/+/39281/comment/1f48a891_01871ca… : PS6, Line 231: endp->iofd_rtp = osmo_iofd_setup(endp, -1, NULL, > Did you think about deferring this allocation step until osmo_twrtp_supply_fds is called? at least f […] Please see how I handle it in Patchset 7. File src/twrtp_base.c: https://gerrit.osmocom.org/c/libosmo-netif/+/39281/comment/10e8de60_f9a29ba… : PS1, Line 132: * another variant of this API with that alternative behavior. > I'd prefer deferr/avoid allocating rtcp iofd if not needed. Please see how I handle it in Patchset 7. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39281?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ib63215aaf13ef8ab8f2e0c8d310164cd5c8824eb Gerrit-Change-Number: 39281 Gerrit-PatchSet: 7 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 31 Aug 2025 23:38:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XL] Change in libosmo-netif[master]: bring twjit into libosmo-netif
by falconia 31 Aug '25

31 Aug '25

Attention is currently required from: fixeria, jolly, laforge, pespin. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email ) Change subject: bring twjit into libosmo-netif ...................................................................... Patch Set 7: (1 comment) File include/osmocom/netif/twjit.h: https://gerrit.osmocom.org/c/libosmo-netif/+/39280/comment/101e3da7_b0dd8c3… : PS6, Line 50: struct osmo_twjit_config { > Ok I see indeed. […] Please see how I handle it in Patchset 7. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ia3be5834571ca18b68939abbcf1ce3a879156658 Gerrit-Change-Number: 39280 Gerrit-PatchSet: 7 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 31 Aug 2025 23:36:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XL] Change in libosmo-netif[master]: bring twrtp into libosmo-netif
by falconia 31 Aug '25

31 Aug '25

Attention is currently required from: falconia, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/39281?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: bring twrtp into libosmo-netif ...................................................................... bring twrtp into libosmo-netif twrtp is the top layer of Themyscira Wireless RTP endpoint implementation, an alternative to Belledonne libortp. Unlike Belledonne software, ThemWi RTP library was developed specifically for use in Osmocom-based GSM, ISDN and IP-PSTN network elements, and is built on top of libosmocore primitives - thus it can function more natively in Osmocom universe than ortp. This ThemWi library was initially developed externally to Osmocom, but is now being brought into libosmo-netif so it can be used by native Osmocom projects, particularly OsmoBTS. Related: OS#6474 Change-Id: Ib63215aaf13ef8ab8f2e0c8d310164cd5c8824eb --- M include/osmocom/netif/Makefile.am A include/osmocom/netif/rtcp_defs.h A include/osmocom/netif/twrtp.h M src/Makefile.am A src/twrtp.c 5 files changed, 1,553 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/81/39281/7 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39281?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ib63215aaf13ef8ab8f2e0c8d310164cd5c8824eb Gerrit-Change-Number: 39281 Gerrit-PatchSet: 7 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[XL] Change in libosmo-netif[master]: bring twjit into libosmo-netif
by falconia 31 Aug '25

31 Aug '25

Attention is currently required from: falconia, fixeria, jolly, laforge. Hello Jenkins Builder, fixeria, jolly, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: bring twjit into libosmo-netif ...................................................................... bring twjit into libosmo-netif twjit is the jitter buffer portion of Themyscira Wireless RTP endpoint implementation, an alternative to Belledonne libortp. Unlike Belledonne software, ThemWi RTP library was developed specifically for use in Osmocom-based GSM, ISDN and IP-PSTN network elements, and is built on top of libosmocore primitives - thus it can function more natively in Osmocom universe than ortp. This ThemWi library was initially developed externally to Osmocom, but is now being brought into libosmo-netif so it can be used by native Osmocom projects, particularly OsmoBTS. Related: OS#6474 Change-Id: Ia3be5834571ca18b68939abbcf1ce3a879156658 --- M configure.ac M contrib/libosmo-netif.spec.in M include/osmocom/netif/Makefile.am A include/osmocom/netif/twjit.h A include/osmocom/netif/twjit_private.h M src/Makefile.am A src/twjit.c A src/twjit_conf.c 8 files changed, 1,316 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/80/39280/7 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39280?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ia3be5834571ca18b68939abbcf1ce3a879156658 Gerrit-Change-Number: 39280 Gerrit-PatchSet: 7 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-sgsn[master]: Store scu_iups in iu_rnc instead of ue_ctx
by lynxis lazus 30 Aug '25

30 Aug '25

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40984?usp=email ) Change subject: Store scu_iups in iu_rnc instead of ue_ctx ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40984?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I3969af765b7b0d1375b5e6ad8f3f2e9845f939ef Gerrit-Change-Number: 40984 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 30 Aug 2025 08:57:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: use separate install dir for --asan
by fixeria 30 Aug '25

30 Aug '25

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40979?usp=email ) Change subject: testenv: use separate install dir for --asan ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40979?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic75452b75d4c3ee8045b68353830b5532e1ce90e Gerrit-Change-Number: 40979 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Sat, 30 Aug 2025 08:39:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-dev[master]: gen_makefile: --targets: fix subdir projects
by fixeria 30 Aug '25

30 Aug '25

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-dev/+/40978?usp=email ) Change subject: gen_makefile: --targets: fix subdir projects ...................................................................... Patch Set 1: (1 comment) File gen_makefile.py: https://gerrit.osmocom.org/c/osmo-dev/+/40978/comment/ff59a531_f9e9464d?usp… : PS1, Line 247: if "_" in project: Wouldn't this turn `osmo_dia2gsup` into `osmo`? -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/40978?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I136f0d9cd982653b109005aeb35885b6f015eec8 Gerrit-Change-Number: 40978 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Sat, 30 Aug 2025 08:39:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-ci[master]: jobs/ttcn3-testsuites-testenv: enable upf latest
by fixeria 30 Aug '25

30 Aug '25

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40977?usp=email ) Change subject: jobs/ttcn3-testsuites-testenv: enable upf latest ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40977?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia148d627d5f02e165354665e0b1629cf5e3f330a Gerrit-Change-Number: 40977 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Sat, 30 Aug 2025 08:37:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-sgsn[master]: Store scu_iups in iu_rnc instead of ue_ctx
by pespin 29 Aug '25

29 Aug '25

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40984?usp=email ) Change subject: Store scu_iups in iu_rnc instead of ue_ctx ...................................................................... Store scu_iups in iu_rnc instead of ue_ctx All the ue_ctx belong to a given peer RNC, which holds the SCCP User to talk to it. Change-Id: I3969af765b7b0d1375b5e6ad8f3f2e9845f939ef --- M include/osmocom/sgsn/iu_client.h M include/osmocom/sgsn/iu_rnc.h M src/sgsn/gprs_ranap.c M src/sgsn/iu_client.c M src/sgsn/iu_rnc.c M src/sgsn/sccp.c 6 files changed, 21 insertions(+), 17 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/84/40984/1 diff --git a/include/osmocom/sgsn/iu_client.h b/include/osmocom/sgsn/iu_client.h index 4e44f03..e32084b 100644 --- a/include/osmocom/sgsn/iu_client.h +++ b/include/osmocom/sgsn/iu_client.h @@ -20,7 +20,6 @@ struct ranap_ue_conn_ctx { struct llist_head list; /* item in sgsn_sccp->ue_conn_ctx_list */ struct ranap_iu_rnc *rnc; - struct sgsn_sccp_user_iups *scu_iups; uint32_t conn_id; int integrity_active; struct gprs_ra_id ra_id; @@ -87,7 +86,7 @@ int ranap_iu_page_ps2(const char *imsi, const uint32_t *ptmsi, const struct osmo_routing_area_id *rai); -struct ranap_ue_conn_ctx *ue_conn_ctx_alloc(struct ranap_iu_rnc *rnc, struct sgsn_sccp_user_iups *scu_iups, uint32_t conn_id); +struct ranap_ue_conn_ctx *ue_conn_ctx_alloc(struct ranap_iu_rnc *rnc, uint32_t conn_id); /* freeing the UE will release all resources * This will close the SCCP connection connected to the UE */ diff --git a/include/osmocom/sgsn/iu_rnc.h b/include/osmocom/sgsn/iu_rnc.h index 344337d..55f716b 100644 --- a/include/osmocom/sgsn/iu_rnc.h +++ b/include/osmocom/sgsn/iu_rnc.h @@ -24,6 +24,7 @@ struct llist_head entry; struct osmo_rnc_id rnc_id; + struct sgsn_sccp_user_iups *scu_iups; struct osmo_sccp_addr sccp_addr; /* A list of struct iu_lac_rac_entry */ @@ -31,5 +32,6 @@ }; struct ranap_iu_rnc *iu_rnc_find_or_create(const struct osmo_rnc_id *rnc_id, + struct sgsn_sccp_user_iups *scu_iups, const struct osmo_sccp_addr *addr); void iu_rnc_update_rai_seen(struct ranap_iu_rnc *rnc, const struct osmo_routing_area_id *rai); diff --git a/src/sgsn/gprs_ranap.c b/src/sgsn/gprs_ranap.c index d101a3e..d05cc7b 100644 --- a/src/sgsn/gprs_ranap.c +++ b/src/sgsn/gprs_ranap.c @@ -268,7 +268,7 @@ rab_id, gtp_ip, gtp_tei, use_x213_nsap); msg = ranap_new_msg_rab_assign_data(rab_id, gtp_ip, gtp_tei, use_x213_nsap); - return sgsn_scu_iups_tx_data_req(ue_ctx->scu_iups, ue_ctx->conn_id, msg); + return sgsn_scu_iups_tx_data_req(ue_ctx->rnc->scu_iups, ue_ctx->conn_id, msg); } int sgsn_ranap_iu_tx_sec_mode_cmd(struct ranap_ue_conn_ctx *uectx, struct osmo_auth_vector *vec, @@ -279,7 +279,7 @@ /* create RANAP message */ msg = ranap_new_msg_sec_mod_cmd(vec->ik, send_ck ? vec->ck : NULL, new_key ? RANAP_KeyStatus_new : RANAP_KeyStatus_old); - return sgsn_scu_iups_tx_data_req(uectx->scu_iups, uectx->conn_id, msg); + return sgsn_scu_iups_tx_data_req(uectx->rnc->scu_iups, uectx->conn_id, msg); } int sgsn_ranap_iu_tx_common_id(struct ranap_ue_conn_ctx *uectx, const char *imsi) @@ -290,7 +290,7 @@ uectx->conn_id); msg = ranap_new_msg_common_id(imsi); - return sgsn_scu_iups_tx_data_req(uectx->scu_iups, uectx->conn_id, msg); + return sgsn_scu_iups_tx_data_req(uectx->rnc->scu_iups, uectx->conn_id, msg); } /* Send a paging command down a given SCCP User. tmsi and paging_cause are @@ -326,7 +326,7 @@ msg = ranap_new_msg_dt(sapi, msg_nas->data, msgb_length(msg_nas)); msgb_free(msg_nas); - return sgsn_scu_iups_tx_data_req(uectx->scu_iups, uectx->conn_id, msg); + return sgsn_scu_iups_tx_data_req(uectx->rnc->scu_iups, uectx->conn_id, msg); } /* Send CL RANAP message over SCCP: */ @@ -368,7 +368,7 @@ cause = &default_cause; msg = ranap_new_msg_iu_rel_cmd(cause); - return sgsn_scu_iups_tx_data_req(uectx->scu_iups, uectx->conn_id, msg); + return sgsn_scu_iups_tx_data_req(uectx->rnc->scu_iups, uectx->conn_id, msg); } void sgsn_ranap_iu_tx_release_free(struct ranap_ue_conn_ctx *ctx, @@ -428,11 +428,11 @@ gprs_rai_to_osmo(&ra_id2, &ra_id); /* Make sure we know the RNC Id and LAC+RAC coming in on this connection. */ - rnc = iu_rnc_find_or_create(&rnc_id, rem_sccp_addr); + rnc = iu_rnc_find_or_create(&rnc_id, scu_iups, rem_sccp_addr); OSMO_ASSERT(rnc); iu_rnc_update_rai_seen(rnc, &ra_id2); - ue = ue_conn_ctx_alloc(rnc, scu_iups, conn_id); + ue = ue_conn_ctx_alloc(rnc, conn_id); OSMO_ASSERT(ue); ue->ra_id = ra_id; @@ -711,7 +711,7 @@ return sgsn_ranap_iu_tx_error_ind(scu_iups, &ud_prim->calling_addr, &cause); } - rnc = iu_rnc_find_or_create(&rnc_id, &ud_prim->calling_addr); + rnc = iu_rnc_find_or_create(&rnc_id, scu_iups, &ud_prim->calling_addr); OSMO_ASSERT(rnc); /* send reset response */ diff --git a/src/sgsn/iu_client.c b/src/sgsn/iu_client.c index d392152..21c0470 100644 --- a/src/sgsn/iu_client.c +++ b/src/sgsn/iu_client.c @@ -78,19 +78,18 @@ global_iu_event(ctx, RANAP_IU_EVENT_IU_RELEASE, NULL); } -struct ranap_ue_conn_ctx *ue_conn_ctx_alloc(struct ranap_iu_rnc *rnc, struct sgsn_sccp_user_iups *scu_iups, uint32_t conn_id) +struct ranap_ue_conn_ctx *ue_conn_ctx_alloc(struct ranap_iu_rnc *rnc, uint32_t conn_id) { struct ranap_ue_conn_ctx *ctx = talloc_zero(sgsn, struct ranap_ue_conn_ctx); ctx->rnc = rnc; - ctx->scu_iups = scu_iups; ctx->conn_id = conn_id; ctx->notification = true; ctx->free_on_release = false; osmo_timer_setup(&ctx->release_timeout, ue_conn_ctx_release_timeout_cb, ctx); - llist_add(&ctx->list, &scu_iups->ue_conn_ctx_list); + llist_add(&ctx->list, &rnc->scu_iups->ue_conn_ctx_list); return ctx; } @@ -101,7 +100,7 @@ return; osmo_timer_del(&ue_ctx->release_timeout); - osmo_sccp_tx_disconn(ue_ctx->scu_iups->scu, ue_ctx->conn_id, NULL, 0); + osmo_sccp_tx_disconn(ue_ctx->rnc->scu_iups->scu, ue_ctx->conn_id, NULL, 0); llist_del(&ue_ctx->list); talloc_free(ue_ctx); } diff --git a/src/sgsn/iu_rnc.c b/src/sgsn/iu_rnc.c index 8bb5bc1..36350ff 100644 --- a/src/sgsn/iu_rnc.c +++ b/src/sgsn/iu_rnc.c @@ -43,7 +43,9 @@ #include <osmocom/sgsn/sccp.h> #include <osmocom/sgsn/sgsn.h> -static struct ranap_iu_rnc *iu_rnc_alloc(const struct osmo_rnc_id *rnc_id, const struct osmo_sccp_addr *addr) +static struct ranap_iu_rnc *iu_rnc_alloc(const struct osmo_rnc_id *rnc_id, + struct sgsn_sccp_user_iups *scu_iups, + const struct osmo_sccp_addr *addr) { struct ranap_iu_rnc *rnc = talloc_zero(sgsn, struct ranap_iu_rnc); OSMO_ASSERT(rnc); @@ -51,6 +53,7 @@ INIT_LLIST_HEAD(&rnc->lac_rac_list); rnc->rnc_id = *rnc_id; + rnc->scu_iups = scu_iups; rnc->sccp_addr = *addr; llist_add(&rnc->entry, &sgsn->rnc_list); @@ -71,6 +74,7 @@ } struct ranap_iu_rnc *iu_rnc_find_or_create(const struct osmo_rnc_id *rnc_id, + struct sgsn_sccp_user_iups *scu_iups, const struct osmo_sccp_addr *addr) { struct ranap_iu_rnc *rnc; @@ -84,7 +88,7 @@ rnc->sccp_addr = *addr; } } else { - rnc = iu_rnc_alloc(rnc_id, addr); + rnc = iu_rnc_alloc(rnc_id, scu_iups, addr); } return rnc; } diff --git a/src/sgsn/sccp.c b/src/sgsn/sccp.c index b1291a3..1eed08a 100644 --- a/src/sgsn/sccp.c +++ b/src/sgsn/sccp.c @@ -150,7 +150,7 @@ global_iu_event(ue, RANAP_IU_EVENT_LINK_INVALIDATED, NULL); /* A RANAP_IU_EVENT_LINK_INVALIDATED, can lead to a free */ - ue = ue_conn_ctx_find(ue->scu_iups, conn_id); + ue = ue_conn_ctx_find(ue->rnc->scu_iups, conn_id); if (!ue) return; if (ue->free_on_release) -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40984?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I3969af765b7b0d1375b5e6ad8f3f2e9845f939ef Gerrit-Change-Number: 40984 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-sgsn[master]: iu_rnc: Split iu_rnc_register API into 2 steps
by lynxis lazus 29 Aug '25

29 Aug '25

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40973?usp=email ) Change subject: iu_rnc: Split iu_rnc_register API into 2 steps ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40973?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I3761cc539c63a7ed680b04bb8136a43d397c10aa Gerrit-Change-Number: 40973 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 29 Aug 2025 15:21:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0