August 2025 - gerrit-log - lists.osmocom.org

[M] Change in osmo-sgsn[master]: ranap: Improve error handling in Rx RESET

by lynxis lazus

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40975?usp=email ) Change subject: ranap: Improve error handling in Rx RESET ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40975?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I2a53e10c3903992a42d081e3ec300fbdb9b3c34c Gerrit-Change-Number: 40975 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 29 Aug 2025 15:21:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 weeks, 2 days

1
0
0 0

[M] Change in osmo-sgsn[master]: iu_rnc: Split iu_rnc_register API into 2 steps

by lynxis lazus

Attention is currently required from: pespin. lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40973?usp=email ) Change subject: iu_rnc: Split iu_rnc_register API into 2 steps ...................................................................... Patch Set 2: (1 comment) File src/sgsn/iu_rnc.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/40973/comment/01efcaab_3b8abe39?us… : PS1, Line 80: if (rnc) { > in osmo-hnbgw we actually use a unique RNC-ID for the whole hnbgw towards CN. […] To clarify, all HNB of a single HNB-GW uses the same RNC-ID, which is configure in the HNB-GW. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40973?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I3761cc539c63a7ed680b04bb8136a43d397c10aa Gerrit-Change-Number: 40973 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 29 Aug 2025 15:20:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

3 weeks, 2 days

1
0
0 0

[M] Change in osmo-sgsn[master]: iu_rnc: Split iu_rnc_register API into 2 steps

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40973?usp=email ) Change subject: iu_rnc: Split iu_rnc_register API into 2 steps ...................................................................... Patch Set 2: (1 comment) File src/sgsn/iu_rnc.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/40973/comment/f6580bb3_13c21001?us… : PS1, Line 80: if (rnc) { > Yes good point, I didn't think about that scenario with hnbgw. […] in osmo-hnbgw we actually use a unique RNC-ID for the whole hnbgw towards CN. So from SGSN PoV it looks like a single RNC and my previous assumptions apply. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40973?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I3761cc539c63a7ed680b04bb8136a43d397c10aa Gerrit-Change-Number: 40973 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 29 Aug 2025 14:30:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

3 weeks, 2 days

1
0
0 0

[XL] Change in osmo-ttcn3-hacks[master]: euicc: clean up superfluous encdec cpp files

by Hoernchen

Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40983?usp=email ) Change subject: euicc: clean up superfluous encdec cpp files ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40983?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ice4ab4328faf6ad34a060bc2004a44de10691cff Gerrit-Change-Number: 40983 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Fri, 29 Aug 2025 13:49:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

3 weeks, 2 days

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: euicc: changes and extensions to support es9p and es2p testing

by Hoernchen

Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40982?usp=email ) Change subject: euicc: changes and extensions to support es9p and es2p testing ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40982?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9c622751e195d33f6f0a832265d6b10674d1c75c Gerrit-Change-Number: 40982 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Fri, 29 Aug 2025 13:48:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

3 weeks, 2 days

1
0
0 0

[M] Change in osmo-ttcn3-hacks[master]: es12_Types_JSON: add ES12 JSON encoder/decoder

by Hoernchen

Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40981?usp=email ) Change subject: es12_Types_JSON: add ES12 JSON encoder/decoder ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40981?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I875cbb3a6dab6ac1eac5df1199f6fb71738a744e Gerrit-Change-Number: 40981 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Fri, 29 Aug 2025 13:48:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

3 weeks, 2 days

1
0
0 0

[L] Change in osmo-ttcn3-hacks[master]: es2p_Types_JSON: add ES2p JSON encoder/decoder

by Hoernchen

Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40980?usp=email ) Change subject: es2p_Types_JSON: add ES2p JSON encoder/decoder ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40980?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic6e230bdd0b2c43a5183cd1f53b930e6f3c53e66 Gerrit-Change-Number: 40980 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Fri, 29 Aug 2025 13:47:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

3 weeks, 2 days

1
0
0 0

[M] Change in osmo-sgsn[master]: ranap: Improve error handling in Rx RESET

by pespin

Attention is currently required from: lynxis lazus. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40975?usp=email ) Change subject: ranap: Improve error handling in Rx RESET ...................................................................... Patch Set 3: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-sgsn/+/40975/comment/dc3bd954_f19aa296?us… : PS1, Line 8: > I'll update the commit description listing the changes plus explaining this also prepares for a foll […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40975?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I2a53e10c3903992a42d081e3ec300fbdb9b3c34c Gerrit-Change-Number: 40975 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 29 Aug 2025 12:54:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

3 weeks, 2 days

1
0
0 0

[M] Change in osmo-sgsn[master]: ranap: Improve error handling in Rx RESET

by pespin

Attention is currently required from: lynxis lazus, pespin. Hello Jenkins Builder, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40975?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by lynxis lazus Change subject: ranap: Improve error handling in Rx RESET ...................................................................... ranap: Improve error handling in Rx RESET * Verify the CN Indicator is set to PS to avoid reacting on content from unexpected peers (eg. IuCS). If none is set, be permissive on rx and assume PS. * If GlobalRNC-ID IE is missing, reject the RESET with an Error Indication towards the peer to notify about the rejection. Same if we couldn't decode properly it. * Introduce Tx helpers for generic SCCP UNITDATA.req and RANAP Error Indication helpers to simplify code and avoid duplication. Depends: osmo-iuh.git Change-Id I58c75b3e0e0f33f48d077385ffac820a6b2be59e Change-Id: I2a53e10c3903992a42d081e3ec300fbdb9b3c34c --- M TODO-RELEASE M include/osmocom/sgsn/gprs_ranap.h M src/sgsn/gprs_ranap.c 3 files changed, 68 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/75/40975/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40975?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I2a53e10c3903992a42d081e3ec300fbdb9b3c34c Gerrit-Change-Number: 40975 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

3 weeks, 2 days

1
0
0 0

[M] Change in osmo-sgsn[master]: iu_rnc: Split iu_rnc_register API into 2 steps

by pespin

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40973?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+2 by lynxis lazus, Verified+1 by Jenkins Builder The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: iu_rnc: Split iu_rnc_register API into 2 steps ...................................................................... iu_rnc: Split iu_rnc_register API into 2 steps Split lookup+allocation from RAI updating. This will be needed once we start creating iu_rnc objects upon SCCP rx RANAP RESET messages, which hold Global RNC-ID but no RAI information. Change-Id: I3761cc539c63a7ed680b04bb8136a43d397c10aa --- M include/osmocom/sgsn/iu_rnc.h M src/sgsn/gprs_ranap.c M src/sgsn/iu_rnc.c 3 files changed, 40 insertions(+), 35 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/73/40973/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40973?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I3761cc539c63a7ed680b04bb8136a43d397c10aa Gerrit-Change-Number: 40973 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

3 weeks, 2 days

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2025