Attention is currently required from: dexter.
laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/40936?usp=email )
Change subject: contrib: add a tool to parse the SIMA response from an eUICC
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/40936?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ida4c3c5446653b283a3869c0c387f328ae51e55e
Gerrit-Change-Number: 40936
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 28 Aug 2025 21:43:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: lynxis lazus.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40973?usp=email )
Change subject: iu_rnc: Split iu_rnc_register API into 2 steps
......................................................................
Patch Set 1:
(1 comment)
File src/sgsn/iu_rnc.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/40973/comment/c40c0fb0_3ee77591?us… :
PS1, Line 80: if (rnc) {
> Is there any relation between RNC and SCCP? […]
yes the relation is: SGSN talks to each RNC/HNBGW through RANAP, which in turn is transported over SCCP.
There can be as many RNCs as you want per SCCP network, only limited by having different SCCP addresses (ie. different M3UA/SUA PC, since SSN is fixed).
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40973?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I3761cc539c63a7ed680b04bb8136a43d397c10aa
Gerrit-Change-Number: 40973
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Thu, 28 Aug 2025 21:43:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: dexter.
laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/40936?usp=email )
Change subject: contrib: add a tool to parse the SIMA response from an eUICC
......................................................................
Patch Set 3:
(2 comments)
File contrib/analyze_simaResponse.py:
https://gerrit.osmocom.org/c/pysim/+/40936/comment/6edbc466_eefbb451?usp=em… :
PS3, Line 3: # A tool to anylaze the eUICC simaResponse (series of EUICCResponse)
sp: analyze
https://gerrit.osmocom.org/c/pysim/+/40936/comment/8c58c7e2_f51de4f5?usp=em… :
PS3, Line 5: Sysmocom s.f.m.c. GmbH
the correct abbreviated version of the company name is "sysmocom - s.f.m.c. GmbH", i.e. lowercase and with dash.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/40936?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ida4c3c5446653b283a3869c0c387f328ae51e55e
Gerrit-Change-Number: 40936
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 28 Aug 2025 21:43:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: lynxis lazus, pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-iuh/+/40974?usp=email )
Change subject: ranap: Introduce ranap_new_msg_error_ind()
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Patchset:
PS2:
> Could you describe a little bit more about the usage of the error indication? […]
without reading the specific 3gpp spec in mind: In any ITU protocol, an "Error indication" is a unilateral message saying "there was an error as specified by the cause value".
The function to create such a message (at the sender side) is used whenever the spec says we should generate such a message.
Whatever the recipient does in reaction is out of scope here, as this code is just generating a to-be-sent message.
--
To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/40974?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Gerrit-Change-Id: I58c75b3e0e0f33f48d077385ffac820a6b2be59e
Gerrit-Change-Number: 40974
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Thu, 28 Aug 2025 21:42:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40972?usp=email )
Change subject: ranap: Reject InitialUE without RAC IE
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Good idea! How about also freeing the iu signalling connection?
I'm already improving this further in follow-up patches when adding the RESET FSM in my WIP branch.
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40972?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I7d6b996ddf1c5a7cde1bf06b500d3ed19c6090c6
Gerrit-Change-Number: 40972
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Thu, 28 Aug 2025 21:41:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>
Attention is currently required from: fixeria, osmith.
keith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40965?usp=email )
Change subject: OBS: --version-append: never override version
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-ci/+/40965/comment/972c1302_fdb64ec6?usp=… :
PS1, Line 25: While IMHO it is a bad idea to just amend the commit of the last release
> I think what I did there was checkout the latest tag, then git rebase -i [quite_some_commits back] a […]
Actually, looking at it again: In the case of osmo-sgsn, What I did was pick a bunch of commits, on top of a particular commit I had been working on and then add more of my own work, but I mistakenly included the commit that bumped the version in the debian changelog. But as I said, understanding the issue, I don't need this change, so if you are making it for me only, then maybe don't.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40965?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I589ceb08b9e1ff2ccdd54e94216b25e1e40f22fe
Gerrit-Change-Number: 40965
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: keith <keith(a)rhizomatica.org>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 28 Aug 2025 21:07:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: keith <keith(a)rhizomatica.org>