August 2025 - gerrit-log - lists.osmocom.org

[M] Change in osmo-sgsn[master]: use variable name rai for `struct osmo_routing_area_id`

by lynxis lazus

Attention is currently required from: lynxis lazus. Hello Jenkins Builder, daniel, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40689?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: use variable name rai for `struct osmo_routing_area_id` ...................................................................... use variable name rai for `struct osmo_routing_area_id` Be consistent with variable naming if a single `struct osmo_routing_area_id *` area id is used. Change-Id: I946983d4857035e06c68af378654466b35025014 --- M include/osmocom/sgsn/gprs_routing_area.h M include/osmocom/sgsn/gprs_sndcp.h M include/osmocom/sgsn/gtp.h M src/sgsn/gprs_bssgp.c M src/sgsn/gprs_gmm.c M src/sgsn/gprs_routing_area.c M src/sgsn/gprs_sndcp.c M src/sgsn/sgsn_libgtp.c M tests/gprs_routing_area/gprs_routing_area_test.c 9 files changed, 57 insertions(+), 57 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/89/40689/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40689?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I946983d4857035e06c68af378654466b35025014 Gerrit-Change-Number: 40689 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

17 hours, 22 minutes

1
0
0 0

[M] Change in osmo-sgsn[master]: routing area: introduce ran_type on the RA

by lynxis lazus

Attention is currently required from: daniel, fixeria, pespin. Hello Jenkins Builder, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40688?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by daniel, Verified+1 by Jenkins Builder Change subject: routing area: introduce ran_type on the RA ...................................................................... routing area: introduce ran_type on the RA A Routing Area should be uniquely identified by the RAI. Following this, it is forbidden to have a RAI which is valid in both, GERAN and UTRAN. Change-Id: I59c35f1a4912ff11574bb31e4fe424816993548c --- M include/osmocom/sgsn/gprs_routing_area.h M src/sgsn/gprs_routing_area.c M tests/gprs_routing_area/gprs_routing_area_test.c 3 files changed, 90 insertions(+), 36 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/88/40688/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40688?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I59c35f1a4912ff11574bb31e4fe424816993548c Gerrit-Change-Number: 40688 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>

17 hours, 22 minutes

1
0
0 0

[S] Change in osmo-sgsn[master]: routing area: move cell.cell_id behind a geran union

by lynxis lazus

Attention is currently required from: fixeria, lynxis lazus, pespin. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40690?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Code-Review+2 by pespin, Verified+1 by Jenkins Builder The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: routing area: move cell.cell_id behind a geran union ...................................................................... routing area: move cell.cell_id behind a geran union To prepare for Iu support, use the SGSN RA cell for both, a GERAN Cell and a UTRAN Service Area. Change-Id: I0c24d98dd699748842dca271b93e58d27cf02285 --- M include/osmocom/sgsn/gprs_routing_area.h M src/sgsn/gprs_routing_area.c 2 files changed, 11 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/90/40690/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40690?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I0c24d98dd699748842dca271b93e58d27cf02285 Gerrit-Change-Number: 40690 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

17 hours, 22 minutes

1
0
0 0

[XS] Change in ...logger_gsmtap[master]: Fix warning: behaviour logger_handler undefined

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/logger_gsmtap/+/40808?usp=email ) Change subject: Fix warning: behaviour logger_handler undefined ...................................................................... Fix warning: behaviour logger_handler undefined Erlang/OTP versions below 27.0.0 have no 'logger_handler' behaviour, so let's declare it conditionally using the ?OTP_RELEASE macro. Change-Id: I11f5723a1b2fa46decee2a3117202d9882b859a7 --- M src/logger_gsmtap_h.erl 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/src/logger_gsmtap_h.erl b/src/logger_gsmtap_h.erl index c3cba56..99da8d6 100644 --- a/src/logger_gsmtap_h.erl +++ b/src/logger_gsmtap_h.erl @@ -15,7 +15,10 @@ GSMTAP logging handler. """. +%% Erlang/OTP versions below 27.0.0 have no 'logger_handler' behaviour +-if(?OTP_RELEASE >= 27). -behaviour(logger_handler). +-endif. %% logger_handler callbacks -export([adding_handler/1, -- To view, visit https://gerrit.osmocom.org/c/erlang/logger_gsmtap/+/40808?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/logger_gsmtap Gerrit-Branch: master Gerrit-Change-Id: I11f5723a1b2fa46decee2a3117202d9882b859a7 Gerrit-Change-Number: 40808 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

17 hours, 24 minutes

1
0
0 0

[XS] Change in ...logger_gsmtap[master]: logger_gsmtap.app.src: add vim modeline and syntax hint

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/erlang/logger_gsmtap/+/40801?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: logger_gsmtap.app.src: add vim modeline and syntax hint ...................................................................... logger_gsmtap.app.src: add vim modeline and syntax hint Change-Id: Id8cd8e1ab19ed2209ff1d867a7026b7663920013 --- M src/logger_gsmtap.app.src 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/src/logger_gsmtap.app.src b/src/logger_gsmtap.app.src index 0307fb0..8eb1a26 100644 --- a/src/logger_gsmtap.app.src +++ b/src/logger_gsmtap.app.src @@ -1,3 +1,5 @@ +%% -*- erlang -*- + {application, logger_gsmtap, [ {description, "GSMTAP handler for Erlang's Logger module"}, {vsn, semver}, @@ -9,3 +11,5 @@ {licenses, ["Mozilla Public License 2.0"]}, {links, [{"Gitea", "https://gitea.osmocom.org/erlang/logger_gsmtap"}]} ]}. + +%% vim:set ts=4 sw=4 et: -- To view, visit https://gerrit.osmocom.org/c/erlang/logger_gsmtap/+/40801?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: erlang/logger_gsmtap Gerrit-Branch: master Gerrit-Change-Id: Id8cd8e1ab19ed2209ff1d867a7026b7663920013 Gerrit-Change-Number: 40801 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

17 hours, 24 minutes

1
0
0 0

[XS] Change in ...logger_gsmtap[master]: Fix warning: behaviour logger_handler undefined

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/logger_gsmtap/+/40808?usp=email ) Change subject: Fix warning: behaviour logger_handler undefined ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/erlang/logger_gsmtap/+/40808?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/logger_gsmtap Gerrit-Branch: master Gerrit-Change-Id: I11f5723a1b2fa46decee2a3117202d9882b859a7 Gerrit-Change-Number: 40808 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Aug 2025 12:48:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

17 hours, 28 minutes

1
0
0 0

[XS] Change in ...logger_gsmtap[master]: TEST

by fixeria

fixeria has abandoned this change. ( https://gerrit.osmocom.org/c/erlang/logger_gsmtap/+/40807?usp=email ) Change subject: TEST ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/erlang/logger_gsmtap/+/40807?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: erlang/logger_gsmtap Gerrit-Branch: master Gerrit-Change-Id: I172c97e1998ca491a468c5f4b8c643b73592092c Gerrit-Change-Number: 40807 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

17 hours, 29 minutes

1
0
0 0

[XS] Change in ...logger_gsmtap[master]: Fix warning: behaviour logger_handler undefined

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/logger_gsmtap/+/40808?usp=email ) Change subject: Fix warning: behaviour logger_handler undefined ...................................................................... Fix warning: behaviour logger_handler undefined Erlang/OTP versions below 27.0.0 have no 'logger_handler' behaviour, so let's declare it conditionally using the ?OTP_RELEASE macro. Change-Id: I11f5723a1b2fa46decee2a3117202d9882b859a7 --- M src/logger_gsmtap_h.erl 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/logger_gsmtap refs/changes/08/40808/1 diff --git a/src/logger_gsmtap_h.erl b/src/logger_gsmtap_h.erl index c3cba56..99da8d6 100644 --- a/src/logger_gsmtap_h.erl +++ b/src/logger_gsmtap_h.erl @@ -15,7 +15,10 @@ GSMTAP logging handler. """. +%% Erlang/OTP versions below 27.0.0 have no 'logger_handler' behaviour +-if(?OTP_RELEASE >= 27). -behaviour(logger_handler). +-endif. %% logger_handler callbacks -export([adding_handler/1, -- To view, visit https://gerrit.osmocom.org/c/erlang/logger_gsmtap/+/40808?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/logger_gsmtap Gerrit-Branch: master Gerrit-Change-Id: I11f5723a1b2fa46decee2a3117202d9882b859a7 Gerrit-Change-Number: 40808 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

17 hours, 29 minutes

1
0
0 0

[S] Change in osmo-sgsn[master]: routing area: on alloc, check if RA already exists

by lynxis lazus

Attention is currently required from: fixeria, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40691?usp=email ) Change subject: routing area: on alloc, check if RA already exists ...................................................................... Patch Set 2: (1 comment) File src/sgsn/gprs_routing_area.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/40691/comment/f6a780bb_3a729493?us… : PS2, Line 88: LOGL_ERROR > Please, leave this alloc function lone and use a find_or_create() API instead which uses this alloc […] It should only happen in rare cases, when the PCU + hnodeb/RNC is misconfigured. Ack at pespin. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40691?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I6955a09d9d8f3ba4dc3a14d7ed5cd9798d929c61 Gerrit-Change-Number: 40691 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Aug 2025 12:45:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

17 hours, 31 minutes

1
0
0 0

[M] Change in osmo-sgsn[master]: routing area: introduce ran_type on the RA

by lynxis lazus

Attention is currently required from: fixeria, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40688?usp=email ) Change subject: routing area: introduce ran_type on the RA ...................................................................... Patch Set 2: (7 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-sgsn/+/40688/comment/c7d40e7a_520e232c?us… : PS2, Line 9: unique > uniquely Done File include/osmocom/sgsn/gprs_routing_area.h: https://gerrit.osmocom.org/c/osmo-sgsn/+/40688/comment/7502a69a_eee4c86d?us… : PS2, Line 34: * and for routing, the SGSN must know to which PCU a given cell is connected. > "... and, for routing, the SGSN". […] Done https://gerrit.osmocom.org/c/osmo-sgsn/+/40688/comment/aee3fb1d_509a88bd?us… : PS2, Line 35: 2x PCU serves > Agree with fixeria, writing like does clarifies it. Done https://gerrit.osmocom.org/c/osmo-sgsn/+/40688/comment/e7dd3a47_c2ecd07c?us… : PS2, Line 38: individual > individually Done https://gerrit.osmocom.org/c/osmo-sgsn/+/40688/comment/2f5237c0_f8cfa01c?us… : PS2, Line 39: has > have Done https://gerrit.osmocom.org/c/osmo-sgsn/+/40688/comment/6145ce6d_a2b53cfe?us… : PS2, Line 47: which are alive > yeah, known_cells, active_cells, served_cells, whatever. […] Done File src/sgsn/gprs_routing_area.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/40688/comment/2da1ab82_62cd4071?us… : PS2, Line 201: valid for GERAN > I agree, but this commit can't fix all that at the same time. Most of the previous api is related to geran. But will it do in a following commit. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40688?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I59c35f1a4912ff11574bb31e4fe424816993548c Gerrit-Change-Number: 40688 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Aug 2025 12:42:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

17 hours, 33 minutes

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2025