August 2025 - gerrit-log - lists.osmocom.org

[XS] Change in pysim[master]: requirements: set cmd2>=2.6.2,<3.0

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/pysim/+/40952?usp=email ) Change subject: requirements: set cmd2>=2.6.2,<3.0 ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File requirements.txt: https://gerrit.osmocom.org/c/pysim/+/40952/comment/acee596e_69475f5a?usp=em… : PS1, Line 4: cmd2>=2.6.2,<3.0 > I'm not sure I understand what you mean. This sets the range of versions of cmd2 from 2.6. […] Ah, indeed this does not limit those who may have `>=3.0` provided by their distribution. Fine then. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40952?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I4ba65ed486247c5670313b75f43a242d264df14b Gerrit-Change-Number: 40952 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 28 Aug 2025 12:04:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

3 weeks, 3 days

1
0
0 0

[M] Change in osmo-ci[master]: OBS: lib/debian: format with ruff

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/40964?usp=email ) Change subject: OBS: lib/debian: format with ruff ...................................................................... OBS: lib/debian: format with ruff Change-Id: I9aeade2c81f9d7bcfe0c04a0b9c75012217af90f --- M .ruff.toml M scripts/obs/lib/debian.py 2 files changed, 36 insertions(+), 31 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve diff --git a/.ruff.toml b/.ruff.toml index d8e72e2..a75a783 100644 --- a/.ruff.toml +++ b/.ruff.toml @@ -11,7 +11,6 @@ "scripts/obs/lib/binpkg_deb.py", "scripts/obs/lib/binpkg_rpm.py", "scripts/obs/lib/config.py", - "scripts/obs/lib/debian.py", "scripts/obs/lib/docker.py", "scripts/obs/lib/git.py", "scripts/obs/lib/metapkg.py", diff --git a/scripts/obs/lib/debian.py b/scripts/obs/lib/debian.py index 8e0fd5e..9193d66 100644 --- a/scripts/obs/lib/debian.py +++ b/scripts/obs/lib/debian.py @@ -15,9 +15,10 @@ except ImportError: pass + def control_add_depend(project, pkgname, version): - """ :param pkgname: of the meta-package to depend on (e.g. osmocom-nightly) - :param version: of the meta-pkgname to depend on or None """ + """:param pkgname: of the meta-package to depend on (e.g. osmocom-nightly) + :param version: of the meta-pkgname to depend on or None""" repo_path = lib.git.get_repo_path(project) if version: @@ -30,7 +31,7 @@ def changelog_add_entry(project, version): - """ :param version: for the new changelog entry """ + """:param version: for the new changelog entry""" feed = lib.args.feed repo_path = lib.git.get_repo_path(project) changelog_path = f"{repo_path}/debian/changelog" @@ -52,8 +53,7 @@ with open(changelog_path, "w") as f: f.write(f"{pkgname} ({version}) unstable; urgency=medium\n") f.write("\n") - f.write(" * Automatically generated changelog entry for building the" - f" Osmocom {feed} feed\n") + f.write(f" * Automatically generated changelog entry for building the Osmocom {feed} feed\n") f.write("\n") f.write(f" -- Osmocom OBS scripts <info(a)osmocom.org> {date_str}\n") f.write("\n") @@ -61,7 +61,7 @@ def fix_source_format(project): - """ Always use format "3.0 (native)" (e.g. limesuite has "3.0 (quilt)").""" + """Always use format "3.0 (native)" (e.g. limesuite has "3.0 (quilt)").""" repo_path = lib.git.get_repo_path(project) format_path = f"{repo_path}/debian/source/format" if not os.path.exists(format_path): @@ -104,18 +104,19 @@ def changelog_add_entry_if_needed(project, version): - """ Adjust the changelog if the version in the changelog is different from - the given version. """ + """Adjust the changelog if the version in the changelog is different from + the given version.""" version_changelog = get_last_version_from_changelog(project) # Don't use a lower number (OS#6173) try: - if packaging.version.parse(version_changelog.split("-")[0]) > \ - packaging.version.parse(version.split("-")[0]): - print(f"{project}: WARNING: version from changelog" - f" ({version_changelog}) is higher than version based on git tag" - f" ({version}), using version from changelog (git tag not pushed" - " yet?)") + if packaging.version.parse(version_changelog.split("-")[0]) > packaging.version.parse(version.split("-")[0]): + print( + f"{project}: WARNING: version from changelog" + f" ({version_changelog}) is higher than version based on git tag" + f" ({version}), using version from changelog (git tag not pushed" + " yet?)" + ) return except packaging.version.InvalidVersion: # packaging.version.parse can parse the version numbers used in Osmocom @@ -129,15 +130,14 @@ if version_changelog == version: return - print(f"{project}: adding debian/changelog entry ({version_changelog} =>" - f" {version})") + print(f"{project}: adding debian/changelog entry ({version_changelog} => {version})") changelog_add_entry(project, version) def configure_append(project, parameters): - """ Add one or more configure parameters like --enable-sanitize to the - dh_auto_configure line, also add the override_dh_auto_configure block - if missing. """ + """Add one or more configure parameters like --enable-sanitize to the + dh_auto_configure line, also add the override_dh_auto_configure block + if missing.""" print(f"{project}: adding configure parameters: {parameters}") rules = f"{lib.git.get_repo_path(project)}/debian/rules" override_found = False @@ -154,20 +154,21 @@ if " -- " in line.replace("\t", " "): lines[i] = line.replace(" --", f" -- {parameters}", 1) else: - lines[i] = line.replace("dh_auto_configure", - f"dh_auto_configure -- {parameters}", 1) + lines[i] = line.replace("dh_auto_configure", f"dh_auto_configure -- {parameters}", 1) break if not override_found: - lines += ["\n", - "override_dh_auto_configure:\n", - f"\tdh_auto_configure -- {parameters}\n"] + lines += [ + "\n", + "override_dh_auto_configure:\n", + f"\tdh_auto_configure -- {parameters}\n", + ] with open(rules, "w") as f: f.writelines(lines) def disable_manuals(project): - """ Disabling manuals speeds up the build time significantly, we don't - need them for e.g. the asan repository. """ + """Disabling manuals speeds up the build time significantly, we don't + need them for e.g. the asan repository.""" print(f"{project}: disabling manuals") debian = f"{lib.git.get_repo_path(project)}/debian" # Remove dependencies @@ -183,11 +184,16 @@ def build_source_package(project): fix_source_format(project) print(f"{project}: building debian source package") - lib.run_cmd(["dpkg-buildpackage", "-S", "-uc", "-us", "-d"], - cwd=lib.git.get_repo_path(project)) + lib.run_cmd( + ["dpkg-buildpackage", "-S", "-uc", "-us", "-d"], + cwd=lib.git.get_repo_path(project), + ) def move_files_to_output(project): path_output = lib.get_output_path(project) - lib.run_cmd(f"mv *.tar* *.dsc {shlex.quote(path_output)}", shell=True, - cwd=lib.config.path_cache) + lib.run_cmd( + f"mv *.tar* *.dsc {shlex.quote(path_output)}", + shell=True, + cwd=lib.config.path_cache, + ) -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40964?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I9aeade2c81f9d7bcfe0c04a0b9c75012217af90f Gerrit-Change-Number: 40964 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

3 weeks, 3 days

1
0
0 0

[M] Change in osmo-ci[master]: OBS: lib/debian: format with ruff

by osmith

osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40964?usp=email ) Change subject: OBS: lib/debian: format with ruff ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40964?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I9aeade2c81f9d7bcfe0c04a0b9c75012217af90f Gerrit-Change-Number: 40964 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 28 Aug 2025 11:48:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 weeks, 3 days

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: fix TESTENV_INSTALL_DIR for --binary-repo

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40967?usp=email ) Change subject: testenv: fix TESTENV_INSTALL_DIR for --binary-repo ...................................................................... testenv: fix TESTENV_INSTALL_DIR for --binary-repo When --binary-repo is set, "/" must be used as install directory, without any suffix for the distribution. Fix for: realpath: /-debian-trixie/usr/lib/osmo-s1gw: No such file or directory Fixes: 2152d512 ("testenv: use separate cache dirs per distro") Change-Id: I1e1ca65fd6a7d77c751dd7138015ff474f8ae576 --- M _testenv/testenv/cmd.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/_testenv/testenv/cmd.py b/_testenv/testenv/cmd.py index 6f50677..2cc590a 100644 --- a/_testenv/testenv/cmd.py +++ b/_testenv/testenv/cmd.py @@ -33,7 +33,7 @@ install_dir = "/" else: install_dir = os.path.join(testenv.args.cache, "podman/install") - install_dir += distro_cache_suffix() + install_dir += distro_cache_suffix() else: install_dir = os.path.join(testenv.args.cache, "host/install") -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40967?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1e1ca65fd6a7d77c751dd7138015ff474f8ae576 Gerrit-Change-Number: 40967 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

3 weeks, 3 days

1
0
0 0

[M] Change in osmo-ci[master]: OBS: lib/debian: format with ruff

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40964?usp=email ) Change subject: OBS: lib/debian: format with ruff ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40964?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I9aeade2c81f9d7bcfe0c04a0b9c75012217af90f Gerrit-Change-Number: 40964 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 28 Aug 2025 11:48:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 weeks, 3 days

1
0
0 0

[XS] Change in osmo-ttcn3-hacks[master]: testenv: fix TESTENV_INSTALL_DIR for --binary-repo

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40967?usp=email ) Change subject: testenv: fix TESTENV_INSTALL_DIR for --binary-repo ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40967?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1e1ca65fd6a7d77c751dd7138015ff474f8ae576 Gerrit-Change-Number: 40967 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 28 Aug 2025 11:47:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 weeks, 3 days

1
0
0 0

[M] Change in osmo-iuh[master]: ranap: Constify multiple ptr params

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/40957?usp=email ) Change subject: ranap: Constify multiple ptr params ...................................................................... ranap: Constify multiple ptr params Change-Id: I667dc2ef377c1ceb5b11315458f00b282c143c81 --- M include/osmocom/ranap/ranap_common_cn.h M include/osmocom/ranap/ranap_common_ran.h M include/osmocom/ranap/ranap_msg_factory.h M src/ranap_common_cn.c M src/ranap_common_ran.c M src/ranap_msg_factory.c 6 files changed, 28 insertions(+), 28 deletions(-) Approvals: lynxis lazus: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/ranap/ranap_common_cn.h b/include/osmocom/ranap/ranap_common_cn.h index 5f82378..89f82a9 100644 --- a/include/osmocom/ranap/ranap_common_cn.h +++ b/include/osmocom/ranap/ranap_common_cn.h @@ -9,20 +9,20 @@ void ranap_cn_rx_cl_free(ranap_message *message); /* decode a connection-less RANAP message */ -int ranap_cn_rx_cl_decode2(ranap_message *message, uint8_t *data, size_t len); -int ranap_cn_rx_cl_decode(void *unused, ranap_message *message, uint8_t *data, size_t len) +int ranap_cn_rx_cl_decode2(ranap_message *message, const uint8_t *data, size_t len); +int ranap_cn_rx_cl_decode(void *unused, ranap_message *message, const uint8_t *data, size_t len) OSMO_DEPRECATED("Use ranap_cn_rx_cl_decode2() instead, the first arg is not used"); /* receive a connection-less RANAP message */ -int ranap_cn_rx_cl(ranap_handle_cb cb, void *priv, uint8_t *data, size_t len); +int ranap_cn_rx_cl(ranap_handle_cb cb, void *priv, const uint8_t *data, size_t len); /* free a decoded connection-oriented RANAP message */ void ranap_cn_rx_co_free(ranap_message *message); /* decode a connection-oriented RANAP message */ -int ranap_cn_rx_co_decode2(ranap_message *message, uint8_t *data, size_t len); -int ranap_cn_rx_co_decode(void *unused, ranap_message *message, uint8_t *data, size_t len) +int ranap_cn_rx_co_decode2(ranap_message *message, const uint8_t *data, size_t len); +int ranap_cn_rx_co_decode(void *unused, ranap_message *message, const uint8_t *data, size_t len) OSMO_DEPRECATED("Use ranap_cn_rx_co_decode2() instead, the first arg is not used"); /* receive a connection-oriented RANAP message */ -int ranap_cn_rx_co(ranap_handle_cb cb, void *priv, uint8_t *data, size_t len); +int ranap_cn_rx_co(ranap_handle_cb cb, void *priv, const uint8_t *data, size_t len); diff --git a/include/osmocom/ranap/ranap_common_ran.h b/include/osmocom/ranap/ranap_common_ran.h index d632c46..785b3bb 100644 --- a/include/osmocom/ranap/ranap_common_ran.h +++ b/include/osmocom/ranap/ranap_common_ran.h @@ -9,9 +9,9 @@ void ranap_ran_rx_co_free(ranap_message *message); /* decode a connection-oriented RANAP message */ -int ranap_ran_rx_co_decode2(ranap_message *message, uint8_t *data, size_t len); -int ranap_ran_rx_co_decode(void *unused, ranap_message *message, uint8_t *data, size_t len) +int ranap_ran_rx_co_decode2(ranap_message *message, const uint8_t *data, size_t len); +int ranap_ran_rx_co_decode(void *unused, ranap_message *message, const uint8_t *data, size_t len) OSMO_DEPRECATED("Use ranap_ran_rx_co_decode2() instead, the first arg is not used"); /* receive a connection-oriented RANAP message */ -int ranap_ran_rx_co(ranap_handle_cb cb, void *priv, uint8_t *data, size_t len); +int ranap_ran_rx_co(ranap_handle_cb cb, void *priv, const uint8_t *data, size_t len); diff --git a/include/osmocom/ranap/ranap_msg_factory.h b/include/osmocom/ranap/ranap_msg_factory.h index 318e511..0a4bdf2 100644 --- a/include/osmocom/ranap/ranap_msg_factory.h +++ b/include/osmocom/ranap/ranap_msg_factory.h @@ -49,17 +49,17 @@ const RANAP_Cause_t *cause); struct msgb *ranap_new_msg_reset2(RANAP_CN_DomainIndicator_t domain, const RANAP_Cause_t *cause, - RANAP_GlobalRNC_ID_t *rnc_id); + const RANAP_GlobalRNC_ID_t *rnc_id); /*! \brief generate RANAP RESET ACK message */ struct msgb *ranap_new_msg_reset_ack(RANAP_CN_DomainIndicator_t domain, - RANAP_GlobalRNC_ID_t *rnc_id); + const RANAP_GlobalRNC_ID_t *rnc_id); /*! \brief generate RANAP INITIAL UE message */ struct msgb *ranap_new_msg_initial_ue(uint32_t conn_id, int is_ps, - RANAP_GlobalRNC_ID_t *rnc_id, - uint8_t *nas_pdu, unsigned int nas_len); + const RANAP_GlobalRNC_ID_t *rnc_id, + const uint8_t *nas_pdu, unsigned int nas_len); /*! \brief generate RANAP IU RELEASE REQUEST message */ struct msgb *ranap_new_msg_iu_rel_req(const RANAP_Cause_t *cause); @@ -72,4 +72,4 @@ const RANAP_Cause_t *cause, const uint32_t *conn_id_list, unsigned int conn_id_list_len, - RANAP_GlobalRNC_ID_t *rnc_id); + const RANAP_GlobalRNC_ID_t *rnc_id); diff --git a/src/ranap_common_cn.c b/src/ranap_common_cn.c index 8d0cc0c..a16d127 100644 --- a/src/ranap_common_cn.c +++ b/src/ranap_common_cn.c @@ -376,7 +376,7 @@ } /* decode a connection-oriented RANAP message */ -int ranap_cn_rx_co_decode2(ranap_message *message, uint8_t *data, size_t len) +int ranap_cn_rx_co_decode2(ranap_message *message, const uint8_t *data, size_t len) { RANAP_RANAP_PDU_t *pdu = NULL; asn_dec_rval_t dec_ret; @@ -401,14 +401,14 @@ return rc; } -int ranap_cn_rx_co_decode(void *unused, ranap_message *message, uint8_t *data, size_t len) +int ranap_cn_rx_co_decode(void *unused, ranap_message *message, const uint8_t *data, size_t len) { return ranap_cn_rx_co_decode2(message, data, len); } /* receive a connection-oriented RANAP message and call * cn_ranap_handle_co() with the resulting ranap_message struct */ -int ranap_cn_rx_co(ranap_handle_cb cb, void *priv, uint8_t *data, size_t len) +int ranap_cn_rx_co(ranap_handle_cb cb, void *priv, const uint8_t *data, size_t len) { ranap_message message; int rc; @@ -624,7 +624,7 @@ } /* decode a connection-less RANAP message */ -int ranap_cn_rx_cl_decode2(ranap_message *message, uint8_t *data, size_t len) +int ranap_cn_rx_cl_decode2(ranap_message *message, const uint8_t *data, size_t len) { RANAP_RANAP_PDU_t *pdu = NULL; asn_dec_rval_t dec_ret; @@ -649,14 +649,14 @@ return rc; } -int ranap_cn_rx_cl_decode(void *unused, ranap_message *message, uint8_t *data, size_t len) +int ranap_cn_rx_cl_decode(void *unused, ranap_message *message, const uint8_t *data, size_t len) { return ranap_cn_rx_cl_decode2(message, data, len); } /* receive a connection-less RANAP message and call * cn_ranap_handle_co() with the resulting ranap_message struct */ -int ranap_cn_rx_cl(ranap_handle_cb cb, void *priv, uint8_t *data, size_t len) +int ranap_cn_rx_cl(ranap_handle_cb cb, void *priv, const uint8_t *data, size_t len) { ranap_message message; int rc; diff --git a/src/ranap_common_ran.c b/src/ranap_common_ran.c index 4028611..33da6b7 100644 --- a/src/ranap_common_ran.c +++ b/src/ranap_common_ran.c @@ -289,7 +289,7 @@ } /* decode a connection-oriented RANAP message */ -int ranap_ran_rx_co_decode2(ranap_message *message, uint8_t *data, size_t len) +int ranap_ran_rx_co_decode2(ranap_message *message, const uint8_t *data, size_t len) { RANAP_RANAP_PDU_t *pdu = NULL; asn_dec_rval_t dec_ret; @@ -314,14 +314,14 @@ return rc; } -int ranap_ran_rx_co_decode(void *unused, ranap_message *message, uint8_t *data, size_t len) +int ranap_ran_rx_co_decode(void *unused, ranap_message *message, const uint8_t *data, size_t len) { return ranap_ran_rx_co_decode2(message, data, len); } /* receive a connection-oriented RANAP message and call * cn_ranap_handle_co() with the resulting ranap_message struct */ -int ranap_ran_rx_co(ranap_handle_cb cb, void *priv, uint8_t *data, size_t len) +int ranap_ran_rx_co(ranap_handle_cb cb, void *priv, const uint8_t *data, size_t len) { ranap_message message; int rc; diff --git a/src/ranap_msg_factory.c b/src/ranap_msg_factory.c index ffe2355..8f6a99a 100644 --- a/src/ranap_msg_factory.c +++ b/src/ranap_msg_factory.c @@ -49,7 +49,7 @@ /*! generate RANAP RESET message. Like ranap_new_msg_reset(), but allows passing a Global-RNC-ID. */ struct msgb *ranap_new_msg_reset2(RANAP_CN_DomainIndicator_t domain, const RANAP_Cause_t *cause, - RANAP_GlobalRNC_ID_t *rnc_id) + const RANAP_GlobalRNC_ID_t *rnc_id) { RANAP_ResetIEs_t ies; RANAP_Reset_t out; @@ -89,7 +89,7 @@ /*! \brief generate RANAP RESET ACK message */ struct msgb *ranap_new_msg_reset_ack(RANAP_CN_DomainIndicator_t domain, - RANAP_GlobalRNC_ID_t *rnc_id) + const RANAP_GlobalRNC_ID_t *rnc_id) { RANAP_ResetAcknowledgeIEs_t ies; RANAP_ResetAcknowledge_t out; @@ -131,8 +131,8 @@ /*! \brief generate RANAP INITIAL UE message */ struct msgb *ranap_new_msg_initial_ue(uint32_t conn_id, int is_ps, - RANAP_GlobalRNC_ID_t *rnc_id, - uint8_t *nas_pdu, unsigned int nas_len) + const RANAP_GlobalRNC_ID_t *rnc_id, + const uint8_t *nas_pdu, unsigned int nas_len) { RANAP_InitialUE_MessageIEs_t ies; RANAP_InitialUE_Message_t out; @@ -971,7 +971,7 @@ const RANAP_Cause_t *cause, const uint32_t *conn_id_list, unsigned int conn_id_list_len, - RANAP_GlobalRNC_ID_t *rnc_id) + const RANAP_GlobalRNC_ID_t *rnc_id) { RANAP_ResetResourceItemIEs_t item_ies; RANAP_ResetResourceIEs_t ies; -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/40957?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I667dc2ef377c1ceb5b11315458f00b282c143c81 Gerrit-Change-Number: 40957 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

3 weeks, 3 days

1
0
0 0

[S] Change in osmo-ci[master]: OBS: --version-append: never override version

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40965?usp=email ) Change subject: OBS: --version-append: never override version ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ci/+/40965/comment/08e14bc7_643da00b?usp=… : PS1, Line 25: While IMHO it is a bad idea to just amend the commit of the last release > Wait, did somebody amend a commit in their local repository and force-pushed? Or what happened? yes, but on their own branch, not master. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40965?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I589ceb08b9e1ff2ccdd54e94216b25e1e40f22fe Gerrit-Change-Number: 40965 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 28 Aug 2025 11:39:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

3 weeks, 3 days

1
0
0 0

[XS] Change in osmo-gsm-manuals[master]: fix various typos (thanks Denis)

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/40966?usp=email ) Change subject: fix various typos (thanks Denis) ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/40966?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: Ia0dc13c92430aa441d7c98cd301db13a28da99ca Gerrit-Change-Number: 40966 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Thu, 28 Aug 2025 11:39:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 weeks, 3 days

1
0
0 0

[XS] Change in pysim[master]: docs: fix authors line exceeding the page

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/pysim/+/40953?usp=email ) Change subject: docs: fix authors line exceeding the page ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40953?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iacbba6c2f74bf2b9f96057e71bde017a11f703a8 Gerrit-Change-Number: 40953 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 28 Aug 2025 11:38:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

3 weeks, 3 days

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2025