Attention is currently required from: osmith.
fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/40965?usp=email )
Change subject: OBS: --version-append: never override version
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-ci/+/40965/comment/c1b8a43e_c45004a0?usp=… :
PS1, Line 25: While IMHO it is a bad idea to just amend the commit of the last release
Wait, did somebody amend a commit in their local repository and force-pushed? Or what happened?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40965?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I589ceb08b9e1ff2ccdd54e94216b25e1e40f22fe
Gerrit-Change-Number: 40965
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 28 Aug 2025 11:37:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: pespin.
lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40963?usp=email )
Change subject: Apply uniform prefix to remaining APIs in gprs_ranap.h
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40963?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I4f253f35013085bdebf80e94ab0d2f771e40dba6
Gerrit-Change-Number: 40963
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 28 Aug 2025 10:02:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40962?usp=email )
Change subject: Split Iu RANAP conn release over different layers
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40962?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I4acdbc857df36b7409c8210d364758192dfdb0bb
Gerrit-Change-Number: 40962
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 28 Aug 2025 10:02:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria, pespin.
lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40961?usp=email )
Change subject: Split Iu RANAP RAB PS act/deact over different layers
......................................................................
Patch Set 4:
(1 comment)
File src/sgsn/gprs_gmm.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/40961/comment/48f1dbbd_50e45702?us… :
PS4, Line 1016: if (ctx->ran_type == MM_CTX_T_UTRAN_Iu &&
Please don't check here for UTRAN_Iu.
The check for Iu would be much better if you do it on line 1012,
because Service Request is only valid for Iu and I think it is already checked earlier.
*BUT* The real reason why I don't want to have here, because gmm_auth() will be removed anyways by the vlr patch series and I want to keep the changes of your commit minimal.
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40961?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I98788468b7e50619cfd99b3aef2311bb601fb6be
Gerrit-Change-Number: 40961
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 28 Aug 2025 09:56:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No