Attention is currently required from: osmith, pespin.
lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40956?usp=email )
Change subject: Split most of iu_client.{c,h} into sccp.{c,h} and iu_rnc.{c,h}
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40956?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I4c792ae665720460b5a954b5c7cbfe5acbc37473
Gerrit-Change-Number: 40956
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 28 Aug 2025 09:44:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
lynxis lazus has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/40954?usp=email )
Change subject: Move gsm0408_gprs_rcvmsg_iu to gprs_gmm.{c,h}
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
The current ttcn3 tests cases fail because of a wrong Service Accept.
--
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/40954?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I09c19689fd7016b76ebeee821b551427965b7cf1
Gerrit-Change-Number: 40954
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 28 Aug 2025 09:39:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: laforge.
osmith has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/40966?usp=email )
Change subject: fix various typos (thanks Denis)
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/40966?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Change-Id: Ia0dc13c92430aa441d7c98cd301db13a28da99ca
Gerrit-Change-Number: 40966
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Thu, 28 Aug 2025 09:38:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40967?usp=email )
Change subject: testenv: fix TESTENV_INSTALL_DIR for --binary-repo
......................................................................
testenv: fix TESTENV_INSTALL_DIR for --binary-repo
When --binary-repo is set, "/" must be used as install directory,
without any suffix for the distribution.
Fix for:
realpath: /-debian-trixie/usr/lib/osmo-s1gw: No such file or directory
Fixes: 2152d512 ("testenv: use separate cache dirs per distro")
Change-Id: I1e1ca65fd6a7d77c751dd7138015ff474f8ae576
---
M _testenv/testenv/cmd.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/67/40967/1
diff --git a/_testenv/testenv/cmd.py b/_testenv/testenv/cmd.py
index 6f50677..2cc590a 100644
--- a/_testenv/testenv/cmd.py
+++ b/_testenv/testenv/cmd.py
@@ -33,7 +33,7 @@
install_dir = "/"
else:
install_dir = os.path.join(testenv.args.cache, "podman/install")
- install_dir += distro_cache_suffix()
+ install_dir += distro_cache_suffix()
else:
install_dir = os.path.join(testenv.args.cache, "host/install")
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/40967?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I1e1ca65fd6a7d77c751dd7138015ff474f8ae576
Gerrit-Change-Number: 40967
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Attention is currently required from: dexter.
osmith has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/40936?usp=email )
Change subject: contrib: add a tool to parse the SIMA response from an eUICC
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/40936?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ida4c3c5446653b283a3869c0c387f328ae51e55e
Gerrit-Change-Number: 40936
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 28 Aug 2025 07:59:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: dexter, osmith.
Hello Jenkins Builder, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/pysim/+/40936?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+1 by osmith, Verified+1 by Jenkins Builder
Change subject: contrib: add a tool to parse the SIMA response from an eUICC
......................................................................
contrib: add a tool to parse the SIMA response from an eUICC
When an eUICC performs a profile installation it returns a (concatenated)
series of ASN.1 encoded strings as "simaResponse". In case the profile
installation fails for some reason the simaResponse contains diagnostic
information to diagnose why the profile installation failed.
Unfortunately there are currently no practical tools available to decode
and display the information in the simaResponse. Let's add a tool for that.
Related SYS#7617
Change-Id: Ida4c3c5446653b283a3869c0c387f328ae51e55e
---
A contrib/analyze_simaResponse.py
1 file changed, 112 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/36/40936/3
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/40936?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ida4c3c5446653b283a3869c0c387f328ae51e55e
Gerrit-Change-Number: 40936
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/40965?usp=email )
Change subject: OBS: --version-append: never override version
......................................................................
OBS: --version-append: never override version
We have some branches set up that when pushed to, directly result in
building OBS packages. We append a string to the package version there,
such as ~rhizomatica.testing. The expectation is that all packages built
from that branch have this string in the version.
Recently an edge case was found: when amending the commit of the last
tagged release, e.g. osmo-sgsn 1.12.0, then the generated version is
based on the previous git tag (as the last git tag's commit is not part
of the current branch anymore) while having the newer version in
debian/changelog. This then results in the newer version being used,
without appending the version string:
osmo-sgsn: WARNING: version from changelog (1.12.0) is higher than
version based on git tag (1.11.1.20-e000e~rhizomatica.production),
using version from changelog (git tag not pushed yet?)
While IMHO it is a bad idea to just amend the commit of the last release
instead of making a separate commit, this results in unexpected behavior
so adjust the script to not override the version if --version-append is
used.
Related: OS#5981
Change-Id: I589ceb08b9e1ff2ccdd54e94216b25e1e40f22fe
---
M scripts/obs/lib/debian.py
1 file changed, 6 insertions(+), 5 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/65/40965/1
diff --git a/scripts/obs/lib/debian.py b/scripts/obs/lib/debian.py
index 9193d66..0438dd8 100644
--- a/scripts/obs/lib/debian.py
+++ b/scripts/obs/lib/debian.py
@@ -112,12 +112,13 @@
try:
if packaging.version.parse(version_changelog.split("-")[0]) > packaging.version.parse(version.split("-")[0]):
print(
- f"{project}: WARNING: version from changelog"
- f" ({version_changelog}) is higher than version based on git tag"
- f" ({version}), using version from changelog (git tag not pushed"
- " yet?)"
+ f"{project}: WARNING: version from changelog ({version_changelog}) is higher than version based on git tag ({version})"
)
- return
+ if lib.args.version_append:
+ print(f"{project}: WARNING: assuming commit from last git tag was amended, ignoring...")
+ else:
+ print(f"{project}: WARNING: using version from changelog (git tag not pushed yet?)")
+ return
except packaging.version.InvalidVersion:
# packaging.version.parse can parse the version numbers used in Osmocom
# projects (where we need the above check), but not e.g. some versions
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/40965?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I589ceb08b9e1ff2ccdd54e94216b25e1e40f22fe
Gerrit-Change-Number: 40965
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>