March 2025 - gerrit-log - lists.osmocom.org

[L] Change in osmo-ttcn3-hacks[master]: s1gw: ConnHdlr: allow passing {MME,ENB}-UE-S1AP-ID
by fixeria 31 Mar '25

31 Mar '25

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39881?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: s1gw: ConnHdlr: allow passing {MME,ENB}-UE-S1AP-ID ...................................................................... s1gw: ConnHdlr: allow passing {MME,ENB}-UE-S1AP-ID This is needed for follow-up UEMux testcases, in which we spawn multiple virtual UEs with unique {MME,ENB}-UE-S1AP-IDs. Change-Id: Ife37c77cff348cdfbde191dbad6da816e68ca941 Related: SYS#7288 --- M s1gw/S1GW_ConnHdlr.ttcn M s1gw/S1GW_Tests.ttcn 2 files changed, 177 insertions(+), 96 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/81/39881/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39881?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ife37c77cff348cdfbde191dbad6da816e68ca941 Gerrit-Change-Number: 39881 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

[M] Change in osmo-ttcn3-hacks[master]: s1gw: add UEMux TCs for INITIAL CTX SETUP and UE CTX RELEASE
by fixeria 31 Mar '25

31 Mar '25

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39885?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: s1gw: add UEMux TCs for INITIAL CTX SETUP and UE CTX RELEASE ...................................................................... s1gw: add UEMux TCs for INITIAL CTX SETUP and UE CTX RELEASE Change-Id: I811904e50dd6f0a05b0bb6babebe5b4690e2d3ec Related: SYS#7288 --- M s1gw/S1GW_Tests.ttcn M s1gw/S1GW_UEMux.ttcn M s1gw/expected-results.xml 3 files changed, 127 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/85/39885/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39885?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I811904e50dd6f0a05b0bb6babebe5b4690e2d3ec Gerrit-Change-Number: 39885 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

[L] Change in osmo-ttcn3-hacks[master]: s1gw: ConnHdlr: allow passing {MME,ENB}-UE-S1AP-ID
by fixeria 31 Mar '25

31 Mar '25

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39881?usp=email ) Change subject: s1gw: ConnHdlr: allow passing {MME,ENB}-UE-S1AP-ID ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39881?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ife37c77cff348cdfbde191dbad6da816e68ca941 Gerrit-Change-Number: 39881 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Mon, 31 Mar 2025 19:56:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[M] Change in osmo-ttcn3-hacks[master]: s1gw: add UEMux TCs for E-RAB SETUP and RELEASE
by fixeria 31 Mar '25

31 Mar '25

Attention is currently required from: fixeria, laforge, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39882?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: s1gw: add UEMux TCs for E-RAB SETUP and RELEASE ...................................................................... s1gw: add UEMux TCs for E-RAB SETUP and RELEASE Change-Id: Ia4583f82a768ca3d185aad596ce8ec9bbd37ad32 Related: SYS#7288 --- M s1gw/S1GW_Tests.ttcn M s1gw/S1GW_UEMux.ttcn M s1gw/expected-results.xml 3 files changed, 132 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/82/39882/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39882?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia4583f82a768ca3d185aad596ce8ec9bbd37ad32 Gerrit-Change-Number: 39882 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: s1gw: add UEMux TCs for INITIAL CTX SETUP and UE CTX RELEASE
by fixeria 31 Mar '25

31 Mar '25

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39885?usp=email ) Change subject: s1gw: add UEMux TCs for INITIAL CTX SETUP and UE CTX RELEASE ...................................................................... s1gw: add UEMux TCs for INITIAL CTX SETUP and UE CTX RELEASE Change-Id: I811904e50dd6f0a05b0bb6babebe5b4690e2d3ec Related: SYS#7288 --- M s1gw/S1GW_Tests.ttcn M s1gw/S1GW_UEMux.ttcn M s1gw/expected-results.xml M start-testsuite.sh M ttcn3-tcpdump-start.sh M ttcn3-tcpdump-stop.sh 6 files changed, 134 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/85/39885/1 diff --git a/s1gw/S1GW_Tests.ttcn b/s1gw/S1GW_Tests.ttcn index be3a052..fef8279 100644 --- a/s1gw/S1GW_Tests.ttcn +++ b/s1gw/S1GW_Tests.ttcn @@ -1,6 +1,6 @@ /* OsmoS1GW (S1AP Gateway) test suite in TTCN-3 * - * (C) 2024 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> + * (C) 2024-2025 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de> * Author: Vadim Yanitskiy <vyanitskiy(a)sysmocom.de> * * All rights reserved. @@ -793,6 +793,82 @@ f_UEMuxUEList_all_done(vc_ues); } +function f_TC_uemux_initial_ctx_setup_release(in ERabList erabs, + boolean release_req := false, + boolean release_cmd := false) +runs on UEMuxUE { + f_UEMuxUE_subscribe_for_mme_ue_id(g_mme_ue_id); + f_UEMuxUE_subscribe_for_enb_ue_id(g_enb_ue_id); + + f_rnd_sleep(0.5); + f_UEMux_initial_ctx_setup(erabs); + + if (release_req) { + f_rnd_sleep(0.5); + f_UEMux_ue_ctx_release_req(erabs); + } + if (release_cmd) { + f_rnd_sleep(0.5); + f_UEMux_ue_ctx_release_cmd(erabs); + } + + f_UEMuxUE_unsubscribe(); +} +testcase TC_uemux_initial_ctx_setup() runs on test_CT { + var ConnHdlrPars pars := valueof(t_ConnHdlrPars(num_erabs := mp_multi_ue_num)); + var UEMuxUEList vc_ues; + var UEMux_CT vc_uemux; + + f_init(); + + vc_uemux := f_UEMux_spawn(refers(f_TC_UEMux_main), pars); + + for (var integer i := 0; i < mp_multi_ue_num; i := i + 1) { + var ERabList erabs := { pars.erabs[i] }; + + vc_ues[i] := f_UEMuxUE_create(vc_uemux, pars, i, i); + vc_ues[i].start(f_TC_uemux_initial_ctx_setup_release(erabs)); + } + + f_UEMuxUEList_all_done(vc_ues); +} +testcase TC_uemux_ue_ctx_release_req() runs on test_CT { + var ConnHdlrPars pars := valueof(t_ConnHdlrPars(num_erabs := mp_multi_ue_num)); + var UEMuxUEList vc_ues; + var UEMux_CT vc_uemux; + + f_init(); + + vc_uemux := f_UEMux_spawn(refers(f_TC_UEMux_main), pars); + + for (var integer i := 0; i < mp_multi_ue_num; i := i + 1) { + var ERabList erabs := { pars.erabs[i] }; + + vc_ues[i] := f_UEMuxUE_create(vc_uemux, pars, i, i); + vc_ues[i].start(f_TC_uemux_initial_ctx_setup_release(erabs, release_req := true)); + } + + f_UEMuxUEList_all_done(vc_ues); +} +testcase TC_uemux_ue_ctx_release_cmd() runs on test_CT { + var ConnHdlrPars pars := valueof(t_ConnHdlrPars(num_erabs := mp_multi_ue_num)); + var UEMuxUEList vc_ues; + var UEMux_CT vc_uemux; + + f_init(); + + vc_uemux := f_UEMux_spawn(refers(f_TC_UEMux_main), pars); + + for (var integer i := 0; i < mp_multi_ue_num; i := i + 1) { + var ERabList erabs := { pars.erabs[i] }; + + vc_ues[i] := f_UEMuxUE_create(vc_uemux, pars, i, i); + vc_ues[i].start(f_TC_uemux_initial_ctx_setup_release(erabs, release_cmd := true)); + } + + f_UEMuxUEList_all_done(vc_ues); +} + function f_TC_pfcp_heartbeat(charstring id) runs on ConnHdlr { var integer rts := f_PFCPEM_get_recovery_timestamp(); var PDU_PFCP pfcp_pdu; @@ -838,6 +914,9 @@ execute( TC_uemux_e_rab_setup() ); execute( TC_uemux_e_rab_release_cmd() ); execute( TC_uemux_e_rab_release_ind() ); + execute( TC_uemux_initial_ctx_setup() ); + execute( TC_uemux_ue_ctx_release_req() ); + execute( TC_uemux_ue_ctx_release_cmd() ); execute( TC_pfcp_heartbeat() ); } diff --git a/s1gw/S1GW_UEMux.ttcn b/s1gw/S1GW_UEMux.ttcn index 68be645..baecaff 100644 --- a/s1gw/S1GW_UEMux.ttcn +++ b/s1gw/S1GW_UEMux.ttcn @@ -256,6 +256,9 @@ signature UEMux_erab_setup(inout ERabList erabs); signature UEMux_erab_release_cmd(inout ERabList erabs); signature UEMux_erab_release_ind(inout ERabList erabs); +signature UEMux_initial_ctx_setup(inout ERabList erabs); +signature UEMux_ue_ctx_release_req(inout ERabList erabs); +signature UEMux_ue_ctx_release_cmd(inout ERabList erabs); type port UEMUX_PROC_PT procedure { inout UEMux_subscribe_for_mme_ue_id; @@ -265,6 +268,9 @@ inout UEMux_erab_setup; inout UEMux_erab_release_cmd; inout UEMux_erab_release_ind; + inout UEMux_initial_ctx_setup; + inout UEMux_ue_ctx_release_req; + inout UEMux_ue_ctx_release_cmd; } with { extension "internal" }; /*********************************************************************************** @@ -313,6 +319,27 @@ } } +function f_UEMux_initial_ctx_setup(inout ERabList erabs) +runs on UEMuxUE { + UEMUX_PROC.call(UEMux_initial_ctx_setup:{erabs}) { + [] UEMUX_PROC.getreply(UEMux_initial_ctx_setup:{?}) -> param(erabs); + } +} + +function f_UEMux_ue_ctx_release_req(inout ERabList erabs) +runs on UEMuxUE { + UEMUX_PROC.call(UEMux_ue_ctx_release_req:{erabs}) { + [] UEMUX_PROC.getreply(UEMux_ue_ctx_release_req:{?}) -> param(erabs); + } +} + +function f_UEMux_ue_ctx_release_cmd(inout ERabList erabs) +runs on UEMuxUE { + UEMUX_PROC.call(UEMux_ue_ctx_release_cmd:{erabs}) { + [] UEMUX_PROC.getreply(UEMux_ue_ctx_release_cmd:{?}) -> param(erabs); + } +} + function f_UEMuxUE_tx_s1ap_from_mme(template (value) S1AP_PDU pdu) runs on UEMuxUE { var S1AP_dPDU dpdu := { S1AP_PDU_DIR_FROM_MME, valueof(pdu) }; @@ -422,6 +449,23 @@ f_ConnHdlr_erab_release_ind(erabs, g_uemux_list[idx].mme_ue_id, g_uemux_list[idx].enb_ue_id); UEMUX_PROC.reply(UEMux_erab_release_ind:{erabs}) to vc_conn; } + [] UEMUX_PROC.getcall(UEMux_initial_ctx_setup:{?}) -> param(erabs) sender vc_conn { + var integer idx := f_UEMux_find_ue_by_vc_conn(vc_conn); + f_ConnHdlr_initial_ctx_setup_req(erabs, g_uemux_list[idx].mme_ue_id, g_uemux_list[idx].enb_ue_id); + f_ConnHdlr_initial_ctx_setup_rsp(erabs, g_uemux_list[idx].mme_ue_id, g_uemux_list[idx].enb_ue_id); + UEMUX_PROC.reply(UEMux_initial_ctx_setup:{erabs}) to vc_conn; + } + [] UEMUX_PROC.getcall(UEMux_ue_ctx_release_req:{?}) -> param(erabs) sender vc_conn { + var integer idx := f_UEMux_find_ue_by_vc_conn(vc_conn); + f_ConnHdlr_ue_ctx_release_req(erabs, g_uemux_list[idx].mme_ue_id, g_uemux_list[idx].enb_ue_id); + UEMUX_PROC.reply(UEMux_ue_ctx_release_req:{erabs}) to vc_conn; + } + [] UEMUX_PROC.getcall(UEMux_ue_ctx_release_cmd:{?}) -> param(erabs) sender vc_conn { + var integer idx := f_UEMux_find_ue_by_vc_conn(vc_conn); + f_ConnHdlr_ue_ctx_release_cmd(erabs, g_uemux_list[idx].mme_ue_id, g_uemux_list[idx].enb_ue_id); + f_ConnHdlr_ue_ctx_release_compl(g_uemux_list[idx].mme_ue_id, g_uemux_list[idx].enb_ue_id); + UEMUX_PROC.reply(UEMux_ue_ctx_release_cmd:{erabs}) to vc_conn; + } } } } diff --git a/s1gw/expected-results.xml b/s1gw/expected-results.xml index 27698e9..a44108e 100644 --- a/s1gw/expected-results.xml +++ b/s1gw/expected-results.xml @@ -1,5 +1,5 @@ <?xml version="1.0"?> -<testsuite name='S1GW_Tests' tests='28' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> +<testsuite name='S1GW_Tests' tests='31' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> <testcase classname='S1GW_Tests' name='TC_setup' time='MASKED'/> <testcase classname='S1GW_Tests' name='TC_setup_multi' time='MASKED'/> <testcase classname='S1GW_Tests' name='TC_conn_term_by_mme' time='MASKED'/> @@ -27,5 +27,8 @@ <testcase classname='S1GW_Tests' name='TC_uemux_e_rab_setup' time='MASKED'/> <testcase classname='S1GW_Tests' name='TC_uemux_e_rab_release_cmd' time='MASKED'/> <testcase classname='S1GW_Tests' name='TC_uemux_e_rab_release_ind' time='MASKED'/> + <testcase classname='S1GW_Tests' name='TC_uemux_initial_ctx_setup' time='MASKED'/> + <testcase classname='S1GW_Tests' name='TC_uemux_ue_ctx_release_req' time='MASKED'/> + <testcase classname='S1GW_Tests' name='TC_uemux_ue_ctx_release_cmd' time='MASKED'/> <testcase classname='S1GW_Tests' name='TC_pfcp_heartbeat' time='MASKED'/> </testsuite> diff --git a/start-testsuite.sh b/start-testsuite.sh index 4b88501..6ffacd2 100755 --- a/start-testsuite.sh +++ b/start-testsuite.sh @@ -50,8 +50,8 @@ ulimit -n 100000 # below is for the debian packages -TTCN3_BIN_DIR="${TTCN3_BIN_DIR:-/usr/bin}" -TITAN_LIBRARY_PATH="${TITAN_LIBRARY_PATH:-/usr/lib/titan:/usr/ttcn3/lib}" +TTCN3_BIN_DIR="${TTCN3_DIR}/bin" +TITAN_LIBRARY_PATH="${TTCN3_DIR}/lib" LD_LIBRARY_PATH="$LD_LIBRARY_PATH:$SUITE_DIR:$TITAN_LIBRARY_PATH" "$TTCN3_BIN_DIR/ttcn3_start" $SUITE $CFG $TEST expected="$SUITE_DIR/expected-results.xml" diff --git a/ttcn3-tcpdump-start.sh b/ttcn3-tcpdump-start.sh index 9575a68..bb253b9 100755 --- a/ttcn3-tcpdump-start.sh +++ b/ttcn3-tcpdump-start.sh @@ -36,6 +36,8 @@ TTCN3_PCAP_PATH=/tmp fi +exit + kill_rm_pidfile $PIDFILE_NETCAT kill_rm_pidfile $PIDFILE_PCAP diff --git a/ttcn3-tcpdump-stop.sh b/ttcn3-tcpdump-stop.sh index def10d8..ac04f53 100755 --- a/ttcn3-tcpdump-stop.sh +++ b/ttcn3-tcpdump-stop.sh @@ -54,6 +54,8 @@ fi fi +exit + # Wait for up to 2 seconds if we keep receiving traffinc from packet dumper, # otherwise we might lose last packets from test. i=0 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39885?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I811904e50dd6f0a05b0bb6babebe5b4690e2d3ec Gerrit-Change-Number: 39885 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in ...osmo_dia2gsup[master]: gsup_client: disable gen_server event tracing
by pespin 31 Mar '25

31 Mar '25

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/39884?usp=email ) Change subject: gsup_client: disable gen_server event tracing ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/39884?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I9d0ca595fd6aab2e0e16944e31dde02f5783c772 Gerrit-Change-Number: 39884 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 31 Mar 2025 17:14:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in ...osmo_dia2gsup[master]: gsup_client: disable gen_server event tracing
by fixeria 31 Mar '25

31 Mar '25

Attention is currently required from: fixeria, pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/39884?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by pespin Change subject: gsup_client: disable gen_server event tracing ...................................................................... gsup_client: disable gen_server event tracing Even with the logging level set to info, we're still seeing this: *DBG* gsup_client got call ... *DBG* gsup_client sent ... Those are messages printed by the gen_server module itself, and as it turns out we explicitly enable printing them by passing {debug, [trace]} to gen_server:start_link/3. This kind of logging is way too verbose and not useful for a regular user, so let's disable event tracing. Change-Id: I9d0ca595fd6aab2e0e16944e31dde02f5783c772 Related: SYS#7415 --- M src/gsup_client.erl M src/osmo_dia2gsup_sup.erl 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/84/39884/2 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/39884?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I9d0ca595fd6aab2e0e16944e31dde02f5783c772 Gerrit-Change-Number: 39884 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in ...osmo_dia2gsup[master]: gsup_client: disable gen_server event tracing
by pespin 31 Mar '25

31 Mar '25

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/39884?usp=email ) Change subject: gsup_client: disable gen_server event tracing ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/39884?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I9d0ca595fd6aab2e0e16944e31dde02f5783c772 Gerrit-Change-Number: 39884 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 31 Mar 2025 16:48:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in ...osmo_dia2gsup[master]: gsup_client: disable gen_server event tracing
by fixeria 31 Mar '25

31 Mar '25

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/39884?usp=email ) Change subject: gsup_client: disable gen_server event tracing ...................................................................... gsup_client: disable gen_server event tracing Even with the logging level set to info, we're still seeing this: *DBG* gsup_client got call ... *DBG* gsup_client sent ... Those are messages printed by the gen_server module itself, and as it turns out we explicitly enable printing them by passing {debug, [trace]} to gen_server:start_link/2. This kind of logging is way too verbose and not useful for a regular user, so let's disable event tracing. Change-Id: I9d0ca595fd6aab2e0e16944e31dde02f5783c772 Related: SYS#7415 --- M src/gsup_client.erl M src/osmo_dia2gsup_sup.erl 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/erlang/osmo_dia2gsup refs/changes/84/39884/1 diff --git a/src/gsup_client.erl b/src/gsup_client.erl index 86a46d9..b4f7384 100644 --- a/src/gsup_client.erl +++ b/src/gsup_client.erl @@ -59,7 +59,7 @@ %% ------------------------------------------------------------------ start_link(ServerAddr, ServerPort, GsupName) -> - gen_server:start_link(?MODULE, [ServerAddr, ServerPort, GsupName], [{debug, [trace]}]). + gen_server:start_link(?MODULE, [ServerAddr, ServerPort, GsupName], []). %% ------------------------------------------------------------------ %% gen_server Function Definitions diff --git a/src/osmo_dia2gsup_sup.erl b/src/osmo_dia2gsup_sup.erl index 03c780d..dbb1ae6 100644 --- a/src/osmo_dia2gsup_sup.erl +++ b/src/osmo_dia2gsup_sup.erl @@ -12,7 +12,7 @@ % GSUP side HlrIp = application:get_env(osmo_dia2gsup, hlr_ip, "127.0.0.1"), HlrPort = application:get_env(osmo_dia2gsup, hlr_port, 4222), - Args = [{local, gsup_client}, gsup_client, [HlrIp, HlrPort, "HSS-00-00-00-00-00-00"], [{debug, [trace]}]], + Args = [{local, gsup_client}, gsup_client, [HlrIp, HlrPort, "HSS-00-00-00-00-00-00"], []], GsupChild = {gsup_client, {gen_server, start_link, Args}, permanent, 2000, worker, [gsup_client]}, % DIAMETER side DiaServer = {osmo_dia2gsup,{osmo_dia2gsup,start_link,[]}, -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo_dia2gsup/+/39884?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: erlang/osmo_dia2gsup Gerrit-Branch: master Gerrit-Change-Id: I9d0ca595fd6aab2e0e16944e31dde02f5783c772 Gerrit-Change-Number: 39884 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in osmo-mgw[master]: mgw: rtp-patch rfc5993hr: convert to each end's respective format
by falconia 31 Mar '25

31 Mar '25

Attention is currently required from: laforge, neels, pespin. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39869?usp=email ) Change subject: mgw: rtp-patch rfc5993hr: convert to each end's respective format ...................................................................... Patch Set 2: (6 comments) Patchset: PS2: > and also the BSC has to then be aware of the HR formats in use. This part would be the biggest difficulty in practice. How would the BSC know which BTS is configured for TS 101 318 vs which is configured for RFC 5993, when it is a vty option in OsmoBTS? File src/libosmo-mgcp/mgcp_network.c: https://gerrit.osmocom.org/c/osmo-mgw/+/39869/comment/43c79097_a22c5d4b?usp… : PS2, Line 691: * consider the full RTP chain of a single call: > > (my idea so far, can be in a future patch, is to not send any HR payload to a peer until we have r […] The comment by @laforge@osmocom.org is correct: I also initially thought about sending nothing to all to each peer until that peer sent its own first packet, but then I quickly realized that the result would be no traffic passing at all, ever. Referring to the ASCII art diagram in the detailed comment in my patch, if the policy proposed by @nhofmeyr@sysmocom.de were implemented, each of BSC-MGW-A and BSC-MGW-B would receive packets from BTS-A and BTS-B, but because neither BSC-associated MGW will be the first to send a packet to the CN, neither MSC-MGW-A nor MSC-MGW-B will ever see even one packet. https://gerrit.osmocom.org/c/osmo-mgw/+/39869/comment/15786ea3_af80d169?usp… : PS2, Line 698: will always be RFC 5993 > On AoIP, there is no discussion. It is always RFC5993 as that is what (likely, quoting from memory) 3GPP TS 48.103 mandates. Correct: TS 48.103 is the spec, and it unambiguously specifies RFC 5993 format for HR codec. https://gerrit.osmocom.org/c/osmo-mgw/+/39869/comment/d7bff7ec_09cde6bb?usp… : PS2, Line 715: static int rfc5993_hr_convert(struct msgb *msg, struct mgcp_conn_rtp *dst) > (kind of weird to swap the msgb argument position for no reason) It is an artifact of how I developed this code in stages. I can flip this argument order in the next patch iteration, no big deal. https://gerrit.osmocom.org/c/osmo-mgw/+/39869/comment/bc231742_388288f0?usp… : PS2, Line 1660: strcmp(conn_src->end.cset.codec->subtype_name, "GSM-HR-08") == 0 && conn_src->end.rfc5993_hr_convert) { > I'd say better split this line into 2. I originally had it split, but the overzealous linter forced me to join into this longer line! See the diff between patchset 1 and patchset 2, where patchset 1 was rejected (V-1) by the linter. https://gerrit.osmocom.org/c/osmo-mgw/+/39869/comment/72bff7db_64557059?usp… : PS2, Line 1661: int rc = examine_rtp_rx_gsmhr(msg, conn_src); > Is this called always on GSM-HR-08 or only once, until we successfully detected the HR format? ... […] It is called for every received packet. If we were to perform format detection only on the very first packet, what would happen if a BSC-level handover occurs between two BTS that use (or are configured to use) different HR formats? -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39869?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6b446ad83c540fb8b7e1aae24b78c27010212d64 Gerrit-Change-Number: 39869 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 31 Mar 2025 16:01:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0