March 2025 - gerrit-log - lists.osmocom.org

[M] Change in osmo-ttcn3-hacks[master]: stp: Introduce tests TC_dyn_(2)asp_as_rkm_permitted
by osmith 03 Mar '25

03 Mar '25

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39647?usp=email ) Change subject: stp: Introduce tests TC_dyn_(2)asp_as_rkm_permitted ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39647?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic3116cbe63832003876ae19b31491275aebb41a9 Gerrit-Change-Number: 39647 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Mar 2025 08:15:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: stp: NOTIFY expectancy fixes
by osmith 03 Mar '25

03 Mar '25

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39646?usp=email ) Change subject: stp: NOTIFY expectancy fixes ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File stp/STP_Tests_M3UA.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39646/comment/9a1c4e59_b8d2… : PS1, Line 798: f_M3UA_exp(0, tr_M3UA_NOTIFY(c_M3UA_ST_T_STATE_CHG, c_M3UA_ST_I_AS_ACTIVE, rctxB)); : f_M3UA_exp(0, tr_M3UA_DAVA({*}, rctxA)); : f_M3UA_exp(0, tr_M3UA_NOTIFY(c_M3UA_ST_T_STATE_CHG, c_M3UA_ST_I_AS_ACTIVE, rctxA)); : f_M3UA_exp(0, tr_M3UA_DAVA({*}, rctxB)); is the order in which rctxB and A are used intentional? rctxB NOTIFY rctxA DAVA rctxA NOTIFY rctxB DAVA -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39646?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3a56b4fcb8c119a31815f3175db2d7899fbfddd7 Gerrit-Change-Number: 39646 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Mar 2025 08:11:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: stp: Pass M3UA conn idx to f_M3UA_rkm_register()
by osmith 03 Mar '25

03 Mar '25

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39644?usp=email ) Change subject: stp: Pass M3UA conn idx to f_M3UA_rkm_register() ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39644?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9295a2c3518f82e8c82625fb573e414b1d634146 Gerrit-Change-Number: 39644 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Mar 2025 07:59:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: Use fork of titan.ProtocolModules.M3UA containing fix
by osmith 03 Mar '25

03 Mar '25

Attention is currently required from: daniel, fixeria, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39645?usp=email ) Change subject: Use fork of titan.ProtocolModules.M3UA containing fix ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39645?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9ac3dcad88cd13c1b45fb70bdcd2a474d084a652 Gerrit-Change-Number: 39645 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Mar 2025 07:58:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-netif[master]: cosmetic: add .gitignore to utils
by falconia 02 Mar '25

02 Mar '25

falconia has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39653?usp=email ) Change subject: cosmetic: add .gitignore to utils ...................................................................... cosmetic: add .gitignore to utils The osmo-amr-inspect binary built in utils is not covered by any previous .gitignore files, thus its presence adds noise to 'git status' output, making other work in this repository more difficult. Change-Id: I5fd24c19b00f3ea3a18d30d6ee1ccb621c28434c --- A utils/.gitignore 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/53/39653/1 diff --git a/utils/.gitignore b/utils/.gitignore new file mode 100644 index 0000000..2f568da --- /dev/null +++ b/utils/.gitignore @@ -0,0 +1 @@ +osmo-amr-inspect -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39653?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I5fd24c19b00f3ea3a18d30d6ee1ccb621c28434c Gerrit-Change-Number: 39653 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org>

1 0

[M] Change in osmo-bsc[master]: nokia_site: add function to unlock and reset TRXes
by csaba.sipos 01 Mar '25

01 Mar '25

csaba.sipos has posted comments on this change by csaba.sipos. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39652?usp=email ) Change subject: nokia_site: add function to unlock and reset TRXes ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39652?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I9042a1e24f0932a23a26185181481db2ceddbb7c Gerrit-Change-Number: 39652 Gerrit-PatchSet: 5 Gerrit-Owner: csaba.sipos <metro4(a)freemail.hu> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Sat, 01 Mar 2025 20:59:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[S] Change in ...pyosmocom[master]: utils: add unrpad()
by neels 01 Mar '25

01 Mar '25

neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/39600?usp=email ) Change subject: utils: add unrpad() ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: It turns out there *is* a surprising difference! The rstrip() version causes this error in pySim.esim.saip, can you guess why: File "/home/moi/s/esim/sysmo_esim_mgr/venv/lib/python3.13/site-packages/pySim/esim/saip/personalization.py", line 560, in decimal_hex_to_str return val.to_bytes().decode('ascii') ^^^^^^^^^^^^ AttributeError: 'str' object has no attribute 'to_bytes' I stared for a while until I realized this code is using hexstr.to_bytes(). (hexstr is also here from pyosmocom.) hexstr has a magic trick: def __getitem__(self, val) -> 'hexstr': # make sure slicing a hexstr will return a hexstr return hexstr(super().__getitem__(val)) so with the unrpad() implementation from this patch, a hexstr stays a hexstr. When using val.rstrip('f'), the hexstr becomes a str, and then there is no to_bytes() function. For now I solved it in the calling code as a local function def unrpad(s: hexstr, c='f') -> hexstr: return hexstr(s.rstrip(c)) but something like this next to rpad() now seems useful again... what do you think? -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/39600?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I48c23390926f8c9412624edb4481e7f4cd3f4b46 Gerrit-Change-Number: 39600 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sat, 01 Mar 2025 01:46:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in ...pyosmocom[master]: utils: add unrpad()
by neels 01 Mar '25

01 Mar '25

neels has restored this change. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/39600?usp=email ) Change subject: utils: add unrpad() ...................................................................... Restored -- To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/39600?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: restore Gerrit-Project: python/pyosmocom Gerrit-Branch: master Gerrit-Change-Id: I48c23390926f8c9412624edb4481e7f4cd3f4b46 Gerrit-Change-Number: 39600 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0