June 2026 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-bts[master]: common: reset lchan meas state in gsm_lchan_release()
by fixeria 30 Jun '26

30 Jun '26

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/42909?usp=email ) Change subject: common: reset lchan meas state in gsm_lchan_release() ...................................................................... Patch Set 1: (1 comment) File src/common/gsm_data.c: https://gerrit.osmocom.org/c/osmo-bts/+/42909/comment/62d81af6_e4aae825?usp… : PS1, Line 344: lchan_meas_reset(lchan); > `gsm_lchan_release()` returns early if `lchan->state == LCHAN_S_NONE` (not active), i.e. […] Moved to `gsm_lchan_release()`. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42909?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I18dc9d30417b0c5b2e579660d4a087d93445f956 Gerrit-Change-Number: 42909 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 Jun 2026 16:22:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-bts[master]: common: stop buffering UL measurements when SACCH is deactivated
by fixeria 30 Jun '26

30 Jun '26

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/42911?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: common: stop buffering UL measurements when SACCH is deactivated ...................................................................... common: stop buffering UL measurements when SACCH is deactivated When the BSC sends RSL DEACT SACCH, the per-SACCH UL measurement drain stops (it runs on SACCH timing), but the producer in lchan_new_ul_meas() keeps appending the measurement contributions from every received TCH/SDCCH burst. After one SACCH period (104 frames) the 104-slot uplink measurement buffer fills up, yielding a flood of: NOTICE measurement.c:336 no space for uplink measurement, num_ul_meas=104 Add a bool sacch_active flag to gsm_lchan, set to true in the common l1sap_chan_act() and clear in l1sap_chan_deact_sacch(). Guard lchan_new_ul_meas() with this flag so that measurements are silently discarded while SACCH is inactive - there is nothing to drain the buffer and no SACCH channel on which to report the results to the BSC. Change-Id: I3943c788cab5d2411b06ac681d4d412852bac0a7 AI-Assisted: yes (Claude) --- M include/osmo-bts/lchan.h M src/common/l1sap.c M src/common/measurement.c M tests/meas/meas_test.c 4 files changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/11/42911/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42911?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I3943c788cab5d2411b06ac681d4d412852bac0a7 Gerrit-Change-Number: 42911 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-bts[master]: common: reset lchan meas state in gsm_lchan_release()
by fixeria 30 Jun '26

30 Jun '26

Attention is currently required from: osmith, pespin. Hello Jenkins Builder, osmith, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/42909?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by osmith, Code-Review-1 by pespin, Verified+1 by Jenkins Builder Change subject: common: reset lchan meas state in gsm_lchan_release() ...................................................................... common: reset lchan meas state in gsm_lchan_release() lchan->meas (including interf_meas_num and num_ul_meas) is normally only reset by lchan_meas_reset() called from rsl_tx_chan_act_ack() on RSL CHANNEL ACTIVATION. Idle logical channels are never RSL-activated, so their measurement state is never reset via that path. On an OML link re-establishment, osmo-bts does not exit: abis.c tears down the signalling links, the bts_shutdown FSM powers down all TRXs, and then waits for reconnect. The gsm_bts/trx/ts/lchan structures remain in memory, so stale interf_meas_num survives the reconnect. This is why we're seeing these ERRORs while running ttcn3-bts-test: (bts=0,trx=2,ts=4,ss=6) Not enough room to store interference report (0dBm) Add a lchan_meas_reset() call to gsm_lchan_release(), which is called from gsm_ts_release() when the nm_channel_fsm enters state NM_CHAN_ST_OP_DISABLED_NOTINSTALLED. This is exactly the right moment: the radio is fully stopped, so no new samples arrive. Change-Id: I18dc9d30417b0c5b2e579660d4a087d93445f956 AI-Assisted: yes (Claude) --- M src/common/lchan.c 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/09/42909/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42909?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I18dc9d30417b0c5b2e579660d4a087d93445f956 Gerrit-Change-Number: 42909 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-bts[master]: common: flush paging queue in nm_bts_fsm's NOTINSTALLED on_enter
by fixeria 30 Jun '26

30 Jun '26

Attention is currently required from: fixeria. Hello Jenkins Builder, laforge, osmith, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/42910?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: common: flush paging queue in nm_bts_fsm's NOTINSTALLED on_enter ...................................................................... common: flush paging queue in nm_bts_fsm's NOTINSTALLED on_enter paging_reset() exists to flush stale paging records from the queue, but was never called anywhere. Stale paging records can accumulate when the OML link goes down: osmo-bts does not exit, so the paging queue survives into the next BSC session. Call it alongside bts_cbch_reset() and bts_asci_notification_reset() in st_op_disabled_notinstalled_on_enter(), which fires after all TRXs are confirmed closed and before a new OML connection is accepted. Change-Id: I109ab282986b68b68ba5c11859c44b771c0416fd AI-Assisted: yes (Claude) --- M src/common/nm_bts_fsm.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/10/42910/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42910?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I109ab282986b68b68ba5c11859c44b771c0416fd Gerrit-Change-Number: 42910 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in onomondo-eim[master]: rest_api_response_schema: add missing error codes
by dexter 30 Jun '26

30 Jun '26

Attention is currently required from: dexter, fixeria. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/onomondo-eim/+/42884?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Verified+1 by Jenkins Builder Change subject: rest_api_response_schema: add missing error codes ...................................................................... rest_api_response_schema: add missing error codes In SGP.32 V.1.2, new error codes were added to EnableProfileResult, DisableProfileResult, DeleteProfileResult and AddEimResult See also: SGP.32, section 2.11.2 Change-Id: I525ca9d3b7fb870405d374160272d8ec26c85880 Related: SYS#8100 --- M contrib/rest_api_response_schema.json 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/84/42884/2 -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42884?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: I525ca9d3b7fb870405d374160272d8ec26c85880 Gerrit-Change-Number: 42884 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in onomondo-eim[master]: esipa_rest_utils: align IpaEuiccDataResponse to SGP.32 V.1.2
by dexter 30 Jun '26

30 Jun '26

Attention is currently required from: fixeria. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-eim/+/42883?usp=email ) Change subject: esipa_rest_utils: align IpaEuiccDataResponse to SGP.32 V.1.2 ...................................................................... Patch Set 2: (1 comment) File src/esipa_rest_utils.erl: https://gerrit.osmocom.org/c/onomondo-eim/+/42883/comment/798772bc_8ce93a44… : PS1, Line 553: {ipaEuiccDataResponseError, IpaEuiccDataResponseError} -> : > Why don't you just extract the value from a map in-place? […] Done -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42883?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: Ie734a09ed4b0d57de30dc6fb377dfada79ea2ae4 Gerrit-Change-Number: 42883 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 Jun 2026 15:26:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in onomondo-eim[master]: esipa_rest_utils: align IpaEuiccDataResponse to SGP.32 V.1.2
by dexter 30 Jun '26

30 Jun '26

Attention is currently required from: fixeria. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/onomondo-eim/+/42883?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Verified+1 by Jenkins Builder Change subject: esipa_rest_utils: align IpaEuiccDataResponse to SGP.32 V.1.2 ...................................................................... esipa_rest_utils: align IpaEuiccDataResponse to SGP.32 V.1.2 The ASN.1 struct IpaEuiccDataResponse has renamed the error code member from ipaEuiccDataError to ipaEuiccDataErrorCode. The new ipaEuiccDataErrorCode is a sequence that has an ipaEuiccDataErrorCode member, which is the equivalent of the previously existing ipaEuiccDataError member. See also: SGP.32, section 2.11.2.2 Change-Id: Ie734a09ed4b0d57de30dc6fb377dfada79ea2ae4 Related: SYS#8100 --- M src/esipa_rest_utils.erl 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/83/42883/2 -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42883?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: Ie734a09ed4b0d57de30dc6fb377dfada79ea2ae4 Gerrit-Change-Number: 42883 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in onomondo-eim[master]: esipa_rest_utils: add support for PSMOs added in SGP.32 V.1.2
by dexter 30 Jun '26

30 Jun '26

Attention is currently required from: dexter, laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/onomondo-eim/+/42881?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: esipa_rest_utils: add support for PSMOs added in SGP.32 V.1.2 ...................................................................... esipa_rest_utils: add support for PSMOs added in SGP.32 V.1.2 SGP.32 adds 3 additional PSMOs: - setFallbackAttribute - unsetFallbackAttribute - setDefaultDpAddress Change-Id: I03cdd70065a83dfc611d614cf32d817c13fad347 Related: SYS#8100 --- M contrib/rest_api_resource_schema.json M contrib/rest_api_response_schema.json M src/esipa_rest_utils.erl 3 files changed, 116 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/81/42881/3 -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42881?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: I03cdd70065a83dfc611d614cf32d817c13fad347 Gerrit-Change-Number: 42881 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in osmo-bts[master]: common: stop buffering UL measurements when SACCH is deactivated
by fixeria 30 Jun '26

30 Jun '26

Attention is currently required from: pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/42911?usp=email ) Change subject: common: stop buffering UL measurements when SACCH is deactivated ...................................................................... Patch Set 2: (1 comment) File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/42911/comment/c65ff351_37055a8c?usp… : PS2, Line 2989: return -RSL_ERR_EQUIPMENT_FAIL; > you are lreaving the bool above enabled in this error code path. […] Acknowledged -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42911?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I3943c788cab5d2411b06ac681d4d412852bac0a7 Gerrit-Change-Number: 42911 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 Jun 2026 15:22:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in onomondo-eim[master]: esipa_rest_utils: add support for PSMOs added in SGP.32 V.1.2
by dexter 30 Jun '26

30 Jun '26

Attention is currently required from: dexter, laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/onomondo-eim/+/42881?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: esipa_rest_utils: add support for PSMOs added in SGP.32 V.1.2 ...................................................................... esipa_rest_utils: add support for PSMOs added in SGP.32 V.1.2 SGP.32 adds 3 additional PSMOs: - setFallbackAttribute - unsetFallbackAttribute - setDefaultDpAddress Change-Id: I03cdd70065a83dfc611d614cf32d817c13fad347 Related: SYS#8100 --- M contrib/rest_api_resource_schema.json M contrib/rest_api_response_schema.json M src/esipa_rest_utils.erl 3 files changed, 113 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/81/42881/2 -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42881?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: I03cdd70065a83dfc611d614cf32d817c13fad347 Gerrit-Change-Number: 42881 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0