Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/42911?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: common: stop buffering UL measurements when SACCH is deactivated ...................................................................... common: stop buffering UL measurements when SACCH is deactivated When the BSC sends RSL DEACT SACCH, the per-SACCH UL measurement drain stops (it runs on SACCH timing), but the producer in lchan_new_ul_meas() keeps appending the measurement contributions from every received TCH/SDCCH burst. After one SACCH period (104 frames) the 104-slot uplink measurement buffer fills up, yielding a flood of: NOTICE measurement.c:336 no space for uplink measurement, num_ul_meas=104 Add a bool sacch_active flag to gsm_lchan, set to true in the common l1sap_chan_act() and clear in l1sap_chan_deact_sacch(). Guard lchan_new_ul_meas() with this flag so that measurements are silently discarded while SACCH is inactive - there is nothing to drain the buffer and no SACCH channel on which to report the results to the BSC. Change-Id: I3943c788cab5d2411b06ac681d4d412852bac0a7 AI-Assisted: yes (Claude) --- M include/osmo-bts/lchan.h M src/common/l1sap.c M src/common/measurement.c M tests/meas/meas_test.c 4 files changed, 11 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/11/42911/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42911?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I3943c788cab5d2411b06ac681d4d412852bac0a7 Gerrit-Change-Number: 42911 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: osmith <osmith@sysmocom.de> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de>