Attention is currently required from: fixeria, laforge.
dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-eim/+/42880?usp=email )
Change subject: rest_api: move "required" member to the correct level
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
> This is again a crazy mix of tabs and spaces. […]
Now its spaces only.
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42880?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: I07d51d0e809a718144bd51a6540ab51187bb4daa
Gerrit-Change-Number: 42880
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 30 Jun 2026 15:16:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: laforge.
dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-eim/+/42880?usp=email )
Change subject: rest_api: move "required" member to the correct level
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/onomondo-eim/+/42880/comment/564047b3_6bf1ed67… :
PS1, Line 10: lavel
> level
Done
https://gerrit.osmocom.org/c/onomondo-eim/+/42880/comment/9c9caa2f_b0365406… :
PS1, Line 12: on the same level as the "properties" member
> mh? In some locations you find it on the same level as properties, but thta is incorrect and hence i […]
Done
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42880?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: I07d51d0e809a718144bd51a6540ab51187bb4daa
Gerrit-Change-Number: 42880
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 30 Jun 2026 15:14:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Attention is currently required from: laforge.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/onomondo-eim/+/42880?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: rest_api: move "required" member to the correct level
......................................................................
rest_api: move "required" member to the correct level
In some locations in the JSON schema files we find the "required"
member on the same level as the members of "properties" (likewise
"items"). This is incorrect, the "required" member should always
be on the same level as the "properties" or "items" member.
(At the moment the JSON schema files serve only documentation
purposes, they are not used to do any actual validation yet.)
Change-Id: I07d51d0e809a718144bd51a6540ab51187bb4daa
Related: SYS#8100
---
M contrib/rest_api_resource_schema.json
M contrib/rest_api_response_schema.json
2 files changed, 69 insertions(+), 69 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/80/42880/2
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42880?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: I07d51d0e809a718144bd51a6540ab51187bb4daa
Gerrit-Change-Number: 42880
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Attention is currently required from: dexter, fixeria, laforge.
Hello Jenkins Builder, fixeria, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/onomondo-eim/+/42878?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Code-Review+1 by fixeria, Code-Review+1 by laforge, Verified-1 by Jenkins Builder
Change subject: esipa_rest_utils: re-align to SGP.32 Section 2.11.2
......................................................................
esipa_rest_utils: re-align to SGP.32 Section 2.11.2
Section 2.11.2: rename EuiccPackageResultDataSigned.configureAutoEnableResult to EuiccPackageResultDataSigned.configureImmediateEnableResult
Change-Id: Ib4e6a4b4cb4d26a391346169b9047515496dd308
Related: SYS#8100
---
M contrib/rest_api_resource_schema.json
M contrib/rest_api_response_schema.json
R contrib/tryme_configureImmediateEnable.sh
M src/esipa_rest_utils.erl
4 files changed, 62 insertions(+), 37 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/78/42878/4
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42878?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: Ib4e6a4b4cb4d26a391346169b9047515496dd308
Gerrit-Change-Number: 42878
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: dexter, fixeria, laforge.
Hello Jenkins Builder, fixeria, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/onomondo-eim/+/42877?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified-1 by Jenkins Builder
Change subject: esipa_asn1_handler: re-align to SGP.32 section 2.11.2 and section 5.14.6
......................................................................
esipa_asn1_handler: re-align to SGP.32 section 2.11.2 and section 5.14.6
Section 2.11.2: eIM package result (EuiccPackageResult case) is now concatenated with PendingNotificationList instead of RetrieveNotificationsListResponse
Section 5.14.6: ESipa.ProvideEimPackageResult: Significant change in parameters
Change-Id: Ic0872edefc1844166943c60528557c6b7a6602ce
Related: SYS#8100
---
M src/esipa_asn1_handler.erl
1 file changed, 11 insertions(+), 24 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/77/42877/4
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42877?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: Ic0872edefc1844166943c60528557c6b7a6602ce
Gerrit-Change-Number: 42877
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: dexter, fixeria, laforge.
Hello Jenkins Builder, fixeria, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/onomondo-eim/+/42877?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+1 by fixeria, Code-Review+2 by laforge, Verified-1 by Jenkins Builder
Change subject: esipa_asn1_handler: re-align to SGP.32 section 2.11.2 and section 5.14.6
......................................................................
esipa_asn1_handler: re-align to SGP.32 section 2.11.2 and section 5.14.6
Section 2.11.2: eIM package result (EuiccPackageResult case) is now concatenated with PendingNotificationList instead of RetrieveNotificationsListResponse
Section 5.14.6: ESipa.ProvideEimPackageResult: Significant change in parameters
Change-Id: Ic0872edefc1844166943c60528557c6b7a6602ce
Related: SYS#8100
---
M src/esipa_asn1_handler.erl
1 file changed, 9 insertions(+), 24 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/77/42877/3
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42877?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: Ic0872edefc1844166943c60528557c6b7a6602ce
Gerrit-Change-Number: 42877
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: dexter, fixeria, laforge.
Hello Jenkins Builder, fixeria, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/onomondo-eim/+/42874?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+1 by fixeria, Code-Review+2 by laforge, Verified-1 by Jenkins Builder
Change subject: es9p_client: section 6.3.2.1, rename euiccCiPKIdToBeused to match SGP.32 V.1.2
......................................................................
es9p_client: section 6.3.2.1, rename euiccCiPKIdToBeused to match SGP.32 V.1.2
Section 6.3.2.1: rename InitiateAuthenticationOkEsipa.euiccCiPKIdToBeused to InitiateAuthenticationOkEsipa.euiccCiPKIdentifierToBeUsed
Change-Id: I44c60a2f0d1129093ea67908d2eed167643a4a87
Related: SYS#8100
---
M src/esipa_asn1_handler.erl
1 file changed, 8 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/74/42874/3
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42874?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: I44c60a2f0d1129093ea67908d2eed167643a4a87
Gerrit-Change-Number: 42874
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
dexter has abandoned this change. ( https://gerrit.osmocom.org/c/onomondo-eim/+/42879?usp=email )
Change subject: rest_api: revert json schema re-formatting
......................................................................
Abandoned
let's not mess with the reformatting and adopt the current style.
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42879?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: abandon
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: I2361891875a8e190fff7003196c2df76fd877080
Gerrit-Change-Number: 42879
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: laforge.
osmith has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/dahdi-linux/+/42898?usp=email )
Change subject: compatibility with kernel >= 7.2 which removed strncpy
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Patchset:
PS1:
> See my comment about backwards compatibility with < 4.10 https://gerrit.osmocom. […]
ack, sent a revert for my patch in https://gerrit.osmocom.org/c/dahdi-linux/+/42913/1?usp=related-change
--
To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/42898?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: dahdi-linux
Gerrit-Branch: master
Gerrit-Change-Id: I11a16ffed90223cbeae456a26834c0342146eb88
Gerrit-Change-Number: 42898
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 30 Jun 2026 10:10:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Attention is currently required from: laforge.
osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/dahdi-linux/+/42913?usp=email )
Change subject: Revert "Adjust to strncpy removal in linux 7.2-rc1"
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
CI failure for linux master is expected here.
--
To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/42913?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: dahdi-linux
Gerrit-Branch: master
Gerrit-Change-Id: I71ad66d33b4a19e4cf9b431bcc3d3cd02cad5e2f
Gerrit-Change-Number: 42913
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 30 Jun 2026 10:10:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No