Attention is currently required from: osmith.
laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/dahdi-linux/+/42898?usp=email )
Change subject: compatibility with kernel >= 7.2 which removed strncpy
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> I think it is better to replace strncpy with strscpy directly in the code instead of adding a define […]
See my comment about backwards compatibility with < 4.10 https://gerrit.osmocom.org/c/dahdi-linux/+/42906
--
To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/42898?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: dahdi-linux
Gerrit-Branch: master
Gerrit-Change-Id: I11a16ffed90223cbeae456a26834c0342146eb88
Gerrit-Change-Number: 42898
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 30 Jun 2026 09:17:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/dahdi-linux/+/42906?usp=email )
Change subject: Adjust to strncpy removal in linux 7.2-rc1
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
According to my analysis, strscpy is "only" available from kernel v4.10 and higher. So this is basically a judgement call of how much backwards compatibility we're willing to sacrifice.
At least upstream DAHDI contains references to earlier kernel support KERNEL_VERSION(2, 6, 29) and KERNEL_VERSION(3, 16, 0) - so I think it's probably unlikely that they would ever merge this patch.
--
To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/42906?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: dahdi-linux
Gerrit-Branch: master
Gerrit-Change-Id: I860344fd23d5780fc588d19388ad91c6f6bcfc90
Gerrit-Change-Number: 42906
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 30 Jun 2026 09:17:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: laforge.
osmith has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/dahdi-linux/+/42896?usp=email )
The change is no longer submittable: Code-Review is unsatisfied now.
Change subject: fix compatibiity with kernel 6.15 + 6.16 regarding timer symbol renaming
......................................................................
Patch Set 1: Code-Review-2
(1 comment)
File include/dahdi/kernel.h:
https://gerrit.osmocom.org/c/dahdi-linux/+/42896/comment/ee723b4b_806efe70?… :
PS1, Line 86: #define del_timer_sync timer_delete_sync
The defines are already set here, from https://gerrit.osmocom.org/c/dahdi-linux/+/42005
--
To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/42896?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: dahdi-linux
Gerrit-Branch: master
Gerrit-Change-Id: I63d777b948994944337798ee6af9fc656c53bc11
Gerrit-Change-Number: 42896
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Tue, 30 Jun 2026 09:01:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes