June 2026 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-pcap[master]: server: fix misleading data length validation log message
by fixeria 19 Jun '26

19 Jun '26

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-pcap/+/42838?usp=email ) Change subject: server: fix misleading data length validation log message ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I also think the previous log was fine too tbh. […] Based on feedback from two reviewers preferring the current message, I decided to abandon this patch. Even though the current format-string is slightly inaccurate about `<` vs `<=`. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/42838?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Ice95c1f8ad1aa8de259364bd70eba0db8918b19e Gerrit-Change-Number: 42838 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Jun 2026 20:17:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-pcap[master]: server: fix misleading data length validation log message
by fixeria 19 Jun '26

19 Jun '26

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-pcap/+/42838?usp=email ) Change subject: server: fix misleading data length validation log message ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-pcap/+/42838/comment/ee1ce67e_335a38d8?us… : PS1, Line 14: Co-Authored-By: Claude Opus 4.8 (1M context) <noreply(a)anthropic.com> > I think I'll start adding my cat as a co-author of all my patches, for giving me so much support whi […] It's not about advertising specific tools I used while writing these patches. It's just an explicit indication for reviewers that AI **was** used. Some projects like Wireshark do require such a statement in commit messages, even if it was not used at all. In this specific patchset it was used to find problems (as a static analyzer). Some fixes were proposed by AI, and I took them as-is or with a bit of tweaking. I've carefully checked them before submitting. Some of them I wrote myself, but generated the commit messages. If you would prefer more neutral indications, like `AI-Used: yes`, please let me know. P.S. If your cats could find memleaks or NULL-derefs for you, I would personally be fine with such statements in commit messages ;) -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/42838?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Ice95c1f8ad1aa8de259364bd70eba0db8918b19e Gerrit-Change-Number: 42838 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Jun 2026 20:14:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-pcap[master]: server: vty: fix docs for cfg_server_rotate_localtime[_mod_n]
by pespin 19 Jun '26

19 Jun '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-pcap/+/42837?usp=email ) Change subject: server: vty: fix docs for cfg_server_rotate_localtime[_mod_n] ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/42837?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I6fd1d081bba035fbd9d72a1705ab58194edf274e Gerrit-Change-Number: 42837 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Jun 2026 16:39:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-pcap[master]: vty: clamp configured snaplen to the wire-framing limit
by pespin 19 Jun '26

19 Jun '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-pcap/+/42836?usp=email ) Change subject: vty: clamp configured snaplen to the wire-framing limit ...................................................................... Patch Set 1: (4 comments) Patchset: PS1: Fine about the osmo-pcap wire framing. I wonder: Is the snaplen also used in the IP over IP setup which iirc can also be used instead of the osmo-pcap wire framing? If that's the case, then there's no limit of uint16_t afaiu? File include/osmo-pcap/common.h: https://gerrit.osmocom.org/c/osmo-pcap/+/42836/comment/6618c9fd_8f4c11a0?us… : PS1, Line 70: #define OSMO_PCAP_MAX_SNAPLEN 65535 can we then set it to UINT16_MAX here? File src/osmo_client_vty.c: https://gerrit.osmocom.org/c/osmo-pcap/+/42836/comment/b05d7768_c9780b6d?us… : PS1, Line 202: "Bytes (effectively limited to 64 KiB by the osmo-pcap wire framing)\n") Can you add the exact integer number here instead of 64KiB so user actually knows what to set it to? File src/osmo_server_vty.c: https://gerrit.osmocom.org/c/osmo-pcap/+/42836/comment/2ca37155_3d09d879?us… : PS1, Line 377: "Bytes (effectively limited to 64 KiB by the osmo-pcap wire framing)\n") Can you add the exact integer number here instead of 64KiB so user actually knows what to set it to? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/42836?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Ia56cad48e8cefe8ae103f2f7d2e037bf28438b71 Gerrit-Change-Number: 42836 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Jun 2026 16:38:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-pcap[master]: doc: clarify 'pcap snaplen' / 'max-snaplen'
by pespin 19 Jun '26

19 Jun '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-pcap/+/42835?usp=email ) Change subject: doc: clarify 'pcap snaplen' / 'max-snaplen' ...................................................................... Patch Set 1: (1 comment) File doc/manuals/chapters/client.adoc: https://gerrit.osmocom.org/c/osmo-pcap/+/42835/comment/c866df44_f726d2f8?us… : PS1, Line 67: the captured interface (e.g. `ethtool -K <iface> gro off lro off gso off tso AFAIR GSO and TSO is for the transmit path, so I fail to see why they apply here? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/42835?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: Ic2c82173c12814d61f0ee9f7454b9e5dcb0c13f4 Gerrit-Change-Number: 42835 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Jun 2026 16:33:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-bts[master]: osmo-bts-trx: shut down on stale clock indication from transceiver
by pespin 19 Jun '26

19 Jun '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/42851?usp=email ) Change subject: osmo-bts-trx: shut down on stale clock indication from transceiver ...................................................................... Patch Set 1: (2 comments) File src/osmo-bts-trx/scheduler_trx.c: https://gerrit.osmocom.org/c/osmo-bts/+/42851/comment/b47fc0e8_f3d78cc0?usp… : PS1, Line 586: * (elapsed_fn < 0) while far more wall-clock time elapsed than its FN AFAIU "elapsed_fn < 0" is not a "FN far BEHIND our local timer", but a " FN BEHIND our local timer". Note how I remove the "far" bit. https://gerrit.osmocom.org/c/osmo-bts/+/42851/comment/17fe27d7_d49718b4?usp… : PS1, Line 597: osmo_timerfd_disable(&tcs->fn_timer_ofd); why do we need to disable this timerfd here? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42851?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If787ab7ed70aa2dcb0389ceb58620c2302c3431a Gerrit-Change-Number: 42851 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Jun 2026 16:28:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-bts[master]: osmo-bts-trx: reset BTS GSM time on clock (re)start
by pespin 19 Jun '26

19 Jun '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/42850?usp=email ) Change subject: osmo-bts-trx: reset BTS GSM time on clock (re)start ...................................................................... Patch Set 1: (1 comment) File src/osmo-bts-trx/scheduler_trx.c: https://gerrit.osmocom.org/c/osmo-bts/+/42850/comment/67676b74_a131f296?usp… : PS1, Line 499: gsm_fn2gsmtime(&bts->gsm_time, 0); Don't we have the same problem on other BTS models? Shouldn't this be put in some more generic code path? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42850?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id8da126e460d3846a3be5bdb271553457fdd0590 Gerrit-Change-Number: 42850 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Jun 2026 16:20:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-pcap[master]: tls: fix broken certificate hostname verification
by pespin 19 Jun '26

19 Jun '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-pcap/+/42849?usp=email ) Change subject: tls: fix broken certificate hostname verification ...................................................................... Patch Set 1: (1 comment) File src/osmo_tls.c: https://gerrit.osmocom.org/c/osmo-pcap/+/42849/comment/88c29c57_b0d358d3?us… : PS1, Line 529: sess->tls_hostname = client->tls_hostname; can client be freed here somehow while sess keeps being valid and hence sess->tls_hostname ends up pointing to a freed string? I'd rather do a talloc_strdrup() here to make the code more robust. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/42849?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: If64950a698bfcfbf556a37ef1be3e68abc124384 Gerrit-Change-Number: 42849 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Jun 2026 16:17:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-pcap[master]: server: fix NULL deref of file_hdr_msg when store is disabled
by pespin 19 Jun '26

19 Jun '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-pcap/+/42848?usp=email ) Change subject: server: fix NULL deref of file_hdr_msg when store is disabled ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/42848?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I419e1b66d07307c3e49294984887c153cd8494c3 Gerrit-Change-Number: 42848 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Jun 2026 16:14:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-pcap[master]: server: vty: validate rotate-localtime modulus against the new interval
by pespin 19 Jun '26

19 Jun '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-pcap/+/42847?usp=email ) Change subject: server: vty: validate rotate-localtime modulus against the new interval ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcap/+/42847?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-pcap Gerrit-Branch: master Gerrit-Change-Id: I0b367d4e255db3208b41e12adec682026b99cc18 Gerrit-Change-Number: 42847 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 19 Jun 2026 16:11:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log June 2026