June 2026 - gerrit-log - lists.osmocom.org

[XS] Change in dahdi-linux[master]: Fix missing include of linux/string.h
by osmith 30 Jun '26

30 Jun '26

Attention is currently required from: laforge. osmith has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/dahdi-linux/+/42895?usp=email ) The change is no longer submittable: Code-Review is unsatisfied now. Change subject: Fix missing include of linux/string.h ...................................................................... Patch Set 1: Code-Review-2 -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/42895?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: Id1341c146b82f0d64370a23ec07432d7055bf13e Gerrit-Change-Number: 42895 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 30 Jun 2026 08:59:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in dahdi-linux[master]: compatibility with kernel >= 7.2 which removed strncpy
by osmith 30 Jun '26

30 Jun '26

Attention is currently required from: laforge. osmith has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/dahdi-linux/+/42898?usp=email ) Change subject: compatibility with kernel >= 7.2 which removed strncpy ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: I think it is better to replace strncpy with strscpy directly in the code instead of adding a define. From https://docs.kernel.org/process/deprecated.html#strncpy: > […] Due to its various behaviors, it was an ambiguous API for determining what an > author’s true intent was for the copy. > The replacements for strncpy() are: […] See https://gerrit.osmocom.org/c/dahdi-linux/+/42906. -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/42898?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I11a16ffed90223cbeae456a26834c0342146eb88 Gerrit-Change-Number: 42898 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 30 Jun 2026 08:58:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in dahdi-linux[master]: dahdi-base: Adjust ppp_input_error() signature to kernel 7.1
by osmith 30 Jun '26

30 Jun '26

Attention is currently required from: laforge. osmith has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/dahdi-linux/+/42897?usp=email ) Change subject: dahdi-base: Adjust ppp_input_error() signature to kernel 7.1 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I made almost the same patch here, sorry 😅 https://gerrit.osmocom.org/c/dahdi-linux/+/42904/1 -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/42897?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: If0cdfeca7272702ba53a61d7a3c871d417efa1bf Gerrit-Change-Number: 42897 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 30 Jun 2026 08:55:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in dahdi-linux[master]: Fix missing include of linux/string.h
by osmith 30 Jun '26

30 Jun '26

Attention is currently required from: laforge. osmith has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/dahdi-linux/+/42895?usp=email ) Change subject: Fix missing include of linux/string.h ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: This error message comes from strncpy being removed in linux 7.2-rc1. Including string.h doesn't change that, instead one of the alternatives need to be used: https://docs.kernel.org/process/deprecated.html#strncpy I'm sorry that I didn't check for / see your patches and sent my own version here: https://gerrit.osmocom.org/c/dahdi-linux/+/42906/1 -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/42895?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: Id1341c146b82f0d64370a23ec07432d7055bf13e Gerrit-Change-Number: 42895 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 30 Jun 2026 08:53:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in onomondo-ipa[master]: scard: add comment about memory-leak in libpcsclite
by laforge 30 Jun '26

30 Jun '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/42873?usp=email ) Change subject: scard: add comment about memory-leak in libpcsclite ...................................................................... scard: add comment about memory-leak in libpcsclite As it seems, SCardReleaseContext does not free all of the memory allocated by SCardEstablishContext. The probem has no real-world impact, but still showas up in valgrind. Let's add a comment so that we do not forget what causes the leak. Related: SYS#8101 Change-Id: I5224f3824ce2ad33e678cd859ad28c47788dbb24 --- M src/ipa/scard.c 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: jolly: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/ipa/scard.c b/src/ipa/scard.c index 806bb9d..b41ba24 100644 --- a/src/ipa/scard.c +++ b/src/ipa/scard.c @@ -182,6 +182,9 @@ rc = SCardDisconnect(ctx->hCard, SCARD_UNPOWER_CARD); PCSC_ERROR(ctx->reader_num, rc, "SCardDisconnect"); + /* As it seems the libpcsc-lite API calls SCardReleaseContext / SCardEstablishContext leak memoroy. There is + * always a remaining, still reachable amount of 1,614 bytes present when the program exits. Since we establish + * the hContext only once in this implementation this problem is no matter of concern. */ rc = SCardReleaseContext(ctx->hContext); PCSC_ERROR(ctx->reader_num, rc, "SCardReleaseContext"); -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/42873?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I5224f3824ce2ad33e678cd859ad28c47788dbb24 Gerrit-Change-Number: 42873 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[S] Change in onomondo-ipa[master]: es10b_get_euicc_info: add explanatory comments regarding EUICCInfo2
by laforge 30 Jun '26

30 Jun '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/42872?usp=email ) Change subject: es10b_get_euicc_info: add explanatory comments regarding EUICCInfo2 ...................................................................... es10b_get_euicc_info: add explanatory comments regarding EUICCInfo2 onomondo-ipa has a built-in IoT eUICC emulation. This means that we have to deal with two different EUICCInfo2 formats, which requires additional logic in ipa_es10b_get_euicc_info_free to free the allocated structs correctly. Since it is not immediately obvious how the logic works, let's add some explanary comments to make it obvious. Related: SYS#8101 Change-Id: I282fa91a4099a771a353101b0ce17ae3daae9c42 --- M src/ipa/libipa/es10b_get_euicc_info.c 1 file changed, 14 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved jolly: Looks good to me, but someone else must approve diff --git a/src/ipa/libipa/es10b_get_euicc_info.c b/src/ipa/libipa/es10b_get_euicc_info.c index db9c541..64e731d 100644 --- a/src/ipa/libipa/es10b_get_euicc_info.c +++ b/src/ipa/libipa/es10b_get_euicc_info.c @@ -105,9 +105,10 @@ if (!asn) return -EINVAL; + /* Present EUICCInfo2 in SGP.32 format (see comment in header file) */ euicc_info->euicc_info_2 = asn; - /* Also offer EUICCInfo2 in SGP.32 format */ + /* Present derived EUICCInfo2 in SGP.32 format */ euicc_info->sgp32_euicc_info_2 = IPA_ALLOC(struct SGP32_EUICCInfo2); convert_euicc_info_2(euicc_info->sgp32_euicc_info_2, euicc_info->euicc_info_2); @@ -122,6 +123,10 @@ if (!asn) return -EINVAL; + /* We do not present EUICCInfo2 in SGP.22 in this case (see comment in header file) */ + euicc_info->euicc_info_2 = NULL; + + /* Present derived EUICCInfo2 in SGP.32 format */ euicc_info->sgp32_euicc_info_2 = asn; return 0; @@ -190,9 +195,17 @@ ASN_STRUCT_FREE(asn_DEF_EUICCInfo1, res->euicc_info_1); if (res->euicc_info_2) { + /* res->sgp32_euicc_info_2 has been created from res->euicc_info_2 (see also dec_get_euicc_info2). This + * means that res->euicc_info_2 holds the original output of the ASN.1 decoder while + * res->sgp32_euicc_info_2 only holds pointers to res->euicc_info_2. This is the reason why we use + * ASN_STRUCT_FREE on res->euicc_info_2 and IPA_FREE on res->sgp32_euicc_info_2. + * (see also comment in header file) */ IPA_FREE(res->sgp32_euicc_info_2); ASN_STRUCT_FREE(asn_DEF_EUICCInfo2, res->euicc_info_2); } else { + /* res->sgp32_euicc_info_2 has been decoded by the ASN.1 decoder, so we have to use the ASN_STRUCT_FREE + * to free it. (res->euicc_info_2 NULL in this case and does not require freeing. + * (see also dec_get_euicc_info2_sgp32) */ ASN_STRUCT_FREE(asn_DEF_SGP32_EUICCInfo2, res->sgp32_euicc_info_2); } -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/42872?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I282fa91a4099a771a353101b0ce17ae3daae9c42 Gerrit-Change-Number: 42872 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in onomondo-ipa[master]: scard: add comment about memory-leak in libpcsclite
by laforge 30 Jun '26

30 Jun '26

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/42873?usp=email ) Change subject: scard: add comment about memory-leak in libpcsclite ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/42873?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I5224f3824ce2ad33e678cd859ad28c47788dbb24 Gerrit-Change-Number: 42873 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 Jun 2026 08:18:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in onomondo-ipa[master]: es10b_get_euicc_info: add explanatory comments regarding EUICCInfo2
by laforge 30 Jun '26

30 Jun '26

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/42872?usp=email ) Change subject: es10b_get_euicc_info: add explanatory comments regarding EUICCInfo2 ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/42872?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I282fa91a4099a771a353101b0ce17ae3daae9c42 Gerrit-Change-Number: 42872 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 Jun 2026 08:13:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: lint: ignore LINUX_VERSION_CODE
by laforge 30 Jun '26

30 Jun '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/42905?usp=email ) Change subject: lint: ignore LINUX_VERSION_CODE ...................................................................... lint: ignore LINUX_VERSION_CODE When running the linter against dahdi-linux.git or potentially other repositories with out-of-tree linux kernel modules, it should not complain about the LINUX_VERSION_CODE being used there: > drivers/dahdi/dahdi-base.c:6397: WARNING:LINUX_VERSION_CODE: > LINUX_VERSION_CODE should be avoided, code should be for the version to > which it is merged Change-Id: I82d64d43c04561b1643785cb71cfee92e513e560 --- M lint/checkpatch/checkpatch_osmo.sh 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved daniel: Looks good to me, but someone else must approve diff --git a/lint/checkpatch/checkpatch_osmo.sh b/lint/checkpatch/checkpatch_osmo.sh index 50551b0..ec10b0c 100755 --- a/lint/checkpatch/checkpatch_osmo.sh +++ b/lint/checkpatch/checkpatch_osmo.sh @@ -68,6 +68,7 @@ # * INITIALISED_STATIC: we use this, see also http://lkml.iu.edu/hypermail/linux/kernel/0808.1/2235.html # * LINE_CONTINUATIONS: false positives # * LINE_SPACING: we don't always put a blank line after declarations +# * LINUX_VERSION_CODE: warns about using LINUX_VERSION_CODE, which doesn't make sense outside of the kernel # * LONG_LINE*: should be 120 chars, but exceptions are done often so don't fail here # * MACRO_WITH_FLOW_CONTROL: not followed # * MISSING_SPACE: warns about breaking strings at space characters, not useful for long strings of hex chars @@ -106,6 +107,7 @@ --ignore INITIALISED_STATIC \ --ignore LINE_CONTINUATIONS \ --ignore LINE_SPACING \ + --ignore LINUX_VERSION_CODE \ --ignore LONG_LINE \ --ignore LONG_LINE_COMMENT \ --ignore LONG_LINE_STRING \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42905?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I82d64d43c04561b1643785cb71cfee92e513e560 Gerrit-Change-Number: 42905 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmo-ci[master]: lint: ignore LINUX_VERSION_CODE
by laforge 30 Jun '26

30 Jun '26

Attention is currently required from: fixeria, osmith. laforge has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/42905?usp=email ) Change subject: lint: ignore LINUX_VERSION_CODE ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42905?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I82d64d43c04561b1643785cb71cfee92e513e560 Gerrit-Change-Number: 42905 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 30 Jun 2026 08:12:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log June 2026